80279 2012-03-05 06:42:46 -0800 Improve comments in the tiled backing store 2012-03-05 06:55:33 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ahf ahf hausmann kenneth oldest_to_newest 570635 0 ahf 2012-03-05 06:42:46 -0800 SSIA. 570642 1 130118 ahf 2012-03-05 06:48:16 -0800 Created attachment 130118 Patch 570644 2 130118 hausmann 2012-03-05 06:51:00 -0800 Comment on attachment 130118 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130118&action=review > Source/WebCore/platform/graphics/TiledBackingStore.cpp:293 > + // Paint the content of the newly created tiles or resized tiles. One could also argue that the comment is redundant compared to the if () that is pretty easy to read :) 570652 3 ahf 2012-03-05 06:55:33 -0800 Committed r109739: <http://trac.webkit.org/changeset/109739> 130118 2012-03-05 06:48:16 -0800 2012-03-05 06:51:00 -0800 Patch bug-80279-20120305155616.patch text/plain 2522 ahf U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5NzM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGQzNWIwOTFhOWY0MjU0 ZTliYzJmOTE2NmJiMTIwMjQ3Mjg0NjFlMS4uOWQ4YzIxMDIzNTc3MDgzOGNmNTc0NTg5YzFmNjY0 YjA5NmU3MGM3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDEyLTAzLTA1ICBBbGV4 YW5kZXIgRsOmcsO4eSAgPGFsZXhhbmRlci5mYWVyb3lAbm9raWEuY29tPgogCisgICAgICAgIElt cHJvdmUgY29tbWVudHMgaW4gdGhlIHRpbGVkIGJhY2tpbmcgc3RvcmUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgwMjc5CisKKyAgICAgICAgUGF0Y2gg YnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4gYW5kIEFsZXhhbmRlciBGw6Zyw7h5LgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvVGlsZWRCYWNraW5nU3RvcmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGlsZWRC YWNraW5nU3RvcmU6OmNyZWF0ZVRpbGVzKToKKworMjAxMi0wMy0wNSAgQWxleGFuZGVyIEbDpnLD uHkgIDxhbGV4YW5kZXIuZmFlcm95QG5va2lhLmNvbT4KKwogICAgICAgICBUaWxlZEJhY2tpbmdT dG9yZS57aCxjcHB9IGNvbnRhaW5zIHVuY2xlYXIgdmFyaWFibGUgbmFtZXMKICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgwMjc2CiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1RpbGVkQmFja2luZ1N0b3JlLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1RpbGVkQmFja2luZ1N0b3JlLmNwcApp bmRleCAyNTRlYmY2ZTZiMjNhZjlmZjI3MmRiZjIxZDQ0OWY5ZWNmMzhmZDA5Li5mMDYyM2ZmOTE0 ODZiZjQ0ZDQ4NmE3Y2FlN2Y1YmQ0N2UyNmEwYmRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9UaWxlZEJhY2tpbmdTdG9yZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvVGlsZWRCYWNraW5nU3RvcmUuY3BwCkBAIC0yNjAsNiAr MjYwLDkgQEAgdm9pZCBUaWxlZEJhY2tpbmdTdG9yZTo6Y3JlYXRlVGlsZXMoKQogICAgIFZlY3Rv cjxUaWxlOjpDb29yZGluYXRlPiB0aWxlc1RvQ3JlYXRlOwogICAgIHVuc2lnbmVkIHJlcXVpcmVk VGlsZUNvdW50ID0gMDsKIAorICAgIC8vIENvdmVyIGFyZWFzIChpbiB0aWxlcykgd2l0aCBtaW5p bXVtIGRpc3RhbmNlIGZyb20gdGhlIHZpc2libGUgcmVjdC4gSWYgdGhlIHZpc2libGUgcmVjdCBp cworICAgIC8vIG5vdCBjb3ZlcmVkIGFscmVhZHkgaXQgd2lsbCBiZSBjb3ZlcmVkIGZpcnN0IGlu IG9uZSBnbywgZHVlIHRvIHRoZSBkaXN0YW5jZSBiZWluZyAwIGZvciB0aWxlcworICAgIC8vIGlu c2lkZSB0aGUgdmlzaWJsZSByZWN0LgogICAgIFRpbGU6OkNvb3JkaW5hdGUgdG9wTGVmdCA9IHRp bGVDb29yZGluYXRlRm9yUG9pbnQoY292ZXJSZWN0LmxvY2F0aW9uKCkpOwogICAgIFRpbGU6OkNv b3JkaW5hdGUgYm90dG9tUmlnaHQgPSB0aWxlQ29vcmRpbmF0ZUZvclBvaW50KGlubmVyQm90dG9t UmlnaHQoY292ZXJSZWN0KSk7CiAgICAgZm9yICh1bnNpZ25lZCB5Q29vcmRpbmF0ZSA9IHRvcExl ZnQueSgpOyB5Q29vcmRpbmF0ZSA8PSBib3R0b21SaWdodC55KCk7ICsreUNvb3JkaW5hdGUpIHsK QEAgLTI2OCw3ICsyNzEsNiBAQCB2b2lkIFRpbGVkQmFja2luZ1N0b3JlOjpjcmVhdGVUaWxlcygp CiAgICAgICAgICAgICBpZiAodGlsZUF0KGN1cnJlbnRDb29yZGluYXRlKSkKICAgICAgICAgICAg ICAgICBjb250aW51ZTsKICAgICAgICAgICAgICsrcmVxdWlyZWRUaWxlQ291bnQ7Ci0gICAgICAg ICAgICAvLyBEaXN0YW5jZSBpcyAwIGZvciBhbGwgdGlsZXMgaW5zaWRlIHRoZSB2aXNpYmxlUmVj dC4KICAgICAgICAgICAgIGRvdWJsZSBkaXN0YW5jZSA9IHRpbGVEaXN0YW5jZSh2aXNpYmxlUmVj dCwgY3VycmVudENvb3JkaW5hdGUpOwogICAgICAgICAgICAgaWYgKGRpc3RhbmNlID4gc2hvcnRl c3REaXN0YW5jZSkKICAgICAgICAgICAgICAgICBjb250aW51ZTsKQEAgLTI4OCw3ICsyOTAsNyBA QCB2b2lkIFRpbGVkQmFja2luZ1N0b3JlOjpjcmVhdGVUaWxlcygpCiAgICAgfQogICAgIHJlcXVp cmVkVGlsZUNvdW50IC09IHRpbGVzVG9DcmVhdGVDb3VudDsKIAotICAgIC8vIFBhaW50IHRoZSBj b250ZW50IG9mIHRoZSBuZXdseSBjcmVhdGVkIHRpbGVzLgorICAgIC8vIFBhaW50IHRoZSBjb250 ZW50IG9mIHRoZSBuZXdseSBjcmVhdGVkIHRpbGVzIG9yIHJlc2l6ZWQgdGlsZXMuCiAgICAgaWYg KHRpbGVzVG9DcmVhdGVDb3VudCB8fCBkaWRSZXNpemVUaWxlcykKICAgICAgICAgdXBkYXRlVGls ZUJ1ZmZlcnMoKTsKIAo=