80277 2012-03-05 06:16:40 -0800 [Qt] Create EWS to build WebKit2 2012-03-06 01:23:37 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kkristof webkit-unassigned abarth eric ojan ossy webkit.review.bot oldest_to_newest 570617 0 kkristof 2012-03-05 06:16:40 -0800 It would be very useful if the ews system also built webkit2. 570626 1 130113 kkristof 2012-03-05 06:25:27 -0800 Created attachment 130113 create wk2 ews 570649 2 130113 ossy 2012-03-05 06:54:56 -0800 Comment on attachment 130113 create wk2 ews View in context: https://bugs.webkit.org/attachment.cgi?id=130113&action=review LGTM, r=me with the following changes. > Tools/ChangeLog:3 > + [Qt] Create ews to build webkit2 ews -> EWS webkit2 -> WebKit2 > Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py:163 > +class QtWk2EWS(AbstractEarlyWarningSystem): QtWk2EWS -> QtWK2EWS > Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:86 > + self._test_builder_ews(QtWk2EWS()) QtWk2EWS -> QtWK2EWS 570653 3 ossy 2012-03-05 06:56:07 -0800 Eric, Adam, will http://queues.webkit.org/ be updated automatically after this patch lands? 570809 4 abarth 2012-03-05 10:06:18 -0800 > Eric, Adam, will http://queues.webkit.org/ be updated automatically after this patch lands? Nope. We'll need to do a re-deploy manually. Ping Eric or me when it lands and we can do that easily for you. 571591 5 130320 kkristof 2012-03-06 00:42:15 -0800 Created attachment 130320 fix the naming issues 571626 6 130320 webkit.review.bot 2012-03-06 01:23:32 -0800 Comment on attachment 130320 fix the naming issues Clearing flags on attachment: 130320 Committed r109878: <http://trac.webkit.org/changeset/109878> 571628 7 webkit.review.bot 2012-03-06 01:23:37 -0800 All reviewed patches have been landed. Closing bug. 130113 2012-03-05 06:25:27 -0800 2012-03-06 00:42:15 -0800 create wk2 ews wk2-ews-final.patch text/plain 2377 kkristof ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4YWVk NTc3Li42YjEyNTFlIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDMtMDUgIEtyaXN0w7NmIEtvc3p0ecOzICA8 a2tyaXN0b2ZAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFtRdF0gQ3JlYXRlIGV3cyB0byBi dWlsZCB3ZWJraXQyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD04MDI3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogUXVldWVTdGF0dXNTZXJ2ZXIvbW9kZWwvcXVldWVzLnB5OgorICAgICAgICAoUXVldWUp OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9lYXJseXdhcm5pbmdz eXN0ZW0ucHk6CisgICAgICAgIChRdFdrMkVXUyk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS90b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbV91bml0dGVzdC5weToKKyAgICAgICAg KEVhcmx5V2FybmluZ1N5dGVtVGVzdC50ZXN0X2J1aWxkZXJfZXdzZXMpOgorCiAyMDEyLTAzLTA1 ICBBbGV4YW5kZXIgRsOmcsO4eSAgPGFsZXhhbmRlci5mYWVyb3lAbm9raWEuY29tPgogCiAgICAg ICAgIFVucmV2aWV3ZWQuIEFkZCBteXNlbGYgdG8gY29tbWl0dGVyIGxpc3QuCmRpZmYgLS1naXQg YS9Ub29scy9RdWV1ZVN0YXR1c1NlcnZlci9tb2RlbC9xdWV1ZXMucHkgYi9Ub29scy9RdWV1ZVN0 YXR1c1NlcnZlci9tb2RlbC9xdWV1ZXMucHkKaW5kZXggYjEzMjg5MS4uM2M0Yjc3ZCAxMDA2NDQK LS0tIGEvVG9vbHMvUXVldWVTdGF0dXNTZXJ2ZXIvbW9kZWwvcXVldWVzLnB5CisrKyBiL1Rvb2xz L1F1ZXVlU3RhdHVzU2VydmVyL21vZGVsL3F1ZXVlcy5weQpAQCAtNDEsNiArNDEsNyBAQCBjbGFz cyBRdWV1ZShvYmplY3QpOgogICAgICAgICAic3R5bGUtcXVldWUiLAogICAgICAgICAiY2hyb21p dW0tZXdzIiwgICMgYWthIGNyLWxpbnV4LWV3cwogICAgICAgICAicXQtZXdzIiwKKyAgICAgICAg InF0LXdrMi1ld3MiLAogICAgICAgICAiZ3RrLWV3cyIsCiAgICAgICAgICJtYWMtZXdzIiwKICAg ICAgICAgIndpbi1ld3MiLApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29s L2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbS5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv dG9vbC9jb21tYW5kcy9lYXJseXdhcm5pbmdzeXN0ZW0ucHkKaW5kZXggNDA4NWUzNi4uMmY2ZDZl NCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Vhcmx5 d2FybmluZ3N5c3RlbS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFu ZHMvZWFybHl3YXJuaW5nc3lzdGVtLnB5CkBAIC0xNjAsNiArMTYwLDExIEBAIGNsYXNzIFF0RVdT KEFic3RyYWN0RWFybHlXYXJuaW5nU3lzdGVtKToKICAgICBwb3J0X25hbWUgPSAicXQiCiAKIAor Y2xhc3MgUXRXazJFV1MoQWJzdHJhY3RFYXJseVdhcm5pbmdTeXN0ZW0pOgorICAgIG5hbWUgPSAi cXQtd2syLWV3cyIKKyAgICBwb3J0X25hbWUgPSAicXQiCisKKwogY2xhc3MgV2luRVdTKEFic3Ry YWN0RWFybHlXYXJuaW5nU3lzdGVtKToKICAgICBuYW1lID0gIndpbi1ld3MiCiAgICAgcG9ydF9u YW1lID0gIndpbiIKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21t YW5kcy9lYXJseXdhcm5pbmdzeXN0ZW1fdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtX3VuaXR0ZXN0LnB5CmluZGV4IGNi MzQ5NDEuLmUxMTZiODkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9j b21tYW5kcy9lYXJseXdhcm5pbmdzeXN0ZW1fdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbV91bml0dGVzdC5weQpA QCAtODMsNiArODMsNyBAQCBjbGFzcyBFYXJseVdhcm5pbmdTeXRlbVRlc3QoUXVldWVzVGVzdCk6 CiAgICAgICAgIHNlbGYuX3Rlc3RfYnVpbGRlcl9ld3MoTWFjRVdTKCkpCiAgICAgICAgIHNlbGYu X3Rlc3RfYnVpbGRlcl9ld3MoQ2hyb21pdW1XaW5kb3dzRVdTKCkpCiAgICAgICAgIHNlbGYuX3Rl c3RfYnVpbGRlcl9ld3MoUXRFV1MoKSkKKyAgICAgICAgc2VsZi5fdGVzdF9idWlsZGVyX2V3cyhR dFdrMkVXUygpKQogICAgICAgICBzZWxmLl90ZXN0X2J1aWxkZXJfZXdzKEd0a0VXUygpKQogICAg ICAgICBzZWxmLl90ZXN0X2J1aWxkZXJfZXdzKEVmbEVXUygpKQogCg== 130320 2012-03-06 00:42:15 -0800 2012-03-06 01:23:31 -0800 fix the naming issues ews.patch text/plain 2367 kkristof ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlYWU2 ZGUyLi44NGZlZWQ0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDMtMDYgIEtyaXN0w7NmIEtvc3p0ecOzICA8 a2tyaXN0b2ZAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFtRdF0gQ3JlYXRlIEVXUyB0byBi dWlsZCBXZWJLaXQyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD04MDI3NworCisgICAgICAgIFJldmlld2VkIGJ5IENzYWJhIE9zenRyb2dvbsOhYy4KKwor ICAgICAgICAqIFF1ZXVlU3RhdHVzU2VydmVyL21vZGVsL3F1ZXVlcy5weToKKyAgICAgICAgKFF1 ZXVlKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJu aW5nc3lzdGVtLnB5OgorICAgICAgICAoUXRXSzJFV1MpOgorICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cHkvdG9vbC9jb21tYW5kcy9lYXJseXdhcm5pbmdzeXN0ZW1fdW5pdHRlc3QucHk6CisgICAg ICAgIChFYXJseVdhcm5pbmdTeXRlbVRlc3QudGVzdF9idWlsZGVyX2V3c2VzKToKKwogMjAxMi0w My0wNSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAg ICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEwOTczMy4KZGlmZiAtLWdpdCBhL1Rvb2xzL1F1 ZXVlU3RhdHVzU2VydmVyL21vZGVsL3F1ZXVlcy5weSBiL1Rvb2xzL1F1ZXVlU3RhdHVzU2VydmVy L21vZGVsL3F1ZXVlcy5weQppbmRleCBiMTMyODkxLi4zYzRiNzdkIDEwMDY0NAotLS0gYS9Ub29s cy9RdWV1ZVN0YXR1c1NlcnZlci9tb2RlbC9xdWV1ZXMucHkKKysrIGIvVG9vbHMvUXVldWVTdGF0 dXNTZXJ2ZXIvbW9kZWwvcXVldWVzLnB5CkBAIC00MSw2ICs0MSw3IEBAIGNsYXNzIFF1ZXVlKG9i amVjdCk6CiAgICAgICAgICJzdHlsZS1xdWV1ZSIsCiAgICAgICAgICJjaHJvbWl1bS1ld3MiLCAg IyBha2EgY3ItbGludXgtZXdzCiAgICAgICAgICJxdC1ld3MiLAorICAgICAgICAicXQtd2syLWV3 cyIsCiAgICAgICAgICJndGstZXdzIiwKICAgICAgICAgIm1hYy1ld3MiLAogICAgICAgICAid2lu LWV3cyIsCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMv ZWFybHl3YXJuaW5nc3lzdGVtLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1h bmRzL2Vhcmx5d2FybmluZ3N5c3RlbS5weQppbmRleCA0MDg1ZTM2Li4zN2JjNGI3IDEwMDY0NAot LS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lz dGVtLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9lYXJseXdh cm5pbmdzeXN0ZW0ucHkKQEAgLTE2MCw2ICsxNjAsMTEgQEAgY2xhc3MgUXRFV1MoQWJzdHJhY3RF YXJseVdhcm5pbmdTeXN0ZW0pOgogICAgIHBvcnRfbmFtZSA9ICJxdCIKIAogCitjbGFzcyBRdFdL MkVXUyhBYnN0cmFjdEVhcmx5V2FybmluZ1N5c3RlbSk6CisgICAgbmFtZSA9ICJxdC13azItZXdz IgorICAgIHBvcnRfbmFtZSA9ICJxdCIKKworCiBjbGFzcyBXaW5FV1MoQWJzdHJhY3RFYXJseVdh cm5pbmdTeXN0ZW0pOgogICAgIG5hbWUgPSAid2luLWV3cyIKICAgICBwb3J0X25hbWUgPSAid2lu IgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Vhcmx5 d2FybmluZ3N5c3RlbV91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9j b21tYW5kcy9lYXJseXdhcm5pbmdzeXN0ZW1fdW5pdHRlc3QucHkKaW5kZXggY2IzNDk0MS4uM2Fk YWQ0YyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Vh cmx5d2FybmluZ3N5c3RlbV91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtX3VuaXR0ZXN0LnB5CkBAIC04Myw2ICs4 Myw3IEBAIGNsYXNzIEVhcmx5V2FybmluZ1N5dGVtVGVzdChRdWV1ZXNUZXN0KToKICAgICAgICAg c2VsZi5fdGVzdF9idWlsZGVyX2V3cyhNYWNFV1MoKSkKICAgICAgICAgc2VsZi5fdGVzdF9idWls ZGVyX2V3cyhDaHJvbWl1bVdpbmRvd3NFV1MoKSkKICAgICAgICAgc2VsZi5fdGVzdF9idWlsZGVy X2V3cyhRdEVXUygpKQorICAgICAgICBzZWxmLl90ZXN0X2J1aWxkZXJfZXdzKFF0V0syRVdTKCkp CiAgICAgICAgIHNlbGYuX3Rlc3RfYnVpbGRlcl9ld3MoR3RrRVdTKCkpCiAgICAgICAgIHNlbGYu X3Rlc3RfYnVpbGRlcl9ld3MoRWZsRVdTKCkpCiAK