80258 2012-03-05 03:13:18 -0800 Web Inspector: Incorrect appropriateSelectorFor() suggestion for when a DOMNode has more than 2 CSS classes 2012-03-05 17:38:41 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 570545 0 apavlov 2012-03-05 03:13:18 -0800 Upstreaming http://code.google.com/p/chromium/issues/detail?id=116229 (second issue). Patch to follow. 570552 1 130088 apavlov 2012-03-05 03:31:53 -0800 Created attachment 130088 Patch 570564 2 apavlov 2012-03-05 04:04:23 -0800 Committed r109732: <http://trac.webkit.org/changeset/109732> 571266 3 joepeck 2012-03-05 17:38:41 -0800 This code looks like it would not handle duplicate classes very well. So: <div class="foo foo foo"></div> Might produce: div.foo.foo.foo Maybe some of the code inside of WebInspector.DOMPresentationUtils.decorateNodeLabel should be shared. That does eliminate duplicates. 130088 2012-03-05 03:31:53 -0800 2012-03-05 03:58:39 -0800 Patch bug-80258-20120305153151.patch text/plain 1447 apavlov U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5NzI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODlmNTkxNzRkMWYwZmRj ZmY3ZDg5NjllNjI2YzAxYmRkM2I3ZTMwNS4uYTc4MGY0M2IyNGJjMjVlMmY1OGM3Mjg4YTI4MzQ5 NzNlMTQyN2U4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAzLTA1ICBBbGV4 YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogSW5jb3JyZWN0IGFwcHJvcHJpYXRlU2VsZWN0b3JGb3IoKSBzdWdnZXN0aW9uIGZvciB3 aGVuIGEgRE9NTm9kZSBoYXMgbW9yZSB0aGFuIDIgQ1NTIGNsYXNzZXMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgwMjU4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0RP TUFnZW50LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRPTU5vZGUucHJvdG90eXBlLmFwcHJv cHJpYXRlU2VsZWN0b3JGb3IpOgorCiAyMDEyLTAzLTA1ICBZb3NoaWZ1bWkgSW5vdWUgIDx5b3Np bkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Zvcm1zXSBUaGUgIm9wdGdyb3VwIiBlbGVtZW50 IHNob3VsZCBub3QgYmUgYSBmb3JtLWFzc29jaWF0ZWQgZWxlbWVudApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9ET01BZ2VudC5qcyBiL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRE9NQWdlbnQuanMKaW5kZXggMzY2ZDRhOGMwYjg0ZmQw MmQ4ODMyNTk1MzI5NzVkZGUzMjhjNGM4NS4uMjgxNzg2MTczYzc0ZjA3NGY3ZmNkZGQ3OTQ3N2Iw YmI0OTY4OWVlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9ET01BZ2VudC5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RP TUFnZW50LmpzCkBAIC0zNjUsNyArMzY1LDcgQEAgV2ViSW5zcGVjdG9yLkRPTU5vZGUucHJvdG90 eXBlID0gewogCiAgICAgICAgIHZhciBjbGFzc05hbWUgPSB0aGlzLmdldEF0dHJpYnV0ZSgiY2xh c3MiKTsKICAgICAgICAgaWYgKGNsYXNzTmFtZSkgewotICAgICAgICAgICAgdmFyIHNlbGVjdG9y ID0gIi4iICsgY2xhc3NOYW1lLnJlcGxhY2UoL1xzKy8sICIuIik7CisgICAgICAgICAgICB2YXIg c2VsZWN0b3IgPSAiLiIgKyBjbGFzc05hbWUucmVwbGFjZSgvXHMrL2csICIuIik7CiAgICAgICAg ICAgICByZXR1cm4gKGp1c3RTZWxlY3RvciA/IHNlbGVjdG9yIDogbG93ZXJDYXNlTmFtZSArIHNl bGVjdG9yKTsKICAgICAgICAgfQogCg==