80251 2012-03-05 00:50:23 -0800 GraphicsContext3D.h should include RefCounted.h explicitly 2012-03-05 22:41:32 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 leo.yang leo.yang charles.wei rwlbuis staikos tonikitoo webkit.review.bot zimmermann oldest_to_newest 570478 0 leo.yang 2012-03-05 00:50:23 -0800 GraphicsContext3D.h is using RefCounted but including RefCounted.h indirectly. For some configuration, the indirect include may be failing. We should include the header explicitly anyway. 570519 1 130080 leo.yang 2012-03-05 01:41:01 -0800 Created attachment 130080 Patch 570573 2 130080 rwlbuis 2012-03-05 04:28:01 -0800 Comment on attachment 130080 Patch This is touching cross-platform code! Can you give a concrete example where it fails to compile? 571256 3 leo.yang 2012-03-05 17:32:55 -0800 (In reply to comment #2) > (From update of attachment 130080 [details]) > This is touching cross-platform code! Can you give a concrete example where it fails to compile? Build blackberry porting for x86 configuration. Note that the upstreamed IntSize.h (not including 2 unnecessary inclusion of PlatformString.h and CString.h which are in the internal version of IntSize.h) was used. This patch is to prepare for removing the 2 unnecessary inclusion in the internal IntSize.h. [ 9%] Building CXX object WebCore/CMakeFiles/webcore.dir/platform/graphics/skia/GraphicsContext3DSkia.cpp.o [ 9%] Building CXX object WebCore/CMakeFiles/webcore.dir/platform/graphics/skia/ImageBufferSkia.cpp.o [ 9%] Building CXX object WebCore/CMakeFiles/webcore.dir/platform/graphics/skia/NativeImageSkia.cpp.o [ 9%] Building CXX object WebCore/CMakeFiles/webcore.dir/platform/graphics/skia/PlatformContextSkia.cpp.o In file included from /home/leo/workspace/playbook/webkit/Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp:36:0: /home/leo/workspace/playbook/webkit/Source/WebCore/platform/graphics/GraphicsContext3D.h:123:44: error: expected template-name before '<' token /home/leo/workspace/playbook/webkit/Source/WebCore/platform/graphics/GraphicsContext3D.h:123:44: error: expected '{' before '<' token /home/leo/workspace/playbook/webkit/Source/WebCore/platform/graphics/GraphicsContext3D.h:123:44: error: expected unqualified-id before '<' token /home/leo/workspace/playbook/webkit/Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp:130:1: error: expected '}' at end of input cc: /opt/bbndk-2.0.0-beta1/host/linux/x86/usr/lib/gcc/i486-pc-nto-qnx6.5.0/4.6.2/cc1plus error 1 make[2]: *** [WebCore/CMakeFiles/webcore.dir/platform/graphics/skia/NativeImageSkia.cpp.o] Error 1 571341 4 130080 rwlbuis 2012-03-05 18:34:10 -0800 Comment on attachment 130080 Patch The change is good since GraphicsContext3D does derive from RefCounted and relying indirectly is not pretty. But please update the ChangeLog saying the indirection goes through Animation.h and why it does not work for us. 571345 5 leo.yang 2012-03-05 18:38:00 -0800 (In reply to comment #4) > (From update of attachment 130080 [details]) > The change is good since GraphicsContext3D does derive from RefCounted and relying indirectly is not pretty. But please update the ChangeLog saying the indirection goes through Animation.h and why it does not work for us. Thanks. I'll explain more in the ChangeLog 571354 6 130264 leo.yang 2012-03-05 18:53:45 -0800 Created attachment 130264 Patch for landing 571418 7 130264 webkit.review.bot 2012-03-05 20:24:58 -0800 Comment on attachment 130264 Patch for landing Clearing flags on attachment: 130264 Committed r109841: <http://trac.webkit.org/changeset/109841> 130080 2012-03-05 01:41:01 -0800 2012-03-05 22:41:01 -0800 Patch 0001-GraphicsContext3D.h-should-include-RefCounted.h-expl.patch text/plain 2115 leo.yang RnJvbSBkZTEzMDkyZThjZDYzMGM3Y2IzOGU0NGNiZDhhMzQzZTE3NjJlMjUxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVvLnlhbmdAdG9yY2htb2JpbGUuY29tLmNu PgpEYXRlOiBNb24sIDUgTWFyIDIwMTIgMTY6NTM6MDIgKzA4MDAKU3ViamVjdDogW1BBVENIXSBH cmFwaGljc0NvbnRleHQzRC5oIHNob3VsZCBpbmNsdWRlIFJlZkNvdW50ZWQuaCBleHBsaWNpdGx5 CiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODAyNTEKClJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgoKR3JhcGhpY3NDb250ZXh0M0QuaCB3YXMgdXNpbmcgUmVmQ291 bnRlZCBidXQgaW5jbHVkaW5nIFJlZkNvdW50ZWQuaCBpbmRpcmVjdGx5LgpGb3Igc29tZSBjb25m aWd1cmF0aW9ucywgdGhlIGluZGlyZWN0IGluY2x1c2lvbiBtYXkgYmUgZmFpbGluZy4KV2Ugc2hv dWxkIGluY2x1ZGUgdGhlIGhlYWRlciBleHBsaWNpdGx5IGFueXdheS4KCiogcGxhdGZvcm0vZ3Jh cGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuaDoKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cg ICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTMgKysrKysrKysrKysrKwogLi4uL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuaCAgfCAgICAxICsKIDIgZmls ZXMgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5k ZXggZjlmZGNjZi4uY2ZiNWI2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAz LTA1ICBMZW8gWWFuZyAgPGxlby55YW5nQHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBH cmFwaGljc0NvbnRleHQzRC5oIHNob3VsZCBpbmNsdWRlIFJlZkNvdW50ZWQuaCBleHBsaWNpdGx5 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MDI1MQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEdyYXBoaWNz Q29udGV4dDNELmggd2FzIHVzaW5nIFJlZkNvdW50ZWQgYnV0IGluY2x1ZGluZyBSZWZDb3VudGVk LmggaW5kaXJlY3RseS4KKyAgICAgICAgRm9yIHNvbWUgY29uZmlndXJhdGlvbnMsIHRoZSBpbmRp cmVjdCBpbmNsdXNpb24gbWF5IGJlIGZhaWxpbmcuCisgICAgICAgIFdlIHNob3VsZCBpbmNsdWRl IHRoZSBoZWFkZXIgZXhwbGljaXRseSBhbnl3YXkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9HcmFwaGljc0NvbnRleHQzRC5oOgorCiAyMDEyLTAzLTAxICBNT1JJVEEgSGFqaW1lICA8 bW9ycml0YUBnb29nbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjEwODc1OCk6IEFzc2Vy dGlvbiBmYWlsdXJlIGluIFdlYkNvcmU6OlJlbmRlck1lbnVMaXN0OjphZGRDaGlsZApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0Qu aCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmgK aW5kZXggYzgzMGU2NS4uZTk5NzIyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5oCkBAIC0zMyw2ICszMyw3IEBACiAjaW5j bHVkZSA8d3RmL0hhc2hNYXAuaD4KICNpbmNsdWRlIDx3dGYvTGlzdEhhc2hTZXQuaD4KICNpbmNs dWRlIDx3dGYvTm9uY29weWFibGUuaD4KKyNpbmNsdWRlIDx3dGYvUmVmQ291bnRlZC5oPgogCiAv LyBGSVhNRTogRmluZCBhIGJldHRlciB3YXkgdG8gYXZvaWQgdGhlIG5hbWUgY29uZmxpY3Rpb24g Zm9yIE5PX0VSUk9SLgogI2lmICgoUExBVEZPUk0oQ0hST01JVU0pICYmIE9TKFdJTkRPV1MpKSB8 fCBQTEFURk9STShXSU4pIHx8IChQTEFURk9STShRVCkgJiYgT1MoV0lORE9XUykpKQotLSAKMS43 LjUuNAoK 130264 2012-03-05 18:53:45 -0800 2012-03-05 20:24:58 -0800 Patch for landing 0001-GraphicsContext3D.h-should-include-RefCounted.h-expl.patch text/plain 2695 leo.yang RnJvbSBlYzdhMDcyNzI1MWFlOTE2MDU2ZDkwYzRiMDVkMmYwZjM3YmI4NzA0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVvLnlhbmdAdG9yY2htb2JpbGUuY29tLmNu PgpEYXRlOiBUdWUsIDYgTWFyIDIwMTIgMTA6NTE6NDkgKzA4MDAKU3ViamVjdDogW1BBVENIXSBH cmFwaGljc0NvbnRleHQzRC5oIHNob3VsZCBpbmNsdWRlIFJlZkNvdW50ZWQuaCBleHBsaWNpdGx5 CiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODAyNTEKClJldmlld2Vk IGJ5IFJvYiBCdWlzLgoKR3JhcGhpY3NDb250ZXh0M0QuaCB3YXMgdXNpbmcgUmVmQ291bnRlZCBi dXQgaW5jbHVkaW5nIFJlZkNvdW50ZWQuaCBpbmRpcmVjdGx5CnRocm91Z2ggR3JhcGhpY3NMYXll ci5oIHRocm91Z2ggQW5pbWF0aW9uLmguIEhvd2V2ZXIgQW5pbWF0aW9uLmggaXMgaW5jbHVkZWQK YnkgR3JhcGhpY3NMYXllci5oIG9ubHkgd2hlbiBBQ0NFTEVSQVRFRF9DT01QT1NJVElORyBpcyBv bi4gRm9yIHNvbWUgY29uZmlndXJhdGlvbnMKdGhhdCBkb24ndCB1c2UgQUNDRUxFUkFURURfQ09N UE9TSVRJTkcgYnV0IHVzZSBHcmFwaGljc0NvbnRleHQzRCwgbGlrZSB0aGUKQmxhY2tCZXJyeSB4 ODYgY29uZmlndXJhdGlvbiwgdGhlIGluZGlyZWN0IGluY2x1c2lvbiB3aWxsIGZhaWwuCgpUaGlz IHBhdGNoIGlzIGFkZGluZyBleHBsaWNpdCBpbmNsdXNpb24gb2YgUmVmQ291bnRlZC5oIHRvIGF2 b2lkIHRoYXQga2luZCBvZgpwcm9ibGVtLgoKKiBwbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0Nv bnRleHQzRC5oOgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAg ICAgICAgICAgIHwgICAxOCArKysrKysrKysrKysrKysrKysKIC4uLi9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmggIHwgICAgMSArCiAyIGZpbGVzIGNoYW5nZWQs IDE5IGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGY5ZmRjY2Yu LjUxNTUxNzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMi0wMy0wNSAgTGVvIFlh bmcgIDxsZW8ueWFuZ0B0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgR3JhcGhpY3NDb250 ZXh0M0QuaCBzaG91bGQgaW5jbHVkZSBSZWZDb3VudGVkLmggZXhwbGljaXRseQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODAyNTEKKworICAgICAgICBS ZXZpZXdlZCBieSBSb2IgQnVpcy4KKworICAgICAgICBHcmFwaGljc0NvbnRleHQzRC5oIHdhcyB1 c2luZyBSZWZDb3VudGVkIGJ1dCBpbmNsdWRpbmcgUmVmQ291bnRlZC5oIGluZGlyZWN0bHkKKyAg ICAgICAgdGhyb3VnaCBHcmFwaGljc0xheWVyLmggdGhyb3VnaCBBbmltYXRpb24uaC4gSG93ZXZl ciBBbmltYXRpb24uaCBpcyBpbmNsdWRlZAorICAgICAgICBieSBHcmFwaGljc0xheWVyLmggb25s eSB3aGVuIEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HIGlzIG9uLiBGb3Igc29tZSBjb25maWd1cmF0 aW9ucworICAgICAgICB0aGF0IGRvbid0IHVzZSBBQ0NFTEVSQVRFRF9DT01QT1NJVElORyBidXQg dXNlIEdyYXBoaWNzQ29udGV4dDNELCBsaWtlIHRoZQorICAgICAgICBCbGFja0JlcnJ5IHg4NiBj b25maWd1cmF0aW9uLCB0aGUgaW5kaXJlY3QgaW5jbHVzaW9uIHdpbGwgZmFpbC4KKworICAgICAg ICBUaGlzIHBhdGNoIGlzIGFkZGluZyBleHBsaWNpdCBpbmNsdXNpb24gb2YgUmVmQ291bnRlZC5o IHRvIGF2b2lkIHRoYXQga2luZCBvZgorICAgICAgICBwcm9ibGVtLgorCisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuaDoKKwogMjAxMi0wMy0wMSAgTU9SSVRB IEhhamltZSAgPG1vcnJpdGFAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIxMDg3 NTgpOiBBc3NlcnRpb24gZmFpbHVyZSBpbiBXZWJDb3JlOjpSZW5kZXJNZW51TGlzdDo6YWRkQ2hp bGQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNz Q29udGV4dDNELmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0Nv bnRleHQzRC5oCmluZGV4IGM4MzBlNjUuLmU5OTcyMjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmgKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuaApAQCAtMzMsNiArMzMs NyBAQAogI2luY2x1ZGUgPHd0Zi9IYXNoTWFwLmg+CiAjaW5jbHVkZSA8d3RmL0xpc3RIYXNoU2V0 Lmg+CiAjaW5jbHVkZSA8d3RmL05vbmNvcHlhYmxlLmg+CisjaW5jbHVkZSA8d3RmL1JlZkNvdW50 ZWQuaD4KIAogLy8gRklYTUU6IEZpbmQgYSBiZXR0ZXIgd2F5IHRvIGF2b2lkIHRoZSBuYW1lIGNv bmZsaWN0aW9uIGZvciBOT19FUlJPUi4KICNpZiAoKFBMQVRGT1JNKENIUk9NSVVNKSAmJiBPUyhX SU5ET1dTKSkgfHwgUExBVEZPUk0oV0lOKSB8fCAoUExBVEZPUk0oUVQpICYmIE9TKFdJTkRPV1Mp KSkKLS0gCjEuNy41LjQKCg==