<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>80232</bug_id>
          
          <creation_ts>2012-03-04 19:24:57 -0800</creation_ts>
          <short_desc>Add account to committer list</short_desc>
          <delta_ts>2012-03-04 20:02:33 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Trivial</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Charles Wei">charles.wei</reporter>
          <assigned_to name="Leo Yang">leo.yang</assigned_to>
          <cc>abarth</cc>
    
    <cc>ojan</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>570362</commentid>
    <comment_count>0</comment_count>
    <who name="Charles Wei">charles.wei</who>
    <bug_when>2012-03-04 19:24:57 -0800</bug_when>
    <thetext>Need to add account charles.wei@torchmobile.com.cn to the committer list who was just granted the commit access.

I submit a patch for this because we have direct SVN access problem here in China and have to have a patch for a bug to get this change landed. Will have the SVN access figured out later and won&apos;t do this any more.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>570367</commentid>
    <comment_count>1</comment_count>
      <attachid>130046</attachid>
    <who name="Charles Wei">charles.wei</who>
    <bug_when>2012-03-04 19:39:00 -0800</bug_when>
    <thetext>Created attachment 130046
Patch to add charles.wei@torchmobile.com.cn to the committer list.

patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>570370</commentid>
    <comment_count>2</comment_count>
      <attachid>130046</attachid>
    <who name="Charles Wei">charles.wei</who>
    <bug_when>2012-03-04 19:42:44 -0800</bug_when>
    <thetext>Comment on attachment 130046
Patch to add charles.wei@torchmobile.com.cn to the committer list.

Try to commit it by myself.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>570371</commentid>
    <comment_count>3</comment_count>
      <attachid>130046</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-03-04 19:42:58 -0800</bug_when>
    <thetext>Comment on attachment 130046
Patch to add charles.wei@torchmobile.com.cn to the committer list.

Rejecting attachment 130046 from commit-queue.

charles.wei@torchmobile.com.cn does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>570373</commentid>
    <comment_count>4</comment_count>
      <attachid>130046</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-03-04 20:02:29 -0800</bug_when>
    <thetext>Comment on attachment 130046
Patch to add charles.wei@torchmobile.com.cn to the committer list.

Clearing flags on attachment: 130046

Committed r109701: &lt;http://trac.webkit.org/changeset/109701&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>570374</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-03-04 20:02:33 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>130046</attachid>
            <date>2012-03-04 19:39:00 -0800</date>
            <delta_ts>2012-03-04 20:02:28 -0800</delta_ts>
            <desc>Patch to add charles.wei@torchmobile.com.cn to the committer list.</desc>
            <filename>0001-Unreviewed-Add-myself-to-committer-list.patch</filename>
            <type>text/plain</type>
            <size>1920</size>
            <attacher name="Charles Wei">charles.wei</attacher>
            
              <data encoding="base64">RnJvbSAzZDVmOTY5ZTQwNDRlZjE4MDQ3ZmJiYmRhMDIyZDgyY2E4OTEwZGUxIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBDaGFybGVzIFdlaSA8Y2hhcmxlcy53ZWlAdG9yY2htb2JpbGUu
Y29tLmNuPgpEYXRlOiBNb24sIDUgTWFyIDIwMTIgMTE6Mzk6MzIgKzA4MDAKU3ViamVjdDogW1BB
VENIXSBVbnJldmlld2VkLCBBZGQgbXlzZWxmIHRvIGNvbW1pdHRlciBsaXN0LgogaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgwMjMyCgoqIFNjcmlwdHMvd2Via2l0cHkv
Y29tbW9uL2NvbmZpZy9jb21taXR0ZXJzLnB5OgotLS0KIFRvb2xzL0NoYW5nZUxvZyAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgNyArKysrKysrCiBUb29scy9TY3JpcHRz
L3dlYmtpdHB5L2NvbW1vbi9jb25maWcvY29tbWl0dGVycy5weSB8ICAgIDEgKwogMiBmaWxlcyBj
aGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvVG9v
bHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGRlM2RlZDguLjY3YjdkYjIgMTAw
NjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyAr
MSwxMCBAQAorMjAxMi0wMy0wNCAgQ2hhcmxlcyBXZWkgIDxjaGFybGVzLndlaUB0b3JjaG1vYmls
ZS5jb20uY24+CisKKyAgICAgICAgVW5yZXZpZXdlZCwgQWRkIG15c2VsZiB0byBjb21taXR0ZXIg
bGlzdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgw
MjMyCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvY29tbWl0dGVy
cy5weToKKwogMjAxMi0wMy0wNCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29t
PgogCiAgICAgICAgIE5ld2VyIHZlcnNpb25zIG9mIGNsYW5nIGZhaWwgdG8gY29tcGlsZSBXZWJL
aXQuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvY29t
bWl0dGVycy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9jb21taXR0
ZXJzLnB5CmluZGV4IDZiZTVkNmIuLjdlZmEzZGUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv
d2Via2l0cHkvY29tbW9uL2NvbmZpZy9jb21taXR0ZXJzLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMv
d2Via2l0cHkvY29tbW9uL2NvbmZpZy9jb21taXR0ZXJzLnB5CkBAIC0xOTYsNiArMTk2LDcgQEAg
Y29tbWl0dGVyc191bmFibGVfdG9fcmV2aWV3ID0gWwogICAgIENvbW1pdHRlcigiQ2FybG9zIEdh
cmNpYSBDYW1wb3MiLCBbImNnYXJjaWFAaWdhbGlhLmNvbSIsICJjYXJsb3NnY0Bnbm9tZS5vcmci
LCAiY2FybG9zZ2NAd2Via2l0Lm9yZyJdLCAiS2FMIiksCiAgICAgQ29tbWl0dGVyKCJDYXJvbCBT
emFibyIsIFsiY2Fyb2xAd2Via2l0Lm9yZyIsICJjYXJvbC5zemFib0Bub2tpYS5jb20iXSwgImNz
emFibzEiKSwKICAgICBDb21taXR0ZXIoIkNhcnkgQ2xhcmsiLCBbImNhcnljbGFya0Bnb29nbGUu
Y29tIiwgImNhcnljbGFya0BjaHJvbWl1bS5vcmciXSwgImNhcnljbGFyayIpLAorICAgIENvbW1p
dHRlcigiQ2hhcmxlcyBXZWkiLCBbImNoYXJsZXMud2VpQHRvcmNobW9iaWxlLmNvbS5jbiJdLCAi
Y3N3ZWkiKSwKICAgICBDb21taXR0ZXIoIkNocmlzIEV2YW5zIiwgWyJjZXZhbnNAZ29vZ2xlLmNv
bSIsICJjZXZhbnNAY2hyb21pdW0ub3JnIl0pLAogICAgIENvbW1pdHRlcigiQ2hyaXMgR3VpbGxv
cnkiLCBbImN0Z3VpbEBjaHJvbWl1bS5vcmciLCAiY2hyaXMuZ3VpbGxvcnlAZ29vZ2xlLmNvbSJd
LCAiY3RndWlsIiksCiAgICAgQ29tbWl0dGVyKCJDaHJpcyBQZXRlcnNlbiIsICJjcGV0ZXJzZW5A
YXBwbGUuY29tIiwgImNwZXRlcnNlbiIpLAotLSAKMS43LjkuMQoK
</data>

          </attachment>
      

    </bug>

</bugzilla>