80215 2012-03-03 15:00:58 -0800 [Gtk] [Win32] WebKitGtk+ fails to build on Win32 after changeset 109584 2022-02-28 04:05:05 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 80737 P2 Normal --- 0 tuxator webkit-unassigned mrobinson pnormand webkit.review.bot zan oldest_to_newest 570178 0 130008 tuxator 2012-03-03 15:00:58 -0800 Created attachment 130008 proposed patch Attempting to cross-compile WebKitGtk+ for windows results in error: CXXLD libwebkitgtk-3.0.la Creating library file: .libs/libwebkitgtk-3.0.dll.a ./.libs/libWebCore.a(libWebCore_la-ScrollAnimatorWin.o):ScrollAnimatorWin.cpp:(.text+0x6d0): multiple definition of `WebCore::ScrollAnimator::create(WebCore::ScrollableArea*)' ./.libs/libWebCore.a(libWebCore_la-ScrollAnimatorNone.o):ScrollAnimatorNone.cpp:(.text+0x1330): first defined here collect2: error: ld returned 1 exit status make[1]: *** [libwebkitgtk-3.0.la] Error 1 make[1]: Leaving directory `/home/pawel/src/WebKit' make: *** [all] Error 2 570235 1 pnormand 2012-03-04 07:40:08 -0800 Have you tried a clean build? We had this issue on the bots too (Linux) and a clean build worked out. 570236 2 130008 pnormand 2012-03-04 07:44:32 -0800 Comment on attachment 130008 proposed patch I don't see any X11 specific code in ScrollAnimatorNone, moving these files to TARGET_X11 looks only like a workaround for your cross-compiling issue. 570276 3 tuxator 2012-03-04 12:22:55 -0800 Yes i tried clean build (as in "make clean"). Build stopped again in this same place. With TARGET_WIN32 you have if TARGET_WIN32 webcore_sources += \ <------>Source/WebCore/platform/ScrollAnimatorWin.cpp \ <------>Source/WebCore/platform/ScrollAnimatorWin.h \ Which in turn doubles the definitions from ScrollAnimatorNone. So i think it should be like in attached patchlet or the other way around, removing ScrollAnimatorWin. Moving just ScrollAnimatorNone into TARGET_X11 guard seemed logical to me and it feels a bit more cautious. 570285 4 pnormand 2012-03-04 12:56:42 -0800 Indeed both conflict, I'm no expert about this code but maybe we should choose one and keep it whatever the platform is to keep scrolling experience as consistent as we can. CCing Zan and Martin. What do you think? 570288 5 tuxator 2012-03-04 13:07:20 -0800 Yea, sounds reasonable. The less duplication, the better. I'm sure they will come up with something nice. 570296 6 zan 2012-03-04 13:46:31 -0800 (In reply to comment #4) > CCing Zan and Martin. What do you think? Oddly enough, the ScrollAnimatorWin.cpp and the header do not include any Windows-specific headers either. Anyway, like mentioned, I also think it would be best to use one class on every target, so I'd say removing ScrollAnimatorWin from the build and using ScrollAnimatorNone instead. ScrollAnimatorWin is also used by the WinCE port and it'd be best to avoid causing trouble if that class grows out of today's boundaries. 570352 7 mrobinson 2012-03-04 19:02:01 -0800 (In reply to comment #6) > Anyway, like mentioned, I also think it would be best to use one class on every target, so I'd say removing ScrollAnimatorWin from the build and using ScrollAnimatorNone instead. ScrollAnimatorWin is also used by the WinCE port and it'd be best to avoid causing trouble if that class grows out of today's boundaries. I think the important thing is to determine which animator best follows the scrolling behavior of GTK+ applications on Windows and use that one. If that turns out to be ScrollAnimatorWin.cpp, I think the risk of using it is very low. 573075 8 zan 2012-03-07 11:49:09 -0800 (In reply to comment #7) > (In reply to comment #6) > > > Anyway, like mentioned, I also think it would be best to use one class on every target, so I'd say removing ScrollAnimatorWin from the build and using ScrollAnimatorNone instead. ScrollAnimatorWin is also used by the WinCE port and it'd be best to avoid causing trouble if that class grows out of today's boundaries. > > I think the important thing is to determine which animator best follows the scrolling behavior of GTK+ applications on Windows and use that one. If that turns out to be ScrollAnimatorWin.cpp, I think the risk of using it is very low. I'd like to hear bug reporter's feedback on the scrolling behavior with ScrollAnimatorWin class. If the behavior is acceptable/superior to ScrollAnimatorNone, the patch should be reuploaded with ChangeLog entries and reviewed. 576445 9 131391 tuxator 2012-03-12 13:15:44 -0700 Created attachment 131391 Patch with Changelog entry I think behaviour with ScrollAnimatorNone is fine, updated patch to remove ScrollAnimatorWin 576605 10 131391 webkit.review.bot 2012-03-12 15:19:26 -0700 Comment on attachment 131391 Patch with Changelog entry Rejecting attachment 131391 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: artin Rob..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/GNUmakefile.list.am Hunk #1 FAILED at 4645. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/GNUmakefile.list.am.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Martin Rob..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11941183 576650 11 mrobinson 2012-03-12 15:57:50 -0700 *** This bug has been marked as a duplicate of bug 80737 *** 130008 2012-03-03 15:00:58 -0800 2022-02-28 04:05:05 -0800 proposed patch scrollanimator_build_fix.patch text/plain 970 tuxator ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmxpc3QuYW0gYi9Tb3VyY2Uv V2ViQ29yZS9HTlVtYWtlZmlsZS5saXN0LmFtCmluZGV4IDdmOWFkYzguLjVmOWI2NGEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmxpc3QuYW0KKysrIGIvU291cmNlL1dl YkNvcmUvR05VbWFrZWZpbGUubGlzdC5hbQpAQCAtMzM4Nyw4ICszMzg3LDYgQEAgd2ViY29yZV9z b3VyY2VzICs9IFwKIAlTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY2hlbWVSZWdpc3RyeS5oIFwK IAlTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxBbmltYXRvci5jcHAgXAogCVNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL1Njcm9sbEFuaW1hdG9yLmggXAotCVNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL1Njcm9sbEFuaW1hdG9yTm9uZS5jcHAgXAotCVNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Nj cm9sbEFuaW1hdG9yTm9uZS5oIFwKIAlTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxhYmxl QXJlYS5jcHAgXAogCVNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbGFibGVBcmVhLmggXAog CVNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbGJhci5jcHAgXApAQCAtNDYyNiw2ICs0NjI0 LDggQEAgd2ViY29yZWd0a19zb3VyY2VzICs9IFwKIAogaWYgVEFSR0VUX1gxMQogd2ViY29yZWd0 a19zb3VyY2VzICs9IFwKKwlTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxBbmltYXRvck5v bmUuaCBcCisJU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsQW5pbWF0b3JOb25lLmNwcCBc CiAJU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ2x4L0dMQ29udGV4dEdMWC5jcHAg XAogCVNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9HTENvbnRleHRHdGsuY3Bw IFwKIAlTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HTENvbnRleHQuaCBc Cg== 131391 2012-03-12 13:15:44 -0700 2012-03-12 15:19:26 -0700 Patch with Changelog entry Scroll_build.patch text/plain 1145 tuxator ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5MDIwMTEwLi5jMGExMjFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTItMDMtMTIgIFBhd2XFgiBGb3J5c2l1ayAgPHR1eGF0b3JAbzIucGw+CisKKyAgICAg ICAgW0d0a10gW1dpbjMyXSBXZWJLaXRHdGsrIGZhaWxzIHRvIGJ1aWxkIG9uIFdpbjMyIGFmdGVy IGNoYW5nZXNldCAxMDk1ODQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTgwMjE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KworICAgICAgICAqIEdOVW1ha2VmaWxlLmxpc3QuYW06IFJlbW92ZSBTY3JvbGxBbmltYXRvcldp biBmcm9tIHdlYmNvcmVfc291cmNlcyBhcyBpdCBjbGFzaGVzIHdpdGggZGVmaW5pdGlvbnMgaW4g U2Nyb2xsQW5pbWF0b3JOb25lLgorCiAyMDEyLTAzLTEyICBBbmRyZWFzIEtsaW5nICA8YXdlc29t ZWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXN0b3JlIEF0dHI6OnN0eWxlKCkgZnVuY3Rp b25hbGl0eS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmxpc3QuYW0g Yi9Tb3VyY2UvV2ViQ29yZS9HTlVtYWtlZmlsZS5saXN0LmFtCmluZGV4IDJiZDFmNjUuLmEzNDQ0 MzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmxpc3QuYW0KKysrIGIv U291cmNlL1dlYkNvcmUvR05VbWFrZWZpbGUubGlzdC5hbQpAQCAtNDY0NSw4ICs0NjQ1LDYgQEAg ZW5kaWYKIAogaWYgVEFSR0VUX1dJTjMyCiB3ZWJjb3JlX3NvdXJjZXMgKz0gXAotCVNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL1Njcm9sbEFuaW1hdG9yV2luLmNwcCBcCi0JU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vU2Nyb2xsQW5pbWF0b3JXaW4uaCBcCiAJU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v d2luL1N5c3RlbUluZm8uY3BwIFwKIAlTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vU3lzdGVt SW5mby5oIFwKIAlTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL3dpbi9QbHVnaW5EYXRhYmFzZVdpbi5j cHAgXAo=