80209 2012-03-02 23:40:10 -0800 [Qt][WK2] http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml crashes 2012-05-15 13:25:30 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Critical --- 79668 1 ossy michael.bruning menard michael.bruning ossy webkit.review.bot zoltan oldest_to_newest 570121 0 ossy 2012-03-02 23:40:10 -0800 http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml crashes on Qt5-WK2 platform. I don't know when started it to crash and I don't have crash log, because it didn't upload it. It needs more investigation. 570122 1 ossy 2012-03-02 23:49:19 -0800 I skipped it to paint the bot green (r109655.) 570131 2 ossy 2012-03-03 01:19:14 -0800 Here is the debug crash log: $ cat xss-DENIED-xsl-document-securityOrigin-crash-log.txt | c++filt ERROR: Icon database already has a path and is already open. We don't currently support changing its path and reopening. /home/oszi/WebKit/Source/WebKit2/UIProcess/WebIconDatabase.cpp(66) : void WebKit::WebIconDatabase::setDatabasePath(const WTF::String&) ASSERTION FAILED: !iconURLOriginal.isEmpty() /home/oszi/WebKit/Source/WebCore/loader/icon/IconDatabase.cpp(578) : virtual void WebCore::IconDatabase::setIconURLForPageURL(const WTF::String&, const WTF::String&) 1 0x7f5f481fed65 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.4(WebCore::IconDatabase::setIconURLForPageURL(WTF::String const&, WTF::String const&)+0xc9) [0x7f5f481fed65] 2 0x7f5f47364852 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.4(WebKit::WebIconDatabase::setIconURLForPageURL(WTF::String const&, WTF::String const&)+0x112) [0x7f5f47364852] 3 0x7f5f4750f42a /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.4(void CoreIPC::callMemberFunction<WebKit::WebIconDatabase, void (WebKit::WebIconDatabase::*)(WTF::String const&, WTF::String const&), WTF::String, WTF::String>(CoreIPC::Arguments2<WTF::String, WTF::String> const&, WebKit::WebIconDatabase*, void (WebKit::WebIconDatabase::*)(WTF::String const&, WTF::String const&))+0x69) [0x7f5f4750f42a] 4 0x7f5f4750eeb4 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.4(void CoreIPC::handleMessage<Messages::WebIconDatabase::SetIconURLForPageURL, WebKit::WebIconDatabase, void (WebKit::WebIconDatabase::*)(WTF::String const&, WTF::String const&)>(CoreIPC::ArgumentDecoder*, WebKit::WebIconDatabase*, void (WebKit::WebIconDatabase::*)(WTF::String const&, WTF::String const&))+0x5f) [0x7f5f4750eeb4] 5 0x7f5f4750ea72 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.4(WebKit::WebIconDatabase::didReceiveWebIconDatabaseMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::ArgumentDecoder*)+0xf4) [0x7f5f4750ea72] 6 0x7f5f47365404 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.4(WebKit::WebIconDatabase::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::ArgumentDecoder*)+0x32) [0x7f5f47365404] 7 0x7f5f4734794c /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.4(WebKit::WebContext::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::ArgumentDecoder*)+0x268) [0x7f5f4734794c] 8 0x7f5f473bab63 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.4(WebKit::WebProcessProxy::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::ArgumentDecoder*)+0x14f) [0x7f5f473bab63] 9 0x7f5f4733e22f /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.4(WebKit::WebConnectionToWebProcess::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::ArgumentDecoder*)+0x179) [0x7f5f4733e22f] 10 0x7f5f472948e3 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.4(CoreIPC::Connection::dispatchMessage(CoreIPC::Connection::Message<CoreIPC::ArgumentDecoder>&)+0x171) [0x7f5f472948e3] 11 0x7f5f47294ac5 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.4(CoreIPC::Connection::dispatchMessages()+0xc9) [0x7f5f47294ac5] 12 0x7f5f4729ee9d /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.4(WTF::FunctionWrapper<void (CoreIPC::Connection::*)()>::operator()(CoreIPC::Connection*)+0x59) [0x7f5f4729ee9d] 13 0x7f5f4729eba6 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.4(WTF::BoundFunctionImpl<WTF::FunctionWrapper<void (CoreIPC::Connection::*)()>, void ()(CoreIPC::Connection*)>::operator()()+0x32) [0x7f5f4729eba6] 14 0x7f5f473d5a60 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.4(WTF::Function<void ()()>::operator()() const+0x72) [0x7f5f473d5a60] 15 0x7f5f47ebf831 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.4(WebCore::RunLoop::performWork()+0x91) [0x7f5f47ebf831] 16 0x7f5f48195ccc /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.4(WebCore::RunLoop::TimerObject::performWork()+0x1c) [0x7f5f48195ccc] 17 0x7f5f48196b05 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.4(+0x2cacb05) [0x7f5f48196b05] 18 0x7f5f41db2286 /usr/local/Trolltech/Qt5/Qt-5.0.0-r25/lib/libQtCore.so.5(QObject::event(QEvent*)+0x396) [0x7f5f41db2286] 19 0x7f5f42ed40ac /usr/local/Trolltech/Qt5/Qt-5.0.0-r25/lib/libQtWidgets.so.5(QApplicationPrivate::notify_helper(QObject*, QEvent*)+0xac) [0x7f5f42ed40ac] 20 0x7f5f42edcf22 /usr/local/Trolltech/Qt5/Qt-5.0.0-r25/lib/libQtWidgets.so.5(QApplication::notify(QObject*, QEvent*)+0x152) [0x7f5f42edcf22] 21 0x7f5f41d91c24 /usr/local/Trolltech/Qt5/Qt-5.0.0-r25/lib/libQtCore.so.5(QCoreApplication::notifyInternal(QObject*, QEvent*)+0x84) [0x7f5f41d91c24] 22 0x7f5f41d96692 /usr/local/Trolltech/Qt5/Qt-5.0.0-r25/lib/libQtCore.so.5(QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*)+0x2e2) [0x7f5f41d96692] 23 0x7f5f41dd6d43 /usr/local/Trolltech/Qt5/Qt-5.0.0-r25/lib/libQtCore.so.5(+0x20bd43) [0x7f5f41dd6d43] 24 0x7f5f447446f2 /lib/libglib-2.0.so.0(g_main_context_dispatch+0x1f2) [0x7f5f447446f2] 25 0x7f5f44748568 /lib/libglib-2.0.so.0(+0x42568) [0x7f5f44748568] 26 0x7f5f4474871c /lib/libglib-2.0.so.0(g_main_context_iteration+0x6c) [0x7f5f4474871c] 27 0x7f5f41dd683e /usr/local/Trolltech/Qt5/Qt-5.0.0-r25/lib/libQtCore.so.5(QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>)+0x6e) [0x7f5f41dd683e] 28 0x7f5f41d91b7d /usr/local/Trolltech/Qt5/Qt-5.0.0-r25/lib/libQtCore.so.5(QCoreApplication::processEvents(QFlags<QEventLoop::ProcessEventsFlag>, int)+0x3d) [0x7f5f41d91b7d] 29 0x4117a0 /home/oszi/WebKit/WebKitBuild/Debug/bin/WebKitTestRunner() [0x4117a0] 30 0x414212 /home/oszi/WebKit/WebKitBuild/Debug/bin/WebKitTestRunner() [0x414212] 31 0x417b3b /home/oszi/WebKit/WebKitBuild/Debug/bin/WebKitTestRunner() [0x417b3b] 623809 3 michael.bruning 2012-05-15 01:53:08 -0700 Investigating... 623886 4 michael.bruning 2012-05-15 04:21:14 -0700 The problem here seems to be that WTR is creating a new WebView reusing the WebContext reference from the previous view, which leads to the resetting of the WebIconsDatabase databasePath. I have checked the mac port and it's not a problem there as the mac WKView does not initialize the icon database automatically. Will look how to best fix this. 624169 5 michael.bruning 2012-05-15 09:17:14 -0700 I have solved the first crash, but this uncovered an ASSERT on debug builds and a crash (not 100% reproducible) on Release builds. I will upload the first patch anyway as this might cause errors elsewhere in WTR and investigate furhter on the 2nd assert / crash. 624184 6 141989 michael.bruning 2012-05-15 09:33:16 -0700 Created attachment 141989 Patch 624478 7 141989 webkit.review.bot 2012-05-15 13:25:25 -0700 Comment on attachment 141989 Patch Clearing flags on attachment: 141989 Committed r117141: <http://trac.webkit.org/changeset/117141> 624479 8 webkit.review.bot 2012-05-15 13:25:30 -0700 All reviewed patches have been landed. Closing bug. 141989 2012-05-15 09:33:16 -0700 2012-05-15 13:25:25 -0700 Patch bug-80209-20120515183313.patch text/plain 3864 michael.bruning U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3MDgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmM2N2IzYmRiMTNmN2Nl ZTQwODZiMjIwMTQ1MTk1YWYyYmY4Mjg1MS4uZjExYjEyZWY1NTcwZDhlOTMyYTkzZmJjZjAwNDBk M2Q1MDZiYzUyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA1LTE1ICBNaWNo YWVsIEJyw7xuaW5nICA8bWljaGFlbC5icnVuaW5nQG5va2lhLmNvbT4KKworICAgICAgICBbUXRd W1dLMl0gaHR0cC90ZXN0cy9zZWN1cml0eS94c3MtREVOSUVELXhzbC1kb2N1bWVudC1zZWN1cml0 eU9yaWdpbi54bWwgY3Jhc2hlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODAyMDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGlzIHBhdGNoIGFkZHMgYSBtZXRob2QgaXNPcGVuIHRvIFdlYkljb25EYXRh YmFzZSB0bworICAgICAgICBiZSBhYmxlIHRvIGNoZWNrIHdoZXRoZXIgdGhlIGRhdGFiYXNlIGhh cyBhbHJlYWR5IGJlZW4gb3BlbmVkLgorICAgICAgICBUaGlzIGhlbHBzIHByZXZlbnRpbmcgcHJv YmxlbXMgd2hlbiByZXVzaW5nIGEgV2ViQ29udGV4dAorICAgICAgICB0byBjcmVhdGUgYW5vdGhl ciB2aWV3LCBhcyBlLmcuIFdlYktpdFRlc3RSdW5uZXIgZG9lcyBpdCBpbiB0aGUKKyAgICAgICAg UXQgcG9ydC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJJY29uRGF0YWJhc2UuY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJJY29uRGF0YWJhc2U6OnNldERhdGFiYXNlUGF0aCk6CisgICAgICAg IChXZWJLaXQ6OldlYkljb25EYXRhYmFzZTo6aXNPcGVuKTogQWRkZWQuCisgICAgICAgIChXZWJL aXQpOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJJY29uRGF0YWJhc2UuaDoKKyAgICAgICAgKFdl Ykljb25EYXRhYmFzZSk6CisgICAgICAgICogVUlQcm9jZXNzL3F0L1F0V2ViSWNvbkRhdGFiYXNl Q2xpZW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6UXRXZWJJY29uRGF0YWJhc2VDbGllbnQ6OlF0 V2ViSWNvbkRhdGFiYXNlQ2xpZW50KToKKwogMjAxMi0wNS0xNSAgRGludSBKYWNvYiAgPGRpbnUu amFjb2JAbm9raWEuY29tPgogCiAgICAgICAgIFtRdF1bV0syXSBmYXN0L2xvYWRlci9jcmVhdGUt ZnJhbWUtaW4tRE9NQ29udGVudExvYWRlZC5odG1sIGNyYXNoZXMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJJY29uRGF0YWJhc2UuY3BwIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1dlYkljb25EYXRhYmFzZS5jcHAKaW5kZXggODAxNmNmYmQ2ZTdlMWY3NjhhYThk MTZjMjVlY2M3ZjZiMDc5MzVmYy4uMTA4MDRmNzAyZjg1Y2JlYTI5ZjZlMWNiZWZmYWVkODIwMTgz NmMxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkljb25EYXRhYmFz ZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkljb25EYXRhYmFzZS5jcHAK QEAgLTYyLDcgKzYyLDcgQEAgdm9pZCBXZWJJY29uRGF0YWJhc2U6OmludmFsaWRhdGUoKQogCiB2 b2lkIFdlYkljb25EYXRhYmFzZTo6c2V0RGF0YWJhc2VQYXRoKGNvbnN0IFN0cmluZyYgcGF0aCkK IHsKLSAgICBpZiAobV9pY29uRGF0YWJhc2VJbXBsICYmIG1faWNvbkRhdGFiYXNlSW1wbC0+aXNP cGVuKCkpIHsKKyAgICBpZiAoaXNPcGVuKCkpIHsKICAgICAgICAgTE9HX0VSUk9SKCJJY29uIGRh dGFiYXNlIGFscmVhZHkgaGFzIGEgcGF0aCBhbmQgaXMgYWxyZWFkeSBvcGVuLiBXZSBkb24ndCBj dXJyZW50bHkgc3VwcG9ydCBjaGFuZ2luZyBpdHMgcGF0aCBhbmQgcmVvcGVuaW5nLiIpOwogICAg ICAgICByZXR1cm47CiAgICAgfQpAQCAtMTkwLDYgKzE5MCwxMSBAQCBJbWFnZSogV2ViSWNvbkRh dGFiYXNlOjppbWFnZUZvclBhZ2VVUkwoY29uc3QgU3RyaW5nJiBwYWdlVVJMLCBjb25zdCBXZWJD b3JlOjpJbgogICAgIHJldHVybiBtX2ljb25EYXRhYmFzZUltcGwtPnN5bmNocm9ub3VzSWNvbkZv clBhZ2VVUkwocGFnZVVSTCwgaWNvblNpemUpOwogfQogCitib29sIFdlYkljb25EYXRhYmFzZTo6 aXNPcGVuKCkKK3sKKyAgICByZXR1cm4gbV9pY29uRGF0YWJhc2VJbXBsICYmIG1faWNvbkRhdGFi YXNlSW1wbC0+aXNPcGVuKCk7Cit9CisKIHZvaWQgV2ViSWNvbkRhdGFiYXNlOjpyZW1vdmVBbGxJ Y29ucygpCiB7CiAgICAgbV9pY29uRGF0YWJhc2VJbXBsLT5yZW1vdmVBbGxJY29ucygpOyAgIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkljb25EYXRhYmFzZS5oIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkljb25EYXRhYmFzZS5oCmluZGV4IGI3NGMyMTA4 NjQ4NTE3MDA5NjczNDk4MGRiMTcwNTlmMmNkZTI4MTQuLjdhZTNmZGNlMGU5MDRmZmYyYzI4Y2Nl MTkzODk1M2VmMTQxNGU5OTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9X ZWJJY29uRGF0YWJhc2UuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViSWNvbkRh dGFiYXNlLmgKQEAgLTc4LDcgKzc4LDggQEAgcHVibGljOgogICAgIHZvaWQgZ2V0TG9hZERlY2lz aW9uRm9ySWNvblVSTChjb25zdCBTdHJpbmcmLCB1aW50NjRfdCBjYWxsYmFja0lEKTsKIAogICAg IFdlYkNvcmU6OkltYWdlKiBpbWFnZUZvclBhZ2VVUkwoY29uc3QgU3RyaW5nJiwgY29uc3QgV2Vi Q29yZTo6SW50U2l6ZSYgaWNvblNpemUgPSBXZWJDb3JlOjpJbnRTaXplKDMyLCAzMikpOwotICAg IAorICAgIGJvb2wgaXNPcGVuKCk7CisKICAgICB2b2lkIHJlbW92ZUFsbEljb25zKCk7CiAgICAg dm9pZCBjaGVja0ludGVncml0eUJlZm9yZU9wZW5pbmcoKTsKICAgICB2b2lkIGNsb3NlKCk7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJJY29uRGF0YWJhc2VD bGllbnQuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2ViSWNvbkRhdGFiYXNl Q2xpZW50LmNwcAppbmRleCBkOTRiNjM0YjMzZjkyYmJiOThjZWRmNWFkYWFhODVlYzUxYjk3M2Q0 Li5jNzY5YzhiMDNiYzFiMDExMjEzMWU5Mzc5NzkzZjE4YmIxZjEzZDVkIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJJY29uRGF0YWJhc2VDbGllbnQuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdlYkljb25EYXRhYmFzZUNsaWVudC5j cHAKQEAgLTQ1LDcgKzQ1LDggQEAgUXRXZWJJY29uRGF0YWJhc2VDbGllbnQ6OlF0V2ViSWNvbkRh dGFiYXNlQ2xpZW50KFF0V2ViQ29udGV4dCAqcXRXZWJDb250ZXh0KQogICAgIG1fY29udGV4dElk ID0gcXRXZWJDb250ZXh0LT5jb250ZXh0SUQoKTsKICAgICAvLyBUaGUgc2V0dGVyIGNhbGxzIHRo ZSBnZXR0ZXIgaGVyZSBhcyBpdCB0cmlnZ2VycyB0aGUgc3RhcnR1cCBvZiB0aGUgaWNvbiBkYXRh YmFzZS4KICAgICBXZWJDb250ZXh0KiBjb250ZXh0ID0gcXRXZWJDb250ZXh0LT5jb250ZXh0KCk7 Ci0gICAgY29udGV4dC0+c2V0SWNvbkRhdGFiYXNlUGF0aChjb250ZXh0LT5pY29uRGF0YWJhc2VQ YXRoKCkpOworICAgIGlmICghY29udGV4dC0+aWNvbkRhdGFiYXNlKCktPmlzT3BlbigpKQorICAg ICAgICBjb250ZXh0LT5zZXRJY29uRGF0YWJhc2VQYXRoKGNvbnRleHQtPmljb25EYXRhYmFzZVBh dGgoKSk7CiAgICAgbV9pY29uRGF0YWJhc2UgPSBjb250ZXh0LT5pY29uRGF0YWJhc2UoKTsKIAog ICAgIFdLSWNvbkRhdGFiYXNlQ2xpZW50IGljb25EYXRhYmFzZUNsaWVudDsK