80198 2012-03-02 15:26:46 -0800 AssociatedURLLoader doesn't support Access-Control-Expose-Headers field in response. 2012-03-03 10:50:10 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All Unspecified RESOLVED FIXED P2 Normal --- 0 bbudge webkit-unassigned abarth fishd webkit.review.bot oldest_to_newest 569988 0 bbudge 2012-03-02 15:26:46 -0800 The CORS expose header mechanism is broken. 569994 1 129968 bbudge 2012-03-02 15:37:23 -0800 Created attachment 129968 Proposed Patch 570038 2 129968 abarth 2012-03-02 16:44:15 -0800 Comment on attachment 129968 Proposed Patch I wonder if we should have an HTTPHeaderNames.h similar to the one in Chromium to help avoid these sorts of bugs... It might be worth waiting until we see this problem again. 570077 3 129968 webkit.review.bot 2012-03-02 18:44:17 -0800 Comment on attachment 129968 Proposed Patch Rejecting attachment 129968 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: _by_email return self._reviewer_only(self.account_by_email(email)) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 632, in account_by_email return self._email_to_account_map().get(email.lower()) if email else None File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 525, in _email_to_account_map assert(email not in self._accounts_by_email) # We should never have duplicate emails. AssertionError Full output: http://queues.webkit.org/results/11796250 570156 4 129968 webkit.review.bot 2012-03-03 10:50:06 -0800 Comment on attachment 129968 Proposed Patch Clearing flags on attachment: 129968 Committed r109661: <http://trac.webkit.org/changeset/109661> 570157 5 webkit.review.bot 2012-03-03 10:50:10 -0800 All reviewed patches have been landed. Closing bug. 129968 2012-03-02 15:37:23 -0800 2012-03-03 10:50:06 -0800 Proposed Patch aaa.txt text/plain 3235 bbudge SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMDk2MjApCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEz IEBACisyMDEyLTAzLTAyICBCaWxsIEJ1ZGdlICA8YmJ1ZGdlQGNocm9taXVtLm9yZz4KKworICAg ICAgICBGaXhlcyBBc3NvY2lhdGVkVVJMTG9hZGVyIHN1cHBvcnQgZm9yIEFjY2Vzcy1Db250cm9s LUV4cG9zZS1IZWFkZXJzIGZpZWxkIGluIHJlc3BvbnNlLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODAxOTgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHNyYy9Bc3NvY2lhdGVkVVJMTG9hZGVyLmNwcDoK KyAgICAgICAgKiB0ZXN0cy9Bc3NvY2lhdGVkVVJMTG9hZGVyVGVzdC5jcHA6CisKIDIwMTItMDMt MDIgIERhbmEgSmFuc2VucyAgPGRhbmFrakBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9t aXVtXSBBbGxvdyBwbHVnaW5zIHRvIHNldCBvcGFxdWUoKSBvbiB0aGVpciBwbGF0Zm9ybSBsYXll cgpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQXNzb2NpYXRlZFVSTExvYWRlci5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQXNzb2NpYXRlZFVS TExvYWRlci5jcHAJKHJldmlzaW9uIDEwOTIzMikKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL0Fzc29jaWF0ZWRVUkxMb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03OSw2ICs3OSw3 IEBAIHZvaWQgSFRUUFJlcXVlc3RIZWFkZXJWYWxpZGF0b3I6OnZpc2l0SGUKICAgICBtX2lzU2Fm ZSA9IG1faXNTYWZlICYmIGlzVmFsaWRIVFRQVG9rZW4obmFtZSkgJiYgWE1MSHR0cFJlcXVlc3Q6 OmlzQWxsb3dlZEhUVFBIZWFkZXIobmFtZSkgJiYgaXNWYWxpZEhUVFBIZWFkZXJWYWx1ZSh2YWx1 ZSk7CiB9CiAKKy8vIEZJWE1FOiBSZW1vdmUgdGhpcyBhbmQgdXNlIFdlYkNvcmUgY29kZSB0aGF0 IGRvZXMgdGhlIHNhbWUgdGhpbmcuCiBjbGFzcyBIVFRQUmVzcG9uc2VIZWFkZXJWYWxpZGF0b3Ig OiBwdWJsaWMgV2ViSFRUUEhlYWRlclZpc2l0b3IgewogICAgIFdURl9NQUtFX05PTkNPUFlBQkxF KEhUVFBSZXNwb25zZUhlYWRlclZhbGlkYXRvcik7CiBwdWJsaWM6CkBAIC05Nyw3ICs5OCw3IEBA IHZvaWQgSFRUUFJlc3BvbnNlSGVhZGVyVmFsaWRhdG9yOjp2aXNpdEgKIHsKICAgICBTdHJpbmcg aGVhZGVyTmFtZShuYW1lKTsKICAgICBpZiAobV91c2luZ0FjY2Vzc0NvbnRyb2wpIHsKLSAgICAg ICAgaWYgKGVxdWFsSWdub3JpbmdDYXNlKGhlYWRlck5hbWUsICJhY2Nlc3MtY29udHJvbC1leHBv c2UtaGVhZGVyIikpCisgICAgICAgIGlmIChlcXVhbElnbm9yaW5nQ2FzZShoZWFkZXJOYW1lLCAi YWNjZXNzLWNvbnRyb2wtZXhwb3NlLWhlYWRlcnMiKSkKICAgICAgICAgICAgIHBhcnNlQWNjZXNz Q29udHJvbEV4cG9zZUhlYWRlcnNBbGxvd0xpc3QodmFsdWUsIG1fZXhwb3NlZEhlYWRlcnMpOwog ICAgICAgICBlbHNlIGlmICghaXNPbkFjY2Vzc0NvbnRyb2xSZXNwb25zZUhlYWRlcldoaXRlbGlz dChoZWFkZXJOYW1lKSkKICAgICAgICAgICAgIG1fYmxvY2tlZEhlYWRlcnMuYWRkKG5hbWUpOwpA QCAtMTEyLDcgKzExMyw3IEBAIGNvbnN0IEhUVFBIZWFkZXJTZXQmIEhUVFBSZXNwb25zZUhlYWRl clYKICAgICAgICAgbV9leHBvc2VkSGVhZGVycy5yZW1vdmUoInNldC1jb29raWUiKTsKICAgICAg ICAgbV9leHBvc2VkSGVhZGVycy5yZW1vdmUoInNldC1jb29raWUyIik7CiAgICAgICAgIC8vIEJs b2NrIEFjY2Vzcy1Db250cm9sLUV4cG9zZS1IZWFkZXIgaXRzZWxmLiBJdCBjb3VsZCBiZSBleHBv c2VkIGxhdGVyLgotICAgICAgICBtX2Jsb2NrZWRIZWFkZXJzLmFkZCgiYWNjZXNzLWNvbnRyb2wt ZXhwb3NlLWhlYWRlciIpOworICAgICAgICBtX2Jsb2NrZWRIZWFkZXJzLmFkZCgiYWNjZXNzLWNv bnRyb2wtZXhwb3NlLWhlYWRlcnMiKTsKICAgICAgICAgSFRUUEhlYWRlclNldDo6Y29uc3RfaXRl cmF0b3IgZW5kID0gbV9leHBvc2VkSGVhZGVycy5lbmQoKTsKICAgICAgICAgZm9yIChIVFRQSGVh ZGVyU2V0Ojpjb25zdF9pdGVyYXRvciBpdCA9IG1fZXhwb3NlZEhlYWRlcnMuYmVnaW4oKTsgaXQg IT0gZW5kOyArK2l0KQogICAgICAgICAgICAgbV9ibG9ja2VkSGVhZGVycy5yZW1vdmUoKml0KTsK SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQXNzb2NpYXRlZFVSTExvYWRlclRl c3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQXNzb2Np YXRlZFVSTExvYWRlclRlc3QuY3BwCShyZXZpc2lvbiAxMDkyMzIpCisrKyBTb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3Rlc3RzL0Fzc29jaWF0ZWRVUkxMb2FkZXJUZXN0LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMjQxLDcgKzI0MSw3IEBAIHB1YmxpYzoKICAgICAgICAgbV9leHBlY3RlZFJlc3BvbnNl LnNldE1JTUVUeXBlKCJ0ZXh0L2h0bWwiKTsKICAgICAgICAgbV9leHBlY3RlZFJlc3BvbnNlLmFk ZEhUVFBIZWFkZXJGaWVsZCgiQWNjZXNzLUNvbnRyb2wtQWxsb3ctT3JpZ2luIiwgIioiKTsKICAg ICAgICAgaWYgKGV4cG9zZWQpCi0gICAgICAgICAgICBtX2V4cGVjdGVkUmVzcG9uc2UuYWRkSFRU UEhlYWRlckZpZWxkKCJhY2Nlc3MtY29udHJvbC1leHBvc2UtaGVhZGVyIiwgaGVhZGVyTmFtZVN0 cmluZyk7CisgICAgICAgICAgICBtX2V4cGVjdGVkUmVzcG9uc2UuYWRkSFRUUEhlYWRlckZpZWxk KCJhY2Nlc3MtY29udHJvbC1leHBvc2UtaGVhZGVycyIsIGhlYWRlck5hbWVTdHJpbmcpOwogICAg ICAgICBtX2V4cGVjdGVkUmVzcG9uc2UuYWRkSFRUUEhlYWRlckZpZWxkKGhlYWRlck5hbWVTdHJp bmcsICJmb28iKTsKICAgICAgICAgd2Via2l0X3N1cHBvcnQ6OlJlZ2lzdGVyTW9ja2VkVVJMKHVy bCwgbV9leHBlY3RlZFJlc3BvbnNlLCBtX2ZyYW1lRmlsZVBhdGgpOwogCg==