80192 2012-03-02 14:02:08 -0800 [Chromium] [WebSocket] use OVERRIDE in WebSocketImpl.h 2012-03-05 10:58:06 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 toyoshim toyoshim webkit.review.bot oldest_to_newest 569917 0 toyoshim 2012-03-02 14:02:08 -0800 WebKit/chromium/src/WebSocketImpl.h doesn't use OVERRIDE macro. Also binaryType() lack 'virtual' declaration. 569924 1 129956 toyoshim 2012-03-02 14:07:30 -0800 Created attachment 129956 Patch 570055 2 129956 tkent 2012-03-02 17:23:03 -0800 Comment on attachment 129956 Patch ok 570074 3 129956 webkit.review.bot 2012-03-02 18:43:00 -0800 Comment on attachment 129956 Patch Rejecting attachment 129956 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: _by_email return self._reviewer_only(self.account_by_email(email)) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 632, in account_by_email return self._email_to_account_map().get(email.lower()) if email else None File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 525, in _email_to_account_map assert(email not in self._accounts_by_email) # We should never have duplicate emails. AssertionError Full output: http://queues.webkit.org/results/11803226 570774 4 129956 toyoshim 2012-03-05 09:27:38 -0800 Comment on attachment 129956 Patch try cq+ again 570842 5 129956 webkit.review.bot 2012-03-05 10:58:00 -0800 Comment on attachment 129956 Patch Clearing flags on attachment: 129956 Committed r109771: <http://trac.webkit.org/changeset/109771> 570843 6 webkit.review.bot 2012-03-05 10:58:06 -0800 All reviewed patches have been landed. Closing bug. 129956 2012-03-02 14:07:30 -0800 2012-03-05 10:58:00 -0800 Patch bug-80192-20120303070716.patch text/plain 3266 toyoshim U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5MzgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDgxNTc0MDkwMzQ0MzMwM2JhYzhmZDM0YmJjOTJmZWFhZmM5ZTI0ZTEuLmRjYWUxYjZjODdlOTg1 NmVmNjY0MTYwM2Q0MmY0MmNmOWVkMzMyOTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTItMDMtMDIgIFRha2FzaGkgVG95b3NoaW1hICA8dG95b3NoaW1A Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gW1dlYlNvY2tldF0gdXNlIE9WRVJS SURFIGluIFdlYlNvY2tldEltcGwuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODAxOTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHNyYy9XZWJTb2NrZXRJbXBsLmg6IHVzZSBPVkVSUklERSBtYWNyby4K KyAgICAgICAgKFdlYlNvY2tldEltcGwpOgorCiAyMDEyLTAzLTAxICBLZW50YXJvIEhhcmEgIDxo YXJha2VuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSRUdSRVNTSU9OKHIxMDkyODgpOiBXZWJW aWV3SW1wbDo6ZW5hYmxlQXV0b1Jlc2l6ZU1vZGUgbG9vcHMgaW5maW5pdGVseQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU29ja2V0SW1wbC5oIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViU29ja2V0SW1wbC5oCmluZGV4IDNkNDJiZDUwNmI0NjNiNjgy MWJiNjIxMTZmMWQyMWFmMDQyYTFlNDUuLjkxNTRjZjVhNmYxMDg2NjNmOTBjOWM3YWI1MjY2ZDQy NDZiMmUzZTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNvY2tl dEltcGwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTb2NrZXRJbXBsLmgK QEAgLTUzLDI1ICs1MywyNSBAQCBwdWJsaWM6CiAKICAgICBib29sIGlzTnVsbCgpIGNvbnN0IHsg cmV0dXJuICFtX3ByaXZhdGU7IH0KIAotICAgIEJpbmFyeVR5cGUgYmluYXJ5VHlwZSgpIGNvbnN0 OwotICAgIHZpcnR1YWwgYm9vbCBzZXRCaW5hcnlUeXBlKEJpbmFyeVR5cGUpOwotICAgIHZpcnR1 YWwgdm9pZCBjb25uZWN0KGNvbnN0IFdlYlVSTCYsIGNvbnN0IFdlYlN0cmluZyYgcHJvdG9jb2wp OwotICAgIHZpcnR1YWwgV2ViU3RyaW5nIHN1YnByb3RvY29sKCk7Ci0gICAgdmlydHVhbCBib29s IHNlbmRUZXh0KGNvbnN0IFdlYlN0cmluZyYpOwotICAgIHZpcnR1YWwgYm9vbCBzZW5kQXJyYXlC dWZmZXIoY29uc3QgV2ViQXJyYXlCdWZmZXImKTsKLSAgICB2aXJ0dWFsIHVuc2lnbmVkIGxvbmcg YnVmZmVyZWRBbW91bnQoKSBjb25zdDsKLSAgICB2aXJ0dWFsIHZvaWQgY2xvc2UoaW50IGNvZGUs IGNvbnN0IFdlYlN0cmluZyYgcmVhc29uKTsKLSAgICB2aXJ0dWFsIHZvaWQgZmFpbChjb25zdCBX ZWJTdHJpbmcmIHJlYXNvbik7Ci0gICAgdmlydHVhbCB2b2lkIGRpc2Nvbm5lY3QoKTsKKyAgICB2 aXJ0dWFsIEJpbmFyeVR5cGUgYmluYXJ5VHlwZSgpIGNvbnN0IE9WRVJSSURFOworICAgIHZpcnR1 YWwgYm9vbCBzZXRCaW5hcnlUeXBlKEJpbmFyeVR5cGUpIE9WRVJSSURFOworICAgIHZpcnR1YWwg dm9pZCBjb25uZWN0KGNvbnN0IFdlYlVSTCYsIGNvbnN0IFdlYlN0cmluZyYgcHJvdG9jb2wpIE9W RVJSSURFOworICAgIHZpcnR1YWwgV2ViU3RyaW5nIHN1YnByb3RvY29sKCkgT1ZFUlJJREU7Cisg ICAgdmlydHVhbCBib29sIHNlbmRUZXh0KGNvbnN0IFdlYlN0cmluZyYpIE9WRVJSSURFOworICAg IHZpcnR1YWwgYm9vbCBzZW5kQXJyYXlCdWZmZXIoY29uc3QgV2ViQXJyYXlCdWZmZXImKSBPVkVS UklERTsKKyAgICB2aXJ0dWFsIHVuc2lnbmVkIGxvbmcgYnVmZmVyZWRBbW91bnQoKSBjb25zdCBP VkVSUklERTsKKyAgICB2aXJ0dWFsIHZvaWQgY2xvc2UoaW50IGNvZGUsIGNvbnN0IFdlYlN0cmlu ZyYgcmVhc29uKSBPVkVSUklERTsKKyAgICB2aXJ0dWFsIHZvaWQgZmFpbChjb25zdCBXZWJTdHJp bmcmIHJlYXNvbikgT1ZFUlJJREU7CisgICAgdmlydHVhbCB2b2lkIGRpc2Nvbm5lY3QoKSBPVkVS UklERTsKIAogICAgIC8vIFdlYlNvY2tldENoYW5uZWxDbGllbnQKLSAgICB2aXJ0dWFsIHZvaWQg ZGlkQ29ubmVjdCgpOwotICAgIHZpcnR1YWwgdm9pZCBkaWRSZWNlaXZlTWVzc2FnZShjb25zdCBT dHJpbmcmIG1lc3NhZ2UpOwotICAgIHZpcnR1YWwgdm9pZCBkaWRSZWNlaXZlQmluYXJ5RGF0YShQ YXNzT3duUHRyPFZlY3RvcjxjaGFyPiA+IGJpbmFyeURhdGEpOwotICAgIHZpcnR1YWwgdm9pZCBk aWRSZWNlaXZlTWVzc2FnZUVycm9yKCk7Ci0gICAgdmlydHVhbCB2b2lkIGRpZFVwZGF0ZUJ1ZmZl cmVkQW1vdW50KHVuc2lnbmVkIGxvbmcgYnVmZmVyZWRBbW91bnQpOwotICAgIHZpcnR1YWwgdm9p ZCBkaWRTdGFydENsb3NpbmdIYW5kc2hha2UoKTsKLSAgICB2aXJ0dWFsIHZvaWQgZGlkQ2xvc2Uo dW5zaWduZWQgbG9uZyBidWZmZXJlZEFtb3VudCwgQ2xvc2luZ0hhbmRzaGFrZUNvbXBsZXRpb25T dGF0dXMsIHVuc2lnbmVkIHNob3J0IGNvZGUsIGNvbnN0IFN0cmluZyYgcmVhc29uKTsKKyAgICB2 aXJ0dWFsIHZvaWQgZGlkQ29ubmVjdCgpIE9WRVJSSURFOworICAgIHZpcnR1YWwgdm9pZCBkaWRS ZWNlaXZlTWVzc2FnZShjb25zdCBTdHJpbmcmIG1lc3NhZ2UpIE9WRVJSSURFOworICAgIHZpcnR1 YWwgdm9pZCBkaWRSZWNlaXZlQmluYXJ5RGF0YShQYXNzT3duUHRyPFZlY3RvcjxjaGFyPiA+IGJp bmFyeURhdGEpIE9WRVJSSURFOworICAgIHZpcnR1YWwgdm9pZCBkaWRSZWNlaXZlTWVzc2FnZUVy cm9yKCkgT1ZFUlJJREU7CisgICAgdmlydHVhbCB2b2lkIGRpZFVwZGF0ZUJ1ZmZlcmVkQW1vdW50 KHVuc2lnbmVkIGxvbmcgYnVmZmVyZWRBbW91bnQpIE9WRVJSSURFOworICAgIHZpcnR1YWwgdm9p ZCBkaWRTdGFydENsb3NpbmdIYW5kc2hha2UoKSBPVkVSUklERTsKKyAgICB2aXJ0dWFsIHZvaWQg ZGlkQ2xvc2UodW5zaWduZWQgbG9uZyBidWZmZXJlZEFtb3VudCwgQ2xvc2luZ0hhbmRzaGFrZUNv bXBsZXRpb25TdGF0dXMsIHVuc2lnbmVkIHNob3J0IGNvZGUsIGNvbnN0IFN0cmluZyYgcmVhc29u KSBPVkVSUklERTsKIAogcHJpdmF0ZToKICAgICBSZWZQdHI8V2ViQ29yZTo6V2ViU29ja2V0Q2hh bm5lbD4gbV9wcml2YXRlOwo=