80190 2012-03-02 13:41:58 -0800 [Chromium] [WebSocket] Add WebSocket extensions query WebKit API 2012-03-06 02:17:40 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 toyoshim toyoshim abarth bashi fishd tkent webkit.review.bot yutak oldest_to_newest 569899 0 toyoshim 2012-03-02 13:41:58 -0800 Recently, Ishibashi-san implement extensions property on WebSocket. This must be exported as WebKit API, too. 569905 1 129952 toyoshim 2012-03-02 13:47:28 -0800 Created attachment 129952 Patch 569911 2 webkit.review.bot 2012-03-02 13:50:49 -0800 Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. 571032 3 130202 toyoshim 2012-03-05 14:09:23 -0800 Created attachment 130202 Patch 571035 4 toyoshim 2012-03-05 14:11:12 -0800 I rebased the patch. Now, WebSocketImpl uses OVERRIDE macro. 571677 5 130202 webkit.review.bot 2012-03-06 02:17:27 -0800 Comment on attachment 130202 Patch Clearing flags on attachment: 130202 Committed r109889: <http://trac.webkit.org/changeset/109889> 571678 6 webkit.review.bot 2012-03-06 02:17:40 -0800 All reviewed patches have been landed. Closing bug. 129952 2012-03-02 13:47:28 -0800 2012-03-05 14:09:16 -0800 Patch bug-80190-20120303064727.patch text/plain 2882 toyoshim U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5MzgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDgxNTc0MDkwMzQ0MzMwM2JhYzhmZDM0YmJjOTJmZWFhZmM5ZTI0ZTEuLmM2YWE4ZWRiZWRiZTZm ZWQyOWZmODQ3NDgwYjRiMzM2NWY3OTU1NzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTItMDMtMDIgIFRha2FzaGkgVG95b3NoaW1hICA8dG95b3NoaW1A Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gW1dlYlNvY2tldF0gQWRkIFdlYlNv Y2tldCBleHRlbnNpb25zIHF1ZXJ5IFdlYktpdCBBUEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgwMTkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViU29ja2V0Lmg6IEFkZCBleHRlbnNp b25zKCkgZGVjbGFyYXRpb24uCisgICAgICAgIChXZWJTb2NrZXQpOgorICAgICAgICAqIHNyYy9X ZWJTb2NrZXRJbXBsLmNwcDogSW1wbGVtZW50IGV4dGVuc2lvbnMoKSBicmlkZ2UuCisgICAgICAg IChXZWJLaXQ6OldlYlNvY2tldEltcGw6OmV4dGVuc2lvbnMpOgorICAgICAgICAoV2ViS2l0KToK KyAgICAgICAgKiBzcmMvV2ViU29ja2V0SW1wbC5oOiBBZGQgZXh0ZW5zaW9ucygpIGRlY2xhcmF0 aW9uLgorICAgICAgICAoV2ViU29ja2V0SW1wbCk6CisKIDIwMTItMDMtMDEgIEtlbnRhcm8gSGFy YSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjEwOTI4OCk6 IFdlYlZpZXdJbXBsOjplbmFibGVBdXRvUmVzaXplTW9kZSBsb29wcyBpbmZpbml0ZWx5CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTb2NrZXQuaCBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNvY2tldC5oCmluZGV4IGMxMGMzNzJhZGU4ZjEy ZGU0YWUxZWE5ZjUyMjFkNDNhMjMyZDBlMDguLmYyYTE0MGNmYWFmMzhmMDUyZTVhNjIzODhmYzA3 MmQ4MmMwM2M0YWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dl YlNvY2tldC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNvY2tldC5o CkBAIC04MCw2ICs4MCw3IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgdm9pZCBjb25uZWN0KGNv bnN0IFdlYlVSTCYsIGNvbnN0IFdlYlN0cmluZyYgcHJvdG9jb2wpID0gMDsKICAgICB2aXJ0dWFs IFdlYlN0cmluZyBzdWJwcm90b2NvbCgpID0gMDsKKyAgICB2aXJ0dWFsIFdlYlN0cmluZyBleHRl bnNpb25zKCkgPSAwOwogICAgIHZpcnR1YWwgYm9vbCBzZW5kVGV4dChjb25zdCBXZWJTdHJpbmcm KSA9IDA7CiAgICAgdmlydHVhbCBib29sIHNlbmRBcnJheUJ1ZmZlcihjb25zdCBXZWJBcnJheUJ1 ZmZlciYpID0gMDsKICAgICB2aXJ0dWFsIHVuc2lnbmVkIGxvbmcgYnVmZmVyZWRBbW91bnQoKSBj b25zdCA9IDA7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTb2Nr ZXRJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNvY2tldEltcGwuY3Bw CmluZGV4IGYwYmYyODIwNjc5N2U1NDIwZjQyYTlhMWRhYzUzOTc3OWYxYmFhZTcuLmJiYjE2MGYz YzY4MTAwZTc4ZGFiZTMwZWNmOWY0ODZlN2EwYjMxOGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYlNvY2tldEltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYlNvY2tldEltcGwuY3BwCkBAIC0xMDUsNiArMTA1LDE1IEBAIFdlYlN0cmlu ZyBXZWJTb2NrZXRJbXBsOjpzdWJwcm90b2NvbCgpCiAjZW5kaWYKIH0KIAorV2ViU3RyaW5nIFdl YlNvY2tldEltcGw6OmV4dGVuc2lvbnMoKQoreworI2lmIEVOQUJMRShXRUJfU09DS0VUUykKKyAg ICByZXR1cm4gbV9wcml2YXRlLT5leHRlbnNpb25zKCk7CisjZWxzZQorICAgIEFTU0VSVF9OT1Rf UkVBQ0hFRCgpOworI2VuZGlmCit9CisKIGJvb2wgV2ViU29ja2V0SW1wbDo6c2VuZFRleHQoY29u c3QgV2ViU3RyaW5nJiBtZXNzYWdlKQogewogI2lmIEVOQUJMRShXRUJfU09DS0VUUykKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNvY2tldEltcGwuaCBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNvY2tldEltcGwuaAppbmRleCAzZDQyYmQ1MDZiNDYz YjY4MjFiYjYyMTE2ZjFkMjFhZjA0MmExZTQ1Li40MGI3OWZiMTVkOTkzY2EwMTg5MThhMWUwY2Vi NmNiZDc3N2RkZGEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJT b2NrZXRJbXBsLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU29ja2V0SW1w bC5oCkBAIC01Nyw2ICs1Nyw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgc2V0QmluYXJ5 VHlwZShCaW5hcnlUeXBlKTsKICAgICB2aXJ0dWFsIHZvaWQgY29ubmVjdChjb25zdCBXZWJVUkwm LCBjb25zdCBXZWJTdHJpbmcmIHByb3RvY29sKTsKICAgICB2aXJ0dWFsIFdlYlN0cmluZyBzdWJw cm90b2NvbCgpOworICAgIHZpcnR1YWwgV2ViU3RyaW5nIGV4dGVuc2lvbnMoKTsKICAgICB2aXJ0 dWFsIGJvb2wgc2VuZFRleHQoY29uc3QgV2ViU3RyaW5nJik7CiAgICAgdmlydHVhbCBib29sIHNl bmRBcnJheUJ1ZmZlcihjb25zdCBXZWJBcnJheUJ1ZmZlciYpOwogICAgIHZpcnR1YWwgdW5zaWdu ZWQgbG9uZyBidWZmZXJlZEFtb3VudCgpIGNvbnN0Owo= 130202 2012-03-05 14:09:23 -0800 2012-03-06 02:17:27 -0800 Patch bug-80190-20120306070921.patch text/plain 2936 toyoshim U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5Nzg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGVjZjE2NTM0NDZiYTRiYzM0ZDMyMjJhNTNmMGUyNjA0MjVlMDQxYzkuLmU0MjEwMDcwMDQ4MTE0 MTY5NTMxZGU1ZTEzZDdmOTI1MTViYzBhOTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTItMDMtMDUgIFRha2FzaGkgVG95b3NoaW1hICA8dG95b3NoaW1A Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gW1dlYlNvY2tldF0gQWRkIFdlYlNv Y2tldCBleHRlbnNpb25zIHF1ZXJ5IFdlYktpdCBBUEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgwMTkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViU29ja2V0Lmg6IEFkZCBleHRlbnNp b25zKCkgZGVjbGFyYXRpb24uCisgICAgICAgIChXZWJTb2NrZXQpOgorICAgICAgICAqIHNyYy9X ZWJTb2NrZXRJbXBsLmNwcDogSW1wbGVtZW50IGV4dGVuc2lvbnMoKSBicmlkZ2UuCisgICAgICAg IChXZWJLaXQ6OldlYlNvY2tldEltcGw6OmV4dGVuc2lvbnMpOgorICAgICAgICAoV2ViS2l0KToK KyAgICAgICAgKiBzcmMvV2ViU29ja2V0SW1wbC5oOiBBZGQgZXh0ZW5zaW9ucygpIGRlY2xhcmF0 aW9uLgorICAgICAgICAoV2ViU29ja2V0SW1wbCk6CisKIDIwMTItMDMtMDUgIENoYXJsaWUgUmVp cyAgPGNyZWlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIFBhc3MgV2ViTmF2 aWdhdGlvblBvbGljeSB0byBXZWJWaWV3Q2xpZW50OjpjcmVhdGVWaWV3CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTb2NrZXQuaCBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYlNvY2tldC5oCmluZGV4IGMxMGMzNzJhZGU4ZjEyZGU0YWUxZWE5 ZjUyMjFkNDNhMjMyZDBlMDguLmYyYTE0MGNmYWFmMzhmMDUyZTVhNjIzODhmYzA3MmQ4MmMwM2M0 YWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNvY2tldC5o CisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNvY2tldC5oCkBAIC04MCw2 ICs4MCw3IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgdm9pZCBjb25uZWN0KGNvbnN0IFdlYlVS TCYsIGNvbnN0IFdlYlN0cmluZyYgcHJvdG9jb2wpID0gMDsKICAgICB2aXJ0dWFsIFdlYlN0cmlu ZyBzdWJwcm90b2NvbCgpID0gMDsKKyAgICB2aXJ0dWFsIFdlYlN0cmluZyBleHRlbnNpb25zKCkg PSAwOwogICAgIHZpcnR1YWwgYm9vbCBzZW5kVGV4dChjb25zdCBXZWJTdHJpbmcmKSA9IDA7CiAg ICAgdmlydHVhbCBib29sIHNlbmRBcnJheUJ1ZmZlcihjb25zdCBXZWJBcnJheUJ1ZmZlciYpID0g MDsKICAgICB2aXJ0dWFsIHVuc2lnbmVkIGxvbmcgYnVmZmVyZWRBbW91bnQoKSBjb25zdCA9IDA7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTb2NrZXRJbXBsLmNw cCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNvY2tldEltcGwuY3BwCmluZGV4IGYw YmYyODIwNjc5N2U1NDIwZjQyYTlhMWRhYzUzOTc3OWYxYmFhZTcuLmJiYjE2MGYzYzY4MTAwZTc4 ZGFiZTMwZWNmOWY0ODZlN2EwYjMxOGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYlNvY2tldEltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYlNvY2tldEltcGwuY3BwCkBAIC0xMDUsNiArMTA1LDE1IEBAIFdlYlN0cmluZyBXZWJTb2Nr ZXRJbXBsOjpzdWJwcm90b2NvbCgpCiAjZW5kaWYKIH0KIAorV2ViU3RyaW5nIFdlYlNvY2tldElt cGw6OmV4dGVuc2lvbnMoKQoreworI2lmIEVOQUJMRShXRUJfU09DS0VUUykKKyAgICByZXR1cm4g bV9wcml2YXRlLT5leHRlbnNpb25zKCk7CisjZWxzZQorICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgp OworI2VuZGlmCit9CisKIGJvb2wgV2ViU29ja2V0SW1wbDo6c2VuZFRleHQoY29uc3QgV2ViU3Ry aW5nJiBtZXNzYWdlKQogewogI2lmIEVOQUJMRShXRUJfU09DS0VUUykKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNvY2tldEltcGwuaCBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYlNvY2tldEltcGwuaAppbmRleCA5MTU0Y2Y1YTZmMTA4NjYzZjkwYzlj N2FiNTI2NmQ0MjQ2YjJlM2U0Li5lZjE0YjE4Yzc3MWZkZTI2NGRhYWEzOTE2YmIyMjFiMDU2NmE2 YTE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTb2NrZXRJbXBs LmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU29ja2V0SW1wbC5oCkBAIC01 Nyw2ICs1Nyw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgc2V0QmluYXJ5VHlwZShCaW5h cnlUeXBlKSBPVkVSUklERTsKICAgICB2aXJ0dWFsIHZvaWQgY29ubmVjdChjb25zdCBXZWJVUkwm LCBjb25zdCBXZWJTdHJpbmcmIHByb3RvY29sKSBPVkVSUklERTsKICAgICB2aXJ0dWFsIFdlYlN0 cmluZyBzdWJwcm90b2NvbCgpIE9WRVJSSURFOworICAgIHZpcnR1YWwgV2ViU3RyaW5nIGV4dGVu c2lvbnMoKSBPVkVSUklERTsKICAgICB2aXJ0dWFsIGJvb2wgc2VuZFRleHQoY29uc3QgV2ViU3Ry aW5nJikgT1ZFUlJJREU7CiAgICAgdmlydHVhbCBib29sIHNlbmRBcnJheUJ1ZmZlcihjb25zdCBX ZWJBcnJheUJ1ZmZlciYpIE9WRVJSSURFOwogICAgIHZpcnR1YWwgdW5zaWduZWQgbG9uZyBidWZm ZXJlZEFtb3VudCgpIGNvbnN0IE9WRVJSSURFOwo=