80180 2012-03-02 12:18:02 -0800 links for virtual tests are broken in the flakiness dashboard 2012-03-02 13:13:33 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth eric ojan tony oldest_to_newest 569836 0 dpranke 2012-03-02 12:18:02 -0800 links for virtual tests are broken in the flakiness dashboard 569838 1 129936 dpranke 2012-03-02 12:18:25 -0800 Created attachment 129936 Patch 569841 2 dpranke 2012-03-02 12:20:15 -0800 It looks like there is only one minor tweak needed to make the flakiness dashboard work with virtual tests - it mostly works now, just the link to the test in trac is broken. It turns out we got "lucky" in that the flakiness dashboard only looks at the results of the run, and by the time links end up in the results the actual/virtual distinction is gone (all tests look the same). 569842 3 dpranke 2012-03-02 12:20:33 -0800 How do I run tests for this, and does it make sense to add a test for this? 569846 4 129936 ojan 2012-03-02 12:25:09 -0800 Comment on attachment 129936 Patch Please do add a test. The test suite for this code is pretty...bare, but testing this specific thing should be easy enough. The tests are in flakiness_dashboard_tests.js, you run them in the browser by loading flakiness_dashboard#useTestData=true off your local disk. It's wonky, but good enough for now. :) Did you test loading the expected results for the test, e.g. a page like http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=fast%2Fjs%2Fnavigator-language.html? The test itself should be one of the frames. Also, we show all the expected results in the fallback order. How does the fallback order for virtual tests work? You probably need to update that code as well. 569850 5 dpranke 2012-03-02 12:30:07 -0800 (In reply to comment #3) > How do I run tests for this, and does it make sense to add a test for this? (In reply to comment #4) > (From update of attachment 129936 [details]) > Please do add a test. The test suite for this code is pretty...bare, but testing this specific thing should be easy enough. The tests are in flakiness_dashboard_tests.js, you run them in the browser by loading flakiness_dashboard#useTestData=true off your local disk. It's wonky, but good enough for now. :) > Will do. > Did you test loading the expected results for the test, e.g. a page like http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=fast%2Fjs%2Fnavigator-language.html? The test itself should be one of the frames. Also, we show all the expected results in the fallback order. How does the fallback order for virtual tests work? You probably need to update that code as well. Hm. I thought I did and it looked like it was working, but when I look at it now, I'm not seeing them. I will work on it some more as a different bug/patch. 569873 6 129946 dpranke 2012-03-02 13:09:20 -0800 Created attachment 129946 Patch 569877 7 129946 dpranke 2012-03-02 13:13:28 -0800 Comment on attachment 129946 Patch Clearing flags on attachment: 129946 Committed r109606: <http://trac.webkit.org/changeset/109606> 569878 8 dpranke 2012-03-02 13:13:33 -0800 All reviewed patches have been landed. Closing bug. 129936 2012-03-02 12:18:25 -0800 2012-03-02 13:09:17 -0800 Patch bug-80180-20120302121823.patch text/plain 1377 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5NTk3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjE3ZjVkYjUwZWQ3MGU1N2MwZjAxY2MzOGI4N2UxNzEx YWRiY2ZkOS4uNmE4ZmRhMjc4OTg0NGI3OTFhMjZhYTcwOTI4YzUzYmJkOTgwOTU0MSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDEyLTAzLTAyICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIGxpbmtzIGZvciB2aXJ0dWFsIHRlc3RzIGFyZSBicm9rZW4gaW4gdGhlIGZsYWtpbmVz cyBkYXNoYm9hcmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTgwMTgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBUZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2ZsYWtpbmVzc19kYXNoYm9h cmQuaHRtbDoKKwogMjAxMi0wMy0wMiAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxp YS5jb20+CiAKICAgICAgICAgW0dUS10gc2VjdXJpdHkvYmxvY2stdGVzdC5odG1sIGJhc2VsaW5l cyBkaWZmZXIgZnJvbSBtYWMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3Rh dGljLWRhc2hib2FyZHMvZmxha2luZXNzX2Rhc2hib2FyZC5odG1sIGIvVG9vbHMvVGVzdFJlc3Vs dFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9mbGFraW5lc3NfZGFzaGJvYXJkLmh0bWwKaW5kZXgg MDllZDJhYzZiNGFiY2RiMjJhOWViNmEwNjM0MWMyZTA3N2QwZWQ0Yi4uNTExMmRiYzFmMzI5MTAx Zjg4OGU4NmZhMzAzYjIyMWU0NGEzYjBjOSAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFJlc3VsdFNl cnZlci9zdGF0aWMtZGFzaGJvYXJkcy9mbGFraW5lc3NfZGFzaGJvYXJkLmh0bWwKKysrIGIvVG9v bHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9mbGFraW5lc3NfZGFzaGJvYXJk Lmh0bWwKQEAgLTExNzQsNiArMTE3NCw5IEBAIGZ1bmN0aW9uIGh0bWxGb3JCdWdzKGJ1Z3MpCiAK IGZ1bmN0aW9uIGxpbmtIVE1MVG9PcGVuV2luZG93KHVybCwgdGV4dCkKIHsKKyAgICAvLyBGSVhN RTogV2UgcHJvYmFibHkgbmVlZCBhIG1vcmUgZ2VuZXJhbCB3YXkgdG8gbWFwIHZpcnR1YWwgdGVz dHMKKyAgICAvLyB0byB0aGVpciB1bmRlcmx5aW5nIGFjdHVhbCB0ZXN0cy4KKyAgICB1cmwgPSB1 cmwucmVwbGFjZSgncGxhdGZvcm0vY2hyb21pdW0vdmlydHVhbC9ncHUnLCAnJykKICAgICByZXR1 cm4gJzxhIGhyZWY9IicgKyB1cmwgKyAnIiB0YXJnZXQ9Il9ibGFuayI+JyArIHRleHQgKyAnPC9h Pic7CiB9CiAK 129946 2012-03-02 13:09:20 -0800 2012-03-02 13:13:28 -0800 Patch bug-80180-20120302130919.patch text/plain 2689 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5NTk3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjE3ZjVkYjUwZWQ3MGU1N2MwZjAxY2MzOGI4N2UxNzEx YWRiY2ZkOS4uY2RiOGMxN2I0N2MwNmE4MzBiN2U2ZDE2NzI0ZjBiOTk0ZDY2NDhhOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTAzLTAyICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIGxpbmtzIGZvciB2aXJ0dWFsIHRlc3RzIGFyZSBicm9rZW4gaW4gdGhlIGZsYWtpbmVz cyBkYXNoYm9hcmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTgwMTgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBUZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2ZsYWtpbmVzc19kYXNoYm9h cmQuaHRtbDoKKyAgICAgICAgKGxpbmtIVE1MVG9PcGVuV2luZG93KToKKyAgICAgICAgKiBUZXN0 UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2ZsYWtpbmVzc19kYXNoYm9hcmRfdGVzdHMu anM6CisgICAgICAgICh0ZXN0TGlua0hUTUxUb09wZW5XaW5kb3cpOiBhZGRlZC4KKwogMjAxMi0w My0wMiAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAgICAgICAg W0dUS10gc2VjdXJpdHkvYmxvY2stdGVzdC5odG1sIGJhc2VsaW5lcyBkaWZmZXIgZnJvbSBtYWMK ZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvZmxh a2luZXNzX2Rhc2hib2FyZC5odG1sIGIvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFz aGJvYXJkcy9mbGFraW5lc3NfZGFzaGJvYXJkLmh0bWwKaW5kZXggMDllZDJhYzZiNGFiY2RiMjJh OWViNmEwNjM0MWMyZTA3N2QwZWQ0Yi4uMzdiYmIzMTk0NGQ2NmE3YzU1MzJlZTM2NmJjMGViZGJk NzRlZTA5ZSAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJv YXJkcy9mbGFraW5lc3NfZGFzaGJvYXJkLmh0bWwKKysrIGIvVG9vbHMvVGVzdFJlc3VsdFNlcnZl ci9zdGF0aWMtZGFzaGJvYXJkcy9mbGFraW5lc3NfZGFzaGJvYXJkLmh0bWwKQEAgLTExNzQsNiAr MTE3NCw5IEBAIGZ1bmN0aW9uIGh0bWxGb3JCdWdzKGJ1Z3MpCiAKIGZ1bmN0aW9uIGxpbmtIVE1M VG9PcGVuV2luZG93KHVybCwgdGV4dCkKIHsKKyAgICAvLyBGSVhNRTogV2UgcHJvYmFibHkgbmVl ZCBhIG1vcmUgZ2VuZXJhbCB3YXkgdG8gbWFwIHZpcnR1YWwgdGVzdHMKKyAgICAvLyB0byB0aGVp ciB1bmRlcmx5aW5nIGFjdHVhbCB0ZXN0cy4KKyAgICB1cmwgPSB1cmwucmVwbGFjZSgncGxhdGZv cm0vY2hyb21pdW0vdmlydHVhbC9ncHUvJywgJycpCiAgICAgcmV0dXJuICc8YSBocmVmPSInICsg dXJsICsgJyIgdGFyZ2V0PSJfYmxhbmsiPicgKyB0ZXh0ICsgJzwvYT4nOwogfQogCmRpZmYgLS1n aXQgYS9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2ZsYWtpbmVzc19k YXNoYm9hcmRfdGVzdHMuanMgYi9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9h cmRzL2ZsYWtpbmVzc19kYXNoYm9hcmRfdGVzdHMuanMKaW5kZXggNTY1MmIyNjk2MWIyOGE4MGQ2 MTJhNWVmZWNiMzhiMTgzMTNiOGRlMC4uZjc0NTQ0YjU1YTc5ODc4NTMyN2JhZGViMmVmY2Y2Njk5 MWUyZjdlZiAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJv YXJkcy9mbGFraW5lc3NfZGFzaGJvYXJkX3Rlc3RzLmpzCisrKyBiL1Rvb2xzL1Rlc3RSZXN1bHRT ZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvZmxha2luZXNzX2Rhc2hib2FyZF90ZXN0cy5qcwpAQCAt NDA0LDYgKzQwNCwxNiBAQCBmdW5jdGlvbiB0ZXN0SHRtbEZvclRlc3RUeXBlU3dpdGNoZXJHcm91 cCgpCiAgICAgYXNzZXJ0RXF1YWxzKGdyb3VwLmNoaWxkcmVuLmxlbmd0aCwgNCk7CiB9CiAKK2Z1 bmN0aW9uIHRlc3RMaW5rSFRNTFRvT3BlbldpbmRvdygpCit7CisgICAgdmFyIHRleHQgPSAndGV4 dCc7CisgICAgLy8gVGVzdCB0aGF0IHdlIG1hcCByZWd1bGFyIHRlc3RzIGFuZCB2aXJ0dWFsIHRl c3RzIHByb3Blcmx5LgorICAgIHNlbGYuYXNzZXJ0RXF1YWxzKGxpbmtIVE1MVG9PcGVuV2luZG93 KCdodHRwOi8vbG9jYWxob3N0L2Zhc3QvY2FudmFzL2Zvby5odG1sJywgdGV4dCksCisgICAgICAg ICAgICAgICAgICAgICAgJzxhIGhyZWY9Imh0dHA6Ly9sb2NhbGhvc3QvZmFzdC9jYW52YXMvZm9v Lmh0bWwiIHRhcmdldD0iX2JsYW5rIj50ZXh0PC9hPicpOworICAgIHNlbGYuYXNzZXJ0RXF1YWxz KGxpbmtIVE1MVG9PcGVuV2luZG93KCdodHRwOi8vbG9jYWxob3N0L3BsYXRmb3JtL2Nocm9taXVt L3ZpcnR1YWwvZ3B1L2Zhc3QvY2FudmFzL2Zvby5odG1sJywgdGV4dCksCisgICAgICAgICAgICAg ICAgICAgICAgJzxhIGhyZWY9Imh0dHA6Ly9sb2NhbGhvc3QvZmFzdC9jYW52YXMvZm9vLmh0bWwi IHRhcmdldD0iX2JsYW5rIj50ZXh0PC9hPicpOworfQorCiBmdW5jdGlvbiBydW5UZXN0cygpCiB7 CiAgICAgZG9jdW1lbnQuYm9keS5pbm5lckhUTUwgPSAnPHByZSBpZD11bml0dGVzdC1yZXN1bHRz PjwvcHJlPic7Cg==