80179 2012-03-02 12:16:51 -0800 [Qt] Add support for vertical sliders in mobile theme 2012-03-14 12:46:15 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pierre.rossi pierre.rossi dglazkov webkit.review.bot oldest_to_newest 569834 0 pierre.rossi 2012-03-02 12:16:51 -0800 [Qt] Add support for vertical sliders in mobile theme 569849 1 129939 pierre.rossi 2012-03-02 12:29:32 -0800 Created attachment 129939 Patch 569980 2 129939 webkit.review.bot 2012-03-02 15:16:19 -0800 Comment on attachment 129939 Patch Attachment 129939 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11800151 New failing tests: editing/selection/select-line-break-with-opposite-directionality.html 573073 3 129939 hausmann 2012-03-07 11:45:32 -0800 Comment on attachment 129939 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129939&action=review > Source/WebCore/platform/qt/RenderThemeQtMobile.cpp:471 > + const int horizontalBorder = (vertical ? rect.width() / 4 : 0); > + const int verticalBorder = (vertical ? 0 : rect.height() / 4); I personally tend to leave out the extra pair of parentheses here. 578666 4 pierre.rossi 2012-03-14 12:46:15 -0700 Committed r110730: <http://trac.webkit.org/changeset/110730> 129939 2012-03-02 12:29:32 -0800 2012-03-07 11:45:32 -0800 Patch bug-80179-20120302213235.patch text/plain 5144 pierre.rossi U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5NTk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTIyNmJmOTkzZTE5MDVk YzE1Mjg0YTA5NGNiZDQwNmM2MDdmZTY2Ny4uOTYwZGE3NjIxMjc1YWUyZGVlM2E3YTFjN2Y1MGEx NWNiMzBjYTRjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAzLTAyICBQaWVy cmUgUm9zc2kgIDxwaWVycmUucm9zc2lAZ21haWwuY29tPgorCisgICAgICAgIFtRdF0gQWRkIHN1 cHBvcnQgZm9yIHZlcnRpY2FsIHNsaWRlcnMgaW4gbW9iaWxlIHRoZW1lCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MDE3OQorCisgICAgICAgIFRoaXMg bWFrZXMgc2xpZGVycyB1c2luZyB0aGUgInNsaWRlci12ZXJ0aWNhbCIgYXBwZWFyYW5jZSBtb3Jl IHNlbnNpYmxlLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cywgc2luY2UgdGhlIG1vYmlsZSB0aGVtZSBzdGlsbCBpc24ndCB1c2Vk IGluIGxheW91dCB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL3F0L1JlbmRlclRoZW1lUXRN b2JpbGUuY3BwOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZVBh aW50ZXJNb2JpbGU6OmRyYXdQcm9ncmVzcyk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVt ZVF0TW9iaWxlOjpwYWludFNsaWRlclRyYWNrKToKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9SZW5k ZXJUaGVtZVF0TW9iaWxlLmg6CisgICAgICAgIChTdHlsZVBhaW50ZXJNb2JpbGUpOgorCiAyMDEy LTAzLTAyICBNYWNpZWogU3RhY2hvd2lhayAgPG1qc0BhcHBsZS5jb20+CiAKICAgICAgICAgUkVH UkVTU0lPTihyOTczNTMpOiBDcmFzaCB3aGVuIGFjY2Vzc2luZyBsb2NhdGlvbiBvciBoaXN0b3J5 IHByb3BlcnRpZXMgaW5zaWRlIGEgbmF2aWdhdGVkIHdpbmRvdwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vcXQvUmVuZGVyVGhlbWVRdE1vYmlsZS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9xdC9SZW5kZXJUaGVtZVF0TW9iaWxlLmNwcAppbmRleCAyMDFhMWIyMDY4 NDRlNmFlMjljNzEzMThkOTJjNzMwMTZlMDNmZGM5Li5jMjRkMjBkZDIyMmEwNjM2NmM4MWQ3YmI3 NDhhOWRkZDE3ZDhjMDVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9S ZW5kZXJUaGVtZVF0TW9iaWxlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9S ZW5kZXJUaGVtZVF0TW9iaWxlLmNwcApAQCAtNTYsNyArNTYsNyBAQCBzdGF0aWMgY29uc3QgaW50 IGFycm93Qm94V2lkdGggPSAyNjsKIHN0YXRpYyBjb25zdCBpbnQgZnJhbWVXaWR0aCA9IDI7CiBz dGF0aWMgY29uc3QgaW50IGNoZWNrQm94V2lkdGggPSAyMTsKIHN0YXRpYyBjb25zdCBpbnQgcmFk aW9XaWR0aCA9IDIxOwotc3RhdGljIGNvbnN0IGludCBzbGlkZXJTaXplID0gMTk7CitzdGF0aWMg Y29uc3QgaW50IHNsaWRlclNpemUgPSAyMDsKIHN0YXRpYyBjb25zdCBpbnQgYnV0dG9uSGVpZ2h0 UmF0aW8gPSAxLjU7CiAKIHN0YXRpYyBjb25zdCBmbG9hdCBtdWx0aXBsZUNvbWJvRG90c09mZnNl dEZhY3RvciA9IDEuODsKQEAgLTQ2NSwxMyArNDY1LDE2IEBAIHZvaWQgU3R5bGVQYWludGVyTW9i aWxlOjpkcmF3Q29tYm9Cb3goY29uc3QgUVJlY3QmIHJlY3QsIGJvb2wgbXVsdGlwbGUsIGJvb2wg ZW5hCiAgICAgcGFpbnRlci0+ZHJhd1BpeG1hcCh0YXJnZXRSZWN0LnRvUmVjdCgpLCBwaWMpOwog fQogCi12b2lkIFN0eWxlUGFpbnRlck1vYmlsZTo6ZHJhd1Byb2dyZXNzKGNvbnN0IFFSZWN0JiBy ZWN0LCBkb3VibGUgcHJvZ3Jlc3MsIGJvb2wgbGVmdFRvUmlnaHQsIGJvb2wgYW5pbWF0ZWQpIGNv bnN0Cit2b2lkIFN0eWxlUGFpbnRlck1vYmlsZTo6ZHJhd1Byb2dyZXNzKGNvbnN0IFFSZWN0JiBy ZWN0LCBkb3VibGUgcHJvZ3Jlc3MsIGJvb2wgbGVmdFRvUmlnaHQsIGJvb2wgYW5pbWF0ZWQsIGJv b2wgdmVydGljYWwpIGNvbnN0CiB7Ci0gICAgY29uc3QgaW50IGJvcmRlciA9IHJlY3QuaGVpZ2h0 KCkgLyA0OwotICAgIGNvbnN0IFFSZWN0IHRhcmdldFJlY3QgPSByZWN0LmFkanVzdGVkKDAsIGJv cmRlciwgMCwgLWJvcmRlcik7CisgICAgY29uc3QgaW50IGhvcml6b250YWxCb3JkZXIgPSAodmVy dGljYWwgPyByZWN0LndpZHRoKCkgLyA0IDogMCk7CisgICAgY29uc3QgaW50IHZlcnRpY2FsQm9y ZGVyID0gKHZlcnRpY2FsID8gMCA6IHJlY3QuaGVpZ2h0KCkgLyA0KTsKKyAgICBjb25zdCBRUmVj dCB0YXJnZXRSZWN0ID0gcmVjdC5hZGp1c3RlZChob3Jpem9udGFsQm9yZGVyLCB2ZXJ0aWNhbEJv cmRlciwgLWhvcml6b250YWxCb3JkZXIsIC12ZXJ0aWNhbEJvcmRlcik7CiAKICAgICBRUGl4bWFw IHJlc3VsdDsKLSAgICBjb25zdCBRU2l6ZSBpbWFnZVNpemUgPSBzaXplRm9yUGFpbnRlclNjYWxl KHRhcmdldFJlY3QpOworICAgIFFTaXplIGltYWdlU2l6ZSA9IHNpemVGb3JQYWludGVyU2NhbGUo dGFyZ2V0UmVjdCk7CisgICAgaWYgKHZlcnRpY2FsKQorICAgICAgICBxU3dhcChpbWFnZVNpemUu cmhlaWdodCgpLCBpbWFnZVNpemUucndpZHRoKCkpOwogICAgIEtleUlkZW50aWZpZXIgaWQ7CiAg ICAgaWQudHlwZSA9IEtleUlkZW50aWZpZXI6OlByb2dyZXNzOwogICAgIGlkLndpZHRoID0gaW1h Z2VTaXplLndpZHRoKCk7CkBAIC01MTYsNyArNTE5LDkgQEAgdm9pZCBTdHlsZVBhaW50ZXJNb2Jp bGU6OmRyYXdQcm9ncmVzcyhjb25zdCBRUmVjdCYgcmVjdCwgZG91YmxlIHByb2dyZXNzLCBib29s IGwKICAgICAgICAgfQogICAgICAgICBpbnNlcnRJbnRvQ2FjaGUoaWQsIHJlc3VsdCk7CiAgICAg fQotICAgIHBhaW50ZXItPmRyYXdQaXhtYXAodGFyZ2V0UmVjdCwgcmVzdWx0KTsKKyAgICBRVHJh bnNmb3JtIHRyYW5zZm9ybTsKKyAgICB0cmFuc2Zvcm0ucm90YXRlKC05MCk7CisgICAgcGFpbnRl ci0+ZHJhd1BpeG1hcCh0YXJnZXRSZWN0LCB2ZXJ0aWNhbCA/IHJlc3VsdC50cmFuc2Zvcm1lZCh0 cmFuc2Zvcm0pIDogcmVzdWx0KTsKIH0KIAogdm9pZCBTdHlsZVBhaW50ZXJNb2JpbGU6OmRyYXdT bGlkZXJUaHVtYihjb25zdCBRUmVjdCAmIHJlY3QsIGJvb2wgcHJlc3NlZCkgY29uc3QKQEAgLTgw MSwxMCArODA2LDE0IEBAIGJvb2wgUmVuZGVyVGhlbWVRdE1vYmlsZTo6cGFpbnRTbGlkZXJUcmFj ayhSZW5kZXJPYmplY3QqIG8sIGNvbnN0IFBhaW50SW5mbyYgcGksCiAgICAgY29uc3QgZG91Ymxl IG1heCA9IHNsaWRlci0+bWF4aW11bSgpOwogICAgIGNvbnN0IGRvdWJsZSBwcm9ncmVzcyA9ICht YXggLSBtaW4gPiAwKSA/IChzbGlkZXItPnZhbHVlQXNOdW1iZXIoKSAtIG1pbikgLyAobWF4IC0g bWluKSA6IDA7CiAKLSAgICAvLyBSZW5kZXIgdGhlIHNwaW4gYnV0dG9ucyBmb3IgTFRSIG9yIFJU TCBhY2NvcmRpbmdseS4KLSAgICBjb25zdCBpbnQgZ3Jvb3ZlUGFkZGluZyA9IHIuaGVpZ2h0KCkg KiBzbGlkZXJHcm9vdmVCb3JkZXJSYXRpbzsKLSAgICBjb25zdCBRUmVjdCByZWN0KHIpOwotICAg IHAuZHJhd1Byb2dyZXNzKHJlY3QuYWRqdXN0ZWQoMCwgZ3Jvb3ZlUGFkZGluZywgMCwgLWdyb292 ZVBhZGRpbmcpLCBwcm9ncmVzcywgby0+c3R5bGUoKS0+aXNMZWZ0VG9SaWdodERpcmVjdGlvbigp KTsKKyAgICBRUmVjdCByZWN0KHIpOworICAgIGNvbnN0IGJvb2wgdmVydGljYWwgPSAoby0+c3R5 bGUoKS0+YXBwZWFyYW5jZSgpID09IFNsaWRlclZlcnRpY2FsUGFydCk7CisgICAgY29uc3QgaW50 IGdyb292ZVBhZGRpbmcgPSB2ZXJ0aWNhbCA/IHIud2lkdGgoKSAqIHNsaWRlckdyb292ZUJvcmRl clJhdGlvIDogci5oZWlnaHQoKSAqIHNsaWRlckdyb292ZUJvcmRlclJhdGlvOworICAgIGlmICh2 ZXJ0aWNhbCkKKyAgICAgICAgcmVjdC5hZGp1c3QoZ3Jvb3ZlUGFkZGluZywgMCwgLWdyb292ZVBh ZGRpbmcsIDApOworICAgIGVsc2UKKyAgICAgICAgcmVjdC5hZGp1c3QoMCwgZ3Jvb3ZlUGFkZGlu ZywgMCwgLWdyb292ZVBhZGRpbmcpOworICAgIHAuZHJhd1Byb2dyZXNzKHJlY3QsIHByb2dyZXNz LCBvLT5zdHlsZSgpLT5pc0xlZnRUb1JpZ2h0RGlyZWN0aW9uKCksIC8qYW5pbWF0ZWQgPSAqLyBm YWxzZSwgdmVydGljYWwpOwogCiAgICAgcmV0dXJuIGZhbHNlOwogfQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvUmVuZGVyVGhlbWVRdE1vYmlsZS5oIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vcXQvUmVuZGVyVGhlbWVRdE1vYmlsZS5oCmluZGV4IGM1N2ExODAyOWUy ZTkxYWU5MzE5NDc4MDY4ZWE2YTEwMzk0NTI5MmQuLjBkMzZiOGM5MzFlMDU3YmYxOTZhMTc5Mzhk MTUyNzRmYTEzNzYxZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1Jl bmRlclRoZW1lUXRNb2JpbGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9SZW5k ZXJUaGVtZVF0TW9iaWxlLmgKQEAgLTEzNSw3ICsxMzUsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBk cmF3UmFkaW9CdXR0b24oY29uc3QgUVJlY3QmLCBib29sIGNoZWNrZWQsIGJvb2wgZW5hYmxlZCA9 IHRydWUpOwogICAgIHZvaWQgZHJhd1B1c2hCdXR0b24oY29uc3QgUVJlY3QmLCBib29sIHN1bmtl biwgYm9vbCBlbmFibGVkID0gdHJ1ZSk7CiAgICAgdm9pZCBkcmF3Q29tYm9Cb3goY29uc3QgUVJl Y3QmLCBib29sIG11bHRpcGxlLCBib29sIGVuYWJsZWQgPSB0cnVlKTsKLSAgICB2b2lkIGRyYXdQ cm9ncmVzcyhjb25zdCBRUmVjdCYsIGRvdWJsZSBwcm9ncmVzcywgYm9vbCBsZWZ0VG9SaWdodCA9 IHRydWUsIGJvb2wgYW5pbWF0ZWQgPSBmYWxzZSkgY29uc3Q7CisgICAgdm9pZCBkcmF3UHJvZ3Jl c3MoY29uc3QgUVJlY3QmLCBkb3VibGUgcHJvZ3Jlc3MsIGJvb2wgbGVmdFRvUmlnaHQgPSB0cnVl LCBib29sIGFuaW1hdGVkID0gZmFsc2UsIGJvb2wgdmVydGljYWwgPSBmYWxzZSkgY29uc3Q7CiAg ICAgdm9pZCBkcmF3U2xpZGVyVGh1bWIoY29uc3QgUVJlY3QmLCBib29sIHByZXNzZWQpIGNvbnN0 OwogCiBwcml2YXRlOgo=