80177 2012-03-02 11:53:06 -0800 [BlackBerry] Expose WebInspector state to client and clean up WebSettings 2012-03-02 18:41:55 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mifenton mifenton tonikitoo webkit.review.bot oldest_to_newest 569815 0 mifenton 2012-03-02 11:53:06 -0800 Expose the current state of WebInspector to the client and re-order settings in WebSettings to match initialization. 569820 1 129934 mifenton 2012-03-02 11:55:11 -0800 Created attachment 129934 Patch 569885 2 129934 webkit.review.bot 2012-03-02 13:29:30 -0800 Comment on attachment 129934 Patch Attachment 129934 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11803096 New failing tests: editing/selection/select-line-break-with-opposite-directionality.html 570071 3 129934 webkit.review.bot 2012-03-02 18:41:51 -0800 Comment on attachment 129934 Patch Clearing flags on attachment: 129934 Committed r109646: <http://trac.webkit.org/changeset/109646> 570072 4 webkit.review.bot 2012-03-02 18:41:55 -0800 All reviewed patches have been landed. Closing bug. 129934 2012-03-02 11:55:11 -0800 2012-03-02 18:41:51 -0800 Patch 0001-2012-03-02-Mike-Fenton-mifenton-rim.com.patch text/plain 6614 mifenton RnJvbSA1ZmJjZTQwOGJhNDllZjVhNDk0YTEwMGFiYzZmMTgzMWI1YWRiYmIzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWtlIEZlbnRvbiA8bWlmZW50b25AcmltLmNvbT4KRGF0ZTog RnJpLCAyIE1hciAyMDEyIDE0OjM1OjIwIC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gMjAxMi0wMy0w MiAgTWlrZSBGZW50b24gIDxtaWZlbnRvbkByaW0uY29tPgoKICAgICAgICBQUiAxMzk5NzcuCgog ICAgICAgIEV4cG9zZSB0aGUgV2ViIEluc3BlY3RvciBzdGF0ZSB0byBXZWJQYWdlIGNsaWVudCdz IGFuZAogICAgICAgIHJlLW9yZGVyIGluaXRpYWxpemF0aW9uIG9mIFdlYlNldHRpbmdzIHRvIGJl IGFscGhhYmV0aWNhbAogICAgICAgIG1hdGNoaW5nIHRoZWlyIGRlZmluaXRpb25zLgoKICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgKiBBcGkvV2ViUGFnZS5jcHA6 CiAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFnZTo6aXNXZWJJbnNwZWN0b3JFbmFi bGVkKToKICAgICAgICAqIEFwaS9XZWJQYWdlLmg6CiAgICAgICAgKiBBcGkvV2ViU2V0dGluZ3Mu Y3BwOgogICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlNldHRpbmdzOjpzdGFuZGFyZFNl dHRpbmdzKToKLS0tCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwICAg ICB8ICAgIDUgKysrKysKIFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5oICAg ICAgIHwgICAgMSArCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlNldHRpbmdzLmNw cCB8ICAgMTQgKysrKysrKy0tLS0tLS0KIFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VM b2cgICAgICAgICAgIHwgICAxNyArKysrKysrKysrKysrKysrKwogNCBmaWxlcyBjaGFuZ2VkLCAz MCBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv QXBpL1dlYlBhZ2UuY3BwCmluZGV4IDM4ZGM0MzcuLjFhYjkxOTcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcApAQCAtNTAyNCw2ICs1MDI0LDExIEBAIHZvaWQgV2Vi UGFnZTo6ZGlzYWJsZVdlYkluc3BlY3RvcigpCiAgICAgZC0+bV9wYWdlLT5zZXR0aW5ncygpLT5z ZXREZXZlbG9wZXJFeHRyYXNFbmFibGVkKGZhbHNlKTsKIH0KIAorYm9vbCBXZWJQYWdlOjppc1dl Ykluc3BlY3RvckVuYWJsZWQoKQoreworICAgIHJldHVybiBkLT5tX3BhZ2UtPnNldHRpbmdzKCkt PmRldmVsb3BlckV4dHJhc0VuYWJsZWQoKTsKK30KKwogdm9pZCBXZWJQYWdlOjplbmFibGVQYXNz d29yZEVjaG8oKQogewogICAgIGQtPm1fcGFnZS0+c2V0dGluZ3MoKS0+c2V0UGFzc3dvcmRFY2hv RW5hYmxlZCh0cnVlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkv V2ViUGFnZS5oIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmgKaW5kZXgg NDhjMTViZi4uM2E4ODNjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0Fw aS9XZWJQYWdlLmgKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmgK QEAgLTMwMCw2ICszMDAsNyBAQCBwdWJsaWM6CiAKICAgICB2b2lkIGVuYWJsZVdlYkluc3BlY3Rv cigpOwogICAgIHZvaWQgZGlzYWJsZVdlYkluc3BlY3RvcigpOworICAgIGJvb2wgaXNXZWJJbnNw ZWN0b3JFbmFibGVkKCk7CiAgICAgdm9pZCBlbmFibGVQYXNzd29yZEVjaG8oKTsKICAgICB2b2lk IGRpc2FibGVQYXNzd29yZEVjaG8oKTsKICAgICB2b2lkIGRpc3BhdGNoSW5zcGVjdG9yTWVzc2Fn ZShjb25zdCBzdGQ6OnN0cmluZyYgbWVzc2FnZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQXBpL1dlYlNldHRpbmdzLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9BcGkvV2ViU2V0dGluZ3MuY3BwCmluZGV4IDE2MTZlYjYuLmY2MDY3MTcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViU2V0dGluZ3MuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViU2V0dGluZ3MuY3BwCkBAIC01Miw2ICs1Miw3IEBA IERFRklORV9TVEFUSUNfTE9DQUwoU3RyaW5nLCBCbGFja0JlcnJ5VXNlckFnZW50U3RyaW5nLCAo IkJsYWNrQmVycnlVc2VyQWdlbnRTdHJpCiBERUZJTkVfU1RBVElDX0xPQ0FMKFN0cmluZywgQmxh Y2tCZXJyeVVzZXJTY2FsYWJsZUVuYWJsZWQsICgiQmxhY2tCZXJyeVVzZXJTY2FsYWJsZUVuYWJs ZWQiKSk7CiBERUZJTkVfU1RBVElDX0xPQ0FMKFN0cmluZywgQmxhY2tCZXJyeVZpZXdwb3J0V2lk dGgsICgiQmxhY2tCZXJyeVZpZXdwb3J0V2lkdGgiKSk7CiBERUZJTkVfU1RBVElDX0xPQ0FMKFN0 cmluZywgQmxhY2tCZXJyeVpvb21Ub0ZpdE9uTG9hZEVuYWJsZWQsICgiQmxhY2tCZXJyeVpvb21U b0ZpdE9uTG9hZEVuYWJsZWQiKSk7CitERUZJTkVfU1RBVElDX0xPQ0FMKFN0cmluZywgU3BhdGlh bE5hdmlnYXRpb25FbmFibGVkLCAoIlNwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZCIpKTsKIERFRklO RV9TVEFUSUNfTE9DQUwoU3RyaW5nLCBXZWJLaXREYXRhYmFzZVBhdGgsICgiV2ViS2l0RGF0YWJh c2VQYXRoIikpOwogREVGSU5FX1NUQVRJQ19MT0NBTChTdHJpbmcsIFdlYktpdERhdGFiYXNlc0Vu YWJsZWQsICgiV2ViS2l0RGF0YWJhc2VzRW5hYmxlZCIpKTsKIERFRklORV9TVEFUSUNfTE9DQUwo U3RyaW5nLCBXZWJLaXREZWZhdWx0Rml4ZWRGb250U2l6ZSwgKCJXZWJLaXREZWZhdWx0Rml4ZWRG b250U2l6ZSIpKTsKQEAgLTgyLDcgKzgzLDYgQEAgREVGSU5FX1NUQVRJQ19MT0NBTChTdHJpbmcs IFdlYktpdFVzZXJTdHlsZVNoZWV0LCAoIldlYktpdFVzZXJTdHlsZVNoZWV0IikpOwogREVGSU5F X1NUQVRJQ19MT0NBTChTdHJpbmcsIFdlYktpdFVzZXJTdHlsZVNoZWV0TG9jYXRpb24sICgiV2Vi S2l0VXNlclN0eWxlU2hlZXRMb2NhdGlvbiIpKTsKIERFRklORV9TVEFUSUNfTE9DQUwoU3RyaW5n LCBXZWJLaXRXZWJTb2NrZXRzRW5hYmxlZCwgKCJXZWJLaXRXZWJTb2NrZXRzRW5hYmxlZCIpKTsK IERFRklORV9TVEFUSUNfTE9DQUwoU3RyaW5nLCBXZWJLaXRYU1NBdWRpdG9yRW5hYmxlZCwgKCJX ZWJLaXRYU1NBdWRpdG9yRW5hYmxlZCIpKTsKLURFRklORV9TVEFUSUNfTE9DQUwoU3RyaW5nLCBT cGF0aWFsTmF2aWdhdGlvbkVuYWJsZWQsICgiU3BhdGlhbE5hdmlnYXRpb25FbmFibGVkIikpOwog CiAvLyBGSVhNRTogV2Ugc2hvdWxkIGNvbnNpZGVyIG1vdmluZyBhbGwgdGhlIG1pbWUgdHlwZSBj b2RlIGludG8gaXRzIG93biBvYmplY3QuCiAKQEAgLTIxNSwyNSArMjE1LDI1IEBAIFdlYlNldHRp bmdzKiBXZWJTZXR0aW5nczo6c3RhbmRhcmRTZXR0aW5ncygpCiAgICAgLy8gRklYTUU6IFdlIHNo b3VsZCBkZXRlY3Qgd2hldGhlciB3ZSBhcmUgZW1iZWRkZWQgaW4gYSBicm93c2VyIG9yIGFuIGVt YWlsIGNsaWVudCBhbmQgZGVmYXVsdCB0byBUZXh0UmVmbG93RW5hYmxlZE9ubHlGb3JCbG9ja1pv b20gYW5kIFRleHRSZWZsb3dFbmFibGVkLCByZXNwZWN0aXZlbHkuCiAgICAgc2V0dGluZ3MtPm1f cHJpdmF0ZS0+c2V0VGV4dFJlZmxvd01vZGUoQmxhY2tCZXJyeVRleHRSZWZsb3dNb2RlLCBUZXh0 UmVmbG93RGlzYWJsZWQpOwogCi0gICAgc2V0dGluZ3MtPm1fcHJpdmF0ZS0+c2V0Qm9vbGVhbihC bGFja0JlcnJ5VXNlclNjYWxhYmxlRW5hYmxlZCwgdHJ1ZSk7CiAgICAgc2V0dGluZ3MtPm1fcHJp dmF0ZS0+c2V0Qm9vbGVhbihCbGFja0JlcnJ5VXNlV2ViS2l0Q2FjaGUsIHRydWUpOworICAgIHNl dHRpbmdzLT5tX3ByaXZhdGUtPnNldEJvb2xlYW4oQmxhY2tCZXJyeVVzZXJTY2FsYWJsZUVuYWJs ZWQsIHRydWUpOwogICAgIHNldHRpbmdzLT5tX3ByaXZhdGUtPnNldEJvb2xlYW4oQmxhY2tCZXJy eVpvb21Ub0ZpdE9uTG9hZEVuYWJsZWQsIHRydWUpOworCiAgICAgc2V0dGluZ3MtPm1fcHJpdmF0 ZS0+c2V0SW50ZWdlcihXZWJLaXREZWZhdWx0Rm9udFNpemUsIDE2KTsKICAgICBzZXR0aW5ncy0+ bV9wcml2YXRlLT5zZXRJbnRlZ2VyKFdlYktpdERlZmF1bHRGaXhlZEZvbnRTaXplLCAxMyk7Ci0g ICAgc2V0dGluZ3MtPm1fcHJpdmF0ZS0+c2V0SW50ZWdlcihXZWJLaXRNaW5pbXVtRm9udFNpemUs IDgpOwogICAgIHNldHRpbmdzLT5tX3ByaXZhdGUtPnNldFN0cmluZyhXZWJLaXREZWZhdWx0VGV4 dEVuY29kaW5nTmFtZSwgImlzby04ODU5LTEiKTsKKyAgICBzZXR0aW5ncy0+bV9wcml2YXRlLT5z ZXRCb29sZWFuKFdlYktpdERvd25sb2FkYWJsZUJpbmFyeUZvbnRzRW5hYmxlZCwgdHJ1ZSk7CiAg ICAgc2V0dGluZ3MtPm1fcHJpdmF0ZS0+c2V0SW50ZWdlcihXZWJLaXRGaXJzdFNjaGVkdWxlZExh eW91dERlbGF5LCAyNTApOyAvLyBNYXRjaCBEb2N1bWVudDo6Y0xheW91dFNjaGVkdWxlVGhyZXNo b2xkLgorICAgIHNldHRpbmdzLT5tX3ByaXZhdGUtPnNldFN0cmluZyhXZWJLaXRGaXhlZEZvbnRG YW1pbHksICJDb3VyaWVyIE5ldyIpOwogICAgIHNldHRpbmdzLT5tX3ByaXZhdGUtPnNldEJvb2xl YW4oV2ViS2l0SmF2YVNjcmlwdEVuYWJsZWQsIHRydWUpOwogICAgIHNldHRpbmdzLT5tX3ByaXZh dGUtPnNldEJvb2xlYW4oV2ViS2l0TG9hZHNJbWFnZXNBdXRvbWF0aWNhbGx5LCB0cnVlKTsKLSAg ICBzZXR0aW5ncy0+bV9wcml2YXRlLT5zZXRCb29sZWFuKFdlYktpdERvd25sb2FkYWJsZUJpbmFy eUZvbnRzRW5hYmxlZCwgdHJ1ZSk7CiAgICAgc2V0dGluZ3MtPm1fcHJpdmF0ZS0+c2V0VW5zaWdu ZWRMb25nTG9uZyhXZWJLaXRMb2NhbFN0b3JhZ2VRdW90YSwgNSAqIDEwMjQgKiAxMDI0KTsKICAg ICBzZXR0aW5ncy0+bV9wcml2YXRlLT5zZXRJbnRlZ2VyKFdlYktpdE1heGltdW1QYWdlc0luQ2Fj aGUsIDApOwotICAgIHNldHRpbmdzLT5tX3ByaXZhdGUtPnNldEJvb2xlYW4oV2ViS2l0V2ViU29j a2V0c0VuYWJsZWQsIHRydWUpOwotICAgIHNldHRpbmdzLT5tX3ByaXZhdGUtPnNldFN0cmluZyhX ZWJLaXRGaXhlZEZvbnRGYW1pbHksICJDb3VyaWVyIE5ldyIpOworICAgIHNldHRpbmdzLT5tX3By aXZhdGUtPnNldEludGVnZXIoV2ViS2l0TWluaW11bUZvbnRTaXplLCA4KTsKICAgICBzZXR0aW5n cy0+bV9wcml2YXRlLT5zZXRTdHJpbmcoV2ViS2l0U2Fuc1NlcmlmZkZvbnRGYW1pbHksICJBcmlh bCIpOwogICAgIHNldHRpbmdzLT5tX3ByaXZhdGUtPnNldFN0cmluZyhXZWJLaXRTZXJpZmZGb250 RmFtaWx5LCAiVGltZXMgTmV3IFJvbWFuIik7CiAgICAgc2V0dGluZ3MtPm1fcHJpdmF0ZS0+c2V0 U3RyaW5nKFdlYktpdFN0YW5kYXJkRm9udEZhbWlseSwgIlRpbWVzIE5ldyBSb21hbiIpOwotICAg IHNldHRpbmdzLT5tX3ByaXZhdGUtPnNldEJvb2xlYW4oU3BhdGlhbE5hdmlnYXRpb25FbmFibGVk LCBmYWxzZSk7CisgICAgc2V0dGluZ3MtPm1fcHJpdmF0ZS0+c2V0Qm9vbGVhbihXZWJLaXRXZWJT b2NrZXRzRW5hYmxlZCwgdHJ1ZSk7CiAKICAgICByZXR1cm4gc2V0dGluZ3M7CiB9CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L0NoYW5nZUxvZwppbmRleCAxMWU5Y2ExLi4zNmYyZmEwIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMi0wMy0wMiAgTWlrZSBGZW50 b24gIDxtaWZlbnRvbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBFeHBvc2UgV2Vi SW5zcGVjdG9yIHN0YXRlIHRvIGNsaWVudCBhbmQgY2xlYW4gdXAgV2ViU2V0dGluZ3MKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgwMTc3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRXhwb3NlIHRoZSBXZWIg SW5zcGVjdG9yIHN0YXRlIHRvIFdlYlBhZ2UgY2xpZW50J3MgYW5kCisgICAgICAgIHJlLW9yZGVy IGluaXRpYWxpemF0aW9uIG9mIFdlYlNldHRpbmdzIHRvIGJlIGFscGhhYmV0aWNhbAorICAgICAg ICBtYXRjaGluZyB0aGVpciBkZWZpbml0aW9ucy4KKworICAgICAgICAqIEFwaS9XZWJQYWdlLmNw cDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFnZTo6aXNXZWJJbnNwZWN0b3JF bmFibGVkKToKKyAgICAgICAgKiBBcGkvV2ViUGFnZS5oOgorICAgICAgICAqIEFwaS9XZWJTZXR0 aW5ncy5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlNldHRpbmdzOjpzdGFu ZGFyZFNldHRpbmdzKToKKwogMjAxMi0wMy0wMiAgS29ucmFkIFBpYXNjaWsgIDxrcGlhc2Npa0By aW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBTZXQgdGhlIGRldmljZVBpeGVsUmF0aW8g ZnJvbSB0aGUgcmVzdWx0cyBvZiBjb21wdXRlVmlld3BvcnRBdHRyaWJ1dGVzCi0tIAoxLjcuNS40 Cgo=