80171 2012-03-02 10:33:53 -0800 [Chromium] Allow plugins to set opaque() on their platform layer 2012-03-02 11:45:15 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 danakj danakj abarth backer fishd jamesr jbauman piman webkit.review.bot oldest_to_newest 569752 0 danakj 2012-03-02 10:33:53 -0800 [Chromium] Allow plugins to set opaque() on their platform layer 569753 1 129921 danakj 2012-03-02 10:34:56 -0800 Created attachment 129921 Patch 569754 2 danakj 2012-03-02 10:36:21 -0800 This matches the interface on WebMediaPlayerClient. 569755 3 webkit.review.bot 2012-03-02 10:36:29 -0800 Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. 569759 4 129922 danakj 2012-03-02 10:39:56 -0800 Created attachment 129922 Patch grammar fix. 569763 5 129922 jamesr 2012-03-02 10:44:06 -0800 Comment on attachment 129922 Patch Do you want this for WebExternalTextureLayer as well? 569766 6 danakj 2012-03-02 10:49:06 -0800 (In reply to comment #5) > (From update of attachment 129922 [details]) > Do you want this for WebExternalTextureLayer as well? I think that's covered by its superclass WebLayer? 569773 7 129922 jamesr 2012-03-02 11:03:04 -0800 Comment on attachment 129922 Patch Right, right. R=me 569805 8 129922 webkit.review.bot 2012-03-02 11:45:10 -0800 Comment on attachment 129922 Patch Clearing flags on attachment: 129922 Committed r109590: <http://trac.webkit.org/changeset/109590> 569806 9 webkit.review.bot 2012-03-02 11:45:15 -0800 All reviewed patches have been landed. Closing bug. 129921 2012-03-02 10:34:56 -0800 2012-03-02 10:39:51 -0800 Patch bug-80171-20120302133454.patch text/plain 3197 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5NTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGRmMWMyNWVkNDk2NWI3YjBhZWE4YzM4ZTA4NGE4OGFhODJlODgzMDcuLjg3MDdmZTBkZjMxMDY4 MzZhMjFkNWYyMDM3NjkwMDBjNGNjMjc4YmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTItMDMtMDIgIERhbmEgSmFuc2VucyAgPGRhbmFrakBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBBbGxvdyBwbHVnaW5zIHRvIHNldCBvcGFxdWUo KSBvbiB0aGVpciBwbGF0Zm9ybSBsYXllcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODAxNzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHB1YmxpYy9XZWJQbHVnaW5Db250YWluZXIuaDoKKyAgICAgICAg KFdlYlBsdWdpbkNvbnRhaW5lcik6CisgICAgICAgICogc3JjL1dlYlBsdWdpbkNvbnRhaW5lcklt cGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQbHVnaW5Db250YWluZXJJbXBsOjpzZXRPcGFx dWUpOgorICAgICAgICAoV2ViS2l0KToKKyAgICAgICAgKiBzcmMvV2ViUGx1Z2luQ29udGFpbmVy SW1wbC5oOgorICAgICAgICAoV2ViUGx1Z2luQ29udGFpbmVySW1wbCk6CisKIDIwMTItMDMtMDEg IENhaW8gTWFyY2VsbyBkZSBPbGl2ZWlyYSBGaWxobyAgPGNhaW8ub2xpdmVpcmFAb3BlbmJvc3Nh Lm9yZz4KIAogICAgICAgICBNYWtlIHBhcnNlciBjb2RlIG5vdCBkZXBlbmQgb24gTmFtZWROb2Rl TWFwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJQbHVnaW5D b250YWluZXIuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlBsdWdpbkNvbnRh aW5lci5oCmluZGV4IDg0NWNiMWEyOGVhMGU0NmE3Yzg1MTg0ZmEzODBkMDE0OWFlZTNkNzguLjMy ZjNiODVkYTIwODQzMDJjMzJkMmQ0YjhmNjY5NDViMDUxYWI5MTAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlBsdWdpbkNvbnRhaW5lci5oCisrKyBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlBsdWdpbkNvbnRhaW5lci5oCkBAIC0xMDAsNiAr MTAwLDkgQEAgcHVibGljOgogICAgIC8vIE5vdGlmaWVzIHRoYXQgdGhlIHpvb20gbGV2ZWwgaGFz IGNoYW5nZWQuCiAgICAgdmlydHVhbCB2b2lkIHpvb21MZXZlbENoYW5nZWQoZG91YmxlIHpvb21M ZXZlbCkgPSAwOwogCisgICAgLy8gTm90aWZpZXMgaWYgdGhlIGNvbnRlbnRzIG9mIHRoZSBwbHVn aW4gYXJlIGVudGlyZWx5IG9wYXF1ZS4KKyAgICB2aXJ0dWFsIHZvaWQgc2V0T3BhcXVlKGJvb2wp ID0gMDsKKwogICAgIC8vIERldGVybWluZXMgd2hldGhlciB0aGUgZ2l2ZW4gcmVjdGFuZ2xlIGlu IHRoaXMgcGx1Z2luIGlzIGFib3ZlIGFsbCBvdGhlcgogICAgIC8vIGNvbnRlbnQuIFRoZSByZWN0 YW5nbGUgaXMgaW4gdGhlIHBsdWdpbidzIGNvb3JkaW5hdGUgc3lzdGVtLgogICAgIHZpcnR1YWwg Ym9vbCBpc1JlY3RUb3Btb3N0KGNvbnN0IFdlYlJlY3QmKSA9IDA7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmNwcCBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuY3BwCmluZGV4IGY3 OTc1MmVjMzMyMjg2NTY4MjhkYTNkOWJjNzAyZjdhNmRhMGZmZDAuLmE3MTcwM2IxNWZiMTZiOWMx ZWMzZDdiZDI5ZWNiN2NlNzExZTBjN2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuY3BwCkBAIC00MzUsNiArNDM1LDE0IEBA IHZvaWQgV2ViUGx1Z2luQ29udGFpbmVySW1wbDo6em9vbUxldmVsQ2hhbmdlZChkb3VibGUgem9v bUxldmVsKQogICAgIHZpZXctPmZ1bGxGcmFtZVBsdWdpblpvb21MZXZlbENoYW5nZWQoem9vbUxl dmVsKTsKIH0KICAKK3ZvaWQgV2ViUGx1Z2luQ29udGFpbmVySW1wbDo6c2V0T3BhcXVlKGJvb2wg b3BhcXVlKQoreworI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKKyAgICBpZiAobV9w bGF0Zm9ybUxheWVyKQorICAgICAgICBtX3BsYXRmb3JtTGF5ZXItPnNldE9wYXF1ZShvcGFxdWUp OworI2VuZGlmCit9CisKIGJvb2wgV2ViUGx1Z2luQ29udGFpbmVySW1wbDo6aXNSZWN0VG9wbW9z dChjb25zdCBXZWJSZWN0JiByZWN0KQogewogICAgIFBhZ2UqIHBhZ2UgPSBtX2VsZW1lbnQtPmRv Y3VtZW50KCktPnBhZ2UoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYlBsdWdpbkNvbnRhaW5lckltcGwuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YlBsdWdpbkNvbnRhaW5lckltcGwuaAppbmRleCA4OTgxMzAwODQ2ZjhiNmNkYjgwYzY5MTBmODE2 OWRlMDNjMDk1NDYxLi45ZDk3MGYyZjhkZGIwN2Y4MGE4MDFmMmEzYTE4M2E4OTUzNWU3ZDk0IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250YWluZXJJ bXBsLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVy SW1wbC5oCkBAIC0xMDQsNiArMTA0LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgV2ViU3RyaW5n IGV4ZWN1dGVTY3JpcHRVUkwoY29uc3QgV2ViVVJMJiwgYm9vbCBwb3B1cHNBbGxvd2VkKTsKICAg ICB2aXJ0dWFsIHZvaWQgbG9hZEZyYW1lUmVxdWVzdChjb25zdCBXZWJVUkxSZXF1ZXN0JiwgY29u c3QgV2ViU3RyaW5nJiB0YXJnZXQsIGJvb2wgbm90aWZ5TmVlZGVkLCB2b2lkKiBub3RpZnlEYXRh KTsKICAgICB2aXJ0dWFsIHZvaWQgem9vbUxldmVsQ2hhbmdlZChkb3VibGUgem9vbUxldmVsKTsg ICAgCisgICAgdmlydHVhbCB2b2lkIHNldE9wYXF1ZShib29sKTsKICAgICB2aXJ0dWFsIGJvb2wg aXNSZWN0VG9wbW9zdChjb25zdCBXZWJSZWN0Jik7CiAKICAgICAvLyBUaGlzIGNhbm5vdCBiZSBu dWxsLgo= 129922 2012-03-02 10:39:56 -0800 2012-03-02 11:45:10 -0800 Patch bug-80171-20120302133955.patch text/plain 3202 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5NTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGRmMWMyNWVkNDk2NWI3YjBhZWE4YzM4ZTA4NGE4OGFhODJlODgzMDcuLjg3MDdmZTBkZjMxMDY4 MzZhMjFkNWYyMDM3NjkwMDBjNGNjMjc4YmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTItMDMtMDIgIERhbmEgSmFuc2VucyAgPGRhbmFrakBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBBbGxvdyBwbHVnaW5zIHRvIHNldCBvcGFxdWUo KSBvbiB0aGVpciBwbGF0Zm9ybSBsYXllcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODAxNzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHB1YmxpYy9XZWJQbHVnaW5Db250YWluZXIuaDoKKyAgICAgICAg KFdlYlBsdWdpbkNvbnRhaW5lcik6CisgICAgICAgICogc3JjL1dlYlBsdWdpbkNvbnRhaW5lcklt cGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQbHVnaW5Db250YWluZXJJbXBsOjpzZXRPcGFx dWUpOgorICAgICAgICAoV2ViS2l0KToKKyAgICAgICAgKiBzcmMvV2ViUGx1Z2luQ29udGFpbmVy SW1wbC5oOgorICAgICAgICAoV2ViUGx1Z2luQ29udGFpbmVySW1wbCk6CisKIDIwMTItMDMtMDEg IENhaW8gTWFyY2VsbyBkZSBPbGl2ZWlyYSBGaWxobyAgPGNhaW8ub2xpdmVpcmFAb3BlbmJvc3Nh Lm9yZz4KIAogICAgICAgICBNYWtlIHBhcnNlciBjb2RlIG5vdCBkZXBlbmQgb24gTmFtZWROb2Rl TWFwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJQbHVnaW5D b250YWluZXIuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlBsdWdpbkNvbnRh aW5lci5oCmluZGV4IDg0NWNiMWEyOGVhMGU0NmE3Yzg1MTg0ZmEzODBkMDE0OWFlZTNkNzguLjc3 NzQzMWZiMDQ1MWI5YjA2Yzg3MGMzYjA5YjIyODEzOTg2MGI3MDAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlBsdWdpbkNvbnRhaW5lci5oCisrKyBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlBsdWdpbkNvbnRhaW5lci5oCkBAIC0xMDAsNiAr MTAwLDkgQEAgcHVibGljOgogICAgIC8vIE5vdGlmaWVzIHRoYXQgdGhlIHpvb20gbGV2ZWwgaGFz IGNoYW5nZWQuCiAgICAgdmlydHVhbCB2b2lkIHpvb21MZXZlbENoYW5nZWQoZG91YmxlIHpvb21M ZXZlbCkgPSAwOwogCisgICAgLy8gTm90aWZpZXMgd2hldGhlciB0aGUgY29udGVudHMgb2YgdGhl IHBsdWdpbiBhcmUgZW50aXJlbHkgb3BhcXVlLgorICAgIHZpcnR1YWwgdm9pZCBzZXRPcGFxdWUo Ym9vbCkgPSAwOworCiAgICAgLy8gRGV0ZXJtaW5lcyB3aGV0aGVyIHRoZSBnaXZlbiByZWN0YW5n bGUgaW4gdGhpcyBwbHVnaW4gaXMgYWJvdmUgYWxsIG90aGVyCiAgICAgLy8gY29udGVudC4gVGhl IHJlY3RhbmdsZSBpcyBpbiB0aGUgcGx1Z2luJ3MgY29vcmRpbmF0ZSBzeXN0ZW0uCiAgICAgdmly dHVhbCBib29sIGlzUmVjdFRvcG1vc3QoY29uc3QgV2ViUmVjdCYpID0gMDsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuY3BwIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVySW1wbC5jcHAKaW5k ZXggZjc5NzUyZWMzMzIyODY1NjgyOGRhM2Q5YmM3MDJmN2E2ZGEwZmZkMC4uYTcxNzAzYjE1ZmIx NmI5YzFlYzNkN2JkMjllY2I3Y2U3MTFlMGM3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVySW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVySW1wbC5jcHAKQEAgLTQzNSw2ICs0MzUs MTQgQEAgdm9pZCBXZWJQbHVnaW5Db250YWluZXJJbXBsOjp6b29tTGV2ZWxDaGFuZ2VkKGRvdWJs ZSB6b29tTGV2ZWwpCiAgICAgdmlldy0+ZnVsbEZyYW1lUGx1Z2luWm9vbUxldmVsQ2hhbmdlZCh6 b29tTGV2ZWwpOwogfQogIAordm9pZCBXZWJQbHVnaW5Db250YWluZXJJbXBsOjpzZXRPcGFxdWUo Ym9vbCBvcGFxdWUpCit7CisjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQorICAgIGlm IChtX3BsYXRmb3JtTGF5ZXIpCisgICAgICAgIG1fcGxhdGZvcm1MYXllci0+c2V0T3BhcXVlKG9w YXF1ZSk7CisjZW5kaWYKK30KKwogYm9vbCBXZWJQbHVnaW5Db250YWluZXJJbXBsOjppc1JlY3RU b3Btb3N0KGNvbnN0IFdlYlJlY3QmIHJlY3QpCiB7CiAgICAgUGFnZSogcGFnZSA9IG1fZWxlbWVu dC0+ZG9jdW1lbnQoKS0+cGFnZSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVySW1wbC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViUGx1Z2luQ29udGFpbmVySW1wbC5oCmluZGV4IDg5ODEzMDA4NDZmOGI2Y2RiODBjNjkx MGY4MTY5ZGUwM2MwOTU0NjEuLjlkOTcwZjJmOGRkYjA3ZjgwYTgwMWYyYTNhMTgzYTg5NTM1ZTdk OTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBsdWdpbkNvbnRh aW5lckltcGwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250 YWluZXJJbXBsLmgKQEAgLTEwNCw2ICsxMDQsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBXZWJT dHJpbmcgZXhlY3V0ZVNjcmlwdFVSTChjb25zdCBXZWJVUkwmLCBib29sIHBvcHVwc0FsbG93ZWQp OwogICAgIHZpcnR1YWwgdm9pZCBsb2FkRnJhbWVSZXF1ZXN0KGNvbnN0IFdlYlVSTFJlcXVlc3Qm LCBjb25zdCBXZWJTdHJpbmcmIHRhcmdldCwgYm9vbCBub3RpZnlOZWVkZWQsIHZvaWQqIG5vdGlm eURhdGEpOwogICAgIHZpcnR1YWwgdm9pZCB6b29tTGV2ZWxDaGFuZ2VkKGRvdWJsZSB6b29tTGV2 ZWwpOyAgICAKKyAgICB2aXJ0dWFsIHZvaWQgc2V0T3BhcXVlKGJvb2wpOwogICAgIHZpcnR1YWwg Ym9vbCBpc1JlY3RUb3Btb3N0KGNvbnN0IFdlYlJlY3QmKTsKIAogICAgIC8vIFRoaXMgY2Fubm90 IGJlIG51bGwuCg==