80160 2012-03-02 07:25:24 -0800 [BlackBerry] Set the devicePixelRatio from the results of computeViewportAttributes 2012-03-02 09:40:35 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 kpiascik webkit-unassigned tonikitoo webkit.review.bot oldest_to_newest 569638 0 kpiascik 2012-03-02 07:25:24 -0800 [BlackBerry] Set the devicePixelRatio from the results of computeViewportAttributes 569639 1 129898 kpiascik 2012-03-02 07:26:35 -0800 Created attachment 129898 Patch 569662 2 129902 kpiascik 2012-03-02 08:22:55 -0800 Created attachment 129902 Patch 569663 3 129902 kpiascik 2012-03-02 08:28:12 -0800 Comment on attachment 129902 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129902&action=review > Source/WebKit/blackberry/ChangeLog:10 > + they report the devicePixelRatio returned by computeViewportAttributes. Just to clarify this was a manual test that I ran on these 2 files. 569712 4 129902 webkit.review.bot 2012-03-02 09:40:30 -0800 Comment on attachment 129902 Patch Clearing flags on attachment: 129902 Committed r109583: <http://trac.webkit.org/changeset/109583> 569713 5 webkit.review.bot 2012-03-02 09:40:35 -0800 All reviewed patches have been landed. Closing bug. 129898 2012-03-02 07:26:35 -0800 2012-03-02 08:22:50 -0800 Patch bug-80160-20120302102642.patch text/plain 1477 kpiascik U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5NDk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBlMWEzZTMxMzAyY2YwM2Y4MzVhM2U4Zjk5Y2I3MmRmOGFmYWY2ZjFmLi5mNWM4MGRmOTFj OGU5OWNiYWEwNjc2YTI4YjIyYjU4MGNjODI1Y2FiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0wMy0wMiAgS29ucmFkIFBpYXNjaWsgIDxrcGlh c2Npa0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBTZXQgdGhlIGRldmljZVBpeGVs UmF0aW8gZnJvbSB0aGUgcmVzdWx0cyBvZiBjb21wdXRlVmlld3BvcnRBdHRyaWJ1dGVzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MDE2MAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQXBpL1dlYlBhZ2Uu Y3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZTo6cmVjb21w dXRlVmlydHVhbFZpZXdwb3J0RnJvbVZpZXdwb3J0QXJndW1lbnRzKToKKwogMjAxMi0wMy0wMSAg Q2hhcmxlcyBXZWkgIDxjaGFybGVzLndlaUB0b3JjaG1vYmlsZS5jb20uY24+CiAKICAgICAgICAg W0JsYWNrQmVycnldIFdlYiBOb3RpZmljYXRpb24gY3Jhc2hlcyB0aGUgYnJvd3Nlci4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCmluZGV4IDljOGQxN2M5NjEzYWJiOTQ3 YjZiM2NhMzllMDMyY2JhM2RkMzAwMjIuLmZkYjJlZDgzNzYzNDI4NzE4ODY5ZDI4NGRiY2U4NDlk OTYzZTFkOWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFn ZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcApAQCAt MzAyMCw2ICszMDIwLDcgQEAgSW50U2l6ZSBXZWJQYWdlUHJpdmF0ZTo6cmVjb21wdXRlVmlydHVh bFZpZXdwb3J0RnJvbVZpZXdwb3J0QXJndW1lbnRzKCkKICAgICB9CiAKICAgICBWaWV3cG9ydEF0 dHJpYnV0ZXMgcmVzdWx0ID0gY29tcHV0ZVZpZXdwb3J0QXR0cmlidXRlcyhtX3ZpZXdwb3J0QXJn dW1lbnRzLCBkZXNrdG9wV2lkdGgsIGRldmljZVdpZHRoLCBkZXZpY2VIZWlnaHQsIGRldmljZURQ SSwgbV9kZWZhdWx0TGF5b3V0U2l6ZSk7CisgICAgbV9wYWdlLT5zZXREZXZpY2VTY2FsZUZhY3Rv cihyZXN1bHQuZGV2aWNlUGl4ZWxSYXRpbyk7CiAgICAgcmV0dXJuIEludFNpemUocmVzdWx0Lmxh eW91dFNpemUud2lkdGgoKSwgcmVzdWx0LmxheW91dFNpemUuaGVpZ2h0KCkpOwogfQogCg== 129902 2012-03-02 08:22:55 -0800 2012-03-02 09:40:30 -0800 Patch bug-80160-20120302112301.patch text/plain 1742 kpiascik U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5NDk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBlMWEzZTMxMzAyY2YwM2Y4MzVhM2U4Zjk5Y2I3MmRmOGFmYWY2ZjFmLi44YjllYTdiZTMz Yzk0YjhkY2NhOTUwNWVmYTkxOTVmOGRlN2E5NDM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0wMy0wMiAgS29ucmFkIFBpYXNjaWsgIDxrcGlh c2Npa0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBTZXQgdGhlIGRldmljZVBpeGVs UmF0aW8gZnJvbSB0aGUgcmVzdWx0cyBvZiBjb21wdXRlVmlld3BvcnRBdHRyaWJ1dGVzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MDE2MAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3RlZCBieSBnb2lu ZyB0byBsYXlvdXQgdGVzdCBmYXN0L3ZpZXdwb3J0L3ZpZXdwb3J0LTk1Lmh0bWwgYW5kIHZpZXdw b3J0LTkzLmh0bWwKKyAgICAgICAgUHJldmlvdXNseSB3aGVuIGV4ZWN1dGluZyB3aW5kb3cuZGV2 aWNlUGl4ZWxSYXRpbyB0aGVzZSB0d28gcGFnZXMgcmV0dXJuZWQgMSBub3cKKyAgICAgICAgdGhl eSByZXBvcnQgdGhlIGRldmljZVBpeGVsUmF0aW8gcmV0dXJuZWQgYnkgY29tcHV0ZVZpZXdwb3J0 QXR0cmlidXRlcy4KKworICAgICAgICAqIEFwaS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKEJsYWNr QmVycnk6OldlYktpdDo6V2ViUGFnZVByaXZhdGU6OnJlY29tcHV0ZVZpcnR1YWxWaWV3cG9ydEZy b21WaWV3cG9ydEFyZ3VtZW50cyk6CisKIDIwMTItMDMtMDEgIENoYXJsZXMgV2VpICA8Y2hhcmxl cy53ZWlAdG9yY2htb2JpbGUuY29tLmNuPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBXZWIgTm90 aWZpY2F0aW9uIGNyYXNoZXMgdGhlIGJyb3dzZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0Fw aS9XZWJQYWdlLmNwcAppbmRleCA5YzhkMTdjOTYxM2FiYjk0N2I2YjNjYTM5ZTAzMmNiYTNkZDMw MDIyLi5mZGIyZWQ4Mzc2MzQyODcxODg2OWQyODRkYmNlODQ5ZDk2M2UxZDlmIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKQEAgLTMwMjAsNiArMzAyMCw3IEBAIElu dFNpemUgV2ViUGFnZVByaXZhdGU6OnJlY29tcHV0ZVZpcnR1YWxWaWV3cG9ydEZyb21WaWV3cG9y dEFyZ3VtZW50cygpCiAgICAgfQogCiAgICAgVmlld3BvcnRBdHRyaWJ1dGVzIHJlc3VsdCA9IGNv bXB1dGVWaWV3cG9ydEF0dHJpYnV0ZXMobV92aWV3cG9ydEFyZ3VtZW50cywgZGVza3RvcFdpZHRo LCBkZXZpY2VXaWR0aCwgZGV2aWNlSGVpZ2h0LCBkZXZpY2VEUEksIG1fZGVmYXVsdExheW91dFNp emUpOworICAgIG1fcGFnZS0+c2V0RGV2aWNlU2NhbGVGYWN0b3IocmVzdWx0LmRldmljZVBpeGVs UmF0aW8pOwogICAgIHJldHVybiBJbnRTaXplKHJlc3VsdC5sYXlvdXRTaXplLndpZHRoKCksIHJl c3VsdC5sYXlvdXRTaXplLmhlaWdodCgpKTsKIH0KIAo=