80150 2012-03-02 05:00:55 -0800 [GTK] Invalid check in webkit_web_view_set_zoom_level() when zoom-text-only is enabled 2012-03-02 08:31:14 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned gustavo pnormand webkit.review.bot oldest_to_newest 569574 0 cgarcia 2012-03-02 05:00:55 -0800 We are always comparing with the page zoom factor to check whether zoom level changed or not 569575 1 129884 cgarcia 2012-03-02 05:03:42 -0800 Created attachment 129884 Patch 569576 2 webkit.review.bot 2012-03-02 05:05:24 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 569665 3 cgarcia 2012-03-02 08:31:14 -0800 Committed r109578: <http://trac.webkit.org/changeset/109578> 129884 2012-03-02 05:03:42 -0800 2012-03-02 08:24:36 -0800 Patch wk2-set-zoom-level-check.diff text/plain 1699 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA0MjA1MWZkLi5lNmQ0NDY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDMtMDIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIEludmFsaWQgaW4gY2hlY2sgaW4gd2Via2l0X3dlYl92aWV3X3Nl dF96b29tX2xldmVsKCkgd2hlbiB6b29tLXRleHQtb25seSBpcyBlbmFibGVkCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MDE1MAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsv V2ViS2l0V2ViVmlldy5jcHA6CisgICAgICAgICh3ZWJraXRfd2ViX3ZpZXdfc2V0X3pvb21fbGV2 ZWwpOiBVc2UKKyAgICAgICAgd2Via2l0X3dlYl92aWV3X2dldF96b29tX2xldmVsKCkgaW5zdGVh ZCBvZgorICAgICAgICBXS1BhZ2VHZXRQYWdlWm9vbUZhY3RvcigpIHRvIGdldCB0aGUgY3VycmVu dCBlZmZlY3RpdmUgem9vbSBsZXZlbAorICAgICAgICBkZXBlbmRpbmcgb24gem9vbS10ZXh0LW9u bHkgc2V0dGluZy4KKwogMjAxMi0wMy0wMSAgQW5kcmFzIEJlY3NpICA8YW5kcmFzLmJlY3NpQG5v a2lhLmNvbT4KIAogICAgICAgICBbUXRdW1dLMl0gTWFrZSB0aGUgaW50ZXJhY3Rpb24gd2l0aCB0 aGUgRmxpY2thYmxlIHdvcmsgb24gdGhlIE45CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwCmluZGV4IGRmNWRkZTguLmUxODJhYmQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcu Y3BwCkBAIC0xMzgwLDEwICsxMzgwLDEwIEBAIHZvaWQgd2Via2l0X3dlYl92aWV3X3NldF96b29t X2xldmVsKFdlYktpdFdlYlZpZXcqIHdlYlZpZXcsIGdkb3VibGUgem9vbUxldmVsKQogewogICAg IGdfcmV0dXJuX2lmX2ZhaWwoV0VCS0lUX0lTX1dFQl9WSUVXKHdlYlZpZXcpKTsKIAotICAgIFdL UGFnZVJlZiB3a1BhZ2UgPSB0b0FQSSh3ZWJraXRXZWJWaWV3QmFzZUdldFBhZ2UoV0VCS0lUX1dF Ql9WSUVXX0JBU0Uod2ViVmlldykpKTsKLSAgICBpZiAoV0tQYWdlR2V0UGFnZVpvb21GYWN0b3Io d2tQYWdlKSA9PSB6b29tTGV2ZWwpCisgICAgaWYgKHdlYmtpdF93ZWJfdmlld19nZXRfem9vbV9s ZXZlbCh3ZWJWaWV3KSA9PSB6b29tTGV2ZWwpCiAgICAgICAgIHJldHVybjsKIAorICAgIFdLUGFn ZVJlZiB3a1BhZ2UgPSB0b0FQSSh3ZWJraXRXZWJWaWV3QmFzZUdldFBhZ2UoV0VCS0lUX1dFQl9W SUVXX0JBU0Uod2ViVmlldykpKTsKICAgICBpZiAod2Via2l0X3NldHRpbmdzX2dldF96b29tX3Rl eHRfb25seSh3ZWJWaWV3LT5wcml2LT5zZXR0aW5ncy5nZXQoKSkpCiAgICAgICAgIFdLUGFnZVNl dFRleHRab29tRmFjdG9yKHdrUGFnZSwgem9vbUxldmVsKTsKICAgICBlbHNlCg==