80137 2012-03-02 02:54:04 -0800 [EFL][DRT] Implements LayoutTestController's setPopupBlockingEnabled 2012-03-06 23:54:55 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 g.czajkowski webkit-unassigned gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 569483 0 g.czajkowski 2012-03-02 02:54:04 -0800 Adds implementation LayoutTestController's setPopupBlockingEnabled. I am working on this, patch will be uploaded. 571583 1 130314 g.czajkowski 2012-03-06 00:33:19 -0800 Created attachment 130314 proposed patch This patch: - implements LayoutTestController's setPopupBlockingEnabled, - enables tests connected with setPopupBlockingEnabled - deletes idler which called by scheduleAsynchronousClickCallback (EventSender.cpp), sendClick should be called only once to pass popup-blocking-click-in-iframe.html 571745 2 130314 rakuco 2012-03-06 04:57:41 -0800 Comment on attachment 130314 proposed patch Looks fine. 571785 3 130314 gyuyoung.kim 2012-03-06 05:55:35 -0800 Comment on attachment 130314 proposed patch Looks good too. 572590 4 130314 eric 2012-03-06 23:36:59 -0800 Comment on attachment 130314 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=130314&action=review LGTM. > Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:439 > +void LayoutTestController::setPopupBlockingEnabled(bool flag) Woudl be better to use a nicer name. Like enablePopupBlocking. 572602 5 g.czajkowski 2012-03-06 23:53:44 -0800 (In reply to comment #4) > (From update of attachment 130314 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=130314&action=review > > LGTM. > > > Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:439 > > +void LayoutTestController::setPopupBlockingEnabled(bool flag) > > Woudl be better to use a nicer name. Like enablePopupBlocking. Yes, but this implements a common interface for all WebKit ports (Tools/DumpRenderTree/LayoutTestController.h) We can change it while general refactoring of DRT in my opinion :) 572603 6 130314 webkit.review.bot 2012-03-06 23:54:51 -0800 Comment on attachment 130314 proposed patch Clearing flags on attachment: 130314 Committed r110028: <http://trac.webkit.org/changeset/110028> 572604 7 webkit.review.bot 2012-03-06 23:54:55 -0800 All reviewed patches have been landed. Closing bug. 130314 2012-03-06 00:33:19 -0800 2012-03-06 23:54:51 -0800 proposed patch drt_set_popup_blocking.patch text/plain 6125 g.czajkowski ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyMDZjN2UxLi4zOTQ3YjczIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDMt MDUgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWprb3dza2lAc2Ftc3VuZy5jb20+CisKKyAg ICAgICAgW0VGTF1bRFJUXSBJbXBsZW1lbnRzIExheW91dFRlc3RDb250cm9sbGVyJ3Mgc2V0UG9w dXBCbG9ja2luZ0VuYWJsZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04MDEzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEVuYWJsZXMgdGVzdHMgY29ubmVjdGVkIHdpdGggc2V0UG9wdXBCbG9ja2luZ0Vu YWJsZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvU2tpcHBlZDoKKwogMjAxMi0wMy0wNSAg Q3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF0gVW5y ZXZpZXdlZCBnYXJkZW5pbmcuIFNraXAgbmV3IGNyYXNoaW5nIHRlc3RzLApkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9l ZmwvU2tpcHBlZAppbmRleCA3NWIxM2VkLi45MWUyYWZkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9lZmwvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvU2tp cHBlZApAQCAtNTU0LDI1ICs1NTQsNiBAQCBlZGl0aW5nL3NlbGVjdGlvbi9kb3VibGVjbGljay13 aGl0ZXNwYWNlLWNyYXNoLmh0bWwKIGVkaXRpbmcvc2VsZWN0aW9uL2RvdWJsZWNsaWNrLXdoaXRl c3BhY2UtaW1nLWNyYXNoLmh0bWwKIGVkaXRpbmcvc2VsZWN0aW9uL2RvdWJsZWNsaWNrLXdoaXRl c3BhY2UuaHRtbAogCi0jIEVGTCdzIExheW91dFRlc3RDb250cm9sbGVyIGRvZXMgbm90IGltcGxl bWVudCBzZXRQb3B1cEJsb2NraW5nRW5hYmxlZAotZmFzdC9ldmVudHMvb3Blbi13aW5kb3ctZnJv bS1hbm90aGVyLWZyYW1lLmh0bWwKLWZhc3QvZXZlbnRzL3BvcHVwLWFsbG93ZWQtZnJvbS1nZXN0 dXJlLWluaXRpYXRlZC1ldmVudC5odG1sCi1mYXN0L2V2ZW50cy9wb3B1cC1hbGxvd2VkLWZyb20t Z2VzdHVyZS1pbml0aWF0ZWQtZm9ybS1zdWJtaXQuaHRtbAotZmFzdC9ldmVudHMvcG9wdXAtYmxv Y2tlZC1mcm9tLWZha2UtYnV0dG9uLWNsaWNrLmh0bWwKLWZhc3QvZXZlbnRzL3BvcHVwLWJsb2Nr ZWQtZnJvbS1mYWtlLWZvY3VzLmh0bWwKLWZhc3QvZXZlbnRzL3BvcHVwLWJsb2NrZWQtZnJvbS1m YWtlLXVzZXItZ2VzdHVyZS5odG1sCi1mYXN0L2V2ZW50cy9wb3B1cC1ibG9ja2VkLWZyb20taGlz dG9yeS1yZWxvYWQuaHRtbAotZmFzdC9ldmVudHMvcG9wdXAtYmxvY2tlZC1mcm9tLWlmcmFtZS1z Y3JpcHQuaHRtbAotZmFzdC9ldmVudHMvcG9wdXAtYmxvY2tlZC1mcm9tLWlmcmFtZS1zcmMuaHRt bAotZmFzdC9ldmVudHMvcG9wdXAtYmxvY2tlZC1mcm9tLW1vdXNlbW92ZS5odG1sCi1mYXN0L2V2 ZW50cy9wb3B1cC1ibG9ja2VkLWZyb20tdW50cnVzdGVkLWNsaWNrLWV2ZW50LW9uLWFuY2hvci5o dG1sCi1mYXN0L2V2ZW50cy9wb3B1cC1ibG9ja2VkLWZyb20tdW50cnVzdGVkLW1vdXNlLWNsaWNr Lmh0bWwKLWZhc3QvZXZlbnRzL3BvcHVwLWJsb2NrZWQtZnJvbS13aW5kb3ctb3Blbi5odG1sCi1m YXN0L2V2ZW50cy9wb3B1cC1ibG9ja2VkLXRvLXBvc3QtYmxhbmsuaHRtbAotZmFzdC9ldmVudHMv cG9wdXAtYmxvY2tpbmctY2xpY2staW4taWZyYW1lLmh0bWwKLWZhc3QvZXZlbnRzL3BvcHVwLWJs b2NraW5nLXRpbWVycy5odG1sCi1mYXN0L2V2ZW50cy9wb3B1cC13aGVuLXNlbGVjdC1jaGFuZ2Uu aHRtbAotCiAjIEVGTCdzIExheW91dFRlc3RDb250cm9sbGVyIGRvZXMgbm90IGltcGxlbWVudCBl bGVtZW50RG9lc0F1dG9Db21wbGV0ZUZvckVsZW1lbnRXaXRoSWQKIHNlY3VyaXR5L3NldC1mb3Jt LWF1dG9jb21wbGV0ZS1hdHRyaWJ1dGUuaHRtbAogCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VM b2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWFlNmRlMi4uZGE1MjIzZSAxMDA2NDQKLS0tIGEv VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisy MDEyLTAzLTA1ICBHcnplZ29yeiBDemFqa293c2tpICA8Zy5jemFqa293c2tpQHNhbXN1bmcuY29t PgorCisgICAgICAgIFtFRkxdW0RSVF0gSW1wbGVtZW50cyBMYXlvdXRUZXN0Q29udHJvbGxlcidz IHNldFBvcHVwQmxvY2tpbmdFbmFibGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODAxMzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZGRzIGltcGxlbWVudGF0aW9uIExheW91dFRlc3RDb250cm9sbGVy J3Mgc2V0UG9wdXBCbG9ja2luZ0VuYWJsZWQuCisgICAgICAgIFRvIHBhc3MgcG9wdXAtYmxvY2tp bmctY2xpY2staW4taWZyYW1lLmh0bWwgRXZlbnRTZW5kZXIgc2hvdWxkIG5vdAorICAgICAgICBy ZXBlYXQgY2xpY2sgZXZlbnRzIGluIGlkbGVyJ3MgZnVuY3Rpb24uIEV2ZW50U2VuZGVyIGFsbG93 cyB0bworICAgICAgICBhc3luY2hyb25vdXNseSBzZW5kIGNsaWNrIGV2ZW50IHRocm91Z2ggZWNv cmVfaWRsZXJfYWRkLgorICAgICAgICBUaGlzIGV2ZW50IHdpbGwgYmUgY2FsbGVkIHJlcGVhdGVk bHkgYXMgbG9uZyBhcyBpdCByZXR1cm4gdHJ1ZS4KKyAgICAgICAgQ2xpY2sgZXZlbnQgc2hvdWxk IGJlIGNhbGxlZCBvbmx5IG9uY2UgYnkgcmV0dXJuaW5nIEVDT1JFX0NBTExCQUNLX0NBTkNFTC4K KworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2VmbC9FdmVudFNlbmRlci5jcHA6CisgICAgICAg IChzZW5kTW91c2VFdmVudCk6IENoYW5nZWQgcmV0dXJuIHZhbHVlIGZyb20gYm9vbCB0byB2b2lk IGJlY2F1c2UgaXQgYWx3YXlzIHJldHVybnMgdHJ1ZS4KKyAgICAgICAgKHNlbmRDbGljayk6IElk bGVyIGlzIGRlbGV0ZWQgYnkgcmV0dXJuaW5nIEVDT1JFX0NBTExCQUNLX0NBTkNFTC4KKyAgICAg ICAgKG1vdXNlRG93bkNhbGxiYWNrKTogUmVtb3ZlIHVubmVjZXNzYXJ5IGNoZWNraW5nIG9mIHJl dHVybiB2YWx1ZS4KKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9lZmwvTGF5b3V0VGVzdENvbnRy b2xsZXJFZmwuY3BwOgorICAgICAgICAoTGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldFBvcHVwQmxv Y2tpbmdFbmFibGVkKToKKwogMjAxMi0wMy0wNSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3 LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEwOTcz My4KZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9FdmVudFNlbmRlci5jcHAg Yi9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRXZlbnRTZW5kZXIuY3BwCmluZGV4IDkzZmFmYjku LjdhNGNhMzAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9FdmVudFNlbmRl ci5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0V2ZW50U2VuZGVyLmNwcApAQCAt MTMwLDcgKzEzMCw3IEBAIHN0YXRpYyBFdmFzTW91c2VCdXR0b24gdHJhbnNsYXRlTW91c2VCdXR0 b25OdW1iZXIoaW50IGV2ZW50U2VuZGVyQnV0dG9uTnVtYmVyKQogICAgIHJldHVybiBFdmFzTW91 c2VCdXR0b25MZWZ0OwogfQogCi1zdGF0aWMgYm9vbCBzZW5kTW91c2VFdmVudChFdmFzKiBldmFz LCBFdmFzTW91c2VFdmVudCBldmVudCwgaW50IGJ1dHRvbk51bWJlciwgRXZhc0tleU1vZGlmaWVy IG1vZGlmaWVycykKK3N0YXRpYyB2b2lkIHNlbmRNb3VzZUV2ZW50KEV2YXMqIGV2YXMsIEV2YXNN b3VzZUV2ZW50IGV2ZW50LCBpbnQgYnV0dG9uTnVtYmVyLCBFdmFzS2V5TW9kaWZpZXIgbW9kaWZp ZXJzKQogewogICAgIHVuc2lnbmVkIHRpbWVTdGFtcCA9IDA7CiAKQEAgLTE1NSwxMyArMTU1LDEy IEBAIHN0YXRpYyBib29sIHNlbmRNb3VzZUV2ZW50KEV2YXMqIGV2YXMsIEV2YXNNb3VzZUV2ZW50 IGV2ZW50LCBpbnQgYnV0dG9uTnVtYmVyLCBFCiAgICAgICAgIGV2YXNfZXZlbnRfZmVlZF9tb3Vz ZV93aGVlbChldmFzLCAxLCAoZXZlbnQgJiBFdmFzTW91c2VFdmVudFNjcm9sbExlZnQpID8gMTAg OiAtMTAsIHRpbWVTdGFtcCwgMCk7CiAKICAgICBzZXRFdmFzTW9kaWZpZXJzKGV2YXMsIEV2YXNL ZXlNb2RpZmllck5vbmUpOwotCi0gICAgcmV0dXJuIHRydWU7CiB9CiAKIHN0YXRpYyBFaW5hX0Jv b2wgc2VuZENsaWNrKHZvaWQqKQogewotICAgIHJldHVybiAhIXNlbmRNb3VzZUV2ZW50KGV2YXNf b2JqZWN0X2V2YXNfZ2V0KGJyb3dzZXItPm1haW5GcmFtZSgpKSwgRXZhc01vdXNlRXZlbnRDbGlj aywgRXZhc01vdXNlQnV0dG9uTGVmdCwgRXZhc0tleU1vZGlmaWVyTm9uZSk7CisgICAgc2VuZE1v dXNlRXZlbnQoZXZhc19vYmplY3RfZXZhc19nZXQoYnJvd3Nlci0+bWFpbkZyYW1lKCkpLCBFdmFz TW91c2VFdmVudENsaWNrLCBFdmFzTW91c2VCdXR0b25MZWZ0LCBFdmFzS2V5TW9kaWZpZXJOb25l KTsKKyAgICByZXR1cm4gRUNPUkVfQ0FMTEJBQ0tfQ0FOQ0VMOwogfQogCiBzdGF0aWMgSlNWYWx1 ZVJlZiBzY2hlZHVsZUFzeW5jaHJvbm91c0NsaWNrQ2FsbGJhY2soSlNDb250ZXh0UmVmIGNvbnRl eHQsIEpTT2JqZWN0UmVmIGZ1bmN0aW9uLCBKU09iamVjdFJlZiB0aGlzT2JqZWN0LCBzaXplX3Qg YXJndW1lbnRDb3VudCwgY29uc3QgSlNWYWx1ZVJlZiBhcmd1bWVudHNbXSwgSlNWYWx1ZVJlZiog ZXhjZXB0aW9uKQpAQCAtMjMyLDggKzIzMSw3IEBAIHN0YXRpYyBKU1ZhbHVlUmVmIG1vdXNlRG93 bkNhbGxiYWNrKEpTQ29udGV4dFJlZiBjb250ZXh0LCBKU09iamVjdFJlZiBmdW5jdGlvbiwKICAg ICB1cGRhdGVDbGlja0NvdW50KGJ1dHRvbik7CiAKICAgICBFdmFzS2V5TW9kaWZpZXIgbW9kaWZp ZXJzID0gYXJndW1lbnRDb3VudCA+PSAyID8gbW9kaWZpZXJzRnJvbUpTVmFsdWUoY29udGV4dCwg YXJndW1lbnRzWzFdKSA6IEV2YXNLZXlNb2RpZmllck5vbmU7Ci0gICAgaWYgKCFzZW5kTW91c2VF dmVudChldmFzX29iamVjdF9ldmFzX2dldChicm93c2VyLT5tYWluRnJhbWUoKSksIEV2YXNNb3Vz ZUV2ZW50RG93biwgYnV0dG9uLCBtb2RpZmllcnMpKQotICAgICAgICByZXR1cm4gSlNWYWx1ZU1h a2VVbmRlZmluZWQoY29udGV4dCk7CisgICAgc2VuZE1vdXNlRXZlbnQoZXZhc19vYmplY3RfZXZh c19nZXQoYnJvd3Nlci0+bWFpbkZyYW1lKCkpLCBFdmFzTW91c2VFdmVudERvd24sIGJ1dHRvbiwg bW9kaWZpZXJzKTsKIAogICAgIGdCdXR0b25DdXJyZW50bHlEb3duID0gYnV0dG9uOwogICAgIHJl dHVybiBKU1ZhbHVlTWFrZVVuZGVmaW5lZChjb250ZXh0KTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL2VmbC9MYXlvdXRUZXN0Q29udHJvbGxlckVmbC5jcHAgYi9Ub29scy9EdW1w UmVuZGVyVHJlZS9lZmwvTGF5b3V0VGVzdENvbnRyb2xsZXJFZmwuY3BwCmluZGV4IGRhMGM3Y2Eu LmViNGEyOTMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9MYXlvdXRUZXN0 Q29udHJvbGxlckVmbC5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0xheW91dFRl c3RDb250cm9sbGVyRWZsLmNwcApAQCAtNDM2LDkgKzQzNiw5IEBAIHZvaWQgTGF5b3V0VGVzdENv bnRyb2xsZXI6OnNldFNlbGVjdFRyYWlsaW5nV2hpdGVzcGFjZUVuYWJsZWQoYm9vbCkKICAgICBu b3RJbXBsZW1lbnRlZCgpOwogfQogCi12b2lkIExheW91dFRlc3RDb250cm9sbGVyOjpzZXRQb3B1 cEJsb2NraW5nRW5hYmxlZChib29sKQordm9pZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0UG9w dXBCbG9ja2luZ0VuYWJsZWQoYm9vbCBmbGFnKQogewotICAgIG5vdEltcGxlbWVudGVkKCk7Cisg ICAgZXdrX3ZpZXdfc2V0dGluZ19zY3JpcHRzX2Nhbl9vcGVuX3dpbmRvd3Nfc2V0KGJyb3dzZXIt Pm1haW5WaWV3KCksICFmbGFnKTsKIH0KIAogdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0 UGx1Z2luc0VuYWJsZWQoYm9vbCBmbGFnKQo=