80132 2012-03-02 02:07:38 -0800 AX: embedded attachments do not report their parents correctly 2012-03-14 21:20:03 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach bdakin oldest_to_newest 569447 0 cfleizach 2012-03-02 02:07:38 -0800 When a WebHTMLView has embedded attachments in it, the AXParent of those attachments is wrong. It usually points to the AXScrollView of the web area. That's because there's been no way for WebCore to communicate that this attachment view should actually make believe that it's parent is within the WebCore AX tree. We can fix that by overriding the AXParent in overriden attributes 569449 1 cfleizach 2012-03-02 02:07:59 -0800 rdar://10413412 569454 2 129857 cfleizach 2012-03-02 02:12:27 -0800 Created attachment 129857 patch 579111 3 cfleizach 2012-03-14 21:20:03 -0700 http://trac.webkit.org/changeset/110819 129857 2012-03-02 02:12:27 -0800 2012-03-13 16:33:55 -0700 patch patch.txt text/plain 6083 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwOTUzNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMxIEBACisyMDEyLTAzLTAyICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IGVtYmVkZGVkIGF0 dGFjaG1lbnRzIGRvIG5vdCByZXBvcnQgdGhlaXIgcGFyZW50cyBjb3JyZWN0bHkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgwMTMyCisKKyAgICAgICAg V2hlbiBhIFdlYkhUTUxWaWV3IGhhcyBlbWJlZGRlZCBhdHRhY2htZW50cyBpbiBpdCwgdGhlIEFY UGFyZW50IG9mIHRob3NlIGF0dGFjaG1lbnRzIGlzIHdyb25nLiAKKyAgICAgICAgSXQgdXN1YWxs eSBwb2ludHMgdG8gdGhlIEFYU2Nyb2xsVmlldyBvZiB0aGUgd2ViIGFyZWEuIFRoYXQncyBiZWNh dXNlIHRoZXJlIGhhcyBiZWVuIG5vIHdheSBmb3IgV2ViQ29yZSB0byAKKyAgICAgICAgY29tbXVu aWNhdGUgdGhhdCB0aGlzIGF0dGFjaG1lbnQgdmlldyBzaG91bGQgYWN0dWFsbHkgbWFrZSBiZWxp ZXZlIHRoYXQgaXQncyBwYXJlbnQgaXMgd2l0aGluIHRoZSBXZWJDb3JlIEFYIHRyZWUuCisKKyAg ICAgICAgV2UgY2FuIGZpeCB0aGF0IGJ5IG92ZXJyaWRpbmcgdGhlIEFYUGFyZW50IGluIG92ZXJy aWRlbiBhdHRyaWJ1dGVzIGZvciBpdGVtcyB0aGF0IGFyZSBhdHRhY2htZW50cy4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOb3QgYWJsZSB0byBjb25z dHJ1Y3QgYSBsYXlvdXQgdGVzdCBiZWNhdXNlIGl0IHJlbGllcyBvbiBlbWJlZGRlZCBhdHRhY2ht ZW50cy4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5T2JqZWN0OjpkZXRhY2hGcm9tUGFyZW50 KToKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuaDoKKyAgICAg ICAgKEFjY2Vzc2liaWxpdHlPYmplY3QpOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0 eU9iamVjdDo6b3ZlcnJpZGVBdHRhY2htZW50UGFyZW50KToKKyAgICAgICAgKiBhY2Nlc3NpYmls aXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QWNj ZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6dXBkYXRlQXR0YWNobWVudFZpZXdQYXJlbnRzKToKKyAg ICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OmFkZENoaWxkcmVuKToK KyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuaDoKKyAg ICAgICAgKEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QpOgorICAgICAgICAqIGFjY2Vzc2liaWxp dHkvbWFjL0FjY2Vzc2liaWxpdHlPYmplY3RNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpBY2Nl c3NpYmlsaXR5T2JqZWN0OjpvdmVycmlkZUF0dGFjaG1lbnRQYXJlbnQpOgorCiAyMDEyLTAzLTAx ICBWc2V2b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJ bnNwZWN0b3I6IFtJbnNwZWN0b3JJbmRleGVkREJdIFNob3cgbWVhbmluZ2Z1bCBkZXNjcmlwdGlv biBmb3Igb2JqZWN0IHN0b3JlIGl0ZW1zIHZhbHVlcy4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Fj Y2Vzc2liaWxpdHkvbWFjL0FjY2Vzc2liaWxpdHlPYmplY3RNYWMubW0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9tYWMvQWNjZXNzaWJpbGl0eU9iamVjdE1hYy5t bQkocmV2aXNpb24gMTA5MTY3KQorKysgU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9tYWMv QWNjZXNzaWJpbGl0eU9iamVjdE1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtMzMsNiArMzMsMjEg QEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCit2b2lkIEFjY2Vzc2liaWxpdHlPYmplY3Q6Om92 ZXJyaWRlQXR0YWNobWVudFBhcmVudChBY2Nlc3NpYmlsaXR5T2JqZWN0KiBwYXJlbnQpCit7Cisg ICAgaWYgKCFpc0F0dGFjaG1lbnQoKSkKKyAgICAgICAgcmV0dXJuOworICAgIAorICAgIGlkIHBh cmVudFdyYXBwZXIgPSBuaWw7CisgICAgaWYgKHBhcmVudCkgeworICAgICAgICBpZiAocGFyZW50 LT5hY2Nlc3NpYmlsaXR5SXNJZ25vcmVkKCkpCisgICAgICAgICAgICBwYXJlbnQgPSBwYXJlbnQt PnBhcmVudE9iamVjdFVuaWdub3JlZCgpOworICAgICAgICBwYXJlbnRXcmFwcGVyID0gcGFyZW50 LT53cmFwcGVyKCk7CisgICAgfQorICAgIAorICAgIFtbd3JhcHBlcigpIGF0dGFjaG1lbnRWaWV3 XSBhY2Nlc3NpYmlsaXR5U2V0T3ZlcnJpZGVWYWx1ZTpwYXJlbnRXcmFwcGVyIGZvckF0dHJpYnV0 ZTpOU0FjY2Vzc2liaWxpdHlQYXJlbnRBdHRyaWJ1dGVdOworfQorICAgIAogYm9vbCBBY2Nlc3Np YmlsaXR5T2JqZWN0OjphY2Nlc3NpYmlsaXR5SWdub3JlQXR0YWNobWVudCgpIGNvbnN0CiB7CiAg ICAgLy8gRnJhbWVWaWV3IGF0dGFjaG1lbnRzIGFyZSBub3cgaGFuZGxlZCBieSBBY2Nlc3NpYmls aXR5U2Nyb2xsVmlldywgCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vz c2liaWxpdHlSZW5kZXJPYmplY3QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9hY2Nl c3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuaAkocmV2aXNpb24gMTA5MTY3KQor KysgU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0 LmgJKHdvcmtpbmcgY29weSkKQEAgLTMwNiw2ICszMDYsNyBAQAogICAgIHZvaWQgYWRkVGV4dEZp ZWxkQ2hpbGRyZW4oKTsKICAgICB2b2lkIGFkZEltYWdlTWFwQ2hpbGRyZW4oKTsKICAgICB2b2lk IGFkZEF0dGFjaG1lbnRDaGlsZHJlbigpOworICAgIHZvaWQgdXBkYXRlQXR0YWNobWVudFZpZXdQ YXJlbnRzKCk7CiAgICAgCiAgICAgdm9pZCBhcmlhU2VsZWN0ZWRSb3dzKEFjY2Vzc2liaWxpdHlD aGlsZHJlblZlY3RvciYpOwogICAgIApJbmRleDogU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYWNj ZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmgJKHJldmlzaW9uIDEwOTE2NykKKysrIFNv dXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5oCSh3b3JraW5n IGNvcHkpCkBAIC01NTcsNyArNTU3LDcgQEAKICAgICB2aXJ0dWFsIHZvaWQgdXBkYXRlQ2hpbGRy ZW5JZk5lY2Vzc2FyeSgpOwogICAgIHZpcnR1YWwgdm9pZCBzZXROZWVkc1RvVXBkYXRlQ2hpbGRy ZW4oKSB7IH0KICAgICB2aXJ0dWFsIHZvaWQgY2xlYXJDaGlsZHJlbigpOwotICAgIHZpcnR1YWwg dm9pZCBkZXRhY2hGcm9tUGFyZW50KCkgeyB9CisgICAgdmlydHVhbCB2b2lkIGRldGFjaEZyb21Q YXJlbnQoKTsKIAogICAgIHZpcnR1YWwgdm9pZCBzZWxlY3RlZENoaWxkcmVuKEFjY2Vzc2liaWxp dHlDaGlsZHJlblZlY3RvciYpIHsgfQogICAgIHZpcnR1YWwgdm9pZCB2aXNpYmxlQ2hpbGRyZW4o QWNjZXNzaWJpbGl0eUNoaWxkcmVuVmVjdG9yJikgeyB9CkBAIC02NjcsNyArNjY3LDEzIEBACiAg ICAgfQogI2VuZGlmCiAjZW5kaWYKLQorICAgIAorI2lmIFBMQVRGT1JNKE1BQykKKyAgICB2b2lk IG92ZXJyaWRlQXR0YWNobWVudFBhcmVudChBY2Nlc3NpYmlsaXR5T2JqZWN0KiBwYXJlbnQpOwor I2Vsc2UKKyAgICB2b2lkIG92ZXJyaWRlQXR0YWNobWVudFBhcmVudChBY2Nlc3NpYmlsaXR5T2Jq ZWN0KikgeyB9CisjZW5kaWYKKyAgICAKICNpZiBIQVZFKEFDQ0VTU0lCSUxJVFkpCiAgICAgLy8g YSBwbGF0Zm9ybS1zcGVjaWZpYyBtZXRob2QgZm9yIGRldGVybWluaW5nIGlmIGFuIGF0dGFjaG1l bnQgaXMgaWdub3JlZAogICAgIGJvb2wgYWNjZXNzaWJpbGl0eUlnbm9yZUF0dGFjaG1lbnQoKSBj b25zdDsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJl bmRlck9iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcAkocmV2aXNpb24gMTA5MTY3KQorKysgU291 cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcAko d29ya2luZyBjb3B5KQpAQCAtMzUyOSw2ICszNTI5LDIwIEBACiAgICAgICAgIG1fY2hpbGRyZW4u YXBwZW5kKGF4V2lkZ2V0KTsKIH0KICAgICAKK3ZvaWQgQWNjZXNzaWJpbGl0eVJlbmRlck9iamVj dDo6dXBkYXRlQXR0YWNobWVudFZpZXdQYXJlbnRzKCkKK3sKKyAgICAvLyBPbmx5IHRoZSB1bmln bm9yZWQgcGFyZW50IHNob3VsZCBzZXQgdGhlIGF0dGFjaG1lbnQgcGFyZW50LCBiZWNhdXNlIHRo YXQncyB3aGF0IGlzIHJlZmxlY3RlZCBpbiB0aGUgQVggCisgICAgLy8gaGllcmFyY2h5IHRvIHRo ZSBjbGllbnQuCisgICAgaWYgKGFjY2Vzc2liaWxpdHlJc0lnbm9yZWQoKSkKKyAgICAgICAgcmV0 dXJuOworICAgIAorICAgIHNpemVfdCBsZW5ndGggPSBtX2NoaWxkcmVuLnNpemUoKTsKKyAgICBm b3IgKHNpemVfdCBrID0gMDsgayA8IGxlbmd0aDsgaysrKSB7CisgICAgICAgIGlmIChtX2NoaWxk cmVuW2tdLT5pc0F0dGFjaG1lbnQoKSkKKyAgICAgICAgICAgIG1fY2hpbGRyZW5ba10tPm92ZXJy aWRlQXR0YWNobWVudFBhcmVudCh0aGlzKTsKKyAgICB9Cit9CisgICAgCiB2b2lkIEFjY2Vzc2li aWxpdHlSZW5kZXJPYmplY3Q6OmFkZENoaWxkcmVuKCkKIHsKICAgICAvLyBJZiB0aGUgbmVlZCB0 byBhZGQgbW9yZSBjaGlsZHJlbiBpbiBhZGRpdGlvbiB0byBleGlzdGluZyBjaGlsZHJlbiBhcmlz ZXMsIApAQCAtMzU2Niw2ICszNTgwLDcgQEAKICAgICBhZGRBdHRhY2htZW50Q2hpbGRyZW4oKTsK ICAgICBhZGRJbWFnZU1hcENoaWxkcmVuKCk7CiAgICAgYWRkVGV4dEZpZWxkQ2hpbGRyZW4oKTsK KyAgICB1cGRhdGVBdHRhY2htZW50Vmlld1BhcmVudHMoKTsKIH0KICAgICAgICAgCiBjb25zdCBB dG9taWNTdHJpbmcmIEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OmFyaWFMaXZlUmVnaW9uU3Rh dHVzKCkgY29uc3QKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJp bGl0eU9iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcAkocmV2aXNpb24gMTA5MTY3KQorKysgU291cmNlL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMTE0MSw2ICsxMTQxLDEyIEBACiAgICAgICAgIGFkZENoaWxkcmVuKCk7ICAgIAogfQog Cit2b2lkIEFjY2Vzc2liaWxpdHlPYmplY3Q6OmRldGFjaEZyb21QYXJlbnQoKQoreworICAgIGlm IChpc0F0dGFjaG1lbnQoKSkKKyAgICAgICAgb3ZlcnJpZGVBdHRhY2htZW50UGFyZW50KDApOwor fQorICAgIAogdm9pZCBBY2Nlc3NpYmlsaXR5T2JqZWN0OjpjbGVhckNoaWxkcmVuKCkKIHsKICAg ICAvLyBTb21lIG9iamVjdHMgaGF2ZSB3ZWFrIHBvaW50ZXJzIHRvIHRoZWlyIHBhcmVudHMgYW5k IHRob3NlIGFzc29jaWF0aW9ucyBuZWVkIHRvIGJlIGRldGFjaGVkLgo=