80116 2012-03-01 23:55:33 -0800 HTMLTrackElement.idl doesn't have default attribute. 2012-03-07 06:08:07 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yosin webkit-unassigned abarth annacc arun.patole eric.carlson haraken ojan tkent webkit.review.bot oldest_to_newest 569338 0 yosin 2012-03-01 23:55:33 -0800 See http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#the-track-element 571522 1 arun.patole 2012-03-05 23:11:33 -0800 (In reply to comment #0) > See http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#the-track-element I could see it in HTMLTrackElement.idl: "attribute [Reflect=default] boolean isDefault;" http://trac.webkit.org/browser/trunk/Source/WebCore/html/HTMLTrackElement.idl 571607 2 yosin 2012-03-06 00:53:46 -0800 > I could see it in HTMLTrackElement.idl: > "attribute [Reflect=default] boolean isDefault;" In JS, it will be track.isDefault instead of track.default. We would like to have attribute [Reflect] boolean default; 571747 3 arun.patole 2012-03-06 04:59:10 -0800 (In reply to comment #2) > > I could see it in HTMLTrackElement.idl: > > "attribute [Reflect=default] boolean isDefault;" > > In JS, it will be track.isDefault instead of track.default. > We would like to have > attribute [Reflect] boolean default; ah, ok. There might be some reason for having isDefault and not 'default', Added Anna and Eric in cc. 571941 4 eric.carlson 2012-03-06 10:08:00 -0800 (In reply to comment #3) > (In reply to comment #2) > > > I could see it in HTMLTrackElement.idl: > > > "attribute [Reflect=default] boolean isDefault;" > > > > In JS, it will be track.isDefault instead of track.default. > > We would like to have > > attribute [Reflect] boolean default; > ah, ok. There might be some reason for having isDefault and not 'default', Added Anna and Eric in cc. I *think* there was a compile problem on at least one port. The intention was to reflect the attribute as 'default', but that is clearly not happening and is a bug. 572586 5 130554 arun.patole 2012-03-06 23:32:53 -0800 Created attachment 130554 proposed patch 572788 6 130554 haraken 2012-03-07 04:31:28 -0800 Comment on attachment 130554 proposed patch The change looks sane. (In reply to comment #4) > I *think* there was a compile problem on at least one port. The intention was to reflect the attribute as 'default', but that is clearly not happening and is a bug. It seems that 'isDefault' was introduced in the initial patch of HTMLTrackElement.idl (https://bugs.webkit.org/attachment.cgi?id=89094&action=review). 572836 7 130554 webkit.review.bot 2012-03-07 06:08:02 -0800 Comment on attachment 130554 proposed patch Clearing flags on attachment: 130554 Committed r110052: <http://trac.webkit.org/changeset/110052> 572837 8 webkit.review.bot 2012-03-07 06:08:07 -0800 All reviewed patches have been landed. Closing bug. 130554 2012-03-06 23:32:53 -0800 2012-03-07 06:08:02 -0800 proposed patch track-default-attr.patch text/plain 3131 arun.patole SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMDAxOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAzLTA2ICBBcnVuIFBh dG9sZSAgPGJtZjgzNEBtb3Rvcm9sYS5jb20+CisKKyAgICAgICAgSFRNTFRyYWNrRWxlbWVudC5p ZGwgZG9lc24ndCBoYXZlIGRlZmF1bHQgYXR0cmlidXRlLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODAxMTYKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW5hbWVkIGlzRGVmYXVsdCB0byAnZGVmYXVsdCcg c28gdGhhdCBpbiBKUywgaXQgd2lsbCBiZSB0cmFjay5kZWZhdWx0IGluc3RlYWQgb2YgdHJhY2su aXNEZWZhdWx0LgorICAgICAgICAqIGh0bWwvSFRNTFRyYWNrRWxlbWVudC5pZGw6CisKIDIwMTIt MDMtMDYgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVu cmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMTAwMTEuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxUcmFja0VsZW1lbnQuaWRsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTFRyYWNrRWxlbWVudC5pZGwJKHJldmlzaW9uIDEwNzUzNikKKysrIFNvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTFRyYWNrRWxlbWVudC5pZGwJKHdvcmtpbmcgY29weSkKQEAgLTMyLDcgKzMyLDcg QEAgbW9kdWxlIGh0bWwgewogICAgICAgICBhdHRyaWJ1dGUgRE9NU3RyaW5nIGtpbmQ7CiAgICAg ICAgIGF0dHJpYnV0ZSBET01TdHJpbmcgc3JjbGFuZzsKICAgICAgICAgYXR0cmlidXRlIERPTVN0 cmluZyBsYWJlbDsKLSAgICAgICAgYXR0cmlidXRlIFtSZWZsZWN0PWRlZmF1bHRdIGJvb2xlYW4g aXNEZWZhdWx0OworICAgICAgICBhdHRyaWJ1dGUgW1JlZmxlY3RdIGJvb2xlYW4gZGVmYXVsdDsK IAogICAgICAgICBjb25zdCB1bnNpZ25lZCBzaG9ydCBOT05FID0gMDsKICAgICAgICAgY29uc3Qg dW5zaWduZWQgc2hvcnQgTE9BRElORyA9IDE7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTAwMTkpCisr KyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAor MjAxMi0wMy0wNiAgQXJ1biBQYXRvbGUgIDxibWY4MzRAbW90b3JvbGEuY29tPgorCisgICAgICAg IEhUTUxUcmFja0VsZW1lbnQuaWRsIGRvZXNuJ3QgaGF2ZSBkZWZhdWx0IGF0dHJpYnV0ZS4gCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MDExNgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ugc3VyZSAn ZGVmYXVsdCcgSURMIGF0dHJpYnV0ZSByZWZsZWN0cyB0aGUgY29udGVudCBhdHRyaWJ1dGUgb2Yg dGhlIHNhbWUgbmFtZS4KKyAgICAgICAgKiBtZWRpYS90cmFjay90cmFjay1kZWZhdWx0LWF0dHJp YnV0ZS1leHBlY3RlZC50eHQ6CisgICAgICAgICogbWVkaWEvdHJhY2svdHJhY2stZGVmYXVsdC1h dHRyaWJ1dGUuaHRtbDoKKwogMjAxMi0wMy0wNiAgRnVtaXRvc2hpIFVrYWkgIDx1a2FpQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCBmaXggbGludCBlcnJvcgpJbmRleDogTGF5 b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJhY2stZGVmYXVsdC1hdHRyaWJ1dGUtZXhwZWN0ZWQudHh0 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL21lZGlhL3RyYWNrL3RyYWNrLWRlZmF1bHQtYXR0 cmlidXRlLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMTA3NTM2KQorKysgTGF5b3V0VGVzdHMvbWVk aWEvdHJhY2svdHJhY2stZGVmYXVsdC1hdHRyaWJ1dGUtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNv cHkpCkBAIC0zLDYgKzMsNyBAQCBUZXN0cyB0aGF0IGEgdHJhY2sgd2l0aCB0aGUgJ2RlZmF1bHQn IGF0CiBFVkVOVChsb2FkKQogRVhQRUNURUQgKGV2ZW50LnRhcmdldC5yZWFkeVN0YXRlID09ICcy JykgT0sKIEVYUEVDVEVEIChldmVudC50YXJnZXQuaWQgPT0gJ2RlZmF1bHQnKSBPSworRVhQRUNU RUQgKGV2ZW50LnRhcmdldC5kZWZhdWx0ID09ICd0cnVlJykgT0sKIAogRU5EIE9GIFRFU1QKIApJ bmRleDogTGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJhY2stZGVmYXVsdC1hdHRyaWJ1dGUuaHRt bAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1kZWZhdWx0LWF0 dHJpYnV0ZS5odG1sCShyZXZpc2lvbiAxMDc1MzYpCisrKyBMYXlvdXRUZXN0cy9tZWRpYS90cmFj ay90cmFjay1kZWZhdWx0LWF0dHJpYnV0ZS5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0xMiw2ICsx Miw3IEBACiAgICAgICAgICAgICAgICAgY29uc29sZVdyaXRlKCJFVkVOVChsb2FkKSIpOwogICAg ICAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgiZXZlbnQudGFyZ2V0LnJlYWR5U3RhdGUiLCBIVE1M VHJhY2tFbGVtZW50LkxPQURFRCk7CiAgICAgICAgICAgICAgICAgdGVzdEV4cGVjdGVkKCJldmVu dC50YXJnZXQuaWQiLCAiZGVmYXVsdCIpOworICAgICAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgi ZXZlbnQudGFyZ2V0LmRlZmF1bHQiLCB0cnVlKTsKICAgICAgICAgICAgICAgICBjb25zb2xlV3Jp dGUoIiIpOwogCiAgICAgICAgICAgICAgICAgLy8gRW5kIHRoZSB0ZXN0IGFmdGVyIGEgYnJpZWYg cGF1c2Ugc28gd2UgYWxsb3cgb3RoZXIgdHJhY2tzIHRvIGxvYWQgaWYgdGhleSB3aWxsLgo=