80102 2012-03-01 22:26:28 -0800 Make order of attribute/method in HTMLTrackElement.idl as same as specification 2012-08-02 22:26:32 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yosin yosin abarth haraken ojan tkent webkit.review.bot oldest_to_newest 569271 0 yosin 2012-03-01 22:26:28 -0800 For ease of maintainability, attributes and methods declaration order should be as same as specification. http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#the-track-element Similar work was done for input element: https://bugs.webkit.org/show_bug.cgi?id=79622 569280 1 129822 yosin 2012-03-01 22:31:15 -0800 Created attachment 129822 Patch 1 569281 2 yosin 2012-03-01 22:33:03 -0800 This is the last patch of series of Forms related IDL cleanup. (^_^)b 569286 3 129822 haraken 2012-03-01 22:35:26 -0800 Comment on attachment 129822 Patch 1 r=me 569287 4 129822 tkent 2012-03-01 22:36:13 -0800 Comment on attachment 129822 Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=129822&action=review > Source/WebCore/ChangeLog:3 > + [Forms] Make order of attribute/method in HTMLTrackElement.idl as same as specification HTMLTrackElement is not related to Forms. 569296 5 haraken 2012-03-01 22:46:41 -0800 (In reply to comment #4) > HTMLTrackElement is not related to Forms. Then I am neutral to the change. Generally speaking, ordering IDL attributes per the spec would be a good thing. On the other hand, we do not want to make a refactoring that does not have any benefit. I'd like to delegate the judgement to tkent (i.e. WONTFIX or r+). 569309 6 tkent 2012-03-01 23:02:05 -0800 (In reply to comment #5) > (In reply to comment #4) > > HTMLTrackElement is not related to Forms. > > Then I am neutral to the change. Generally speaking, ordering IDL attributes per the spec would be a good thing. On the other hand, we do not want to make a refactoring that does not have any benefit. I'd like to delegate the judgement to tkent (i.e. WONTFIX or r+). I'll be ok if we remove [Forms] from the summary. 686230 7 156260 yosin 2012-08-02 22:19:58 -0700 Created attachment 156260 Patch 2 686231 8 156261 yosin 2012-08-02 22:22:09 -0700 Created attachment 156261 Patch 3 686232 9 156261 yosin 2012-08-02 22:22:58 -0700 Comment on attachment 156261 Patch 3 Could you review this patch? Thanks in advance. = Changes since the last review = * Remove "[Forms]" from bug summary and update ChangeLog 686233 10 156261 haraken 2012-08-02 22:24:08 -0700 Comment on attachment 156261 Patch 3 Looks OK. 686234 11 156261 yosin 2012-08-02 22:26:26 -0700 Comment on attachment 156261 Patch 3 Clearing flags on attachment: 156261 Committed r124562: <http://trac.webkit.org/changeset/124562> 686235 12 yosin 2012-08-02 22:26:32 -0700 All reviewed patches have been landed. Closing bug. 129822 2012-03-01 22:31:15 -0800 2012-08-02 22:19:53 -0700 Patch 1 bug-80102-20120302153113.patch text/plain 1464 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5NDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWVhMDVhNWVjNDcxNmZm OGNjNmFkN2YzNThkMzk5ZGRlMGI3Y2EzOC4uZGI0YTA1YjlmNmRlMGE4NDM0ZmFiMDNlMGVkY2Rh NmE2ODIyOWVlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAzLTAxICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Zvcm1zXSBNYWtl IG9yZGVyIG9mIGF0dHJpYnV0ZS9tZXRob2QgaW4gSFRNTFRyYWNrRWxlbWVudC5pZGwgYXMgc2Ft ZSBhcyBzcGVjaWZpY2F0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04MDEwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIE5vIG5ldyB0ZXN0cy4gTm8gYmVoYXZpb3IgY2hhbmdlcy4KKworICAgICAgICAq IGh0bWwvSFRNTFRyYWNrRWxlbWVudC5pZGw6IFJlb3JkZXIgYXR0cmlidXRlL21ldGhvZCBwb3Np dGlvbi4KKwogMjAxMi0wMy0wMSAgTHVrZSBNYWNwaGVyc29uICAgPG1hY3BoZXJzb25AY2hyb21p dW0ub3JnPgogCiAgICAgICAgIEhhbmRsZSBDU1NQcm9wZXJ0eVdlYmtpdEJvcmRlckZpdCBpbiBD U1NTdHlsZUFwcGx5UHJvcGVydHkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxUcmFja0VsZW1lbnQuaWRsIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVHJhY2tFbGVtZW50 LmlkbAppbmRleCA1YzZkMTE5M2QzMzExZThiNmRjMzY2M2MyOGU0OTA4NjEwMGZmOTUxLi43ZGUy NjY1NGZmY2RiZTE4MGE5ZDA5ZTRhZWE1ZTMyZWZmYWUwNGZhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxUcmFja0VsZW1lbnQuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTFRyYWNrRWxlbWVudC5pZGwKQEAgLTI4LDggKzI4LDggQEAgbW9kdWxlIGh0bWwgewog ICAgICAgICBDb25kaXRpb25hbD1WSURFT19UUkFDSywKICAgICAgICAgVjhFbmFibGVkQXRSdW50 aW1lPXdlYmtpdFZpZGVvVHJhY2sKICAgICBdIEhUTUxUcmFja0VsZW1lbnQgOiBIVE1MRWxlbWVu dCB7Ci0gICAgICAgIGF0dHJpYnV0ZSBbUmVmbGVjdCwgVVJMXSBET01TdHJpbmcgc3JjOwogICAg ICAgICBhdHRyaWJ1dGUgRE9NU3RyaW5nIGtpbmQ7CisgICAgICAgIGF0dHJpYnV0ZSBbUmVmbGVj dCwgVVJMXSBET01TdHJpbmcgc3JjOwogICAgICAgICBhdHRyaWJ1dGUgRE9NU3RyaW5nIHNyY2xh bmc7CiAgICAgICAgIGF0dHJpYnV0ZSBET01TdHJpbmcgbGFiZWw7CiAgICAgICAgIGF0dHJpYnV0 ZSBbUmVmbGVjdD1kZWZhdWx0XSBib29sZWFuIGlzRGVmYXVsdDsK 156260 2012-08-02 22:19:58 -0700 2012-08-02 22:22:03 -0700 Patch 2 bug-80102-20120803141938.patch text/plain 1448 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NTYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWExMDZkMTU4M2M4MzM1 NGM0OGZhMGU4ZmQ1OTI0ZWRiMjE2NmFjZi4uNGFjMDEzZjFhNzBiN2JjMDhiYTBkYjc5MDA2N2U1 OWMxMDAzZTIxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA4LTAyICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTWFrZSBvcmRlciBv ZiBhdHRyaWJ1dGUvbWV0aG9kIGluIEhUTUxUcmFja0VsZW1lbnQuaWRsIGFzIHNhbWUgYXMgc3Bl Y2lmaWNhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9ODAxMDIKKworICAgICAgICBSZXZpZXdlZCBieSBLZW50IFRhbXVyYS4KKworICAgICAgICBO byBuZXcgdGVzdHMuIFRoaXMgcGF0Y2ggZG9lc24ndCBjaGFuZ2UgYmVoYXZpb3IuCisKKyAgICAg ICAgKiBodG1sL0hUTUxUcmFja0VsZW1lbnQuaWRsOiBSZW9yZGVyIGF0dHJpYnV0ZS9tZXRob2Qg cG9zaXRpb24uCisKIDIwMTItMDgtMDIgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIEZpeCBjcmFzaGVzIGZvciA8aW5wdXQ+IGFuZCA8dGV4dGFyZWE+IHdpdGgg ZGlzcGxheTpydW4taW4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUcmFj a0VsZW1lbnQuaWRsIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVHJhY2tFbGVtZW50LmlkbApp bmRleCAwMTA3ZGY1YTNkNGE2N2IwMmIyNzM0MmFkOTA2ODM1M2E0NGIyYWRmLi4zZTk4ZmVkNjZm MGFkMDhmYjQyYTQwYTk1MzUwZmQ3ZGZkOTZjOWY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxUcmFja0VsZW1lbnQuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TFRyYWNrRWxlbWVudC5pZGwKQEAgLTI4LDggKzI4LDggQEAgbW9kdWxlIGh0bWwgewogICAgICAg ICBDb25kaXRpb25hbD1WSURFT19UUkFDSywKICAgICAgICAgVjhFbmFibGVkQXRSdW50aW1lPXdl YmtpdFZpZGVvVHJhY2sKICAgICBdIEhUTUxUcmFja0VsZW1lbnQgOiBIVE1MRWxlbWVudCB7Ci0g ICAgICAgIGF0dHJpYnV0ZSBbUmVmbGVjdCwgVVJMXSBET01TdHJpbmcgc3JjOwogICAgICAgICBh dHRyaWJ1dGUgRE9NU3RyaW5nIGtpbmQ7CisgICAgICAgIGF0dHJpYnV0ZSBbUmVmbGVjdCwgVVJM XSBET01TdHJpbmcgc3JjOwogICAgICAgICBhdHRyaWJ1dGUgRE9NU3RyaW5nIHNyY2xhbmc7CiAg ICAgICAgIGF0dHJpYnV0ZSBET01TdHJpbmcgbGFiZWw7CiAgICAgICAgIGF0dHJpYnV0ZSBbUmVm bGVjdF0gYm9vbGVhbiBkZWZhdWx0Owo= 156261 2012-08-02 22:22:09 -0700 2012-08-02 22:26:26 -0700 Patch 3 bug-80102-20120803142149.patch text/plain 1451 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NTYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWExMDZkMTU4M2M4MzM1 NGM0OGZhMGU4ZmQ1OTI0ZWRiMjE2NmFjZi4uMWEwNDk2OTRhZTMzZjA0N2FjZjgyNzYzNzdmZDY1 NDE0NDliNDY5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA4LTAyICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTWFrZSBvcmRlciBv ZiBhdHRyaWJ1dGUvbWV0aG9kIGluIEhUTUxUcmFja0VsZW1lbnQuaWRsIGFzIHNhbWUgYXMgc3Bl Y2lmaWNhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9ODAxMDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBObyBuZXcgdGVzdHMuIFRoaXMgcGF0Y2ggZG9lc24ndCBjaGFuZ2UgYmVoYXZpb3IuCisKKyAg ICAgICAgKiBodG1sL0hUTUxUcmFja0VsZW1lbnQuaWRsOiBSZW9yZGVyIGF0dHJpYnV0ZS9tZXRo b2QgcG9zaXRpb24uCisKIDIwMTItMDgtMDIgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIEZpeCBjcmFzaGVzIGZvciA8aW5wdXQ+IGFuZCA8dGV4dGFyZWE+IHdp dGggZGlzcGxheTpydW4taW4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxU cmFja0VsZW1lbnQuaWRsIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVHJhY2tFbGVtZW50Lmlk bAppbmRleCAwMTA3ZGY1YTNkNGE2N2IwMmIyNzM0MmFkOTA2ODM1M2E0NGIyYWRmLi4zZTk4ZmVk NjZmMGFkMDhmYjQyYTQwYTk1MzUwZmQ3ZGZkOTZjOWY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxUcmFja0VsZW1lbnQuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTFRyYWNrRWxlbWVudC5pZGwKQEAgLTI4LDggKzI4LDggQEAgbW9kdWxlIGh0bWwgewogICAg ICAgICBDb25kaXRpb25hbD1WSURFT19UUkFDSywKICAgICAgICAgVjhFbmFibGVkQXRSdW50aW1l PXdlYmtpdFZpZGVvVHJhY2sKICAgICBdIEhUTUxUcmFja0VsZW1lbnQgOiBIVE1MRWxlbWVudCB7 Ci0gICAgICAgIGF0dHJpYnV0ZSBbUmVmbGVjdCwgVVJMXSBET01TdHJpbmcgc3JjOwogICAgICAg ICBhdHRyaWJ1dGUgRE9NU3RyaW5nIGtpbmQ7CisgICAgICAgIGF0dHJpYnV0ZSBbUmVmbGVjdCwg VVJMXSBET01TdHJpbmcgc3JjOwogICAgICAgICBhdHRyaWJ1dGUgRE9NU3RyaW5nIHNyY2xhbmc7 CiAgICAgICAgIGF0dHJpYnV0ZSBET01TdHJpbmcgbGFiZWw7CiAgICAgICAgIGF0dHJpYnV0ZSBb UmVmbGVjdF0gYm9vbGVhbiBkZWZhdWx0Owo=