80101 2012-03-01 22:20:22 -0800 [Forms] Make order of attribute/method in HTMLTextAreaElement.idl as same as specification 2012-03-02 05:32:02 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yosin yosin abarth haraken ojan tkent webkit.review.bot oldest_to_newest 569265 0 yosin 2012-03-01 22:20:22 -0800 For ease of maintainability, attributes and methods declaration order should be as same as specification. http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#the-textarea-element Similar work was done for input element: https://bugs.webkit.org/show_bug.cgi?id=79622 569268 1 129818 yosin 2012-03-01 22:24:29 -0800 Created attachment 129818 Patch 1 569278 2 129818 haraken 2012-03-01 22:29:56 -0800 Comment on attachment 129818 Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=129818&action=review > Source/WebCore/html/HTMLTextAreaElement.idl:61 > + // WinIE & FireFox extension: I am afraid this comment would be mis-placed by this change. Please be careful not to move comments randomly. 569290 3 yosin 2012-03-01 22:39:30 -0800 Attribute "labels" are now in specification. It is better to remove this obsolete comment not to make people confusing. 569292 4 haraken 2012-03-01 22:42:55 -0800 (In reply to comment #3) > Attribute "labels" are now in specification. It is better to remove this obsolete comment not to make people confusing. I am confused. The comment "// WinIE & FireFox extension:" had been written on selectionStart, selectionEnd, selectionDirection, setSelectionRange() and setSelectionRange(), right? 569304 5 yosin 2012-03-01 22:51:36 -0800 Oops, sorry for confusion. Yes, comment "WinIE & FireFox extension" is above the "selectionStart" attribute, but I'm not sure this comments applied all of them. Anyway, all of them after comments, selectionStart, selectionEnd, selectionDirection and setSelectionRange are now in standard. IF this comment could be in line by line, e.g. attribute unsigned long selectionStart; // FF/IE extension attribute unsigned long selectionEnd; // FF/IE extension easier to understand. 569306 6 129818 haraken 2012-03-01 22:54:57 -0800 Comment on attachment 129818 Patch 1 Makes sense! 569308 7 129818 tkent 2012-03-01 22:59:06 -0800 Comment on attachment 129818 Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=129818&action=review > Source/WebCore/html/HTMLTextAreaElement.idl:64 > + // WinIE & FireFox extension: > #if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C > void setSelectionRange(in long start, in long end); > #else setSelectionRange() isn't WinIE/FireFox extension, and should be below selectionDirection. http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#the-textarea-element 569314 8 129827 yosin 2012-03-01 23:17:43 -0800 Created attachment 129827 Patch 2 569315 9 yosin 2012-03-01 23:18:50 -0800 Thanks tkent@ good catch! I remove "// WinIE & FireFox extension:" 569329 10 129827 tkent 2012-03-01 23:41:42 -0800 Comment on attachment 129827 Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=129827&action=review > Source/WebCore/html/HTMLTextAreaElement.idl:55 > attribute DOMString selectionDirection; > + setSelectionRange should be here. 569368 11 129834 yosin 2012-03-02 00:18:37 -0800 Created attachment 129834 Patch 3 569402 12 129834 tkent 2012-03-02 01:02:20 -0800 Comment on attachment 129834 Patch 3 ok 569591 13 129834 webkit.review.bot 2012-03-02 05:31:55 -0800 Comment on attachment 129834 Patch 3 Clearing flags on attachment: 129834 Committed r109565: <http://trac.webkit.org/changeset/109565> 569592 14 webkit.review.bot 2012-03-02 05:32:02 -0800 All reviewed patches have been landed. Closing bug. 129818 2012-03-01 22:24:29 -0800 2012-03-01 23:17:37 -0800 Patch 1 bug-80101-20120302152428.patch text/plain 3380 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5NDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWVhMDVhNWVjNDcxNmZm OGNjNmFkN2YzNThkMzk5ZGRlMGI3Y2EzOC4uMDBiZjNkMDJhYjU0OWYxOGJhZTE1OTg1YjBmZjYy N2NhOTk5M2QxZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAzLTAxICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Zvcm1zXSBNYWtl IG9yZGVyIG9mIGF0dHJpYnV0ZS9tZXRob2QgaW4gSFRNTFRleHRBcmVhRWxlbWVudC5pZGwgYXMg c2FtZSBhcyBzcGVjaWZpY2F0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04MDEwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gTm8gYmVoYXZpb3IgY2hhbmdlcy4KKworICAgICAg ICAqIGh0bWwvSFRNTFRleHRBcmVhRWxlbWVudC5pZGw6IFJlb3JkZXIgYXR0cmlidXRlL21ldGhv ZCBwb3NpdGlvbi4KKwogMjAxMi0wMy0wMSAgTHVrZSBNYWNwaGVyc29uICAgPG1hY3BoZXJzb25A Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIEhhbmRsZSBDU1NQcm9wZXJ0eVdlYmtpdEJvcmRlckZp dCBpbiBDU1NTdHlsZUFwcGx5UHJvcGVydHkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxUZXh0QXJlYUVsZW1lbnQuaWRsIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVGV4 dEFyZWFFbGVtZW50LmlkbAppbmRleCBmNmVkMzc1MDM2ZWYxZGJkNzQwZTVjMDFkNjVhOGY4ZTY2 OWZmZGY2Li42ZjZmZmNiMDkyMTU0M2I2NWNjNWFmNjFjZTQ1MTMwNDU1YjZmOTJlIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUZXh0QXJlYUVsZW1lbnQuaWRsCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRleHRBcmVhRWxlbWVudC5pZGwKQEAgLTIyLDEzICsyMiwx MSBAQAogbW9kdWxlIGh0bWwgewogCiAgICAgaW50ZXJmYWNlIEhUTUxUZXh0QXJlYUVsZW1lbnQg OiBIVE1MRWxlbWVudCB7Ci0gICAgICAgIGF0dHJpYnV0ZSBbVHJlYXROdWxsQXM9TnVsbFN0cmlu Z10gRE9NU3RyaW5nIGRlZmF1bHRWYWx1ZTsKLSAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIEhU TUxGb3JtRWxlbWVudCBmb3JtOwotICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgVmFsaWRpdHlT dGF0ZSB2YWxpZGl0eTsKKyAgICAgICAgYXR0cmlidXRlIFtSZWZsZWN0XSBib29sZWFuIGF1dG9m b2N1czsKICAgICAgICAgYXR0cmlidXRlIGxvbmcgY29sczsKICAgICAgICAgYXR0cmlidXRlIFtS ZWZsZWN0XSBET01TdHJpbmcgZGlyTmFtZTsKICAgICAgICAgYXR0cmlidXRlIFtSZWZsZWN0XSBi b29sZWFuIGRpc2FibGVkOwotICAgICAgICBhdHRyaWJ1dGUgW1JlZmxlY3RdIGJvb2xlYW4gYXV0 b2ZvY3VzOworICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgSFRNTEZvcm1FbGVtZW50IGZvcm07 CiAgICAgICAgIGF0dHJpYnV0ZSBsb25nIG1heExlbmd0aCBzZXR0ZXIgcmFpc2VzKERPTUV4Y2Vw dGlvbik7CiAgICAgICAgIGF0dHJpYnV0ZSBbVHJlYXROdWxsQXM9TnVsbFN0cmluZ10gRE9NU3Ry aW5nIG5hbWU7CiAgICAgICAgIGF0dHJpYnV0ZSBbUmVmbGVjdF0gRE9NU3RyaW5nIHBsYWNlaG9s ZGVyOwpAQCAtMzYsMjQgKzM0LDMxIEBAIG1vZHVsZSBodG1sIHsKICAgICAgICAgYXR0cmlidXRl IFtSZWZsZWN0XSBib29sZWFuIHJlcXVpcmVkOwogICAgICAgICBhdHRyaWJ1dGUgbG9uZyByb3dz OwogICAgICAgICBhdHRyaWJ1dGUgW1JlZmxlY3RdIERPTVN0cmluZyB3cmFwOworCiAgICAgICAg IHJlYWRvbmx5IGF0dHJpYnV0ZSBET01TdHJpbmcgdHlwZTsKKyAgICAgICAgYXR0cmlidXRlIFtU cmVhdE51bGxBcz1OdWxsU3RyaW5nXSBET01TdHJpbmcgZGVmYXVsdFZhbHVlOwogICAgICAgICBh dHRyaWJ1dGUgW1RyZWF0TnVsbEFzPU51bGxTdHJpbmddIERPTVN0cmluZyB2YWx1ZTsKICAgICAg ICAgcmVhZG9ubHkgYXR0cmlidXRlIHVuc2lnbmVkIGxvbmcgdGV4dExlbmd0aDsKIAotI2lmIGRl ZmluZWQoTEFOR1VBR0VfT0JKRUNUSVZFX0MpICYmIExBTkdVQUdFX09CSkVDVElWRV9DCi0gICAg ICAgIGF0dHJpYnV0ZSBbUmVmbGVjdF0gRE9NU3RyaW5nIGFjY2Vzc0tleTsKLSNlbmRpZgotICAg ICAgICB2b2lkIHNlbGVjdCgpOwotCiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBib29sZWFu IHdpbGxWYWxpZGF0ZTsKKyAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIFZhbGlkaXR5U3RhdGUg dmFsaWRpdHk7CiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBET01TdHJpbmcgdmFsaWRhdGlv bk1lc3NhZ2U7CiAgICAgICAgIGJvb2xlYW4gY2hlY2tWYWxpZGl0eSgpOwogICAgICAgICB2b2lk IHNldEN1c3RvbVZhbGlkaXR5KGluIFtUcmVhdE51bGxBcz1OdWxsU3RyaW5nLCBUcmVhdFVuZGVm aW5lZEFzPU51bGxTdHJpbmddIERPTVN0cmluZyBlcnJvcik7CiAKLSAgICAgICAgLy8gV2luSUUg JiBGaXJlRm94IGV4dGVuc2lvbjoKKyAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIE5vZGVMaXN0 IGxhYmVsczsKKworICAgICAgICB2b2lkIHNlbGVjdCgpOwogICAgICAgICBhdHRyaWJ1dGUgbG9u ZyBzZWxlY3Rpb25TdGFydDsKICAgICAgICAgYXR0cmlidXRlIGxvbmcgc2VsZWN0aW9uRW5kOwog ICAgICAgICBhdHRyaWJ1dGUgRE9NU3RyaW5nIHNlbGVjdGlvbkRpcmVjdGlvbjsKKworCisjaWYg ZGVmaW5lZChMQU5HVUFHRV9PQkpFQ1RJVkVfQykgJiYgTEFOR1VBR0VfT0JKRUNUSVZFX0MKKyAg ICAgICAgYXR0cmlidXRlIFtSZWZsZWN0XSBET01TdHJpbmcgYWNjZXNzS2V5OworI2VuZGlmCisK KyAgICAgICAgLy8gV2luSUUgJiBGaXJlRm94IGV4dGVuc2lvbjoKICNpZiBkZWZpbmVkKExBTkdV QUdFX09CSkVDVElWRV9DKSAmJiBMQU5HVUFHRV9PQkpFQ1RJVkVfQwogICAgICAgICB2b2lkIHNl dFNlbGVjdGlvblJhbmdlKGluIGxvbmcgc3RhcnQsIGluIGxvbmcgZW5kKTsKICNlbHNlCkBAIC02 MSw3ICs2Niw2IEBAIG1vZHVsZSBodG1sIHsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBpbiBbT3B0aW9uYWw9RGVmYXVsdElzVW5kZWZpbmVkXSBsb25nIGVuZCwgCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgaW4gW09wdGlvbmFsXSBET01TdHJpbmcgZGlyZWN0aW9uKTsK ICNlbmRpZgotICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgTm9kZUxpc3QgbGFiZWxzOwotICAg IH07CiAKKyAgICB9OwogfQo= 129827 2012-03-01 23:17:43 -0800 2012-03-02 00:18:31 -0800 Patch 2 bug-80101-20120302161742.patch text/plain 3333 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5NDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWVhMDVhNWVjNDcxNmZm OGNjNmFkN2YzNThkMzk5ZGRlMGI3Y2EzOC4uMDBiZjNkMDJhYjU0OWYxOGJhZTE1OTg1YjBmZjYy N2NhOTk5M2QxZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAzLTAxICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Zvcm1zXSBNYWtl IG9yZGVyIG9mIGF0dHJpYnV0ZS9tZXRob2QgaW4gSFRNTFRleHRBcmVhRWxlbWVudC5pZGwgYXMg c2FtZSBhcyBzcGVjaWZpY2F0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04MDEwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gTm8gYmVoYXZpb3IgY2hhbmdlcy4KKworICAgICAg ICAqIGh0bWwvSFRNTFRleHRBcmVhRWxlbWVudC5pZGw6IFJlb3JkZXIgYXR0cmlidXRlL21ldGhv ZCBwb3NpdGlvbi4KKwogMjAxMi0wMy0wMSAgTHVrZSBNYWNwaGVyc29uICAgPG1hY3BoZXJzb25A Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIEhhbmRsZSBDU1NQcm9wZXJ0eVdlYmtpdEJvcmRlckZp dCBpbiBDU1NTdHlsZUFwcGx5UHJvcGVydHkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxUZXh0QXJlYUVsZW1lbnQuaWRsIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVGV4 dEFyZWFFbGVtZW50LmlkbAppbmRleCBmNmVkMzc1MDM2ZWYxZGJkNzQwZTVjMDFkNjVhOGY4ZTY2 OWZmZGY2Li5jYjMwZGFhMjExODk0MGVkMGRlOTI0NTk2NzZjYjZhMzQ2ZWU5OGZmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUZXh0QXJlYUVsZW1lbnQuaWRsCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRleHRBcmVhRWxlbWVudC5pZGwKQEAgLTIyLDEzICsyMiwx MSBAQAogbW9kdWxlIGh0bWwgewogCiAgICAgaW50ZXJmYWNlIEhUTUxUZXh0QXJlYUVsZW1lbnQg OiBIVE1MRWxlbWVudCB7Ci0gICAgICAgIGF0dHJpYnV0ZSBbVHJlYXROdWxsQXM9TnVsbFN0cmlu Z10gRE9NU3RyaW5nIGRlZmF1bHRWYWx1ZTsKLSAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIEhU TUxGb3JtRWxlbWVudCBmb3JtOwotICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgVmFsaWRpdHlT dGF0ZSB2YWxpZGl0eTsKKyAgICAgICAgYXR0cmlidXRlIFtSZWZsZWN0XSBib29sZWFuIGF1dG9m b2N1czsKICAgICAgICAgYXR0cmlidXRlIGxvbmcgY29sczsKICAgICAgICAgYXR0cmlidXRlIFtS ZWZsZWN0XSBET01TdHJpbmcgZGlyTmFtZTsKICAgICAgICAgYXR0cmlidXRlIFtSZWZsZWN0XSBi b29sZWFuIGRpc2FibGVkOwotICAgICAgICBhdHRyaWJ1dGUgW1JlZmxlY3RdIGJvb2xlYW4gYXV0 b2ZvY3VzOworICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgSFRNTEZvcm1FbGVtZW50IGZvcm07 CiAgICAgICAgIGF0dHJpYnV0ZSBsb25nIG1heExlbmd0aCBzZXR0ZXIgcmFpc2VzKERPTUV4Y2Vw dGlvbik7CiAgICAgICAgIGF0dHJpYnV0ZSBbVHJlYXROdWxsQXM9TnVsbFN0cmluZ10gRE9NU3Ry aW5nIG5hbWU7CiAgICAgICAgIGF0dHJpYnV0ZSBbUmVmbGVjdF0gRE9NU3RyaW5nIHBsYWNlaG9s ZGVyOwpAQCAtMzYsMjQgKzM0LDMwIEBAIG1vZHVsZSBodG1sIHsKICAgICAgICAgYXR0cmlidXRl IFtSZWZsZWN0XSBib29sZWFuIHJlcXVpcmVkOwogICAgICAgICBhdHRyaWJ1dGUgbG9uZyByb3dz OwogICAgICAgICBhdHRyaWJ1dGUgW1JlZmxlY3RdIERPTVN0cmluZyB3cmFwOworCiAgICAgICAg IHJlYWRvbmx5IGF0dHJpYnV0ZSBET01TdHJpbmcgdHlwZTsKKyAgICAgICAgYXR0cmlidXRlIFtU cmVhdE51bGxBcz1OdWxsU3RyaW5nXSBET01TdHJpbmcgZGVmYXVsdFZhbHVlOwogICAgICAgICBh dHRyaWJ1dGUgW1RyZWF0TnVsbEFzPU51bGxTdHJpbmddIERPTVN0cmluZyB2YWx1ZTsKICAgICAg ICAgcmVhZG9ubHkgYXR0cmlidXRlIHVuc2lnbmVkIGxvbmcgdGV4dExlbmd0aDsKIAotI2lmIGRl ZmluZWQoTEFOR1VBR0VfT0JKRUNUSVZFX0MpICYmIExBTkdVQUdFX09CSkVDVElWRV9DCi0gICAg ICAgIGF0dHJpYnV0ZSBbUmVmbGVjdF0gRE9NU3RyaW5nIGFjY2Vzc0tleTsKLSNlbmRpZgotICAg ICAgICB2b2lkIHNlbGVjdCgpOwotCiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBib29sZWFu IHdpbGxWYWxpZGF0ZTsKKyAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIFZhbGlkaXR5U3RhdGUg dmFsaWRpdHk7CiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBET01TdHJpbmcgdmFsaWRhdGlv bk1lc3NhZ2U7CiAgICAgICAgIGJvb2xlYW4gY2hlY2tWYWxpZGl0eSgpOwogICAgICAgICB2b2lk IHNldEN1c3RvbVZhbGlkaXR5KGluIFtUcmVhdE51bGxBcz1OdWxsU3RyaW5nLCBUcmVhdFVuZGVm aW5lZEFzPU51bGxTdHJpbmddIERPTVN0cmluZyBlcnJvcik7CiAKLSAgICAgICAgLy8gV2luSUUg JiBGaXJlRm94IGV4dGVuc2lvbjoKKyAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIE5vZGVMaXN0 IGxhYmVsczsKKworICAgICAgICB2b2lkIHNlbGVjdCgpOwogICAgICAgICBhdHRyaWJ1dGUgbG9u ZyBzZWxlY3Rpb25TdGFydDsKICAgICAgICAgYXR0cmlidXRlIGxvbmcgc2VsZWN0aW9uRW5kOwog ICAgICAgICBhdHRyaWJ1dGUgRE9NU3RyaW5nIHNlbGVjdGlvbkRpcmVjdGlvbjsKKworCisjaWYg ZGVmaW5lZChMQU5HVUFHRV9PQkpFQ1RJVkVfQykgJiYgTEFOR1VBR0VfT0JKRUNUSVZFX0MKKyAg ICAgICAgYXR0cmlidXRlIFtSZWZsZWN0XSBET01TdHJpbmcgYWNjZXNzS2V5OworI2VuZGlmCisK ICNpZiBkZWZpbmVkKExBTkdVQUdFX09CSkVDVElWRV9DKSAmJiBMQU5HVUFHRV9PQkpFQ1RJVkVf QwogICAgICAgICB2b2lkIHNldFNlbGVjdGlvblJhbmdlKGluIGxvbmcgc3RhcnQsIGluIGxvbmcg ZW5kKTsKICNlbHNlCkBAIC02MSw3ICs2NSw1IEBAIG1vZHVsZSBodG1sIHsKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBpbiBbT3B0aW9uYWw9RGVmYXVsdElzVW5kZWZpbmVkXSBsb25n IGVuZCwgCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW4gW09wdGlvbmFsXSBET01T dHJpbmcgZGlyZWN0aW9uKTsKICNlbmRpZgotICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgTm9k ZUxpc3QgbGFiZWxzOwogICAgIH07Ci0KIH0K 129834 2012-03-02 00:18:37 -0800 2012-03-02 05:31:55 -0800 Patch 3 bug-80101-20120302171836.patch text/plain 3533 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5NDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWVhMDVhNWVjNDcxNmZm OGNjNmFkN2YzNThkMzk5ZGRlMGI3Y2EzOC4uMDBiZjNkMDJhYjU0OWYxOGJhZTE1OTg1YjBmZjYy N2NhOTk5M2QxZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAzLTAxICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Zvcm1zXSBNYWtl IG9yZGVyIG9mIGF0dHJpYnV0ZS9tZXRob2QgaW4gSFRNTFRleHRBcmVhRWxlbWVudC5pZGwgYXMg c2FtZSBhcyBzcGVjaWZpY2F0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04MDEwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gTm8gYmVoYXZpb3IgY2hhbmdlcy4KKworICAgICAg ICAqIGh0bWwvSFRNTFRleHRBcmVhRWxlbWVudC5pZGw6IFJlb3JkZXIgYXR0cmlidXRlL21ldGhv ZCBwb3NpdGlvbi4KKwogMjAxMi0wMy0wMSAgTHVrZSBNYWNwaGVyc29uICAgPG1hY3BoZXJzb25A Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIEhhbmRsZSBDU1NQcm9wZXJ0eVdlYmtpdEJvcmRlckZp dCBpbiBDU1NTdHlsZUFwcGx5UHJvcGVydHkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxUZXh0QXJlYUVsZW1lbnQuaWRsIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVGV4 dEFyZWFFbGVtZW50LmlkbAppbmRleCBmNmVkMzc1MDM2ZWYxZGJkNzQwZTVjMDFkNjVhOGY4ZTY2 OWZmZGY2Li5mOWQ4MGI1YWQxYTMwNDU5NzgwMzg5MmRiMWU3YmNlYTYyMmIyMzBkIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUZXh0QXJlYUVsZW1lbnQuaWRsCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRleHRBcmVhRWxlbWVudC5pZGwKQEAgLTIyLDEzICsyMiwx MSBAQAogbW9kdWxlIGh0bWwgewogCiAgICAgaW50ZXJmYWNlIEhUTUxUZXh0QXJlYUVsZW1lbnQg OiBIVE1MRWxlbWVudCB7Ci0gICAgICAgIGF0dHJpYnV0ZSBbVHJlYXROdWxsQXM9TnVsbFN0cmlu Z10gRE9NU3RyaW5nIGRlZmF1bHRWYWx1ZTsKLSAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIEhU TUxGb3JtRWxlbWVudCBmb3JtOwotICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgVmFsaWRpdHlT dGF0ZSB2YWxpZGl0eTsKKyAgICAgICAgYXR0cmlidXRlIFtSZWZsZWN0XSBib29sZWFuIGF1dG9m b2N1czsKICAgICAgICAgYXR0cmlidXRlIGxvbmcgY29sczsKICAgICAgICAgYXR0cmlidXRlIFtS ZWZsZWN0XSBET01TdHJpbmcgZGlyTmFtZTsKICAgICAgICAgYXR0cmlidXRlIFtSZWZsZWN0XSBi b29sZWFuIGRpc2FibGVkOwotICAgICAgICBhdHRyaWJ1dGUgW1JlZmxlY3RdIGJvb2xlYW4gYXV0 b2ZvY3VzOworICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgSFRNTEZvcm1FbGVtZW50IGZvcm07 CiAgICAgICAgIGF0dHJpYnV0ZSBsb25nIG1heExlbmd0aCBzZXR0ZXIgcmFpc2VzKERPTUV4Y2Vw dGlvbik7CiAgICAgICAgIGF0dHJpYnV0ZSBbVHJlYXROdWxsQXM9TnVsbFN0cmluZ10gRE9NU3Ry aW5nIG5hbWU7CiAgICAgICAgIGF0dHJpYnV0ZSBbUmVmbGVjdF0gRE9NU3RyaW5nIHBsYWNlaG9s ZGVyOwpAQCAtMzYsMzIgKzM0LDM0IEBAIG1vZHVsZSBodG1sIHsKICAgICAgICAgYXR0cmlidXRl IFtSZWZsZWN0XSBib29sZWFuIHJlcXVpcmVkOwogICAgICAgICBhdHRyaWJ1dGUgbG9uZyByb3dz OwogICAgICAgICBhdHRyaWJ1dGUgW1JlZmxlY3RdIERPTVN0cmluZyB3cmFwOworCiAgICAgICAg IHJlYWRvbmx5IGF0dHJpYnV0ZSBET01TdHJpbmcgdHlwZTsKKyAgICAgICAgYXR0cmlidXRlIFtU cmVhdE51bGxBcz1OdWxsU3RyaW5nXSBET01TdHJpbmcgZGVmYXVsdFZhbHVlOwogICAgICAgICBh dHRyaWJ1dGUgW1RyZWF0TnVsbEFzPU51bGxTdHJpbmddIERPTVN0cmluZyB2YWx1ZTsKICAgICAg ICAgcmVhZG9ubHkgYXR0cmlidXRlIHVuc2lnbmVkIGxvbmcgdGV4dExlbmd0aDsKIAotI2lmIGRl ZmluZWQoTEFOR1VBR0VfT0JKRUNUSVZFX0MpICYmIExBTkdVQUdFX09CSkVDVElWRV9DCi0gICAg ICAgIGF0dHJpYnV0ZSBbUmVmbGVjdF0gRE9NU3RyaW5nIGFjY2Vzc0tleTsKLSNlbmRpZgotICAg ICAgICB2b2lkIHNlbGVjdCgpOwotCiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBib29sZWFu IHdpbGxWYWxpZGF0ZTsKKyAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIFZhbGlkaXR5U3RhdGUg dmFsaWRpdHk7CiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBET01TdHJpbmcgdmFsaWRhdGlv bk1lc3NhZ2U7CiAgICAgICAgIGJvb2xlYW4gY2hlY2tWYWxpZGl0eSgpOwogICAgICAgICB2b2lk IHNldEN1c3RvbVZhbGlkaXR5KGluIFtUcmVhdE51bGxBcz1OdWxsU3RyaW5nLCBUcmVhdFVuZGVm aW5lZEFzPU51bGxTdHJpbmddIERPTVN0cmluZyBlcnJvcik7CiAKLSAgICAgICAgLy8gV2luSUUg JiBGaXJlRm94IGV4dGVuc2lvbjoKKyAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIE5vZGVMaXN0 IGxhYmVsczsKKworICAgICAgICB2b2lkIHNlbGVjdCgpOwogICAgICAgICBhdHRyaWJ1dGUgbG9u ZyBzZWxlY3Rpb25TdGFydDsKICAgICAgICAgYXR0cmlidXRlIGxvbmcgc2VsZWN0aW9uRW5kOwog ICAgICAgICBhdHRyaWJ1dGUgRE9NU3RyaW5nIHNlbGVjdGlvbkRpcmVjdGlvbjsKICNpZiBkZWZp bmVkKExBTkdVQUdFX09CSkVDVElWRV9DKSAmJiBMQU5HVUFHRV9PQkpFQ1RJVkVfQwogICAgICAg ICB2b2lkIHNldFNlbGVjdGlvblJhbmdlKGluIGxvbmcgc3RhcnQsIGluIGxvbmcgZW5kKTsKICNl bHNlCi0gICAgICAgIHZvaWQgc2V0U2VsZWN0aW9uUmFuZ2UoaW4gW09wdGlvbmFsPURlZmF1bHRJ c1VuZGVmaW5lZF0gbG9uZyBzdGFydCwgCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg aW4gW09wdGlvbmFsPURlZmF1bHRJc1VuZGVmaW5lZF0gbG9uZyBlbmQsIAorICAgICAgICB2b2lk IHNldFNlbGVjdGlvblJhbmdlKGluIFtPcHRpb25hbD1EZWZhdWx0SXNVbmRlZmluZWRdIGxvbmcg c3RhcnQsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW4gW09wdGlvbmFsPURlZmF1 bHRJc1VuZGVmaW5lZF0gbG9uZyBlbmQsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg aW4gW09wdGlvbmFsXSBET01TdHJpbmcgZGlyZWN0aW9uKTsKICNlbmRpZgotICAgICAgICByZWFk b25seSBhdHRyaWJ1dGUgTm9kZUxpc3QgbGFiZWxzOwotICAgIH07CiAKKyNpZiBkZWZpbmVkKExB TkdVQUdFX09CSkVDVElWRV9DKSAmJiBMQU5HVUFHRV9PQkpFQ1RJVkVfQworICAgICAgICBhdHRy aWJ1dGUgW1JlZmxlY3RdIERPTVN0cmluZyBhY2Nlc3NLZXk7CisjZW5kaWYKKyAgICB9OwogfQo=