80091 2012-03-01 21:25:57 -0800 [Forms] Make order of attribute/method in HTMLButtonElement.idl as same as specification 2012-03-02 03:54:48 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yosin yosin abarth haraken ojan webkit.review.bot oldest_to_newest 569222 0 yosin 2012-03-01 21:25:57 -0800 For ease of maintainability, attributes and methods declaration order should be as same as specification. See http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html Similar work was done for input element: https://bugs.webkit.org/show_bug.cgi?id=79622 569223 1 129805 yosin 2012-03-01 21:33:11 -0800 Created attachment 129805 Patch 1 569233 2 129805 haraken 2012-03-01 21:49:29 -0800 Comment on attachment 129805 Patch 1 r=me 569509 3 129805 webkit.review.bot 2012-03-02 03:54:44 -0800 Comment on attachment 129805 Patch 1 Clearing flags on attachment: 129805 Committed r109550: <http://trac.webkit.org/changeset/109550> 569510 4 webkit.review.bot 2012-03-02 03:54:48 -0800 All reviewed patches have been landed. Closing bug. 129805 2012-03-01 21:33:11 -0800 2012-03-02 03:54:44 -0800 Patch 1 bug-80091-20120302143310.patch text/plain 2624 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5NDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWVhMDVhNWVjNDcxNmZm OGNjNmFkN2YzNThkMzk5ZGRlMGI3Y2EzOC4uMzdhNmU0MTY0MjcyNzdjMTM1MDBiZDQ5NmMxYWM1 ZjBhZDQzYzkzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAzLTAxICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Zvcm1zXSBNYWtl IG9yZGVyIG9mIGF0dHJpYnV0ZS9tZXRob2QgaW4gSFRNTEJ1dHRvbkVsZW1lbnQuaWRsIGFzIHNh bWUgYXMgc3BlY2lmaWNhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODAwOTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBObyBuZXcgdGVzdHMuIE5vIGJlaGF2aW9yIGNoYW5nZXMuCisKKyAgICAgICAg KiBodG1sL0hUTUxCdXR0b25FbGVtZW50LmlkbDogUmVvcmRlciBhdHRyaWJ1dGUvbWV0aG9kIHBv c2l0aW9uLgorCiAyMDEyLTAzLTAxICBMdWtlIE1hY3BoZXJzb24gICA8bWFjcGhlcnNvbkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgSGFuZGxlIENTU1Byb3BlcnR5V2Via2l0Qm9yZGVyRml0IGlu IENTU1N0eWxlQXBwbHlQcm9wZXJ0eS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTEJ1dHRvbkVsZW1lbnQuaWRsIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQnV0dG9uRWxl bWVudC5pZGwKaW5kZXggYjllYWZiMGQ1ZTY2YjA5NDFiMTgyNTZlYjNkZTA3YjFmYTZlYzUzOS4u NjkyZmQ2MTJhMWU2NjE1MDBkZjI3N2ZjOGQzN2Q4NzNmZjI1ZDllNCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MQnV0dG9uRWxlbWVudC5pZGwKKysrIGIvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MQnV0dG9uRWxlbWVudC5pZGwKQEAgLTIxLDM0ICsyMSwzMiBAQAogbW9kdWxl IGh0bWwgewogCiAgICAgaW50ZXJmYWNlIEhUTUxCdXR0b25FbGVtZW50IDogSFRNTEVsZW1lbnQg eworICAgICAgICBhdHRyaWJ1dGUgW1JlZmxlY3RdIGJvb2xlYW4gYXV0b2ZvY3VzOworICAgICAg ICBhdHRyaWJ1dGUgW1JlZmxlY3RdIGJvb2xlYW4gZGlzYWJsZWQ7CiAgICAgICAgIHJlYWRvbmx5 IGF0dHJpYnV0ZSBIVE1MRm9ybUVsZW1lbnQgZm9ybTsKLQogICAgICAgICBhdHRyaWJ1dGUgW1Jl ZmxlY3QsIFVSTF0gRE9NU3RyaW5nIGZvcm1BY3Rpb247CiAgICAgICAgIGF0dHJpYnV0ZSBbVHJl YXROdWxsQXM9TnVsbFN0cmluZ10gRE9NU3RyaW5nIGZvcm1FbmN0eXBlOwogICAgICAgICBhdHRy aWJ1dGUgW1RyZWF0TnVsbEFzPU51bGxTdHJpbmddIERPTVN0cmluZyBmb3JtTWV0aG9kOwogICAg ICAgICBhdHRyaWJ1dGUgW1JlZmxlY3RdIGJvb2xlYW4gZm9ybU5vVmFsaWRhdGU7CiAgICAgICAg IGF0dHJpYnV0ZSBbUmVmbGVjdF0gRE9NU3RyaW5nIGZvcm1UYXJnZXQ7Ci0gICAgICAgIHJlYWRv bmx5IGF0dHJpYnV0ZSBWYWxpZGl0eVN0YXRlIHZhbGlkaXR5OwotCi0jaWYgZGVmaW5lZChMQU5H VUFHRV9PQkpFQ1RJVkVfQykgJiYgTEFOR1VBR0VfT0JKRUNUSVZFX0MKLSAgICAgICAgYXR0cmli dXRlIFtSZWZsZWN0XSBET01TdHJpbmcgYWNjZXNzS2V5OwotI2VuZGlmCi0gICAgICAgIGF0dHJp YnV0ZSBbUmVmbGVjdF0gYm9vbGVhbiBkaXNhYmxlZDsKLSAgICAgICAgYXR0cmlidXRlIFtSZWZs ZWN0XSBib29sZWFuIGF1dG9mb2N1czsKICAgICAgICAgYXR0cmlidXRlIFtSZWZsZWN0XSBET01T dHJpbmcgbmFtZTsKICAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIERPTVN0cmluZyB0eXBlOwog ICAgICAgICBhdHRyaWJ1dGUgW1JlZmxlY3RdIERPTVN0cmluZyB2YWx1ZTsKIAogICAgICAgICBy ZWFkb25seSBhdHRyaWJ1dGUgYm9vbGVhbiB3aWxsVmFsaWRhdGU7CisgICAgICAgIHJlYWRvbmx5 IGF0dHJpYnV0ZSBWYWxpZGl0eVN0YXRlIHZhbGlkaXR5OwogICAgICAgICByZWFkb25seSBhdHRy aWJ1dGUgRE9NU3RyaW5nIHZhbGlkYXRpb25NZXNzYWdlOwogICAgICAgICBib29sZWFuIGNoZWNr VmFsaWRpdHkoKTsKICAgICAgICAgdm9pZCBzZXRDdXN0b21WYWxpZGl0eShpbiBbVHJlYXROdWxs QXM9TnVsbFN0cmluZywgVHJlYXRVbmRlZmluZWRBcz1OdWxsU3RyaW5nXSBET01TdHJpbmcgZXJy b3IpOwogCisgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBOb2RlTGlzdCBsYWJlbHM7CisKICNp ZiBkZWZpbmVkKExBTkdVQUdFX09CSkVDVElWRV9DKSAmJiBMQU5HVUFHRV9PQkpFQ1RJVkVfQwot ICAgICAgICB2b2lkIGNsaWNrKCk7CisgICAgICAgIGF0dHJpYnV0ZSBbUmVmbGVjdF0gRE9NU3Ry aW5nIGFjY2Vzc0tleTsKICNlbmRpZgogCi0gICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBOb2Rl TGlzdCBsYWJlbHM7CisjaWYgZGVmaW5lZChMQU5HVUFHRV9PQkpFQ1RJVkVfQykgJiYgTEFOR1VB R0VfT0JKRUNUSVZFX0MKKyAgICAgICAgdm9pZCBjbGljaygpOworI2VuZGlmCiAgICAgfTsKLQog fQo=