80083 2012-03-01 19:19:12 -0800 nrwt: virtual tests aren't being run 2012-03-01 19:28:35 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth eric ojan tony oldest_to_newest 569171 0 dpranke 2012-03-01 19:19:12 -0800 nrwt: virtual tests aren't being run 569172 1 129792 dpranke 2012-03-01 19:19:45 -0800 Created attachment 129792 Patch 569174 2 129792 eric 2012-03-01 19:22:26 -0800 Comment on attachment 129792 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129792&action=review > Tools/Scripts/webkitpy/layout_tests/port/base.py:1086 > + for test in suite.tests: > + if any(test.startswith(p) for p in paths): > + virtual_tests.add(test) > + else: > + virtual_tests.update(set(suite.tests.keys())) I suspect this whole block could be written shorter with comprehesions or a filter statement. 569178 3 dpranke 2012-03-01 19:25:53 -0800 (In reply to comment #2) > (From update of attachment 129792 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=129792&action=review > > > Tools/Scripts/webkitpy/layout_tests/port/base.py:1086 > > + for test in suite.tests: > > + if any(test.startswith(p) for p in paths): > > + virtual_tests.add(test) > > + else: > > + virtual_tests.update(set(suite.tests.keys())) > > I suspect this whole block could be written shorter with comprehesions or a filter statement. Shorter, probably. I don't know if it would be more comprehensible, though. It's a nested-loop join (meaning for each item in one list we have to iterate over another list), and I find those are usually hard to follow w/ list comprehensions. I don't think there's an eas(ier?) way to do it with filter(), but I could be wrong. This code at least has the virtue of being pretty easy to follow. We could pull the 'if paths' out of the outer loop, and it might be slightly easier to follow as well. 569180 4 dpranke 2012-03-01 19:28:35 -0800 Committed r109490: <http://trac.webkit.org/changeset/109490> 129792 2012-03-01 19:19:45 -0800 2012-03-01 19:22:26 -0800 Patch bug-80083-20120301191944.patch text/plain 3780 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5NDU5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDgyYTk4ZDFiMjJmMDhkYzQxNTg4MTljMmFkNzM3ODhm MzU5ZjY3NS4uYmY4NmFkYWQ3N2VlZmU4NGM5MmRlNmZiZTYzNmRmMmYwZGZlOWExNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIz IEBACiAyMDEyLTAzLTAxICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIG5yd3Q6IHZpcnR1YWwgdGVzdHMgYXJlbid0IGJlaW5nIHJ1bgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODAwODMKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJZiB3ZSB0cmllZCB0byBydW4gYWxs IG9mIHRoZSB0ZXN0cyBieSBkZWZhdWx0IChhbmQKKyAgICAgICAgZGlkbid0IHNwZWNpZnkgYW55 IHBhdGhzKSwgdGhlIHZpcnR1YWwgdGVzdHMgd2VyZW4ndAorICAgICAgICBwaWNrZWQgdXAuCisK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Jhc2UucHk6Cisg ICAgICAgIChQb3J0Ll92aXJ0dWFsX3Rlc3RzKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9wb3J0L2Jhc2VfdW5pdHRlc3QucHk6CisgICAgICAgIChQb3J0VGVzdC50 ZXN0X3Rlc3RzKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L3Rlc3QucHk6CisgICAgICAgIChUZXN0UG9ydC52aXJ0dWFsX3Rlc3Rfc3VpdGVzKToKKworMjAx Mi0wMy0wMSAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KKwogICAgICAgICBu cnd0OiB0ZXN0X2lzZmlsZSwgdGVzdF9pc2RpciwgYW5kIHRlc3RfZXhpc3RzIGRvbid0IHdvcmsg Zm9yIHZpcnR1YWwgdGVzdHMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTgwMDQ4CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvYmFzZS5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3BvcnQvYmFzZS5weQppbmRleCBjZTU4ODA0ZGI3ODA4NDAyN2JlOGE4OWU0MTE3Y2MyZDFh OTY0ZTliLi4xMWFhNTA4MWMyYWJlYjZhYWNhOTcwMjFmOWJhZGEwNzg3Y2UzODIzIDEwMDc1NQot LS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Jhc2UucHkKKysr IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNlLnB5CkBAIC0x MDc4LDkgKzEwNzgsMTIgQEAgY2xhc3MgUG9ydChvYmplY3QpOgogICAgIGRlZiBfdmlydHVhbF90 ZXN0cyhzZWxmLCBwYXRocywgc3VpdGVzKToKICAgICAgICAgdmlydHVhbF90ZXN0cyA9IHNldCgp CiAgICAgICAgIGZvciBzdWl0ZSBpbiBzdWl0ZXM6Ci0gICAgICAgICAgICBmb3IgdGVzdCBpbiBz dWl0ZS50ZXN0czoKLSAgICAgICAgICAgICAgICBpZiBhbnkodGVzdC5zdGFydHN3aXRoKHApIGZv ciBwIGluIHBhdGhzKToKLSAgICAgICAgICAgICAgICAgICAgdmlydHVhbF90ZXN0cy5hZGQodGVz dCkKKyAgICAgICAgICAgIGlmIHBhdGhzOgorICAgICAgICAgICAgICAgIGZvciB0ZXN0IGluIHN1 aXRlLnRlc3RzOgorICAgICAgICAgICAgICAgICAgICBpZiBhbnkodGVzdC5zdGFydHN3aXRoKHAp IGZvciBwIGluIHBhdGhzKToKKyAgICAgICAgICAgICAgICAgICAgICAgIHZpcnR1YWxfdGVzdHMu YWRkKHRlc3QpCisgICAgICAgICAgICBlbHNlOgorICAgICAgICAgICAgICAgIHZpcnR1YWxfdGVz dHMudXBkYXRlKHNldChzdWl0ZS50ZXN0cy5rZXlzKCkpKQogICAgICAgICByZXR1cm4gdmlydHVh bF90ZXN0cwogCiAgICAgZGVmIGxvb2t1cF92aXJ0dWFsX3Rlc3RfYmFzZShzZWxmLCB0ZXN0X25h bWUpOgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9y dC9iYXNlX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv cG9ydC9iYXNlX3VuaXR0ZXN0LnB5CmluZGV4IDJmZDFmYTEzMzEzZTI1MDg3YWMyNTEyN2M1ZGFj ODVjMGIwYzVkOTMuLmZkZTA1ZmRhMDBhMGE1MTJkNGRmOGY0MTkxZjQxZWViZTYxNDg1MWIgMTAw NjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZV91 bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L2Jhc2VfdW5pdHRlc3QucHkKQEAgLTQzOCw2ICs0MzgsMjAgQEAgY2xhc3MgUG9ydFRlc3QodW5p dHRlc3QuVGVzdENhc2UpOgogICAgICAgICBzZWxmLmFzc2VydEZhbHNlKHBvcnQudGVzdF9pc2Rp cigndmlydHVhbC9kb2VzX25vdF9leGlzdC8nKSkKICAgICAgICAgc2VsZi5hc3NlcnRGYWxzZShw b3J0LnRlc3RfaXNkaXIoJ3ZpcnR1YWwvcGFzc2VzL3RleHQuaHRtbCcpKQogCisgICAgZGVmIHRl c3RfdGVzdHMoc2VsZik6CisgICAgICAgIHBvcnQgPSBzZWxmLm1ha2VfcG9ydCh3aXRoX3Rlc3Rz PVRydWUpCisgICAgICAgIHRlc3RzID0gcG9ydC50ZXN0cyhbXSkKKyAgICAgICAgc2VsZi5hc3Nl cnRUcnVlKCdwYXNzZXMvdGV4dC5odG1sJyBpbiB0ZXN0cykKKyAgICAgICAgc2VsZi5hc3NlcnRU cnVlKCd2aXJ0dWFsL3Bhc3Nlcy90ZXh0Lmh0bWwnIGluIHRlc3RzKQorCisgICAgICAgIHRlc3Rz ID0gcG9ydC50ZXN0cyhbJ3Bhc3NlcyddKQorICAgICAgICBzZWxmLmFzc2VydFRydWUoJ3Bhc3Nl cy90ZXh0Lmh0bWwnIGluIHRlc3RzKQorICAgICAgICBzZWxmLmFzc2VydEZhbHNlKCd2aXJ0dWFs L3Bhc3Nlcy90ZXh0Lmh0bWwnIGluIHRlc3RzKQorCisgICAgICAgIHRlc3RzID0gcG9ydC50ZXN0 cyhbJ3ZpcnR1YWwvcGFzc2VzJ10pCisgICAgICAgIHNlbGYuYXNzZXJ0RmFsc2UoJ3Bhc3Nlcy90 ZXh0Lmh0bWwnIGluIHRlc3RzKQorICAgICAgICBzZWxmLmFzc2VydFRydWUoJ3ZpcnR1YWwvcGFz c2VzL3RleHQuaHRtbCcgaW4gdGVzdHMpCisKIAogaWYgX19uYW1lX18gPT0gJ19fbWFpbl9fJzoK ICAgICB1bml0dGVzdC5tYWluKCkKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3BvcnQvdGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3BvcnQvdGVzdC5weQppbmRleCA1OGEwOGU1YTFiMmI2MTE1ZjQwMzQxZDkyMDcwNzc4 NjBlNzBmNDU1Li5lMTEzMmNiYWE1YjM5Y2U1NWEwNjE1YzY5MDBkN2E0NjYwOGQ5NWIzIDEwMDY0 NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3Rlc3QucHkK KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC90ZXN0LnB5CkBA IC00OTUsNyArNDk1LDYgQEAgY2xhc3MgVGVzdFBvcnQoUG9ydCk6CiAgICAgZGVmIHZpcnR1YWxf dGVzdF9zdWl0ZXMoc2VsZik6CiAgICAgICAgIHJldHVybiBbCiAgICAgICAgICAgICBWaXJ0dWFs VGVzdFN1aXRlKCd2aXJ0dWFsL3Bhc3NlcycsICdwYXNzZXMnLCBbJy0tdmlydHVhbC1hcmcnXSks Ci0gICAgICAgICAgICBWaXJ0dWFsVGVzdFN1aXRlKCd2aXJ0dWFsL2ZhaWx1cmVzJywgJ2ZhaWx1 cmVzL2V4cGVjdGVkJywgWyctLXZpcnR1YWwtYXJnJ10pLAogICAgICAgICBdCiAKIGNsYXNzIFRl c3REcml2ZXIoRHJpdmVyKToK