80082 2012-03-01 19:19:00 -0800 DOM tests take too long to run 2012-03-02 14:39:57 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa abarth arv morrita ojan oldest_to_newest 569168 0 rniwa 2012-03-01 19:19:00 -0800 It seems like we can lower benchmark.timeToRun from 500 to 100 and still get a pretty decent number. 569173 1 rniwa 2012-03-01 19:22:23 -0800 e.g. we spend 121s in DOM/CreateNodes now: Running DOM/CreateNodes.html (5 of 44) RESULT DOM: CreateNodes= 377.584043095 ms median= 377.545919724 ms, stdev= 1.48541786367 ms, min= 373.933014354 ms, max= 381.514733804 ms Finished: 121.340621 s By reducing the value, we only spend 30s: Running DOM/CreateNodes.html (3 of 10) RESULT DOM: CreateNodes= 376.635416667 ms median= 376.0625 ms, stdev= 2.55494737253 ms, min= 373.0 ms, max= 381.458333333 ms Finished: 29.826671 s 569177 2 129793 rniwa 2012-03-01 19:25:20 -0800 Created attachment 129793 Reduce benchmark.timeToRun from 500ms to 100ms 569191 3 129793 arv 2012-03-01 19:54:07 -0800 Comment on attachment 129793 Reduce benchmark.timeToRun from 500ms to 100ms View in context: https://bugs.webkit.org/attachment.cgi?id=129793&action=review I'm not yet a reviewer but this looks good to me. > PerformanceTests/DOM/resources/dom-perf.js:271 > + } this indentation still looks wrong. 569327 4 129793 rniwa 2012-03-01 23:40:47 -0800 Comment on attachment 129793 Reduce benchmark.timeToRun from 500ms to 100ms View in context: https://bugs.webkit.org/attachment.cgi?id=129793&action=review >> PerformanceTests/DOM/resources/dom-perf.js:271 >> + } > > this indentation still looks wrong. Oops, yeah this isn't right :( 569940 5 129793 eric 2012-03-02 14:21:00 -0800 Comment on attachment 129793 Reduce benchmark.timeToRun from 500ms to 100ms LGTM. You should consider adidng a comment next to the value about how/why 100ms was chosen. If someone had comemnted next to teh 500ms this review would have been even easier. :) 569945 6 rniwa 2012-03-02 14:26:02 -0800 Thanks for the review. (In reply to comment #5) > (From update of attachment 129793 [details]) > LGTM. You should consider adidng a comment next to the value about how/why 100ms was chosen. If someone had comemnted next to teh 500ms this review would have been even easier. :) Done. 569952 7 rniwa 2012-03-02 14:39:57 -0800 Landed in r109615. 129793 2012-03-01 19:25:20 -0800 2012-03-02 14:21:00 -0800 Reduce benchmark.timeToRun from 500ms to 100ms bug-80082-20120301192519.patch text/plain 1926 rniwa SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMDk0ODgpCisrKyBQZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAzLTAxICBS eW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIERPTSB0ZXN0cyB0YWtl IHRvbyBsb25nIHRvIHJ1bgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODAwODIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBSZWR1Y2UgYmVuY2htYXJrLnRpbWVUb1J1biBmcm9tIDUwMG1zIHRvIDEwMG1zLiBE b2Vzbid0IHNlZW0gdG8gYWZmZWN0IHRlc3QgcmVzdWx0cyBtdWNoCisgICAgICAgIChleGNlcHQg RE9NL0RPTVRhYmxlLmh0bWwpIGJ1dCBzaWduaWZpY2FudGx5IHJlZHVjZXMgdGhlIHJ1bnRpbWUg b2YgdGVzdHMuCisKKyAgICAgICAgKiBET00vcmVzb3VyY2VzL2RvbS1wZXJmLmpzOgorICAgICAg ICAoQmVuY2htYXJrU3VpdGUucHJvdG90eXBlLlJ1blNpbmdsZSk6CisKIDIwMTItMDItMjYgIEtl bnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtQZXJmb3JtYW5j ZSBUZXN0c10gW0Nocm9taXVtXSBCaW5kaW5ncy9kb20tYXR0cmlidXRlcy5odG1sIGlzIHRpbWlu ZyBvdXQKSW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvRE9NL3Jlc291cmNlcy9kb20tcGVyZi5qcwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBQZXJmb3JtYW5jZVRlc3RzL0RPTS9yZXNvdXJjZXMvZG9tLXBlcmYuanMJ KHJldmlzaW9uIDEwOTM4NikKKysrIFBlcmZvcm1hbmNlVGVzdHMvRE9NL3Jlc291cmNlcy9kb20t cGVyZi5qcwkod29ya2luZyBjb3B5KQpAQCAtMTMzLDcgKzEzMyw3IEBAIE1hdGgucmFuZG9tID0g KGZ1bmN0aW9uKCkgewogCiBmdW5jdGlvbiBCZW5jaG1hcmsobmFtZSwgcnVuLCBvcHRfc2V0dXAs IG9wdF9jbGVhbnVwLCBvcHRfc2hhcmVTZXR1cCkgewogICAgIHRoaXMubmFtZSA9IG5hbWU7Ci0g ICAgdGhpcy50aW1lVG9SdW4gPSA1MDA7IC8vIG1zCisgICAgdGhpcy50aW1lVG9SdW4gPSAxMDA7 IC8vIG1zCiAgICAgdGhpcy5ydW4gPSBydW47CiAgICAgdGhpcy5zZXR1cCA9IG9wdF9zZXR1cDsK ICAgICB0aGlzLmNsZWFudXAgPSBvcHRfY2xlYW51cDsKQEAgLTIzNyw2ICsyMzcsNyBAQCBCZW5j aG1hcmtTdWl0ZS5wcm90b3R5cGUuUnVuU2luZ2xlID0gZnVuCiAgICAgdmFyIG5aZXJvcyA9IDA7 CiAgICAgdmFyIGVycm9yID0gbnVsbDsKICAgICB2YXIgcHJvZmlsZXIgPSBHZXRQcm9maWxlcigp OworCiAgICAgZm9yICh2YXIgbiA9IDA7ICFlcnJvciAmJiB0b3RhbFRpbWUgPCBiZW5jaG1hcmsu dGltZVRvUnVuOyAgbisrKSB7CiAgICAgICAgIGlmICh0aGlzLmJlbmNobWFya0NvbnRlbnQpCiAg ICAgICAgICAgICB0aGlzLmJlbmNobWFya0NvbnRlbnRIb2xkZXIucmVtb3ZlQ2hpbGQodGhpcy5i ZW5jaG1hcmtDb250ZW50KTsKQEAgLTI2Nyw3ICsyNjgsNyBAQCBCZW5jaG1hcmtTdWl0ZS5wcm90 b3R5cGUuUnVuU2luZ2xlID0gZnVuCiAgICAgICAgICAgICBlcnJvciA9IGU7CiAgICAgICAgIH0K ICAgICAgICAgdG90YWxUaW1lID0gbmV3IERhdGUoKSAtIHN0YXJ0OwotICAgIH0KKyAgfQogCiAg ICAgdmFyIHJlc3VsdCA9IG5ldyBCZW5jaG1hcmtSZXN1bHQoYmVuY2htYXJrLCB0aW1lcywgZXJy b3IsIG51bGwpOwogICAgIGlmICh0aGlzLmJlbmNobWFya0NvbnRlbnQpIHsK