80080 2012-03-01 18:48:11 -0800 WebKit compiled by gcc (Xcode 3.2.6) hangs while running DOM/Accessors.html 2012-03-09 15:25:27 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa andersca fpizlo oliver oldest_to_newest 569157 0 rniwa 2012-03-01 18:48:11 -0800 I attempted a fix in http://trac.webkit.org/changeset/109478 but it had to be reverted due to a build failure: http://trac.webkit.org/changeset/109481 Not sure what the right fix is here. 569160 1 fpizlo 2012-03-01 18:50:18 -0800 (In reply to comment #0) > I attempted a fix in http://trac.webkit.org/changeset/109478 but it had to be reverted due to a build failure: http://trac.webkit.org/changeset/109481 > > Not sure what the right fix is here. The build failure is due to the fact that on 32-bit, uintptr_t and unsigned might be the same type. Well, they're always compatible in type in the sense that unsigned and uintptr_t will both be 32-bit but there's an open question as to whether uintptr_t is "unsigned int" or "unsigned long". The most robust solution is to rename the two weakCompareAndSwaps to: weakCompareAndSwapUnsigned(...) and: weakCompareAndSwapPointer(...) Then there won't be problems. 575294 2 131123 rniwa 2012-03-09 15:19:51 -0800 Created attachment 131123 My desparate attempt to fix JSC 575295 3 131123 fpizlo 2012-03-09 15:21:13 -0800 Comment on attachment 131123 My desparate attempt to fix JSC I like this approach - this side-steps all manner of C++ overload strangeness due to the plethora of ways that uintptr_t can be typedef'd. R=me. 575297 4 rniwa 2012-03-09 15:25:27 -0800 Committed r110342: <http://trac.webkit.org/changeset/110342> 131123 2012-03-09 15:19:51 -0800 2012-03-09 15:21:13 -0800 My desparate attempt to fix JSC bug-80080-20120309151950.patch text/plain 3632 rniwa SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTEwMzM5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDEyLTAzLTA5ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAg IFdlYktpdCBjb21waWxlZCBieSBnY2MgKFhjb2RlIDMuMi42KSBoYW5ncyB3aGlsZSBydW5uaW5n IERPTS9BY2Nlc3NvcnMuaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODAwODAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIGJ5dGVjb2RlL1NhbXBsaW5nVG9vbC5jcHA6CisgICAgICAgIChKU0M6OlNh bXBsaW5nUmVnaW9uOjpMb2NrZXI6OkxvY2tlcik6CisgICAgICAgIChKU0M6OlNhbXBsaW5nUmVn aW9uOjpMb2NrZXI6On5Mb2NrZXIpOgorICAgICAgICAqIGJ5dGVjb2RlL1NhbXBsaW5nVG9vbC5o OgorICAgICAgICAoSlNDOjpTYW1wbGluZ1JlZ2lvbjo6ZXhjaGFuZ2VDdXJyZW50KToKKyAgICAg ICAgKiB3dGYvQXRvbWljcy5oOgorICAgICAgICAoV1RGKToKKyAgICAgICAgKFdURjo6d2Vha0Nv bXBhcmVBbmRTd2FwKToKKyAgICAgICAgKFdURjo6d2Vha0NvbXBhcmVBbmRTd2FwVUludFB0cik6 CisKIDIwMTItMDMtMDkgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29t PgogCiAgICAgICAgIFJFR1JFU1NJT046IERhdGUucGFyc2UoIlR1ZSBOb3YgMjMgMjA6NDA6MDUg MjAxMCBHTVQiKSByZXR1cm5zIE5hTgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVj b2RlL1NhbXBsaW5nVG9vbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L2J5dGVjb2RlL1NhbXBsaW5nVG9vbC5jcHAJKHJldmlzaW9uIDExMDMxOSkKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9ieXRlY29kZS9TYW1wbGluZ1Rvb2wuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0xMDAsNyArMTAwLDcgQEAgU2FtcGxpbmdSZWdpb246OkxvY2tlcjo6TG9ja2VyKCkKICNlbmRp ZgogICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgIH0KLSAgICAgICAgaWYgKFdURjo6d2Vh a0NvbXBhcmVBbmRTd2FwKCZzX2N1cnJlbnRPclJlc2VydmVkLCBwcmV2aW91cywgcHJldmlvdXMg fCAxKSkKKyAgICAgICAgaWYgKFdURjo6d2Vha0NvbXBhcmVBbmRTd2FwVUludFB0cigmc19jdXJy ZW50T3JSZXNlcnZlZCwgcHJldmlvdXMsIHByZXZpb3VzIHwgMSkpCiAgICAgICAgICAgICBicmVh azsKICAgICB9CiB9CkBAIC0xMTMsNyArMTEzLDcgQEAgU2FtcGxpbmdSZWdpb246OkxvY2tlcjo6 fkxvY2tlcigpCiAgICAgdWludHB0cl90IHByZXZpb3VzOwogICAgIGRvIHsKICAgICAgICAgcHJl dmlvdXMgPSBzX2N1cnJlbnRPclJlc2VydmVkOwotICAgIH0gd2hpbGUgKCFXVEY6OndlYWtDb21w YXJlQW5kU3dhcCgmc19jdXJyZW50T3JSZXNlcnZlZCwgcHJldmlvdXMsIHByZXZpb3VzICYgfjEp KTsKKyAgICB9IHdoaWxlICghV1RGOjp3ZWFrQ29tcGFyZUFuZFN3YXBVSW50UHRyKCZzX2N1cnJl bnRPclJlc2VydmVkLCBwcmV2aW91cywgcHJldmlvdXMgJiB+MSkpOwogfQogCiB2b2lkIFNhbXBs aW5nUmVnaW9uOjpzYW1wbGUoKQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2Rl L1NhbXBsaW5nVG9vbC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRl Y29kZS9TYW1wbGluZ1Rvb2wuaAkocmV2aXNpb24gMTEwMzE5KQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2J5dGVjb2RlL1NhbXBsaW5nVG9vbC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNDgsNyAr MTQ4LDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgICAgICAgICAgaWYgKHByZXZpb3VzUHRy KQogICAgICAgICAgICAgICAgICAgICAqcHJldmlvdXNQdHIgPSBiaXR3aXNlX2Nhc3Q8U2FtcGxp bmdSZWdpb24qPihwcmV2aW91cyk7CiAgICAgICAgICAgICAgICAgCi0gICAgICAgICAgICAgICAg aWYgKFdURjo6d2Vha0NvbXBhcmVBbmRTd2FwKCZzX2N1cnJlbnRPclJlc2VydmVkLCBwcmV2aW91 cywgYml0d2lzZV9jYXN0PHVpbnRwdHJfdD4oY3VycmVudCkpKQorICAgICAgICAgICAgICAgIGlm IChXVEY6OndlYWtDb21wYXJlQW5kU3dhcFVJbnRQdHIoJnNfY3VycmVudE9yUmVzZXJ2ZWQsIHBy ZXZpb3VzLCBiaXR3aXNlX2Nhc3Q8dWludHB0cl90PihjdXJyZW50KSkpCiAgICAgICAgICAgICAg ICAgICAgIGJyZWFrOwogICAgICAgICAgICAgfQogICAgICAgICB9CkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvd3RmL0F0b21pY3MuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvd3RmL0F0b21pY3MuaAkocmV2aXNpb24gMTEwMzE5KQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL3d0Zi9BdG9taWNzLmgJKHdvcmtpbmcgY29weSkKQEAgLTExOCw3ICsxMTgsMTEgQEAg aW5saW5lIGludCBhdG9taWNEZWNyZW1lbnQoaW50IHZvbGF0aWxlKgogCiAjZW5kaWYKIAorI2lm IENPTVBJTEVSKEdDQykgJiYgIUNPTVBJTEVSKENMQU5HKSAvLyBXb3JrIGFyb3VuZCBhIGdjYyBi dWcgCitpbmxpbmUgYm9vbCB3ZWFrQ29tcGFyZUFuZFN3YXAodm9sYXRpbGUgdW5zaWduZWQqIGxv Y2F0aW9uLCB1bnNpZ25lZCBleHBlY3RlZCwgdW5zaWduZWQgbmV3VmFsdWUpIAorI2Vsc2UKIGlu bGluZSBib29sIHdlYWtDb21wYXJlQW5kU3dhcCh1bnNpZ25lZCogbG9jYXRpb24sIHVuc2lnbmVk IGV4cGVjdGVkLCB1bnNpZ25lZCBuZXdWYWx1ZSkKKyNlbmRpZgogewogI2lmIEVOQUJMRShDT01Q QVJFX0FORF9TV0FQKQogICAgIGJvb2wgcmVzdWx0OwpAQCAtMTgxLDcgKzE4NSw3IEBAIGlubGlu ZSBib29sIHdlYWtDb21wYXJlQW5kU3dhcCh2b2lkKnZvbGEKICNlbmRpZiAvLyBFTkFCTEUoQ09N UEFSRV9BTkRfU1dBUCkKIH0KIAotaW5saW5lIGJvb2wgd2Vha0NvbXBhcmVBbmRTd2FwKHZvbGF0 aWxlIHVpbnRwdHJfdCogbG9jYXRpb24sIHVpbnRwdHJfdCBleHBlY3RlZCwgdWludHB0cl90IG5l d1ZhbHVlKQoraW5saW5lIGJvb2wgd2Vha0NvbXBhcmVBbmRTd2FwVUludFB0cih2b2xhdGlsZSB1 aW50cHRyX3QqIGxvY2F0aW9uLCB1aW50cHRyX3QgZXhwZWN0ZWQsIHVpbnRwdHJfdCBuZXdWYWx1 ZSkKIHsKICAgICByZXR1cm4gd2Vha0NvbXBhcmVBbmRTd2FwKHJlaW50ZXJwcmV0X2Nhc3Q8dm9p ZCp2b2xhdGlsZSo+KGxvY2F0aW9uKSwgcmVpbnRlcnByZXRfY2FzdDx2b2lkKj4oZXhwZWN0ZWQp LCByZWludGVycHJldF9jYXN0PHZvaWQqPihuZXdWYWx1ZSkpOwogfQo=