80034 2012-03-01 10:07:09 -0800 REGRESSION (r108956): Safari Webpage Preview Fetcher crashes in WebCore::localizedString() when using a WebKit nightly build 2012-03-01 20:55:08 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Regression P1 Normal --- 1 mitz mitz webkit.review.bot oldest_to_newest 568749 0 mitz 2012-03-01 10:07:09 -0800 REGRESSION (r108956): Safari Webpage Preview Fetcher crashes in WebCore::localizedString() when using a WebKit nightly build 568752 1 mitz 2012-03-01 10:08:06 -0800 <rdar://problem/10942540> 568754 2 129721 mitz 2012-03-01 10:12:38 -0800 Created attachment 129721 Null-check the return value of CFBundleGetBundleWithIdentifier() 568784 3 webkit.review.bot 2012-03-01 11:27:47 -0800 Attachment 129721 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'LayoutTests/ChangeLog', u'La..." exit_code: 1 Traceback (most recent call last): File "Tools/Scripts/check-webkit-style", line 48, in <module> sys.exit(CheckWebKitStyle().main()) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/main.py", line 154, in main patch_checker.check(patch) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/patchreader.py", line 66, in check self._text_file_reader.process_file(file_path=path, line_numbers=line_numbers) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/filereader.py", line 130, in process_file self._processor.process(lines, file_path, **kwargs) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checker.py", line 838, in process checker.check(lines) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checkers/test_expectations.py", line 103, in check overrides = self._port_obj.test_expectations_overrides() AttributeError: 'NoneType' object has no attribute 'test_expectations_overrides' If any of these errors are false positives, please file a bug against check-webkit-style. 568790 4 129721 benjamin 2012-03-01 11:44:48 -0800 Comment on attachment 129721 Null-check the return value of CFBundleGetBundleWithIdentifier() View in context: https://bugs.webkit.org/attachment.cgi?id=129721&action=review > Source/WebCore/platform/mac/LocalizedStringsMac.cpp:55 > + else > + result = notFound; > > ASSERT_WITH_MESSAGE(result.get() != notFound, "could not find localizable string %s in bundle", key); You are gonna hit the assert every time. Better move the assert in the if() 569214 5 mitz 2012-03-01 20:55:08 -0800 Fixed in <http://trac.webkit.org/r109497>. 129721 2012-03-01 10:12:38 -0800 2012-03-01 11:44:48 -0800 Null-check the return value of CFBundleGetBundleWithIdentifier() bug-80034-20120301101248.patch text/plain 1920 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwOTM2MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAzLTAxICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjEwODk1Nik6 IFNhZmFyaSBXZWJwYWdlIFByZXZpZXcgRmV0Y2hlciBjcmFzaGVzIGluIFdlYkNvcmU6OmxvY2Fs aXplZFN0cmluZygpIHdoZW4gdXNpbmcgYSBXZWJLaXQgbmlnaHRseSBidWlsZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODAwMzQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTYWZhcmkgV2VicGFnZSBQcmV2 aWV3IEZldGNoZXIgY2Fu4oCZdCBhY2Nlc3MgdGhlIFdlYkNvcmUgZnJhbWV3b3JrIHdoZW4gbGF1 bmNoZWQgZnJvbSBhIFdlYktpdAorICAgICAgICBuaWdodGx5IGJ1aWxkLiBBZnRlciByMTA4OTU2 LCB0aGlzIGNhdXNlcyBpdCB0byBjcmFzaC4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9Mb2Nh bGl6ZWRTdHJpbmdzTWFjLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmxvY2FsaXplZFN0cmluZyk6 IEFkZGVkIGEgbnVsbC1jaGVjayBmb3IgdGhlIHZhbHVlIHJldHVybmVkIGZyb20KKyAgICAgICAg Q0ZCdW5kbGVHZXRCdW5kbGVXaXRoSWRlbnRpZmllcihDRlNUUigiY29tLmFwcGxlLldlYkNvcmUi KSkuCisKIDIwMTItMDMtMDEgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAK ICAgICAgICAgU29tZSB0cml2aWFsIGZpbGUgc3RyZWFtIGNsZWFudXAKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL21hYy9Mb2NhbGl6ZWRTdHJpbmdzTWFjLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvTG9jYWxpemVkU3RyaW5nc01hYy5jcHAJKHJl dmlzaW9uIDEwOTM1NykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9Mb2NhbGl6ZWRT dHJpbmdzTWFjLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDYsNyArNDYsMTEgQEAgU3RyaW5nIGxv Y2FsaXplZFN0cmluZyhjb25zdCBjaGFyKiBrZXkpCiAKICAgICBSZXRhaW5QdHI8Q0ZTdHJpbmdS ZWY+IGtleVN0cmluZyhBZG9wdENGLCBDRlN0cmluZ0NyZWF0ZVdpdGhDU3RyaW5nTm9Db3B5KDAs IGtleSwga0NGU3RyaW5nRW5jb2RpbmdVVEY4LCBrQ0ZBbGxvY2F0b3JOdWxsKSk7CiAgICAgQ0ZT dHJpbmdSZWYgbm90Rm91bmQgPSBDRlNUUigibG9jYWxpemVkIHN0cmluZyBub3QgZm91bmQiKTsK LSAgICBSZXRhaW5QdHI8Q0ZTdHJpbmdSZWY+IHJlc3VsdChBZG9wdENGLCBDRkJ1bmRsZUNvcHlM b2NhbGl6ZWRTdHJpbmcoYnVuZGxlLCBrZXlTdHJpbmcuZ2V0KCksIG5vdEZvdW5kLCAwKSk7Cisg ICAgUmV0YWluUHRyPENGU3RyaW5nUmVmPiByZXN1bHQ7CisgICAgaWYgKGJ1bmRsZSkKKyAgICAg ICAgcmVzdWx0LmFkb3B0Q0YoQ0ZCdW5kbGVDb3B5TG9jYWxpemVkU3RyaW5nKGJ1bmRsZSwga2V5 U3RyaW5nLmdldCgpLCBub3RGb3VuZCwgMCkpOworICAgIGVsc2UKKyAgICAgICAgcmVzdWx0ID0g bm90Rm91bmQ7CiAKICAgICBBU1NFUlRfV0lUSF9NRVNTQUdFKHJlc3VsdC5nZXQoKSAhPSBub3RG b3VuZCwgImNvdWxkIG5vdCBmaW5kIGxvY2FsaXphYmxlIHN0cmluZyAlcyBpbiBidW5kbGUiLCBr ZXkpOwogICAgIHJldHVybiBTdHJpbmcocmVzdWx0LmdldCgpKTsK