<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>80033</bug_id>
          
          <creation_ts>2012-03-01 09:37:24 -0800</creation_ts>
          <short_desc>WebKitTestRunner: Explicitly include unistd.h for gcc 4.7</short_desc>
          <delta_ts>2012-03-01 22:26:27 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Kalev Lember">kalevlember</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>568723</commentid>
    <comment_count>0</comment_count>
    <who name="Kalev Lember">kalevlember</who>
    <bug_when>2012-03-01 09:37:24 -0800</bug_when>
    <thetext>WebKitTestRunner/TestInvocation.cpp uses getcwd(), but only includes the unistd.h header for Mac. This worked fine in the past because gcc &lt; 4.7 included unistd.h from standard C++ library headers. However, this is no longer the case with gcc 4.7 and we need to explicitly include unistd.h.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>568725</commentid>
    <comment_count>1</comment_count>
      <attachid>129717</attachid>
    <who name="Kalev Lember">kalevlember</who>
    <bug_when>2012-03-01 09:40:54 -0800</bug_when>
    <thetext>Created attachment 129717
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>569269</commentid>
    <comment_count>2</comment_count>
      <attachid>129717</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-03-01 22:26:24 -0800</bug_when>
    <thetext>Comment on attachment 129717
Patch

Clearing flags on attachment: 129717

Committed r109509: &lt;http://trac.webkit.org/changeset/109509&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>569270</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-03-01 22:26:27 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>129717</attachid>
            <date>2012-03-01 09:40:54 -0800</date>
            <delta_ts>2012-03-01 22:26:24 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>0001-WebKitTestRunner-Explicitly-include-unistd.h-for-gcc.patch</filename>
            <type>text/plain</type>
            <size>1687</size>
            <attacher name="Kalev Lember">kalevlember</attacher>
            
              <data encoding="base64">RnJvbSAyNzkyMWIwMzQzZjdhZjM3ZmZlNTc1NGZiZjJhNWZmYjNmNmY1NTY5IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBLYWxldiBMZW1iZXIgPGthbGV2bGVtYmVyQGdtYWlsLmNvbT4K
RGF0ZTogVGh1LCAxIE1hciAyMDEyIDEyOjI1OjA1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gV2Vi
S2l0VGVzdFJ1bm5lcjogRXhwbGljaXRseSBpbmNsdWRlIHVuaXN0ZC5oIGZvciBnY2MgNC43Cgot
LS0KIFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxMyArKysr
KysrKysrKysrCiBUb29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RJbnZvY2F0aW9uLmNwcCB8ICAg
IDYgKystLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25z
KC0pCgpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4
IDVlZmZiN2UuLjVkNjNjMDQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29s
cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0wMy0wMSAgS2FsZXYgTGVtYmVyICA8
a2FsZXZsZW1iZXJAZ21haWwuY29tPgorCisgICAgICAgIFdlYktpdFRlc3RSdW5uZXI6IEV4cGxp
Y2l0bHkgaW5jbHVkZSB1bmlzdGQuaCBmb3IgZ2NjIDQuNworICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODAwMzMKKworICAgICAgICBSZXZpZXdlZCBieSBO
T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBHQ0MgNC43IG5vIGxvbmdlciBpbmNsdWRlcyB1bmlz
dGQuaCBmcm9tIG1vc3Qgb2YgdGhlIHN0YW5kYXJkIEMrKworICAgICAgICBoZWFkZXIgZmlsZXMs
IHNvIHdlIG5lZWQgdG8gZXhwbGljaXRseSBpbmNsdWRlIGl0IGZvciBnZXRjd2QoKS4KKworICAg
ICAgICAqIFdlYktpdFRlc3RSdW5uZXIvVGVzdEludm9jYXRpb24uY3BwOiBNYWtlIHN1cmUgdW5p
c3RkLmggZ2V0cyBpbmNsdWRlZAorICAgICAgICBub3Qgb25seSBvbiBNYWMsIGJ1dCBvbiBhbGwg
VW5peCBwbGF0Zm9ybXMuCisKIDIwMTItMDItMjkgIEthbGV2IExlbWJlciAgPGthbGV2bGVtYmVy
QGdtYWlsLmNvbT4KIAogICAgICAgICBbR1RLXSBBdm9pZCBidWlsZGluZyBhbnkgcGFydHMgb2Yg
V2ViS2l0VGVzdFJ1bm5lciB3aGVuIFdLMiBpcyBkaXNhYmxlZApkaWZmIC0tZ2l0IGEvVG9vbHMv
V2ViS2l0VGVzdFJ1bm5lci9UZXN0SW52b2NhdGlvbi5jcHAgYi9Ub29scy9XZWJLaXRUZXN0UnVu
bmVyL1Rlc3RJbnZvY2F0aW9uLmNwcAppbmRleCA5YzY2M2M0Li44MDZlYWE1IDEwMDY0NAotLS0g
YS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RJbnZvY2F0aW9uLmNwcAorKysgYi9Ub29scy9X
ZWJLaXRUZXN0UnVubmVyL1Rlc3RJbnZvY2F0aW9uLmNwcApAQCAtNDIsMTAgKzQyLDggQEAKICNp
bmNsdWRlIDxkaXJlY3QuaD4gLy8gRm9yIF9nZXRjd2QuCiAjZGVmaW5lIGdldGN3ZCBfZ2V0Y3dk
IC8vIE1TRE4gc2F5cyBnZXRjd2QgaXMgZGVwcmVjYXRlZC4KICNkZWZpbmUgUEFUSF9NQVggX01B
WF9QQVRICi0jZW5kaWYKLQotI2lmIFBMQVRGT1JNKE1BQykKLSNpbmNsdWRlIDx1bmlzdGQuaD4K
KyNlbHNlCisjaW5jbHVkZSA8dW5pc3RkLmg+IC8vIEZvciBnZXRjd2QuCiAjZW5kaWYKIAogdXNp
bmcgbmFtZXNwYWNlIFdlYktpdDsKLS0gCjEuNy45LjEKCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>