80029 2012-03-01 08:03:49 -0800 [Qt][WK2] Make the interaction with the Flickable work on the N9 2012-03-01 13:52:04 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 79119 1 abecsi abecsi hausmann vestbo webkit.review.bot oldest_to_newest 568668 0 abecsi 2012-03-01 08:03:49 -0800 Since the WebView accepts all the received touch events, the event to control the Flickable does not get translated to a mouse event on the N9. Do the touch->mouse conversion in QtFlickProvider instead of relying on Qt to translate the unhandled touch events. 568670 1 129706 abecsi 2012-03-01 08:07:38 -0800 Created attachment 129706 proposed patch 568673 2 129706 hausmann 2012-03-01 08:16:18 -0800 Comment on attachment 129706 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=129706&action=review > Source/WebKit2/UIProcess/qt/QtFlickProvider.cpp:156 > + QCoreApplication::sendEvent(m_flickable->canvas(), &mouseEvent); This is a bit unfortunately, it sounds like we need a function in QQuickCanvas to send an event to a specific item, in order to ensure delivery. Couldn't theoretically the event end up in a different item if it happens to be "on top"? (of course we shouldn't have received the touch event in the first place then...) Anyway, this is an improvement and clearly makes the code more robust (less relying on magic event conversion elsewhere). 568686 3 abecsi 2012-03-01 08:38:34 -0800 (In reply to comment #2) Thanks for the review, Simon. > (From update of attachment 129706 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=129706&action=review > > > Source/WebKit2/UIProcess/qt/QtFlickProvider.cpp:156 > > + QCoreApplication::sendEvent(m_flickable->canvas(), &mouseEvent); > > This is a bit unfortunately, it sounds like we need a function in QQuickCanvas to send an event to a specific item, in order to ensure delivery. Couldn't theoretically the event end up in a different item if it happens to be "on top"? (of course we shouldn't have received the touch event in the first place then...) > We could theoretically send the event directly to the Flickable with QQuickCanvas::sendEvent, but since this code path goes to Flickable::handleMouseFooEvent the item does not grab the mouse and this results in strange behavior for gestures which move out of the viewport, which is of course only an issue on desktop. I hope we can leave behind these issues with the touch related changes in Qt5 suggested by Shawn. 568764 4 129706 webkit.review.bot 2012-03-01 10:26:04 -0800 Comment on attachment 129706 proposed patch Rejecting attachment 129706 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/11776526 568882 5 129706 abecsi 2012-03-01 13:51:53 -0800 Comment on attachment 129706 proposed patch Clearing flags on attachment: 129706 Committed r109415: <http://trac.webkit.org/changeset/109415> 568884 6 abecsi 2012-03-01 13:52:04 -0800 All reviewed patches have been landed. Closing bug. 129706 2012-03-01 08:07:38 -0800 2012-03-01 13:51:53 -0800 proposed patch 0001-Qt-WK2-Make-the-interaction-with-the-Flickable-work-.patch text/plain 4852 abecsi RnJvbSBlMzA3ZTEyMDZlZWE3N2FiMDAyYmM0NzBmODExODA4ODQ5NTYwZjkwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmRyYXMgQmVjc2kgPGFuZHJhcy5iZWNzaUBub2tpYS5jb20+ CkRhdGU6IFRodSwgMSBNYXIgMjAxMiAxNjoyMzowMCArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIFtR dF1bV0syXSBNYWtlIHRoZSBpbnRlcmFjdGlvbiB3aXRoIHRoZSBGbGlja2FibGUgd29yayBvbgog dGhlIE45CgotLS0KIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAg ICAgICAgIHwgICAyMSArKysrKysrKysrKwogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0 RmxpY2tQcm92aWRlci5jcHAgICAgfCAgIDM5ICsrKysrKysrKysrKysrKysrKystCiAuLi4vVUlQ cm9jZXNzL3F0L1F0UGFuR2VzdHVyZVJlY29nbml6ZXIuY3BwICAgICAgICB8ICAgIDEgKwogMyBm aWxlcyBjaGFuZ2VkLCA1OSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpp bmRleCBkMmI1MjYxLi45YjdhYTA1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTIt MDMtMDEgIEFuZHJhcyBCZWNzaSAgPGFuZHJhcy5iZWNzaUBub2tpYS5jb20+CisKKyAgICAgICAg W1F0XVtXSzJdIE1ha2UgdGhlIGludGVyYWN0aW9uIHdpdGggdGhlIEZsaWNrYWJsZSB3b3JrIG9u IHRoZSBOOQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 ODAwMjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBC ZWNhdXNlIHRoZSBXZWJWaWV3IGl0ZW0gYWNjZXB0cyBhbGwgdG91Y2ggZXZlbnRzIGl0IHJlY2Vp dmVzIGFuZCBzZW5kcworICAgICAgICB0aGVtIHRvIHRoZSB3ZWIgcHJvY2VzcyBiZWZvcmUgcHJv cGFnYXRpbmcgdGhlbSB0byB0aGUgZ2VzdHVyZSByZWNvZ25pemVycywKKyAgICAgICAgd2hpY2gg aXMgY29ycmVjdCBiZWhhdmlvdXIsIHdlIGNhbiBub3QgcmVseSBvbiB0aGUgdG91Y2gtPm1vdXNl IGNvbnZlcnNpb24KKyAgICAgICAgb2YgUXQ1IHdoZW4gY29udHJvbGxpbmcgRmxpY2thYmxlLiBI ZW5jZSB3ZSBuZWVkIHRvIGNvbnZlcnQgdGhlIHJlY2VpdmVkCisgICAgICAgIHRvdWNoIGV2ZW50 cyB0byBtb3VzZSBldmVudHMgaW4gdGhlIFF0RmxpY2tQcm92aWRlci4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9xdC9RdEZsaWNrUHJvdmlkZXIuY3BwOgorICAgICAgICAoUXRGbGlja1Byb3ZpZGVy OjpoYW5kbGVUb3VjaEZsaWNrRXZlbnQpOgorICAgICAgICBEbyB0aGUgdG91Y2ggdG8gbW91c2Ug ZXZlbnQgY29udmVyc2lvbiBmb3IgdGhlIEZsaWNrYWJsZS4KKyAgICAgICAgKiBVSVByb2Nlc3Mv cXQvUXRQYW5HZXN0dXJlUmVjb2duaXplci5jcHA6CisgICAgICAgIChXZWJLaXQ6OlF0UGFuR2Vz dHVyZVJlY29nbml6ZXI6OnJlY29nbml6ZSk6CisgICAgICAgIEEgdG91Y2ggYmVnaW4gZXZlbnQg c2hvdWxkIGNhbmNlbCB0aGUgcHJldmlvdXMgcGFuIGdlc3R1cmUKKyAgICAgICAgYW5kIHN0b3Ag dGhlIG9uZ29pbmcgZmxpY2sgYW5pbWF0aW9uLgorCiAyMDEyLTAyLTI5ICBDYXJsb3MgR2FyY2lh IENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBVc2UgdGV4dCBv ciBwYWdlIHpvb20gZmFjdG9yIGluIFdlYktpdFdlYlZpZXcgZGVwZW5kaW5nIG9uIHpvb20tdGV4 dC1vbmx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRGbGlja1By b3ZpZGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdEZsaWNrUHJvdmlkZXIu Y3BwCmluZGV4IGMxYWZhNGEuLmIzNGJiYTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9xdC9RdEZsaWNrUHJvdmlkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9xdC9RdEZsaWNrUHJvdmlkZXIuY3BwCkBAIC0yNiw3ICsyNiw5IEBACiAKICNpbmNsdWRl IDxRQ29yZUFwcGxpY2F0aW9uPgogI2luY2x1ZGUgPFFEZWNsYXJhdGl2ZUVuZ2luZT4KKyNpbmNs dWRlIDxRTW91c2VFdmVudD4KICNpbmNsdWRlIDxRUG9pbnRGPgorI2luY2x1ZGUgPFFRdWlja0Nh bnZhcz4KICNpbmNsdWRlIDxRUXVpY2tJdGVtPgogI2luY2x1ZGUgPFFUb3VjaEV2ZW50PgogI2lu Y2x1ZGUgPHd0Zi9Bc3NlcnRpb25zLmg+CkBAIC0xMTYsOSArMTE4LDQyIEBAIFF0RmxpY2tQcm92 aWRlcjo6UXRGbGlja1Byb3ZpZGVyKFFRdWlja1dlYlZpZXcqIHZpZXdJdGVtLCBRUXVpY2tXZWJQ YWdlKiBwYWdlSXRlCiAgICAgY29ubmVjdChtX2ZsaWNrYWJsZSwgU0lHTkFMKGNvbnRlbnRZQ2hh bmdlZCgpKSwgU0lHTkFMKGNvbnRlbnRZQ2hhbmdlZCgpKSwgUXQ6OkRpcmVjdENvbm5lY3Rpb24p OwogfQogCi12b2lkIFF0RmxpY2tQcm92aWRlcjo6aGFuZGxlVG91Y2hGbGlja0V2ZW50KFFUb3Vj aEV2ZW50KiBldmVudCkKK3ZvaWQgUXRGbGlja1Byb3ZpZGVyOjpoYW5kbGVUb3VjaEZsaWNrRXZl bnQoUVRvdWNoRXZlbnQqIHRvdWNoRXZlbnQpCiB7Ci0gICAgUUNvcmVBcHBsaWNhdGlvbjo6c2Vu ZEV2ZW50KG1fZmxpY2thYmxlLCBldmVudCk7CisgICAgLy8gU2luY2UgdGhlIEZsaWNrYWJsZSBk b2VzIG5vdCBoYW5kbGUgdG91Y2ggZXZlbnRzIGRpcmVjdGx5IHRoZSBzZW50CisgICAgLy8gdG91 Y2ggZXZlbnQgd291bGQgZW5kIHVwIGluIHRoZSBXZWJWaWV3IGFnYWluIGFuZCB3b3VsZCB0aHVz IHRyaWdnZXIKKyAgICAvLyBhbiBpbmZpbml0ZSBsb29wLgorICAgIC8vIEhlbmNlIGRvIHRoZSB0 b3VjaCB0byBtb3VzZSBldmVudCBjb252ZXJzaW9uIGZvciB0aGUgRmxpY2thYmxlIGhlcmUuCisg ICAgUUV2ZW50OjpUeXBlIG1vdXNlRXZlbnRUeXBlID0gUUV2ZW50OjpOb25lOworICAgIFF0OjpN b3VzZUJ1dHRvbiBtb3VzZUJ1dHRvbiA9IFF0OjpOb0J1dHRvbjsKKworICAgIHN3aXRjaCAodG91 Y2hFdmVudC0+dHlwZSgpKSB7CisgICAgY2FzZSBRRXZlbnQ6OlRvdWNoQmVnaW46CisgICAgICAg IG1vdXNlRXZlbnRUeXBlID0gUUV2ZW50OjpNb3VzZUJ1dHRvblByZXNzOworCisgICAgICAgIC8v IFdlIG5lZWQgdG8gc2V0IHRoZSBtb3VzZSBidXR0b24gc28gdGhhdCB0aGUgRmxpY2thYmxlCisg ICAgICAgIC8vIGl0ZW0gcmVjZWl2ZXMgdGhlIGluaXRpYWwgbW91c2UgcHJlc3MgZXZlbnQuCisg ICAgICAgIG1vdXNlQnV0dG9uID0gUXQ6OkxlZnRCdXR0b247CisgICAgICAgIGJyZWFrOworICAg IGNhc2UgUUV2ZW50OjpUb3VjaFVwZGF0ZToKKyAgICAgICAgbW91c2VFdmVudFR5cGUgPSBRRXZl bnQ6Ok1vdXNlTW92ZTsKKyAgICAgICAgYnJlYWs7CisgICAgY2FzZSBRRXZlbnQ6OlRvdWNoRW5k OgorICAgICAgICBtb3VzZUV2ZW50VHlwZSA9IFFFdmVudDo6TW91c2VCdXR0b25SZWxlYXNlOwor ICAgICAgICBicmVhazsKKyAgICBkZWZhdWx0OgorICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQo KTsKKyAgICAgICAgYnJlYWs7CisgICAgfQorCisgICAgUVBvaW50RiB0b3VjaFBvc2l0aW9uID0g dG91Y2hFdmVudC0+dG91Y2hQb2ludHMoKS5sYXN0KCkucG9zKCk7CisgICAgUU1vdXNlRXZlbnQg bW91c2VFdmVudChtb3VzZUV2ZW50VHlwZSwgdG91Y2hQb3NpdGlvbiwgbW91c2VCdXR0b24sIG1v dXNlQnV0dG9uLCBRdDo6Tm9Nb2RpZmllcik7CisKKyAgICAvLyBTZW5kIHRoZSBldmVudCB0byB0 aGUgY2FudmFzIGFuZCBsZXQgdGhlIGNhbnZhcyBwcm9wYWdhdGUgaXQKKyAgICAvLyB0byB0aGUg RmxpY2thYmxlLiBUaGlzIG1ha2VzIHN1cmUgdGhhdCB0aGUgRmxpY2thYmxlIGdyYWJzCisgICAg Ly8gdGhlIG1vdXNlIHNvIHRoYXQgaXQgYWxzbyByZWNlaXZlcyB0aGUgZXZlbnRzIG9mIGdlc3R1 cmVzCisgICAgLy8gd2hpY2ggc3RhcnRlZCBpbnNpZGUgdGhlIHZpZXdwb3J0IGJ1dCBlbmRlZCBv dXRzaWRlIG9mIGl0LgorICAgIFFDb3JlQXBwbGljYXRpb246OnNlbmRFdmVudChtX2ZsaWNrYWJs ZS0+Y2FudmFzKCksICZtb3VzZUV2ZW50KTsKIH0KIAogUVF1aWNrSXRlbSogUXRGbGlja1Byb3Zp ZGVyOjpjb250ZW50SXRlbSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv cXQvUXRQYW5HZXN0dXJlUmVjb2duaXplci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv cXQvUXRQYW5HZXN0dXJlUmVjb2duaXplci5jcHAKaW5kZXggMTc4NzM5MS4uYmUxN2FhYyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0UGFuR2VzdHVyZVJlY29nbml6 ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFBhbkdlc3R1cmVSZWNv Z25pemVyLmNwcApAQCAtNjMsNiArNjMsNyBAQCBib29sIFF0UGFuR2VzdHVyZVJlY29nbml6ZXI6 OnJlY29nbml6ZShjb25zdCBRVG91Y2hFdmVudCogZXZlbnQpCiAgICAgICAgIG1fc3RhdGUgPSBH ZXN0dXJlUmVjb2duaXRpb25TdGFydGVkOwogICAgICAgICBtX2ZpcnN0UG9zaXRpb24gPSB0b3Vj aFBvaW50LnNjcmVlblBvcygpOwogICAgICAgICBtX3RvdWNoQmVnaW4ucmVzZXQobmV3IFFUb3Vj aEV2ZW50KCpldmVudCkpOworICAgICAgICBpbnRlcmFjdGlvbkVuZ2luZSgpLT5wYW5HZXN0dXJl Q2FuY2VsbGVkKCk7CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICBjYXNlIFFFdmVudDo6VG91 Y2hVcGRhdGU6IHsKICAgICAgICAgQVNTRVJUKG1fc3RhdGUgIT0gTm9HZXN0dXJlKTsKLS0gCjEu Ny45LjEKCg==