80026 2012-03-01 07:28:03 -0800 [EFL] Prefix run-launcher with run-with-jhbuild 2012-03-19 03:47:51 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 79673 79480 1 d-r d-r pnormand rakuco webkit.review.bot oldest_to_newest 568649 0 d-r 2012-03-01 07:28:03 -0800 In order for the launcher to use the jhbuild-provided EFL libaries, let's prefix it with run-with-jhbuild as well. 579406 1 132056 d-r 2012-03-15 08:25:48 -0700 Created attachment 132056 Run launcher under jhbuild, v1 580499 2 132282 d-r 2012-03-16 07:37:50 -0700 Created attachment 132282 Run launcher under jhbuild, v2 catfile not required, patch simplified. 581699 3 132282 pnormand 2012-03-19 02:27:00 -0700 Comment on attachment 132282 Run launcher under jhbuild, v2 View in context: https://bugs.webkit.org/attachment.cgi?id=132282&action=review > Tools/Scripts/run-launcher:77 > + my $jhbuildWrapper = catdir(sourceDir(), "Tools", "efl", "run-with-jhbuild"); > + $launcherPath = $jhbuildWrapper; Maybe this can be one line? $launcherPath = catdir(sourceDir(), "Tools", "efl", "run-with-jhbuild"); 581703 4 132561 d-r 2012-03-19 02:38:14 -0700 Created attachment 132561 Run launcher under jhbuild, v3 In one line, changelog rebased. 581731 5 132561 webkit.review.bot 2012-03-19 03:47:46 -0700 Comment on attachment 132561 Run launcher under jhbuild, v3 Clearing flags on attachment: 132561 Committed r111172: <http://trac.webkit.org/changeset/111172> 581732 6 webkit.review.bot 2012-03-19 03:47:51 -0700 All reviewed patches have been landed. Closing bug. 132056 2012-03-15 08:25:48 -0700 2012-03-16 07:37:50 -0700 Run launcher under jhbuild, v1 bug80026.patch text/plain 1395 d-r ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4MDY3 MGM0Li45YWIxNDcwIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMTItMDMtMTUgIERvbWluaWsgUsO2dHRzY2hlcyAg PGRvbWluaWsucm90dHNjaGVzQGxpbnV4LmludGVsLmNvbT4KIAorICAgICAgICBbRUZMXSBQcmVm aXggcnVuLWxhdW5jaGVyIHdpdGggcnVuLXdpdGgtamhidWlsZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODAwMjYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLWxhdW5jaGVyOgorCisy MDEyLTAzLTE1ICBEb21pbmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BsaW51eC5p bnRlbC5jb20+CisKICAgICAgICAgUGFyYW1ldHJpemUgcnVuLXdpdGgtamhidWlsZCBhbmQgdXBk YXRlLXdlYmtpdGd0ay1saWJzIHdpdGggcGxhdGZvcm0gLS1ndGsvLS1lZmwKICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5NjczCiAKZGlmZiAtLWdpdCBh L1Rvb2xzL1NjcmlwdHMvcnVuLWxhdW5jaGVyIGIvVG9vbHMvU2NyaXB0cy9ydW4tbGF1bmNoZXIK aW5kZXggYzJhNDdkZC4uNjBiYmNiMSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4tbGF1 bmNoZXIKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4tbGF1bmNoZXIKQEAgLTMwLDcgKzMwLDcgQEAK ICMgU2ltcGxpZmllZCAicnVuIiBzY3JpcHQgZm9yIFdlYktpdCBPcGVuIFNvdXJjZSBQcm9qZWN0 LgogCiB1c2Ugc3RyaWN0OwotdXNlIEZpbGU6OlNwZWM6OkZ1bmN0aW9ucyBxdy9jYXRkaXIvOwor dXNlIEZpbGU6OlNwZWM6OkZ1bmN0aW9ucyBxdy9jYXRkaXIgY2F0ZmlsZS87CiB1c2UgRmlsZTo6 VGVtcCBxdy90ZW1wZmlsZS87CiB1c2UgRmluZEJpbjsKIHVzZSBsaWIgJEZpbmRCaW46OkJpbjsK QEAgLTcyLDcgKzcyLDkgQEAgaWYgKGlzUXQoKSkgewogICAgIH0KICAgICAKICAgICBpZiAoaXNF ZmwoKSkgewotICAgICAgICAkbGF1bmNoZXJQYXRoID0gY2F0ZGlyKCRsYXVuY2hlclBhdGgsICJi aW4iLCAiRVdlYkxhdW5jaGVyIik7CisgICAgICAgIHVuc2hpZnQoQEFSR1YsIGNhdGZpbGUoJGxh dW5jaGVyUGF0aCwgImJpbiIsICJFV2ViTGF1bmNoZXIiKSk7CisgICAgICAgIG15ICRqaGJ1aWxk V3JhcHBlciA9IGNhdGRpcihzb3VyY2VEaXIoKSwgIlRvb2xzIiwgImVmbCIsICJydW4td2l0aC1q aGJ1aWxkIik7CisgICAgICAgICRsYXVuY2hlclBhdGggPSAkamhidWlsZFdyYXBwZXI7CiAgICAg fQogICAgIAogICAgIGlmIChpc1d4KCkpIHsK 132282 2012-03-16 07:37:50 -0700 2012-03-19 02:38:14 -0700 Run launcher under jhbuild, v2 bug80026_v2.patch text/plain 1144 d-r ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlMDBl MWY5Li42NzdkNGZjIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMTItMDMtMTUgIERvbWluaWsgUsO2dHRzY2hlcyAg PGRvbWluaWsucm90dHNjaGVzQGxpbnV4LmludGVsLmNvbT4KIAorICAgICAgICBbRUZMXSBQcmVm aXggcnVuLWxhdW5jaGVyIHdpdGggcnVuLXdpdGgtamhidWlsZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODAwMjYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLWxhdW5jaGVyOgorCisy MDEyLTAzLTE1ICBEb21pbmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BsaW51eC5p bnRlbC5jb20+CisKICAgICAgICAgW0VGTF0gQWRkIGFuZCB1c2UgcnVuLXdpdGgtamhidWlsZCBh bmQgdXBkYXRlLXdlYmtpdGVmbC1saWJzIHNjcmlwdHMgZm9yIEVGTAogICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzk5MDQKIApkaWZmIC0tZ2l0IGEvVG9v bHMvU2NyaXB0cy9ydW4tbGF1bmNoZXIgYi9Ub29scy9TY3JpcHRzL3J1bi1sYXVuY2hlcgppbmRl eCBjMmE0N2RkLi5hNzQwNDdiIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3J1bi1sYXVuY2hl cgorKysgYi9Ub29scy9TY3JpcHRzL3J1bi1sYXVuY2hlcgpAQCAtNzIsNyArNzIsOSBAQCBpZiAo aXNRdCgpKSB7CiAgICAgfQogICAgIAogICAgIGlmIChpc0VmbCgpKSB7Ci0gICAgICAgICRsYXVu Y2hlclBhdGggPSBjYXRkaXIoJGxhdW5jaGVyUGF0aCwgImJpbiIsICJFV2ViTGF1bmNoZXIiKTsK KyAgICAgICAgdW5zaGlmdChAQVJHViwgY2F0ZGlyKCRsYXVuY2hlclBhdGgsICJiaW4iLCAiRVdl YkxhdW5jaGVyIikpOworICAgICAgICBteSAkamhidWlsZFdyYXBwZXIgPSBjYXRkaXIoc291cmNl RGlyKCksICJUb29scyIsICJlZmwiLCAicnVuLXdpdGgtamhidWlsZCIpOworICAgICAgICAkbGF1 bmNoZXJQYXRoID0gJGpoYnVpbGRXcmFwcGVyOwogICAgIH0KICAgICAKICAgICBpZiAoaXNXeCgp KSB7Cg== 132561 2012-03-19 02:38:14 -0700 2012-03-19 03:47:46 -0700 Run launcher under jhbuild, v3 bug80026_v3.patch text/plain 1003 d-r ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxNGU3 MDA3Li5iYjljMTgzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTItMDMtMTkgIERvbWluaWsgUsO2dHRzY2hlcyAg PGRvbWluaWsucm90dHNjaGVzQGxpbnV4LmludGVsLmNvbT4KKworICAgICAgICBbRUZMXSBQcmVm aXggcnVuLWxhdW5jaGVyIHdpdGggcnVuLXdpdGgtamhidWlsZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODAwMjYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLWxhdW5jaGVyOgorCiAy MDEyLTAzLTE4ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAg ICAgW1F0XSBVbnJldmlld2VkLiBEaXNhYmxlIC1XZXJyb3Igb24geDg2IHVudGlsIHByb3BlciBm aXguCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3J1bi1sYXVuY2hlciBiL1Rvb2xzL1Njcmlw dHMvcnVuLWxhdW5jaGVyCmluZGV4IGMyYTQ3ZGQuLjVjN2ZhY2MgMTAwNzU1Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvcnVuLWxhdW5jaGVyCisrKyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWxhdW5jaGVyCkBA IC03Miw3ICs3Miw4IEBAIGlmIChpc1F0KCkpIHsKICAgICB9CiAgICAgCiAgICAgaWYgKGlzRWZs KCkpIHsKLSAgICAgICAgJGxhdW5jaGVyUGF0aCA9IGNhdGRpcigkbGF1bmNoZXJQYXRoLCAiYmlu IiwgIkVXZWJMYXVuY2hlciIpOworICAgICAgICB1bnNoaWZ0KEBBUkdWLCBjYXRkaXIoJGxhdW5j aGVyUGF0aCwgImJpbiIsICJFV2ViTGF1bmNoZXIiKSk7CisgICAgICAgICRsYXVuY2hlclBhdGgg PSBjYXRkaXIoc291cmNlRGlyKCksICJUb29scyIsICJlZmwiLCAicnVuLXdpdGgtamhidWlsZCIp OwogICAgIH0KICAgICAKICAgICBpZiAoaXNXeCgpKSB7Cg==