80025 2012-03-01 07:25:56 -0800 [EFL] Prefixing run-webkit-tests with run-with-jhbuild 2012-03-17 11:13:29 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 79673 79480 1 d-r d-r abarth jberlin ojan rakuco webkit.review.bot oldest_to_newest 568648 0 d-r 2012-03-01 07:25:56 -0800 Next step for solving 79480, let's change the EFL test execution to be prefixed with run-with-jhbuild. 579397 1 132052 d-r 2012-03-15 08:14:42 -0700 Created attachment 132052 Run EFL tests under jhbuild, v1 Ideally, this should be landed together with bug 79904. 579434 2 132052 rakuco 2012-03-15 09:19:01 -0700 Comment on attachment 132052 Run EFL tests under jhbuild, v1 Looks OK. 581281 3 132052 rakuco 2012-03-17 00:34:12 -0700 Comment on attachment 132052 Run EFL tests under jhbuild, v1 Clearing flags on attachment: 132052 Committed r111116: <http://trac.webkit.org/changeset/111116> 581282 4 rakuco 2012-03-17 00:34:19 -0700 All reviewed patches have been landed. Closing bug. 581340 5 jberlin 2012-03-17 10:24:28 -0700 This caused the python tests to start failing on the Mac bots: http://build.webkit.org/builders/Lion%20Intel%20Release%20%28Tests%29/builds/6501/steps/webkitpy-test/logs/stdio All tests pass http://build.webkit.org/builders/Lion%20Intel%20Release%20%28Tests%29/builds/6502/steps/webkitpy-test/logs/stdio ERROR: test_driver_cmd_line (webkitpy.layout_tests.port.efl_unittest.EflPortTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Volumes/Data/slave/lion-intel-release-tests/build/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 70, in test_driver_cmd_line self.assertTrue(len(port.driver_cmd_line())) File "/Volumes/Data/slave/lion-intel-release-tests/build/Tools/Scripts/webkitpy/layout_tests/port/base.py", line 546, in driver_cmd_line driver = self.create_driver(0) File "/Volumes/Data/slave/lion-intel-release-tests/build/Tools/Scripts/webkitpy/layout_tests/port/base.py", line 754, in create_driver return driver.DriverProxy(self, worker_number, self._driver_class(), pixel_tests=self.get_option('pixel_tests'), no_timeout=no_timeout) File "/Volumes/Data/slave/lion-intel-release-tests/build/Tools/Scripts/webkitpy/layout_tests/port/driver.py", line 186, in __init__ self._running_drivers[self._cmd_line_as_key(pixel_tests, [])] = self._driver File "/Volumes/Data/slave/lion-intel-release-tests/build/Tools/Scripts/webkitpy/layout_tests/port/driver.py", line 240, in _cmd_line_as_key return ' '.join(self.cmd_line(pixel_tests, per_test_args)) File "/Volumes/Data/slave/lion-intel-release-tests/build/Tools/Scripts/webkitpy/layout_tests/port/driver.py", line 237, in cmd_line return self._driver.cmd_line(pixel_tests or self._pixel_tests, per_test_args or []) TypeError: cmd_line() takes exactly 1 argument (3 given) ---------------------------------------------------------------------- Ran 1313 tests in 15.009s FAILED (errors=1) Please fix it, or I will be forced to roll it out. 581342 6 rakuco 2012-03-17 11:13:29 -0700 (In reply to comment #5) > This caused the python tests to start failing on the Mac bots: > > http://build.webkit.org/builders/Lion%20Intel%20Release%20%28Tests%29/builds/6501/steps/webkitpy-test/logs/stdio > > All tests pass > > http://build.webkit.org/builders/Lion%20Intel%20Release%20%28Tests%29/builds/6502/steps/webkitpy-test/logs/stdio Fix committed as r111122 <http://trac.webkit.org/changeset/111122>. 132052 2012-03-15 08:14:42 -0700 2012-03-17 00:34:12 -0700 Run EFL tests under jhbuild, v1 bug80025.patch text/plain 1871 d-r ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4MDY3 MGM0Li45M2RjZWE3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMTItMDMtMTUgIERvbWluaWsgUsO2dHRzY2hlcyAg PGRvbWluaWsucm90dHNjaGVzQGxpbnV4LmludGVsLmNvbT4KIAorICAgICAgICBbRUZMXSBQcmVm aXhpbmcgcnVuLXdlYmtpdC10ZXN0cyB3aXRoIHJ1bi13aXRoLWpoYnVpbGQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgwMDI1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9wb3J0L2VmbC5weToKKyAgICAgICAgKEVmbERyaXZlcik6CisgICAgICAgIChF ZmxEcml2ZXIuY21kX2xpbmUpOgorICAgICAgICAoRWZsUG9ydC5fZHJpdmVyX2NsYXNzKToKKwor MjAxMi0wMy0xNSAgRG9taW5payBSw7Z0dHNjaGVzICA8ZG9taW5pay5yb3R0c2NoZXNAbGludXgu aW50ZWwuY29tPgorCiAgICAgICAgIFBhcmFtZXRyaXplIHJ1bi13aXRoLWpoYnVpbGQgYW5kIHVw ZGF0ZS13ZWJraXRndGstbGlicyB3aXRoIHBsYXRmb3JtIC0tZ3RrLy0tZWZsCiAgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03OTY3MwogCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2VmbC5weSBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZWZsLnB5CmluZGV4IGI0OWM0OGMu LjEzNWUxMWUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3BvcnQvZWZsLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Bv cnQvZWZsLnB5CkBAIC0zMSwxOCArMzEsMjcgQEAgaW1wb3J0IHNpZ25hbAogaW1wb3J0IHN1YnBy b2Nlc3MKIAogZnJvbSB3ZWJraXRweS5sYXlvdXRfdGVzdHMubW9kZWxzLnRlc3RfY29uZmlndXJh dGlvbiBpbXBvcnQgVGVzdENvbmZpZ3VyYXRpb24KLWZyb20gd2Via2l0cHkubGF5b3V0X3Rlc3Rz LnBvcnQud2Via2l0IGltcG9ydCBXZWJLaXRQb3J0Citmcm9tIHdlYmtpdHB5LmxheW91dF90ZXN0 cy5wb3J0LndlYmtpdCBpbXBvcnQgV2ViS2l0RHJpdmVyLCBXZWJLaXRQb3J0CiAKIAogX2xvZyA9 IGxvZ2dpbmcuZ2V0TG9nZ2VyKF9fbmFtZV9fKQogCiAKK2NsYXNzIEVmbERyaXZlcihXZWJLaXRE cml2ZXIpOgorICAgIGRlZiBjbWRfbGluZShzZWxmKToKKyAgICAgICAgd3JhcHBlcl9wYXRoID0g c2VsZi5fcG9ydC5wYXRoX2Zyb21fd2Via2l0X2Jhc2UoIlRvb2xzIiwgImVmbCIsICJydW4td2l0 aC1qaGJ1aWxkIikKKyAgICAgICAgcmV0dXJuIFt3cmFwcGVyX3BhdGhdICsgV2ViS2l0RHJpdmVy LmNtZF9saW5lKHNlbGYpCisKKwogY2xhc3MgRWZsUG9ydChXZWJLaXRQb3J0KToKICAgICBwb3J0 X25hbWUgPSAnZWZsJwogCiAgICAgZGVmIF9wb3J0X2ZsYWdfZm9yX3NjcmlwdHMoc2VsZik6CiAg ICAgICAgIHJldHVybiAiLS1lZmwiCiAKKyAgICBkZWYgX2RyaXZlcl9jbGFzcyhzZWxmKToKKyAg ICAgICAgcmV0dXJuIEVmbERyaXZlcgorCiAgICAgZGVmIF9nZW5lcmF0ZV9hbGxfdGVzdF9jb25m aWd1cmF0aW9ucyhzZWxmKToKICAgICAgICAgcmV0dXJuIFtUZXN0Q29uZmlndXJhdGlvbih2ZXJz aW9uPXNlbGYuX3ZlcnNpb24sIGFyY2hpdGVjdHVyZT0neDg2JywgYnVpbGRfdHlwZT1idWlsZF90 eXBlKSBmb3IgYnVpbGRfdHlwZSBpbiBzZWxmLkFMTF9CVUlMRF9UWVBFU10KIAo=