7995 2006-03-26 11:00:33 -0800 is css/maketokenizer is removing the type defs 2007-09-30 11:30:27 -0700 1 1 1 Unclassified WebKit Tools / Tests 420+ PC Linux RESOLVED WONTFIX P2 Normal --- 8515 1 mike.emmel webkit-unassigned bugs-webkit ian oldest_to_newest 37607 0 mike.emmel 2006-03-26 11:00:33 -0800 It seems on OSX the flex typedefs are being picked up from the system while this is not true under linux. Patch attached 37608 1 7313 mike.emmel 2006-03-26 11:03:19 -0800 Created attachment 7313 Patch to add typedefs 37709 2 7313 darin 2006-03-27 17:09:36 -0800 Comment on attachment 7313 Patch to add typedefs I'm not sure I understand what's going on here. The tokenizer.cpp file generated by our version of flex, 2.5.4, doesn't contain any references to types with a "flex_" prefix. It's not true that under OS X the flex types are being "picked up from the OS". What's happening is that these types don't exist at all in the version of flex we're using. I think there are probably better ways to fix this. The maketokenizer script throws away a lot of what flex generates -- we should probably fix it to keep around the typedefs. 37710 3 7313 darin 2006-03-27 17:10:36 -0800 Comment on attachment 7313 Patch to add typedefs This is not the right fix -- we don't want our own copy of the flex typedefs. But I'm sure we can tweak the script another way to make it work with this newer version of flex. It's worth looking at the latest KDE version of this script to see what they decided to do, since this is the unmodified original script we got from them. 57476 4 eric 2007-09-30 11:30:27 -0700 This must have been worked around in some other way in the last 9 months, no? I would think this bug could be closed by now. Last I knew GTKWebKit even has its own buildbot: http://build.webkit.org/post-commit-linux-gtk 7313 2006-03-26 11:03:19 -0800 2006-03-27 17:10:36 -0800 Patch to add typedefs maketokenizer.diff text/plain 844 mike.emmel SW5kZXg6IGNzcy9tYWtldG9rZW5pemVyCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGNzcy9tYWtldG9rZW5pemVy CShyZXZpc2lvbiAxMzQ3OSkKKysrIGNzcy9tYWtldG9rZW5pemVyCSh3b3JraW5nIGNvcHkpCkBA IC0zOSw2ICszOSwyNiBAQAogCiAqLwogCisvKiBDOTkgc3lzdGVtcyBoYXZlIDxpbnR0eXBlcy5o Pi4gTm9uLUM5OSBzeXN0ZW1zIG1heSBvciBtYXkgbm90LiAqLworCisjaWYgZGVmaW5lZCBfX1NU RENfVkVSU0lPTl9fICYmIF9fU1REQ19WRVJTSU9OX18gPj0gMTk5OTAxTAorI2luY2x1ZGUgPGlu dHR5cGVzLmg+Cit0eXBlZGVmIGludDhfdCBmbGV4X2ludDhfdDsKK3R5cGVkZWYgdWludDhfdCBm bGV4X3VpbnQ4X3Q7Cit0eXBlZGVmIGludDE2X3QgZmxleF9pbnQxNl90OwordHlwZWRlZiB1aW50 MTZfdCBmbGV4X3VpbnQxNl90OwordHlwZWRlZiBpbnQzMl90IGZsZXhfaW50MzJfdDsKK3R5cGVk ZWYgdWludDMyX3QgZmxleF91aW50MzJfdDsKKyNlbHNlCit0eXBlZGVmIHNpZ25lZCBjaGFyIGZs ZXhfaW50OF90OwordHlwZWRlZiBzaG9ydCBpbnQgZmxleF9pbnQxNl90OwordHlwZWRlZiBpbnQg ZmxleF9pbnQzMl90OwordHlwZWRlZiB1bnNpZ25lZCBjaGFyIGZsZXhfdWludDhfdDsKK3R5cGVk ZWYgdW5zaWduZWQgc2hvcnQgaW50IGZsZXhfdWludDE2X3Q7Cit0eXBlZGVmIHVuc2lnbmVkIGlu dCBmbGV4X3VpbnQzMl90OworI2VuZGlmIC8qICEgQzk5ICovCisKKwogLy8gLS0tLS0tLS0tIGJl Z2luIGdlbmVyYXRlZCBjb2RlIC0tLS0tLS0tLS0tLS0tLS0tLS0KIAogRU5ECg==