79937 2012-02-29 13:24:50 -0800 Crash at -[WebFrame(WebInternal) _setTypingStyle:withUndoAction:] 2012-02-29 13:28:15 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Mac Unspecified RESOLVED FIXED InRadar, Regression P2 Normal --- 1 enrica enrica rniwa oldest_to_newest 567865 0 enrica 2012-02-29 13:24:50 -0800 This crash can be hit when the passed typing style is NULL. Mail on OS X passes a null value when increasing the quote level. <rdar://problem/10942936> 567871 1 rniwa 2012-02-29 13:26:26 -0800 So we're missing null check somewhere? 567872 2 129504 enrica 2012-02-29 13:27:20 -0800 Created attachment 129504 Patch This patch has been reviewed in person by Dan Bernstein. 567873 3 enrica 2012-02-29 13:28:15 -0800 http://trac.webkit.org/changeset/109254 129504 2012-02-29 13:27:20 -0800 2012-02-29 13:27:20 -0800 Patch settypingstyle.txt text/plain 1313 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwOTI1MCkKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAyLTI5 ICBFbnJpY2EgQ2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jhc2ggYXQg LVtXZWJGcmFtZShXZWJJbnRlcm5hbCkgX3NldFR5cGluZ1N0eWxlOndpdGhVbmRvQWN0aW9uOl0K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5OTM3Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMDk0MjkzNj4KKworICAgICAgICBSZXZpZXdlZCBieSBE YW4gQmVybnN0ZWluLgorCisgICAgICAgICogV2ViVmlldy9XZWJGcmFtZS5tbToKKyAgICAgICAg KC1bV2ViRnJhbWUgX3NldFR5cGluZ1N0eWxlOndpdGhVbmRvQWN0aW9uOl0pOiBBZGRpbmcgYSBu dWxsIGNoZWNrLgorCiAyMDEyLTAyLTI4ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBw bGUuY29tPgogCiAgICAgICAgIFVwZGF0ZSBXZWJLaXRTeXN0ZW1JbnRlcmZhY2UuCkluZGV4OiBT b3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkZyYW1lLm1tCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViRnJhbWUubW0JKHJldmlzaW9uIDEwOTEyOSkKKysrIFNv dXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViRnJhbWUubW0JKHdvcmtpbmcgY29weSkKQEAgLTc5 Nyw3ICs3OTcsNyBAQCAtIChET01DU1NTdHlsZURlY2xhcmF0aW9uICopX3R5cGluZ1N0eWxlCiAK IC0gKHZvaWQpX3NldFR5cGluZ1N0eWxlOihET01DU1NTdHlsZURlY2xhcmF0aW9uICopc3R5bGUg d2l0aFVuZG9BY3Rpb246KEVkaXRBY3Rpb24pdW5kb0FjdGlvbgogewotICAgIGlmICghX3ByaXZh dGUtPmNvcmVGcmFtZSkKKyAgICBpZiAoIV9wcml2YXRlLT5jb3JlRnJhbWUgfHwgIXN0eWxlKQog ICAgICAgICByZXR1cm47CiAgICAgLy8gRklYTUU6IFdlIHNob3VsZG4ndCBoYXZlIHRvIGNyZWF0 ZSBhIGNvcHkgaGVyZS4KICAgICBfcHJpdmF0ZS0+Y29yZUZyYW1lLT5lZGl0b3IoKS0+Y29tcHV0 ZUFuZFNldFR5cGluZ1N0eWxlKGNvcmUoc3R5bGUpLT5jb3B5KCkuZ2V0KCksIHVuZG9BY3Rpb24p Owo=