79933 2012-02-29 12:44:58 -0800 [chromium] Use webkit_support to create session storage namespaces in DRT. 2012-03-01 16:25:36 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 michaeln michaeln dglazkov tkent tony webkit.review.bot oldest_to_newest 567837 0 michaeln 2012-02-29 12:44:58 -0800 Use webkit_support::createSessionStorageNamespace() to create session storage namespaces in DRT instead directly using the factory method in the WebKit api. See related issue http://code.google.com/p/chromium/issues/detail?id=106763 567884 1 129508 michaeln 2012-02-29 13:38:42 -0800 Created attachment 129508 drt commit needs to wait for the chromium-side change in which the new webkit_support function is defined to land, http://codereview.chromium.org/9429029/ 567920 2 michaeln 2012-02-29 14:12:17 -0800 tony, ptal 567931 3 129508 tony 2012-02-29 14:20:32 -0800 Comment on attachment 129508 drt View in context: https://bugs.webkit.org/attachment.cgi?id=129508&action=review > Tools/DumpRenderTree/chromium/WebViewHost.cpp:276 > - return WebKit::WebStorageNamespace::createSessionStorageNamespace(quota); > + return webkit_support::CreateSessionStorageNamespace(quota); I don't see this method in webkit/support/webkit_support.h. Am I missing something? 567934 4 129508 tony 2012-02-29 14:21:35 -0800 Comment on attachment 129508 drt Sorry, just read comment #1. You'll have to roll DEPS in Source/WebKit/chromium/DEPS after the chromium change lands. 567941 5 michaeln 2012-02-29 14:25:57 -0800 (In reply to comment #4) > You'll have to roll DEPS in Source/WebKit/chromium/DEPS after the chromium change lands. will do, thnx 568222 6 129508 webkit.review.bot 2012-02-29 19:05:08 -0800 Comment on attachment 129508 drt Attachment 129508 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11766134 568979 7 129508 michaeln 2012-03-01 15:29:17 -0800 Comment on attachment 129508 drt putting in the commit-queue now that we've rolled DEPs to 124511 (well past 124337) 569039 8 129508 webkit.review.bot 2012-03-01 16:25:29 -0800 Comment on attachment 129508 drt Clearing flags on attachment: 129508 Committed r109462: <http://trac.webkit.org/changeset/109462> 569040 9 webkit.review.bot 2012-03-01 16:25:36 -0800 All reviewed patches have been landed. Closing bug. 129508 2012-02-29 13:38:42 -0800 2012-03-01 16:25:29 -0800 drt drt.txt text/plain 1307 michaeln SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEwOTI0NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDEyLTAyLTI5ICBNaWNoYWVsIE5vcmRtYW4gIDxtaWNoYWVsbkBnb29nbGUu Y29tPgorCisgICAgICAgIFtjaHJvbWl1bV0gVXNlIHdlYmtpdF9zdXBwb3J0IHRvIGNyZWF0ZSBz ZXNzaW9uIHN0b3JhZ2UgbmFtZXNwYWNlcyBpbiBEUlQuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03OTkzMworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmll d0hvc3QuY3BwOgorICAgICAgICAoV2ViVmlld0hvc3Q6OmNyZWF0ZVNlc3Npb25TdG9yYWdlTmFt ZXNwYWNlKToKKwogMjAxMi0wMi0yOSAgR3JlZyBCaWxsb2NrICA8Z2JpbGxvY2tAZ29vZ2xlLmNv bT4KIAogICAgICAgICBBZGQgbW9yZSB0ZXN0cyBmb3Igd2ViIGludGVudHMKSW5kZXg6IFRvb2xz L0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBU b29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5jcHAJKHJldmlzaW9uIDEw OTE4MykKKysrIFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmNwcAko d29ya2luZyBjb3B5KQpAQCAtMjczLDcgKzI3Myw3IEBAIFdlYldpZGdldCogV2ViVmlld0hvc3Q6 OmNyZWF0ZVBvcHVwTWVudSgKIAogV2ViU3RvcmFnZU5hbWVzcGFjZSogV2ViVmlld0hvc3Q6OmNy ZWF0ZVNlc3Npb25TdG9yYWdlTmFtZXNwYWNlKHVuc2lnbmVkIHF1b3RhKQogewotICAgIHJldHVy biBXZWJLaXQ6OldlYlN0b3JhZ2VOYW1lc3BhY2U6OmNyZWF0ZVNlc3Npb25TdG9yYWdlTmFtZXNw YWNlKHF1b3RhKTsKKyAgICByZXR1cm4gd2Via2l0X3N1cHBvcnQ6OkNyZWF0ZVNlc3Npb25TdG9y YWdlTmFtZXNwYWNlKHF1b3RhKTsKIH0KIAogV2ViS2l0OjpXZWJHcmFwaGljc0NvbnRleHQzRCog V2ViVmlld0hvc3Q6OmNyZWF0ZUdyYXBoaWNzQ29udGV4dDNEKGNvbnN0IFdlYktpdDo6V2ViR3Jh cGhpY3NDb250ZXh0M0Q6OkF0dHJpYnV0ZXMmIGF0dHJpYnV0ZXMsIGJvb2wgZGlyZWN0KQo=