79921 2012-02-29 09:19:51 -0800 Web Inspector: timeline markers are not shown on the timeline panel 2012-02-29 09:36:43 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 567676 0 caseq 2012-02-29 09:19:51 -0800 1. navigate to webkit.org 2. open inspector 3. switch to Timeline panel 4. start recording timeline 5. run console.markTimeline() in console EXPECTED: yellow mark on the timeline grid and in the overview ACTUAL: no marks anywhere 567677 1 129462 caseq 2012-02-29 09:20:53 -0800 Created attachment 129462 Patch 567678 2 129462 pfeldman 2012-02-29 09:24:32 -0800 Comment on attachment 129462 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129462&action=review > Source/WebCore/inspector/front-end/TimelinePanel.js:467 > + WebInspector.TimelinePanel.forAllRecords([ formattedRecord ], addTimestampRecords.bind(this)); I wound not bind a function per record. 567683 3 caseq 2012-02-29 09:36:43 -0800 Committed r109221: <http://trac.webkit.org/changeset/109221> 129462 2012-02-29 09:20:53 -0800 2012-02-29 09:24:31 -0800 Patch bug-79921-20120229212051.patch text/plain 2044 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5MjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTVjNDcyNWIwYzgzODRl MzhiMGZiMTc1NzRiNGMxNjJkYzIxZjg2OC4uMzBjZTM0MDNmZTBhMzhhZjIzOGY3ZDc3MTBmZTYy OTBkZDU2YmRmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAyLTI5ICBBbmRy ZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogdGltZWxpbmUgbWFya2VycyBhcmUgbm90IHNob3duIG9uIHRoZSB0aW1lbGluZSBwYW5lbAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzk5MjEKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rv ci9mcm9udC1lbmQvVGltZWxpbmVQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1l bGluZVBhbmVsLnByb3RvdHlwZS5faW5uZXJBZGRSZWNvcmRUb1RpbWVsaW5lLmFkZFRpbWVzdGFt cFJlY29yZHMpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUGFuZWwucHJvdG90eXBl Ll9pbm5lckFkZFJlY29yZFRvVGltZWxpbmUpOgorCiAyMDEyLTAyLTI5ICBQYXZlbCBGZWxkbWFu ICA8cGZlbGRtYW5AZ29vZ2xlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiByZW1vdmUg Y2FsY3VsYXRvcidzIHVwZGF0ZUJvdW5kYXJpZXMgaW4gdGhlIHRpbWVsaW5lIHBhbmVsLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZVBhbmVs LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZVBhbmVsLmpz CmluZGV4IDhiYWI5M2NjZDNjMjIwMGY3ZGY3MzBlZGViMDZmNjYwYTRjZjA5YTUuLjE0NDcxYjI1 N2NlOTgyYTdmMTQxY2JlYWM4ZGQyNGI5ODRhZGU2MmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVQYW5lbC5qcworKysgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanMKQEAgLTQ1OSw4ICs0NTks MTIgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUGFuZWwucHJvdG90eXBlID0gewogICAgICAgICB2 YXIgZm9ybWF0dGVkUmVjb3JkID0gdGhpcy5fcHJlc2VudGF0aW9uTW9kZWwuYWRkUmVjb3JkKHJl Y29yZCwgcGFyZW50UmVjb3JkKTsKICAgICAgICAgKyt0aGlzLl9hbGxSZWNvcmRzQ291bnQ7CiAg ICAgICAgIHZhciByZWNvcmRUeXBlcyA9IFdlYkluc3BlY3Rvci5UaW1lbGluZU1vZGVsLlJlY29y ZFR5cGU7Ci0gICAgICAgIGlmIChyZWNvcmQudHlwZSA9PT0gcmVjb3JkVHlwZXMuTWFya0RPTUNv bnRlbnQgfHwgcmVjb3JkLnR5cGUgPT09IHJlY29yZFR5cGVzLk1hcmtMb2FkIHx8IHJlY29yZC50 eXBlID09PSByZWNvcmRUeXBlcy5UaW1lU3RhbXApCi0gICAgICAgICAgICB0aGlzLl90aW1lU3Rh bXBSZWNvcmRzLnB1c2goZm9ybWF0dGVkUmVjb3JkKTsKKyAgICAgICAgZnVuY3Rpb24gYWRkVGlt ZXN0YW1wUmVjb3JkcyhyZWNvcmQpCisgICAgICAgIHsKKyAgICAgICAgICAgIGlmIChyZWNvcmQu dHlwZSA9PT0gcmVjb3JkVHlwZXMuTWFya0RPTUNvbnRlbnQgfHwgcmVjb3JkLnR5cGUgPT09IHJl Y29yZFR5cGVzLk1hcmtMb2FkIHx8IHJlY29yZC50eXBlID09PSByZWNvcmRUeXBlcy5UaW1lU3Rh bXApCisgICAgICAgICAgICAgICAgdGhpcy5fdGltZVN0YW1wUmVjb3Jkcy5wdXNoKHJlY29yZCk7 CisgICAgICAgIH0KKyAgICAgICAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUGFuZWwuZm9yQWxsUmVj b3JkcyhbIGZvcm1hdHRlZFJlY29yZCBdLCBhZGRUaW1lc3RhbXBSZWNvcmRzLmJpbmQodGhpcykp OwogICAgIH0sCiAKICAgICBzaWRlYmFyUmVzaXplZDogZnVuY3Rpb24oZXZlbnQpCg==