79903 2012-02-29 06:59:06 -0800 WTF: Micro-optimize cleanup of empty vectors and hash tables 2014-04-24 16:45:29 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 wingo wingo barraclough darin ggaren oliver webkit.review.bot oldest_to_newest 567571 0 wingo 2012-02-29 06:59:06 -0800 The patch to be attached has the following changelog: This patch speeds up cleanup of vectors and hash tables whose backing store was never allocated. This is the case by default for most vectors / hash tables that never had any entries added. The result for me is that calling checkSyntax 1000 times on concat-jquery-mootools-prototype.js goes from 6.234s to 6.068s, a 2.4% speedup. * wtf/HashTable.h: (WTF::HashTable::~HashTable): (WTF::::clear): Don't deallocate the storage or frob member variables if there is no backing storage. * wtf/Vector.h: (WTF::VectorBufferBase::deallocateBuffer): Likewise. 567572 1 129436 wingo 2012-02-29 07:00:27 -0800 Created attachment 129436 Patch 567681 2 129436 wingo 2012-02-29 09:30:13 -0800 Comment on attachment 129436 Patch Thanks for the review! 567703 3 129436 ggaren 2012-02-29 10:18:47 -0800 Comment on attachment 129436 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129436&action=review > Source/JavaScriptCore/wtf/HashTable.h:983 > + if (m_table) { WebKit style is to use early return here: if (!m_table) return; This reduces overall indentation. > Source/JavaScriptCore/wtf/Vector.h:284 > + if (bufferToDeallocate) { WebKit style is to use early return here: if (!bufferToDeallocate) return; This reduces overall indentation. 567782 4 129436 wingo 2012-02-29 11:41:28 -0800 Comment on attachment 129436 Patch clearing cq+ in anticipation of landing a patch with ggaren's feedback incorporated 567786 5 129484 wingo 2012-02-29 11:45:18 -0800 Created attachment 129484 Patch for landing 568120 6 129484 webkit.review.bot 2012-02-29 17:09:44 -0800 Comment on attachment 129484 Patch for landing Rejecting attachment 129484 from commit-queue. New failing tests: fast/js/kde/RegExp.html Full output: http://queues.webkit.org/results/11770092 570540 7 129484 wingo 2012-03-05 02:37:29 -0800 Comment on attachment 129484 Patch for landing Flipping cq+ again; I think that the previous run was when the queues were flaky. Will look into this if it does a cq- again. 570558 8 129484 webkit.review.bot 2012-03-05 03:56:30 -0800 Comment on attachment 129484 Patch for landing Clearing flags on attachment: 129484 Committed r109731: <http://trac.webkit.org/changeset/109731> 570559 9 webkit.review.bot 2012-03-05 03:56:37 -0800 All reviewed patches have been landed. Closing bug. 1003862 10 darin 2014-04-24 16:45:29 -0700 Moving all JavaScriptGlue bugs to JavaScriptCore. The JavaScriptGlue framework itself is long gone. And most of the more recent bugs put in this component were put there by people who thought this was for some other aspect of “JavaScript glue” and have nothing to do with the actual original reason for the existence of this component, which was an OS-X-only framework named JavaScriptGlue. 129436 2012-02-29 07:00:27 -0800 2012-02-29 11:45:11 -0800 Patch bug-79903-20120229160025.patch text/plain 3396 wingo U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5MjAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy YjkxOWNjYmY3ODk1YjA3Y2FkNzZjZTBiYzFkMjE3ZDM3MjZjMzVhLi5mZmIyMzQ5MDNmNTAxN2Nh ZGRmM2EyM2UyNjQyN2U5MjFmM2IxMjE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNSBAQAorMjAxMi0wMi0yOSAgQW5keSBXaW5nbyAgPHdpbmdvQGlnYWxpYS5jb20+CisK KyAgICAgICAgV1RGOiBNaWNyby1vcHRpbWl6ZSBjbGVhbnVwIG9mIGVtcHR5IHZlY3RvcnMgYW5k IGhhc2ggdGFibGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03OTkwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoaXMgcGF0Y2ggc3BlZWRzIHVwIGNsZWFudXAgb2YgdmVjdG9ycyBhbmQgaGFzaCB0YWJs ZXMgd2hvc2UKKyAgICAgICAgYmFja2luZyBzdG9yZSB3YXMgbmV2ZXIgYWxsb2NhdGVkLiAgVGhp cyBpcyB0aGUgY2FzZSBieSBkZWZhdWx0CisgICAgICAgIGZvciBtb3N0IHZlY3RvcnMgLyBoYXNo IHRhYmxlcyB0aGF0IG5ldmVyIGhhZCBhbnkgZW50cmllcyBhZGRlZC4KKworICAgICAgICBUaGUg cmVzdWx0IGZvciBtZSBpcyB0aGF0IGNhbGxpbmcgY2hlY2tTeW50YXggMTAwMCB0aW1lcyBvbgor ICAgICAgICBjb25jYXQtanF1ZXJ5LW1vb3Rvb2xzLXByb3RvdHlwZS5qcyBnb2VzIGZyb20gNi4y MzRzIHRvIDYuMDY4cywgYQorICAgICAgICAyLjQlIHNwZWVkdXAuCisKKyAgICAgICAgKiB3dGYv SGFzaFRhYmxlLmg6CisgICAgICAgIChXVEY6Okhhc2hUYWJsZTo6fkhhc2hUYWJsZSk6CisgICAg ICAgIChXVEY6Ojo6Y2xlYXIpOiBEb24ndCBkZWFsbG9jYXRlIHRoZSBzdG9yYWdlIG9yIGZyb2Ig bWVtYmVyCisgICAgICAgIHZhcmlhYmxlcyBpZiB0aGVyZSBpcyBubyBiYWNraW5nIHN0b3JhZ2Uu CisgICAgICAgICogd3RmL1ZlY3Rvci5oOgorICAgICAgICAoV1RGOjpWZWN0b3JCdWZmZXJCYXNl OjpkZWFsbG9jYXRlQnVmZmVyKTogTGlrZXdpc2UuCisKIDIwMTItMDItMjggIFJhcGhhZWwgS3Vi byBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CiAKICAgICAgICAgW0NNYWtlXSBBbHdh eXMgYnVpbGQgd3RmIGFzIGEgc3RhdGljIGxpYnJhcnkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvd3RmL0hhc2hUYWJsZS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9I YXNoVGFibGUuaAppbmRleCBjYmNjMDk4MTc0NTg2N2I0ZWQwOWFiOGU4OGU1YWYxZWQ0ZjU1ZThj Li5hM2FmZDlhOGRkMDFmMjEyMWRmZjU3MzgwOTNlZDQzMGUyY2VlYjI2IDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0hhc2hUYWJsZS5oCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS93dGYvSGFzaFRhYmxlLmgKQEAgLTMxMCw3ICszMTAsOCBAQCBuYW1lc3BhY2UgV1RG IHsKICAgICAgICAgfkhhc2hUYWJsZSgpIAogICAgICAgICB7CiAgICAgICAgICAgICBpbnZhbGlk YXRlSXRlcmF0b3JzKCk7IAotICAgICAgICAgICAgZGVhbGxvY2F0ZVRhYmxlKG1fdGFibGUsIG1f dGFibGVTaXplKTsgCisgICAgICAgICAgICBpZiAobV90YWJsZSkKKyAgICAgICAgICAgICAgICBk ZWFsbG9jYXRlVGFibGUobV90YWJsZSwgbV90YWJsZVNpemUpOwogI2lmIENIRUNLX0hBU0hUQUJM RV9VU0VfQUZURVJfREVTVFJVQ1RJT04KICAgICAgICAgICAgIG1fdGFibGUgPSAoVmFsdWVUeXBl KikodWludHB0cl90KTB4YmJhZGJlZWY7CiAjZW5kaWYKQEAgLTk3OSwxMSArOTgwLDEzIEBAIG5h bWVzcGFjZSBXVEYgewogICAgIHZvaWQgSGFzaFRhYmxlPEtleSwgVmFsdWUsIEV4dHJhY3Rvciwg SGFzaEZ1bmN0aW9ucywgVHJhaXRzLCBLZXlUcmFpdHM+OjpjbGVhcigpCiAgICAgewogICAgICAg ICBpbnZhbGlkYXRlSXRlcmF0b3JzKCk7Ci0gICAgICAgIGRlYWxsb2NhdGVUYWJsZShtX3RhYmxl LCBtX3RhYmxlU2l6ZSk7Ci0gICAgICAgIG1fdGFibGUgPSAwOwotICAgICAgICBtX3RhYmxlU2l6 ZSA9IDA7Ci0gICAgICAgIG1fdGFibGVTaXplTWFzayA9IDA7Ci0gICAgICAgIG1fa2V5Q291bnQg PSAwOworICAgICAgICBpZiAobV90YWJsZSkgeworICAgICAgICAgICAgZGVhbGxvY2F0ZVRhYmxl KG1fdGFibGUsIG1fdGFibGVTaXplKTsKKyAgICAgICAgICAgIG1fdGFibGUgPSAwOworICAgICAg ICAgICAgbV90YWJsZVNpemUgPSAwOworICAgICAgICAgICAgbV90YWJsZVNpemVNYXNrID0gMDsK KyAgICAgICAgICAgIG1fa2V5Q291bnQgPSAwOworICAgICAgICB9CiAgICAgfQogCiAgICAgdGVt cGxhdGU8dHlwZW5hbWUgS2V5LCB0eXBlbmFtZSBWYWx1ZSwgdHlwZW5hbWUgRXh0cmFjdG9yLCB0 eXBlbmFtZSBIYXNoRnVuY3Rpb25zLCB0eXBlbmFtZSBUcmFpdHMsIHR5cGVuYW1lIEtleVRyYWl0 cz4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvVmVjdG9yLmggYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvd3RmL1ZlY3Rvci5oCmluZGV4IDI5YmJkMzdkOTEzYzMyOGQ3ZDMw MDE0MTMwZmZmMjhmNTZiMzA2NTkuLjM1MWQzZTg0YTY5NzY5YTM2ZWNjOTIwNmU0OTAzMDA0MTIz NGNmNmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvVmVjdG9yLmgKKysr IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9WZWN0b3IuaApAQCAtMjgxLDExICsyODEsMTMg QEAgbmFtZXNwYWNlIFdURiB7CiAKICAgICAgICAgdm9pZCBkZWFsbG9jYXRlQnVmZmVyKFQqIGJ1 ZmZlclRvRGVhbGxvY2F0ZSkKICAgICAgICAgewotICAgICAgICAgICAgaWYgKG1fYnVmZmVyID09 IGJ1ZmZlclRvRGVhbGxvY2F0ZSkgewotICAgICAgICAgICAgICAgIG1fYnVmZmVyID0gMDsKLSAg ICAgICAgICAgICAgICBtX2NhcGFjaXR5ID0gMDsKKyAgICAgICAgICAgIGlmIChidWZmZXJUb0Rl YWxsb2NhdGUpIHsKKyAgICAgICAgICAgICAgICBpZiAobV9idWZmZXIgPT0gYnVmZmVyVG9EZWFs bG9jYXRlKSB7CisgICAgICAgICAgICAgICAgICAgIG1fYnVmZmVyID0gMDsKKyAgICAgICAgICAg ICAgICAgICAgbV9jYXBhY2l0eSA9IDA7CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAg ICAgIGZhc3RGcmVlKGJ1ZmZlclRvRGVhbGxvY2F0ZSk7CiAgICAgICAgICAgICB9Ci0gICAgICAg ICAgICBmYXN0RnJlZShidWZmZXJUb0RlYWxsb2NhdGUpOwogICAgICAgICB9CiAKICAgICAgICAg VCogYnVmZmVyKCkgeyByZXR1cm4gbV9idWZmZXI7IH0K 129484 2012-02-29 11:45:18 -0800 2012-03-05 03:56:30 -0800 Patch for landing bug-79903-20120229204516.patch text/plain 2869 wingo U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5MjAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy YjkxOWNjYmY3ODk1YjA3Y2FkNzZjZTBiYzFkMjE3ZDM3MjZjMzVhLi4wZWExMzI4NWYxZTJmNWRm M2Y0OGFiOTRhOTUxZjNiOWM5YzgwNjY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNSBAQAorMjAxMi0wMi0yOSAgQW5keSBXaW5nbyAgPHdpbmdvQGlnYWxpYS5jb20+CisK KyAgICAgICAgV1RGOiBNaWNyby1vcHRpbWl6ZSBjbGVhbnVwIG9mIGVtcHR5IHZlY3RvcnMgYW5k IGhhc2ggdGFibGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03OTkwMworCisgICAgICAgIFJldmlld2VkIGJ5IE1pY2hhZWwgU2Fib2ZmIGFuZCBHZW9m ZnJleSBHYXJlbi4KKworICAgICAgICBUaGlzIHBhdGNoIHNwZWVkcyB1cCBjbGVhbnVwIG9mIHZl Y3RvcnMgYW5kIGhhc2ggdGFibGVzIHdob3NlCisgICAgICAgIGJhY2tpbmcgc3RvcmUgd2FzIG5l dmVyIGFsbG9jYXRlZC4gIFRoaXMgaXMgdGhlIGNhc2UgYnkgZGVmYXVsdAorICAgICAgICBmb3Ig bW9zdCB2ZWN0b3JzIC8gaGFzaCB0YWJsZXMgdGhhdCBuZXZlciBoYWQgYW55IGVudHJpZXMgYWRk ZWQuCisKKyAgICAgICAgVGhlIHJlc3VsdCBmb3IgbWUgaXMgdGhhdCBjYWxsaW5nIGNoZWNrU3lu dGF4IDEwMDAgdGltZXMgb24KKyAgICAgICAgY29uY2F0LWpxdWVyeS1tb290b29scy1wcm90b3R5 cGUuanMgZ29lcyBmcm9tIDYuMjM0cyB0byA2LjA2OHMsIGEKKyAgICAgICAgMi40JSBzcGVlZHVw LgorCisgICAgICAgICogd3RmL0hhc2hUYWJsZS5oOgorICAgICAgICAoV1RGOjpIYXNoVGFibGU6 On5IYXNoVGFibGUpOgorICAgICAgICAoV1RGOjo6OmNsZWFyKTogRG9uJ3QgZGVhbGxvY2F0ZSB0 aGUgc3RvcmFnZSBvciBmcm9iIG1lbWJlcgorICAgICAgICB2YXJpYWJsZXMgaWYgdGhlcmUgaXMg bm8gYmFja2luZyBzdG9yYWdlLgorICAgICAgICAqIHd0Zi9WZWN0b3IuaDoKKyAgICAgICAgKFdU Rjo6VmVjdG9yQnVmZmVyQmFzZTo6ZGVhbGxvY2F0ZUJ1ZmZlcik6IExpa2V3aXNlLgorCiAyMDEy LTAyLTI4ICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxrdWJvQHByb2Z1c2lvbi5tb2JpPgogCiAg ICAgICAgIFtDTWFrZV0gQWx3YXlzIGJ1aWxkIHd0ZiBhcyBhIHN0YXRpYyBsaWJyYXJ5LgpkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9IYXNoVGFibGUuaCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS93dGYvSGFzaFRhYmxlLmgKaW5kZXggY2JjYzA5ODE3NDU4NjdiNGVkMDlh YjhlODhlNWFmMWVkNGY1NWU4Yy4uNGEwMWM3YzY1OGFjNWYwYjZjNTIzMmQ2OTJiYjQ1MzViZTQ4 MWY5YyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9IYXNoVGFibGUuaAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0hhc2hUYWJsZS5oCkBAIC0zMTAsNyArMzEw LDggQEAgbmFtZXNwYWNlIFdURiB7CiAgICAgICAgIH5IYXNoVGFibGUoKSAKICAgICAgICAgewog ICAgICAgICAgICAgaW52YWxpZGF0ZUl0ZXJhdG9ycygpOyAKLSAgICAgICAgICAgIGRlYWxsb2Nh dGVUYWJsZShtX3RhYmxlLCBtX3RhYmxlU2l6ZSk7IAorICAgICAgICAgICAgaWYgKG1fdGFibGUp CisgICAgICAgICAgICAgICAgZGVhbGxvY2F0ZVRhYmxlKG1fdGFibGUsIG1fdGFibGVTaXplKTsK ICNpZiBDSEVDS19IQVNIVEFCTEVfVVNFX0FGVEVSX0RFU1RSVUNUSU9OCiAgICAgICAgICAgICBt X3RhYmxlID0gKFZhbHVlVHlwZSopKHVpbnRwdHJfdCkweGJiYWRiZWVmOwogI2VuZGlmCkBAIC05 NzksNiArOTgwLDkgQEAgbmFtZXNwYWNlIFdURiB7CiAgICAgdm9pZCBIYXNoVGFibGU8S2V5LCBW YWx1ZSwgRXh0cmFjdG9yLCBIYXNoRnVuY3Rpb25zLCBUcmFpdHMsIEtleVRyYWl0cz46OmNsZWFy KCkKICAgICB7CiAgICAgICAgIGludmFsaWRhdGVJdGVyYXRvcnMoKTsKKyAgICAgICAgaWYgKCFt X3RhYmxlKQorICAgICAgICAgICAgcmV0dXJuOworCiAgICAgICAgIGRlYWxsb2NhdGVUYWJsZSht X3RhYmxlLCBtX3RhYmxlU2l6ZSk7CiAgICAgICAgIG1fdGFibGUgPSAwOwogICAgICAgICBtX3Rh YmxlU2l6ZSA9IDA7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1ZlY3Rv ci5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9WZWN0b3IuaAppbmRleCAyOWJiZDM3ZDkx M2MzMjhkN2QzMDAxNDEzMGZmZjI4ZjU2YjMwNjU5Li5iZjdkYzRhYTIxNjVhZTNhODgxNDY3ZDI3 NTA2MDgxNGNiOTkwZTVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1Zl Y3Rvci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvVmVjdG9yLmgKQEAgLTI4MSwx MCArMjgxLDE0IEBAIG5hbWVzcGFjZSBXVEYgewogCiAgICAgICAgIHZvaWQgZGVhbGxvY2F0ZUJ1 ZmZlcihUKiBidWZmZXJUb0RlYWxsb2NhdGUpCiAgICAgICAgIHsKKyAgICAgICAgICAgIGlmICgh YnVmZmVyVG9EZWFsbG9jYXRlKQorICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAg IAogICAgICAgICAgICAgaWYgKG1fYnVmZmVyID09IGJ1ZmZlclRvRGVhbGxvY2F0ZSkgewogICAg ICAgICAgICAgICAgIG1fYnVmZmVyID0gMDsKICAgICAgICAgICAgICAgICBtX2NhcGFjaXR5ID0g MDsKICAgICAgICAgICAgIH0KKwogICAgICAgICAgICAgZmFzdEZyZWUoYnVmZmVyVG9EZWFsbG9j YXRlKTsKICAgICAgICAgfQogCg==