79872 2012-02-28 22:22:11 -0800 perftestsrunner can call printer.write() after printer.cleanup() 2012-02-29 11:48:46 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth ojan rniwa webkit.review.bot oldest_to_newest 567376 0 dpranke 2012-02-28 22:22:11 -0800 perftestsrunner can call printer.write() after printer.cleanup() 567377 1 dpranke 2012-02-28 22:26:24 -0800 PerfTestsRunner.run() calls printer.cleanup(), and you should not call any methods on printer after cleanup(). In the unittests, we call run() twice in a row (in test_run_with_upload_json), and the second time attempts to write something. We should either not call cleanup() during run(), or reinitialize the printer during run(), or not call run() twice. I will post a patch that does the first thing, but I'm not sure if you're supposed to be able to call run() twice in a row or not. 567383 2 129391 dpranke 2012-02-28 22:28:34 -0800 Created attachment 129391 Patch 567387 3 129391 rniwa 2012-02-28 22:31:39 -0800 Comment on attachment 129391 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129391&action=review > Tools/ChangeLog:13 > + It was a fluke that this happened to work, but it is still a bug > + that should be fixed either by not calling cleanup() during > + run() or by not calling run() twice. This patch does the former. Can we take the latter approach instead? We shouldn't be calling run() twice. 567389 4 dpranke 2012-02-28 22:36:10 -0800 Sure, I'll rework it. 567392 5 129392 dpranke 2012-02-28 22:41:15 -0800 Created attachment 129392 don't call run() twice instead 567393 6 129392 dpranke 2012-02-28 22:41:45 -0800 Comment on attachment 129392 don't call run() twice instead please take another look? 567792 7 dpranke 2012-02-29 11:48:46 -0800 Committed r109235: <http://trac.webkit.org/changeset/109235> 129391 2012-02-28 22:28:34 -0800 2012-02-28 22:41:10 -0800 Patch bug-79872-20120228222837.patch text/plain 2596 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5MTYxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGE3NGZmMzc4NGViNWZiMWNmMjIxYzYxYzhiNzNlMmNl MTg4YzQzMS4uZDQ2ZTU0ZWU4NmFhOTJmZDllMzA4ZmNlYmZlMDAzNDI2ZGYyN2NlZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDEyLTAyLTI4ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIHBlcmZ0ZXN0c3J1bm5lciBjYW4gY2FsbCBwcmludGVyLndyaXRlKCkgYWZ0ZXIgcHJp bnRlci5jbGVhbnVwKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTc5ODcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUGVyZlRlc3RzUnVubmVyLnJ1bigpIGNhbGxlZCBwcmludGVyLmNsZWFudXAoKSwgd2hp Y2ggbWVhbnQKKyAgICAgICAgdGhhdCBhIHNlY29uZCBjYWxsIHRvIHJ1bigpIC0tIHdoaWNoIGhh cHBlbmVkIGluIHRoZSB1bml0IHRlc3RzCisgICAgICAgIC0tIHdvdWxkIGNhbGwgcHJpbnRlci53 cml0ZSgpIHdoZW4gaXQgd2FzIG5vdCBzdXBwb3NlZCB0byBiZSBjYWxsZWQuCisgICAgICAgIEl0 IHdhcyBhIGZsdWtlIHRoYXQgdGhpcyBoYXBwZW5lZCB0byB3b3JrLCBidXQgaXQgaXMgc3RpbGwg YSBidWcKKyAgICAgICAgdGhhdCBzaG91bGQgYmUgZml4ZWQgZWl0aGVyIGJ5IG5vdCBjYWxsaW5n IGNsZWFudXAoKSBkdXJpbmcKKyAgICAgICAgcnVuKCkgb3IgYnkgbm90IGNhbGxpbmcgcnVuKCkg dHdpY2UuIFRoaXMgcGF0Y2ggZG9lcyB0aGUgZm9ybWVyLgorCisgICAgICAgICogU2NyaXB0cy93 ZWJraXRweS9wZXJmb3JtYW5jZV90ZXN0cy9wZXJmdGVzdHNydW5uZXIucHk6CisgICAgICAgIChQ ZXJmVGVzdHNSdW5uZXIuX19kZWxfXyk6CisgICAgICAgIChQZXJmVGVzdHNSdW5uZXIpOgorICAg ICAgICAoUGVyZlRlc3RzUnVubmVyLmNsZWFudXApOgorICAgICAgICAoUGVyZlRlc3RzUnVubmVy LnJ1bik6CisKIDIwMTItMDItMjggIE1haGVzaCBLdWxrYXJuaSAgPG1haGVzaC5rdWxrYXJuaUBu b2tpYS5jb20+CiAKICAgICAgICAgW1F0XSBBbGxvdyByZWFkL3dyaXRlIHRvIHRoZSBXZWJWaWV3 LnVybCBwcm9wZXJ0eQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wZXJmb3Jt YW5jZV90ZXN0cy9wZXJmdGVzdHNydW5uZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Bl cmZvcm1hbmNlX3Rlc3RzL3BlcmZ0ZXN0c3J1bm5lci5weQppbmRleCAxODk1MDBmNmEzNjhkMWNm NjJlMTNiYmFlNzNjZjBiNzZhZDZiM2ViLi5hNzI4NGY5OGE1YTQ0ZjY0ZDQ3NDkxZjBmM2JlN2Ex YTZlMGYyNjdkIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BlcmZvcm1hbmNl X3Rlc3RzL3BlcmZ0ZXN0c3J1bm5lci5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Bl cmZvcm1hbmNlX3Rlc3RzL3BlcmZ0ZXN0c3J1bm5lci5weQpAQCAtNjgsNiArNjgsMTQgQEAgY2xh c3MgUGVyZlRlc3RzUnVubmVyKG9iamVjdCk6CiAgICAgICAgIHNlbGYuX3Jlc3VsdHMgPSB7fQog ICAgICAgICBzZWxmLl90aW1lc3RhbXAgPSB0aW1lLnRpbWUoKQogCisgICAgZGVmIF9fZGVsX18o c2VsZik6CisgICAgICAgIHNlbGYuY2xlYW51cCgpCisKKyAgICBkZWYgY2xlYW51cChzZWxmKToK KyAgICAgICAgaWYgc2VsZi5fcHJpbnRlcjoKKyAgICAgICAgICAgIHNlbGYuX3ByaW50ZXIuY2xl YW51cCgpCisgICAgICAgICAgICBzZWxmLl9wcmludGVyID0gTm9uZQorCiAgICAgQHN0YXRpY21l dGhvZAogICAgIGRlZiBfcGFyc2VfYXJncyhhcmdzPU5vbmUpOgogICAgICAgICBwcmludF9vcHRp b25zID0gcHJpbnRpbmcucHJpbnRfb3B0aW9ucygpCkBAIC0xMzQsMTEgKzE0Miw4IEBAIGNsYXNz IFBlcmZUZXN0c1J1bm5lcihvYmplY3QpOgogICAgICAgICAjIFdlIHdyYXAgYW55IHBhcnRzIG9m IHRoZSBydW4gdGhhdCBhcmUgc2xvdyBvciBsaWtlbHkgdG8gcmFpc2UgZXhjZXB0aW9ucwogICAg ICAgICAjIGluIGEgdHJ5L2ZpbmFsbHkgdG8gZW5zdXJlIHRoYXQgd2UgY2xlYW4gdXAgdGhlIGxv Z2dpbmcgY29uZmlndXJhdGlvbi4KICAgICAgICAgdW5leHBlY3RlZCA9IC0xCi0gICAgICAgIHRy eToKLSAgICAgICAgICAgIHRlc3RzID0gc2VsZi5fY29sbGVjdF90ZXN0cygpCi0gICAgICAgICAg ICB1bmV4cGVjdGVkID0gc2VsZi5fcnVuX3Rlc3RzX3NldChzb3J0ZWQobGlzdCh0ZXN0cykpLCBz ZWxmLl9wb3J0KQotICAgICAgICBmaW5hbGx5OgotICAgICAgICAgICAgc2VsZi5fcHJpbnRlci5j bGVhbnVwKCkKKyAgICAgICAgdGVzdHMgPSBzZWxmLl9jb2xsZWN0X3Rlc3RzKCkKKyAgICAgICAg dW5leHBlY3RlZCA9IHNlbGYuX3J1bl90ZXN0c19zZXQoc29ydGVkKGxpc3QodGVzdHMpKSwgc2Vs Zi5fcG9ydCkKIAogICAgICAgICBvcHRpb25zID0gc2VsZi5fb3B0aW9ucwogICAgICAgICBpZiBz ZWxmLl9vcHRpb25zLm91dHB1dF9qc29uX3BhdGg6Cg== 129392 2012-02-28 22:41:15 -0800 2012-02-28 23:22:33 -0800 don't call run() twice instead bug-79872-20120228224117.patch text/plain 1821 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5MTYxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGE3NGZmMzc4NGViNWZiMWNmMjIxYzYxYzhiNzNlMmNl MTg4YzQzMS4uOWZkZGNhMWIwOWY4ZDJjYzVkNmZjMWU3NzA2NWI4NWQ3NTkyNmI4NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTAyLTI4ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIHBlcmZ0ZXN0c3J1bm5lciBjYW4gY2FsbCBwcmludGVyLndyaXRlKCkgYWZ0ZXIgcHJp bnRlci5jbGVhbnVwKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTc5ODcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGhpcyBwYXRjaCBmaXhlcyBhIHVuaXR0ZXN0IHRoYXQgd2FzIGluY29ycmVjdGx5IGNh bGxpbmcKKyAgICAgICAgUGVyZlRlc3RzUnVubmVyLnJ1bigpIHR3aWNlICh3aGljaCBsZWQgdG8g YSB3ZWlyZCBzdGF0ZSBpbiB0aGUKKyAgICAgICAgcHJpbnRlciBvYmplY3QpLgorCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9wZXJmb3JtYW5jZV90ZXN0cy9wZXJmdGVzdHNydW5uZXJfdW5p dHRlc3QucHk6CisgICAgICAgIChNYWluVGVzdC50ZXN0X3J1bl93aXRoX3VwbG9hZF9qc29uKToK KwogMjAxMi0wMi0yOCAgTWFoZXNoIEt1bGthcm5pICA8bWFoZXNoLmt1bGthcm5pQG5va2lhLmNv bT4KIAogICAgICAgICBbUXRdIEFsbG93IHJlYWQvd3JpdGUgdG8gdGhlIFdlYlZpZXcudXJsIHBy b3BlcnR5CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BlcmZvcm1hbmNlX3Rl c3RzL3BlcmZ0ZXN0c3J1bm5lcl91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv cGVyZm9ybWFuY2VfdGVzdHMvcGVyZnRlc3RzcnVubmVyX3VuaXR0ZXN0LnB5CmluZGV4IGUxOTQw NzJjM2YzYzk3YWExMzg3ODE3MWQwMWE5NTNjMGJkMWQ0NDAuLmNkYmNhZGVlOTQ0MWYwNTVkNjhl MTllNzU1NzZlYzY1MTZiNDQ0ODMgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv cGVyZm9ybWFuY2VfdGVzdHMvcGVyZnRlc3RzcnVubmVyX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvcGVyZm9ybWFuY2VfdGVzdHMvcGVyZnRlc3RzcnVubmVyX3VuaXR0 ZXN0LnB5CkBAIC0yODAsNiArMjgwLDEwIEBAIG1heCAxMTIwCiAgICAgICAgIHNlbGYuYXNzZXJ0 RXF1YWwoZ2VuZXJhdGVkX2pzb25bJ2J1aWxkZXItbmFtZSddLCAnYnVpbGRlcjEnKQogICAgICAg ICBzZWxmLmFzc2VydEVxdWFsKGdlbmVyYXRlZF9qc29uWydidWlsZC1udW1iZXInXSwgMTIzKQog ICAgICAgICB1cGxvYWRfanNvbl9yZXR1cm5zX3RydWUgPSBGYWxzZQorCisgICAgICAgIHJ1bm5l ciA9IHNlbGYuY3JlYXRlX3J1bm5lcihhcmdzPVsnLS1vdXRwdXQtanNvbi1wYXRoPS9tb2NrLWNo ZWNrb3V0L291dHB1dC5qc29uJywKKyAgICAgICAgICAgICctLXRlc3QtcmVzdWx0cy1zZXJ2ZXIn LCAnc29tZS5ob3N0JywgJy0tcGxhdGZvcm0nLCAncGxhdGZvcm0xJywgJy0tYnVpbGRlci1uYW1l JywgJ2J1aWxkZXIxJywgJy0tYnVpbGQtbnVtYmVyJywgJzEyMyddKQorICAgICAgICBydW5uZXIu X3VwbG9hZF9qc29uID0gbW9ja191cGxvYWRfanNvbgogICAgICAgICBzZWxmLmFzc2VydEVxdWFs KHJ1bm5lci5ydW4oKSwgLTMpCiAKICAgICBkZWYgdGVzdF91cGxvYWRfanNvbihzZWxmKToK