79866 2012-02-28 21:42:35 -0800 [BlackBerry]Make about:cache feature available in release version. 2012-02-29 20:20:48 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 jasonliuwebkit webkit-unassigned charles.wei dbates jasonliuwebkit jrogers leo.yang staikos webkit.review.bot oldest_to_newest 567359 0 jasonliuwebkit 2012-02-28 21:42:35 -0800 Make about:cache feature available in release version. 567363 1 129386 jasonliuwebkit 2012-02-28 21:59:02 -0800 Created attachment 129386 Patch 567407 2 129396 jasonliuwebkit 2012-02-28 23:10:50 -0800 Created attachment 129396 Patch 568042 3 jrogers 2012-02-29 15:59:47 -0800 I don't see any changes in both patches, the diffs are identical. Shouldn't we just be removing the entire ifdef line altogether? 568174 4 jasonliuwebkit 2012-02-29 18:23:44 -0800 (In reply to comment #3) > I don't see any changes in both patches, the diffs are identical. Shouldn't we just be removing the entire ifdef line altogether? We need to move "#if !defined(PUBLIC_BUILD) || !PUBLIC_BUILD" down several lines to make about:cache work for release version. I made the second patch to replace the tab with space in the first one. 568208 5 jrogers 2012-02-29 18:35:32 -0800 (In reply to comment #4) > (In reply to comment #3) > > I don't see any changes in both patches, the diffs are identical. Shouldn't we just be removing the entire ifdef line altogether? > > We need to move "#if !defined(PUBLIC_BUILD) || !PUBLIC_BUILD" down several lines to make about:cache work for release version. > > I made the second patch to replace the tab with space in the first one. My mistake, I realized after that you moved it. LGTM. 568253 6 129396 tonikitoo 2012-02-29 19:50:45 -0800 Comment on attachment 129396 Patch ja 568278 7 129396 webkit.review.bot 2012-02-29 20:20:40 -0800 Comment on attachment 129396 Patch Clearing flags on attachment: 129396 Committed r109301: <http://trac.webkit.org/changeset/109301> 568279 8 webkit.review.bot 2012-02-29 20:20:48 -0800 All reviewed patches have been landed. Closing bug. 129386 2012-02-28 21:59:02 -0800 2012-02-28 23:10:37 -0800 Patch bug-79866-20120229135900.patch text/plain 1946 jasonliuwebkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5MDU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTEzOGQ0YTQyZGE5MmNk ODBhYmMwMjQ4NWM1MTA4YTA1YTBmZDhmMy4uZmJkMDg5NTk2ZmFhZmE0NTMwNTRjNWVlNWRkMjNh NWE0NDM2MmRiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAyLTI4ICBKYXNv biBMaXUgIDxqYXNvbi5saXVAdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja0Jl cnJ5XU1ha2UgYWJvdXQ6Y2FjaGUgZmVhdHVyZSBhdmFpbGFibGUgaW4gcmVsZWFzZSB2ZXJzaW9u LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzk4NjYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAg IE5vIHRlc3RzLgorICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3Jr Sm9iLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5ldHdvcmtKb2I6OmhhbmRsZUFib3V0KToKKwog MjAxMi0wMi0yNyAgQWRhbSBLbGVpbiAgPGFkYW1rQGNocm9taXVtLm9yZz4KIAogICAgICAgICBB bHdheXMgbm90aWZ5IHN1YnRyZWUgb2YgcmVtb3ZhbCBpbiBDb250YWluZXJOb2RlOjpyZW1vdmVD aGlsZHJlbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFj a2JlcnJ5L05ldHdvcmtKb2IuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9i bGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwCmluZGV4IDI5MTM0NzU3YWQ4MTUzNzg4OTc5ZDJkNTI0 MzZlMmI4ODI1OTc0NjguLjVjZDk1MjdmN2RjMDljM2MwYmE5YmMzZjIwNWE2NmY5MDFjMDdhNzMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9O ZXR3b3JrSm9iLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNr YmVycnkvTmV0d29ya0pvYi5jcHAKQEAgLTkxMSw3ICs5MTEsNiBAQCB2b2lkIE5ldHdvcmtKb2I6 OmhhbmRsZUFib3V0KCkKICAgICAgICAgcmVzdWx0LmFwcGVuZChTdHJpbmcoQmxhY2tCZXJyeTo6 UGxhdGZvcm06OldFQktJVENSRURJVFMpKTsKICAgICAgICAgcmVzdWx0LmFwcGVuZChTdHJpbmco IjwvYm9keT48L2h0bWw+IikpOwogICAgICAgICBoYW5kbGVkID0gdHJ1ZTsKLSNpZiAhZGVmaW5l ZChQVUJMSUNfQlVJTEQpIHx8ICFQVUJMSUNfQlVJTEQKICAgICB9IGVsc2UgaWYgKGFib3V0V2hh dC5zdGFydHNXaXRoKCJjYWNoZT9xdWVyeT0iLCBmYWxzZSkpIHsKICAgICAgICAgQmxhY2tCZXJy eTo6UGxhdGZvcm06OkNsaWVudCogY2xpZW50ID0gQmxhY2tCZXJyeTo6UGxhdGZvcm06OkNsaWVu dDo6Z2V0KCk7CiAgICAgICAgIEFTU0VSVChjbGllbnQpOwpAQCAtOTI5LDYgKzkyOCw3IEBAIHZv aWQgTmV0d29ya0pvYjo6aGFuZGxlQWJvdXQoKQogICAgICAgICByZXN1bHQuYXBwZW5kKFN0cmlu ZyhjbGllbnQtPmdlbmVyYXRlSHRtbEZyYWdtZW50Rm9yQ2FjaGVLZXlzKCkuZGF0YSgpKSk7CiAg ICAgICAgIHJlc3VsdC5hcHBlbmQoU3RyaW5nKCI8L2JvZHk+PC9odG1sPiIpKTsKICAgICAgICAg aGFuZGxlZCA9IHRydWU7CisjaWYgIWRlZmluZWQoUFVCTElDX0JVSUxEKSB8fCAhUFVCTElDX0JV SUxECiAgICAgfSBlbHNlIGlmIChlcXVhbElnbm9yaW5nQ2FzZShhYm91dFdoYXQsICJjYWNoZS9k aXNhYmxlIikpIHsKICAgICAgICAgQmxhY2tCZXJyeTo6UGxhdGZvcm06OkNsaWVudCogY2xpZW50 ID0gQmxhY2tCZXJyeTo6UGxhdGZvcm06OkNsaWVudDo6Z2V0KCk7CiAgICAgICAgIEFTU0VSVChj bGllbnQpOwo= 129396 2012-02-28 23:10:50 -0800 2012-02-29 20:20:40 -0800 Patch bug-79866-20120229151047.patch text/plain 1938 jasonliuwebkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5MDU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTEzOGQ0YTQyZGE5MmNk ODBhYmMwMjQ4NWM1MTA4YTA1YTBmZDhmMy4uMjM1NDZkYTdlNjMzYzkwYTVkZDFhZGZmNzNkOTU5 ZjFjMjA1NDNlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAyLTI4ICBKYXNv biBMaXUgIDxqYXNvbi5saXVAdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja0Jl cnJ5XU1ha2UgYWJvdXQ6Y2FjaGUgZmVhdHVyZSBhdmFpbGFibGUgaW4gcmVsZWFzZSB2ZXJzaW9u LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzk4NjYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyB0ZXN0 cy4KKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpOZXR3b3JrSm9iOjpoYW5kbGVBYm91dCk6CisKIDIwMTItMDIt MjcgIEFkYW0gS2xlaW4gIDxhZGFta0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQWx3YXlzIG5v dGlmeSBzdWJ0cmVlIG9mIHJlbW92YWwgaW4gQ29udGFpbmVyTm9kZTo6cmVtb3ZlQ2hpbGRyZW4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9O ZXR3b3JrSm9iLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJy eS9OZXR3b3JrSm9iLmNwcAppbmRleCAyOTEzNDc1N2FkODE1Mzc4ODk3OWQyZDUyNDM2ZTJiODgy NTk3NDY4Li41Y2Q5NTI3ZjdkYzA5YzNjMGJhOWJjM2YyMDVhNjZmOTAxYzA3YTczIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pv Yi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05l dHdvcmtKb2IuY3BwCkBAIC05MTEsNyArOTExLDYgQEAgdm9pZCBOZXR3b3JrSm9iOjpoYW5kbGVB Ym91dCgpCiAgICAgICAgIHJlc3VsdC5hcHBlbmQoU3RyaW5nKEJsYWNrQmVycnk6OlBsYXRmb3Jt OjpXRUJLSVRDUkVESVRTKSk7CiAgICAgICAgIHJlc3VsdC5hcHBlbmQoU3RyaW5nKCI8L2JvZHk+ PC9odG1sPiIpKTsKICAgICAgICAgaGFuZGxlZCA9IHRydWU7Ci0jaWYgIWRlZmluZWQoUFVCTElD X0JVSUxEKSB8fCAhUFVCTElDX0JVSUxECiAgICAgfSBlbHNlIGlmIChhYm91dFdoYXQuc3RhcnRz V2l0aCgiY2FjaGU/cXVlcnk9IiwgZmFsc2UpKSB7CiAgICAgICAgIEJsYWNrQmVycnk6OlBsYXRm b3JtOjpDbGllbnQqIGNsaWVudCA9IEJsYWNrQmVycnk6OlBsYXRmb3JtOjpDbGllbnQ6OmdldCgp OwogICAgICAgICBBU1NFUlQoY2xpZW50KTsKQEAgLTkyOSw2ICs5MjgsNyBAQCB2b2lkIE5ldHdv cmtKb2I6OmhhbmRsZUFib3V0KCkKICAgICAgICAgcmVzdWx0LmFwcGVuZChTdHJpbmcoY2xpZW50 LT5nZW5lcmF0ZUh0bWxGcmFnbWVudEZvckNhY2hlS2V5cygpLmRhdGEoKSkpOwogICAgICAgICBy ZXN1bHQuYXBwZW5kKFN0cmluZygiPC9ib2R5PjwvaHRtbD4iKSk7CiAgICAgICAgIGhhbmRsZWQg PSB0cnVlOworI2lmICFkZWZpbmVkKFBVQkxJQ19CVUlMRCkgfHwgIVBVQkxJQ19CVUlMRAogICAg IH0gZWxzZSBpZiAoZXF1YWxJZ25vcmluZ0Nhc2UoYWJvdXRXaGF0LCAiY2FjaGUvZGlzYWJsZSIp KSB7CiAgICAgICAgIEJsYWNrQmVycnk6OlBsYXRmb3JtOjpDbGllbnQqIGNsaWVudCA9IEJsYWNr QmVycnk6OlBsYXRmb3JtOjpDbGllbnQ6OmdldCgpOwogICAgICAgICBBU1NFUlQoY2xpZW50KTsK