79864 2012-02-28 21:10:20 -0800 RefCounted::deprecatedTurnOfVerifier() should not be deprecated 2012-02-29 16:15:26 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo webkit-unassigned oldest_to_newest 567348 0 fpizlo 2012-02-28 21:10:20 -0800 It is necessary to call this in the constructor of many objects in JavaScriptCore, because JavaScriptCore objects may be used from multiple threads even if the reference counting is done in a racy manner. This is because a JSC instance may be used from multiple threads so long as all accesses into that instance are protected by a per-instance lock. It would be absolutely wrong to prohibit this pattern, and it would be a disastrous regression to requite that the objects within that instance use a thread-safe version of reference counting. Hence the notion that this method should be deprecated is entirely misguided until a credible, low-overhead verifier is implemented, which can understand JavaScriptCore's well-designed thread safety patterns while also not created confusing noise in our code base. 567382 1 129390 fpizlo 2012-02-28 22:28:18 -0800 Created attachment 129390 the patch 568064 2 fpizlo 2012-02-29 16:15:26 -0800 Landed in http://trac.webkit.org/changeset/109268 129390 2012-02-28 22:28:18 -0800 2012-02-29 09:36:18 -0800 the patch dedeprecate_patch_1.diff text/plain 4330 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTA5MTg5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBA CisyMDEyLTAyLTI4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg UmVmQ291bnRlZDo6ZGVwcmVjYXRlZFR1cm5PZlZlcmlmaWVyKCkgc2hvdWxkIG5vdCBiZSBkZXBy ZWNhdGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03 OTg2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAg ICAgICAgUmVtb3ZlZCB0aGUgd29yZCAiZGVwcmVjYXRlZCIgZnJvbSB0aGUgbmFtZSBvZiB0aGlz IG1ldGhvZCwgc2luY2UgdGhpcyBtZXRob2QKKyAgICAgICAgc2hvdWxkIG5vdCBiZSBkZXByZWNh dGVkLiBJdCB3b3JrcyBqdXN0IGZpbmUgYXMgaXQgaXMsIGFuZCB0aGVyZSBpcyBzaW1wbHkgbm8K KyAgICAgICAgYWx0ZXJuYXRpdmUgdG8gY2FsbGluZyB0aGlzIG1ldGhvZCBmb3IgbWFueSBpbnRl cmVzdGluZyBKU0MgY2xhc3Nlcy4KKworICAgICAgICAqIHBhcnNlci9Tb3VyY2VQcm92aWRlci5o OgorICAgICAgICAoSlNDOjpTb3VyY2VQcm92aWRlcjo6U291cmNlUHJvdmlkZXIpOgorICAgICAg ICAqIHJ1bnRpbWUvU3ltYm9sVGFibGUuaDoKKyAgICAgICAgKEpTQzo6U2hhcmVkU3ltYm9sVGFi bGU6OlNoYXJlZFN5bWJvbFRhYmxlKToKKyAgICAgICAgKiB3dGYvTWV0YUFsbG9jYXRvci5jcHA6 CisgICAgICAgIChXVEY6Ok1ldGFBbGxvY2F0b3JIYW5kbGU6Ok1ldGFBbGxvY2F0b3JIYW5kbGUp OgorICAgICAgICAoV1RGOjpNZXRhQWxsb2NhdG9yOjphbGxvY2F0ZSk6CisgICAgICAgICogd3Rm L1JlZkNvdW50ZWQuaDoKKyAgICAgICAgKFJlZkNvdW50ZWRCYXNlKToKKyAgICAgICAgKFdURjo6 UmVmQ291bnRlZEJhc2U6OnR1cm5PZmZWZXJpZmllcik6CisKIDIwMTItMDItMjggIEdhdmluIEJh cnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIFtbR2V0XV0vW1tQ dXRdXSBmb3IgcHJpbWl0aXZlcyBzaG91bGQgbm90IHdyYXAgb24gc3RyaWN0IGFjY2Vzc29yIGNh bGwKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvU291cmNlUHJvdmlkZXIuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1NvdXJjZVByb3ZpZGVy LmgJKHJldmlzaW9uIDEwOTE3MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvU291 cmNlUHJvdmlkZXIuaAkod29ya2luZyBjb3B5KQpAQCAtNDcsNyArNDcsNyBAQCBuYW1lc3BhY2Ug SlNDIHsKICAgICAgICAgICAgICwgbV9jYWNoZShjYWNoZSA/IGNhY2hlIDogbmV3IFNvdXJjZVBy b3ZpZGVyQ2FjaGUpCiAgICAgICAgICAgICAsIG1fY2FjaGVPd25lZCghY2FjaGUpCiAgICAgICAg IHsKLSAgICAgICAgICAgIGRlcHJlY2F0ZWRUdXJuT2ZmVmVyaWZpZXIoKTsKKyAgICAgICAgICAg IHR1cm5PZmZWZXJpZmllcigpOwogICAgICAgICB9CiAgICAgICAgIHZpcnR1YWwgflNvdXJjZVBy b3ZpZGVyKCkKICAgICAgICAgewpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv U3ltYm9sVGFibGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9TeW1ib2xUYWJsZS5oCShyZXZpc2lvbiAxMDkxNzApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9TeW1ib2xUYWJsZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMjUsNyArMTI1LDcg QEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgcHVibGljOgogICAgICAgICBzdGF0aWMgUGFzc1JlZlB0 cjxTaGFyZWRTeW1ib2xUYWJsZT4gY3JlYXRlKCkgeyByZXR1cm4gYWRvcHRSZWYobmV3IFNoYXJl ZFN5bWJvbFRhYmxlKTsgfQogICAgIHByaXZhdGU6Ci0gICAgICAgIFNoYXJlZFN5bWJvbFRhYmxl KCkgeyBkZXByZWNhdGVkVHVybk9mZlZlcmlmaWVyKCk7IH0KKyAgICAgICAgU2hhcmVkU3ltYm9s VGFibGUoKSB7IHR1cm5PZmZWZXJpZmllcigpOyB9CiAgICAgfTsKICAgICAKIH0gLy8gbmFtZXNw YWNlIEpTQwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9NZXRhQWxsb2NhdG9yLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL01ldGFBbGxvY2F0b3Iu Y3BwCShyZXZpc2lvbiAxMDkxNzApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL01ldGFB bGxvY2F0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NCw2ICs2NCw3IEBAIE1ldGFBbGxvY2F0 b3JIYW5kbGU6Ok1ldGFBbGxvY2F0b3JIYW5kbGUKICAgICBBU1NFUlQoYWxsb2NhdG9yKTsKICAg ICBBU1NFUlQoc3RhcnQpOwogICAgIEFTU0VSVChzaXplSW5CeXRlcyk7CisgICAgdHVybk9mZlZl cmlmaWVyKCk7CiB9CiAKIE1ldGFBbGxvY2F0b3JIYW5kbGU6On5NZXRhQWxsb2NhdG9ySGFuZGxl KCkKQEAgLTE2OSw4ICsxNzAsNiBAQCBQYXNzUmVmUHRyPE1ldGFBbGxvY2F0b3JIYW5kbGU+IE1l dGFBbGxvCiAjZW5kaWYKIAogICAgIE1ldGFBbGxvY2F0b3JIYW5kbGUqIGhhbmRsZSA9IG5ldyBN ZXRhQWxsb2NhdG9ySGFuZGxlKHRoaXMsIHN0YXJ0LCBzaXplSW5CeXRlcywgb3duZXJVSUQpOwot ICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQgYSB2ZXJpZmllciBzY2hlbWUgdGhhdCBncm9rcyBNZXRh QWxsb2NhdG9ySGFuZGxlcwotICAgIGhhbmRsZS0+ZGVwcmVjYXRlZFR1cm5PZmZWZXJpZmllcigp OwogCiAgICAgaWYgKFVOTElLRUxZKCEhbV90cmFja2VyKSkKICAgICAgICAgbV90cmFja2VyLT5u b3RpZnkoaGFuZGxlKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUmVmQ291bnRl ZC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUmVmQ291bnRlZC5o CShyZXZpc2lvbiAxMDkxNzApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1JlZkNvdW50 ZWQuaAkod29ya2luZyBjb3B5KQpAQCAtNzcsOCArNzcsMTUgQEAgcHVibGljOgogCiAgICAgLy8g VHVybnMgb2ZmIHZlcmlmaWNhdGlvbi4gVXNlIG9mIHRoaXMgbWV0aG9kIGlzIGRpc2NvdXJhZ2Vk IChpbnN0ZWFkIGV4dGVuZAogICAgIC8vIFRocmVhZFJlc3RyaWN0aW9uVmVyaWZpZXIgdG8gdmVy aWZ5IHlvdXIgY2FzZSkuCi0gICAgLy8gRklYTUU6IHJlbW92ZSB0aGlzIG1ldGhvZC4KLSAgICB2 b2lkIGRlcHJlY2F0ZWRUdXJuT2ZmVmVyaWZpZXIoKQorICAgIC8vIE5CLiBJdCBpcyBuZWNlc3Nh cnkgdG8gY2FsbCB0aGlzIGluIHRoZSBjb25zdHJ1Y3RvciBvZiBtYW55IG9iamVjdHMgaW4KKyAg ICAvLyBKYXZhU2NyaXB0Q29yZSwgYmVjYXVzZSBKYXZhU2NyaXB0Q29yZSBvYmplY3RzIG1heSBi ZSB1c2VkIGZyb20gbXVsdGlwbGUKKyAgICAvLyB0aHJlYWRzIGV2ZW4gaWYgdGhlIHJlZmVyZW5j ZSBjb3VudGluZyBpcyBkb25lIGluIGEgcmFjeSBtYW5uZXIuIFRoaXMgaXMKKyAgICAvLyBiZWNh dXNlIGEgSlNDIGluc3RhbmNlIG1heSBiZSB1c2VkIGZyb20gbXVsdGlwbGUgdGhyZWFkcyBzbyBs b25nIGFzIGFsbAorICAgIC8vIGFjY2Vzc2VzIGludG8gdGhhdCBpbnN0YW5jZSBhcmUgcHJvdGVj dGVkIGJ5IGEgcGVyLWluc3RhbmNlIGxvY2suIEl0IHdvdWxkCisgICAgLy8gYmUgYWJzb2x1dGVs eSB3cm9uZyB0byBwcm9oaWJpdCB0aGlzIHBhdHRlcm4sIGFuZCBpdCB3b3VsZCBiZSBhIGRpc2Fz dHJvdXMKKyAgICAvLyByZWdyZXNzaW9uIHRvIHJlcXVpcmUgdGhhdCB0aGUgb2JqZWN0cyB3aXRo aW4gdGhhdCBpbnN0YW5jZSB1c2UgYSB0aHJlYWQtCisgICAgLy8gc2FmZSB2ZXJzaW9uIG9mIHJl ZmVyZW5jZSBjb3VudGluZy4KKyAgICB2b2lkIHR1cm5PZmZWZXJpZmllcigpCiAgICAgewogI2lm bmRlZiBOREVCVUcKICAgICAgICAgbV92ZXJpZmllci50dXJuT2ZmVmVyaWZpY2F0aW9uKCk7Cg==