<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>79858</bug_id>
          
          <creation_ts>2012-02-28 19:11:05 -0800</creation_ts>
          <short_desc>The way we invalidate high accuracy geolocation listener is incorrect</short_desc>
          <delta_ts>2012-05-21 12:08:47 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>41341</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Benjamin Poulain">benjamin</reporter>
          <assigned_to name="Benjamin Poulain">benjamin</assigned_to>
          <cc>ap</cc>
    
    <cc>steveblock</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>567326</commentid>
    <comment_count>0</comment_count>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2012-02-28 19:11:05 -0800</bug_when>
    <thetext>Add a high accuracy
Add a non-high accuracy
Remove the high accuracy
--&gt;we stay in high accuracy

The problem is we have one client for all the controller, and the controller assume its client manage setEnableHighAccuracy per controller:

void GeolocationController::removeObserver(Geolocation* observer)
{
    if (!m_observers.contains(observer))
        return;

    m_observers.remove(observer);
    m_highAccuracyObservers.remove(observer);

    if (m_client) {
        if (m_observers.isEmpty())
            m_client-&gt;stopUpdating();
        else if (m_highAccuracyObservers.isEmpty())
            m_client-&gt;setEnableHighAccuracy(false);
    }
}</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>567795</commentid>
    <comment_count>1</comment_count>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2012-02-29 11:50:36 -0800</bug_when>
    <thetext>&lt;rdar://problem/10951749&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>629227</commentid>
    <comment_count>2</comment_count>
    <who name="Steve Block">steveblock</who>
    <bug_when>2012-05-21 10:13:59 -0700</bug_when>
    <thetext>&gt; The problem is we have one client for all the controller, and the controller
&gt; assume its client manage setEnableHighAccuracy per controller:
Do you mean that you&apos;re sharing a single implementation of GeolocationClient between all GeolocationController instances? That would be a port-specific bug. Is this on Mac?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>629235</commentid>
    <comment_count>3</comment_count>
    <who name="Steve Block">steveblock</who>
    <bug_when>2012-05-21 10:24:03 -0700</bug_when>
    <thetext>Having re-read this bug, I think you&apos;re referring to the problem in Bug 41341 ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>629355</commentid>
    <comment_count>4</comment_count>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2012-05-21 12:08:47 -0700</bug_when>
    <thetext>Yep. I close this bug as duplicate.

*** This bug has been marked as a duplicate of bug 41341 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>