79852 2012-02-28 17:51:53 -0800 Optimize the rects being drawn into compositing layers 2012-11-28 16:56:58 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser dino mitz simon.fraser thorton oldest_to_newest 567287 0 simon.fraser 2012-02-28 17:51:53 -0800 We should make sure that we're not drawing more than necessary in composting layers because of rect coalescing. 567301 1 129370 simon.fraser 2012-02-28 18:14:09 -0800 Created attachment 129370 Patch 567319 2 129370 mitz 2012-02-28 18:49:12 -0800 Comment on attachment 129370 Patch In drawRect: we examine the total area of all texts and do a single paint if they cover a sufficiently large fraction of the clip bounds. I wonder if we don't need something similar here. 567320 3 mitz 2012-02-28 18:50:24 -0800 s/texts/rects/. 567339 4 simon.fraser 2012-02-28 20:19:19 -0800 I wonder that too. I'll look to see if CA does that already. 567345 5 simon.fraser 2012-02-28 20:47:50 -0800 http://trac.webkit.org/changeset/109186 778493 6 simon.fraser 2012-11-28 16:52:34 -0800 <rdar://problem/9082399> 778498 7 simon.fraser 2012-11-28 16:56:58 -0800 This change was made to help http://ie.microsoft.com/testdrive/performance/mazesolver/default.html performance. 129370 2012-02-28 18:14:09 -0800 2012-02-28 18:49:11 -0800 Patch bug-79852-20120228181409.patch text/plain 2553 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5MTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzQyMDk1OTkxNGFiODVh ZmYyOWUwY2JmNGNkNmE5YTUwMzJmMzI2NC4uYWUzZmZjYWYzNTc3ZDFjYmFkZTdhZjkxYTkwMDRh M2U5MzRiZDI1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEyLTAyLTI4ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCisgICAgICAgIE9wdGltaXplIHRo ZSByZWN0cyBiZWluZyBkcmF3biBpbnRvIGNvbXBvc2l0aW5nIGxheWVycworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzk4NTIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgdGhlIG5ld2x5IGFkZGVkIFdl YktpdFN5c3RlbUludGVyZmFjZSBtZXRob2QKKyAgICAgICAgdG8gbGltaXQgdGhlIGFyZWEgYmVp bmcgcGFpbnRlZCBpbiBhIENBTGF5ZXIKKyAgICAgICAgLWRyYXdJbkNvbnRleHQgY2FsbGJhY2su IFRoaXMgYXZvaWRzIHJlZHVuZGFudCBkcmF3aW5nLAorICAgICAgICBmb3IgcGVyZm9ybWFuY2Uu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9tYWMvV2ViTGF5ZXIubW06CisgICAgICAg IChkcmF3TGF5ZXJDb250ZW50cyk6CisKKzIwMTItMDItMjggIFNpbW9uIEZyYXNlciAgPHNpbW9u LmZyYXNlckBhcHBsZS5jb20+CisKICAgICAgICAgVXBkYXRlIFdlYktpdFN5c3RlbUludGVyZmFj ZS4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL1dlYkxheWVyLm1tIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL1dlYkxheWVyLm1tCmluZGV4IDI3NzEwNDE0ODg5MzZj YzMyODk5MDg1ZTBmNWU1OWZiOTVkYTM3YTQuLmYzNThjZjUxNDk5YmRmNjEyYTBkNDU2MThhYTg1 ODFjMGI4ODgzNDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L21hYy9XZWJMYXllci5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9t YWMvV2ViTGF5ZXIubW0KQEAgLTM1LDYgKzM1LDcgQEAKICNpbXBvcnQgPG9iamMvb2JqYy1ydW50 aW1lLmg+CiAjaW1wb3J0IDxRdWFydHpDb3JlL1F1YXJ0ekNvcmUuaD4KICNpbXBvcnQgPHd0Zi9V bnVzZWRQYXJhbS5oPgorI2ltcG9ydCAiV2ViQ29yZVN5c3RlbUludGVyZmFjZS5oIgogCiBAaW50 ZXJmYWNlIENBTGF5ZXIoV2ViQ29yZUNBTGF5ZXJQcml2YXRlKQogLSAodm9pZClyZWxvYWRWYWx1 ZUZvcktleVBhdGg6KE5TU3RyaW5nICopa2V5UGF0aDsKQEAgLTc2LDkgKzc3LDI0IEBAIHZvaWQg ZHJhd0xheWVyQ29udGVudHMoQ0dDb250ZXh0UmVmIGNvbnRleHQsIENBTGF5ZXIgKmxheWVyLCBX ZWJDb3JlOjpQbGF0Zm9ybUNBCiAgICAgCiAgICAgLy8gSXQncyBpbXBvcnRhbnQgdG8gZ2V0IHRo ZSBjbGlwIGZyb20gdGhlIGNvbnRleHQsIGJlY2F1c2UgaXQgbWF5IGJlIHNpZ25pZmljYW50bHkK ICAgICAvLyBzbWFsbGVyIHRoYW4gdGhlIGxheWVyIGJvdW5kcyAoZS5nLiB0aWxlZCBsYXllcnMp Ci0gICAgQ0dSZWN0IGNsaXBCb3VuZHMgPSBDR0NvbnRleHRHZXRDbGlwQm91bmRpbmdCb3goY29u dGV4dCk7Ci0gICAgSW50UmVjdCBjbGlwKGVuY2xvc2luZ0ludFJlY3QoY2xpcEJvdW5kcykpOwor ICAgIEZsb2F0UmVjdCBjbGlwQm91bmRzID0gQ0dDb250ZXh0R2V0Q2xpcEJvdW5kaW5nQm94KGNv bnRleHQpOworCisjaWYgIWRlZmluZWQoQlVJTERJTkdfT05fU05PV19MRU9QQVJEKQorICAgIF9f YmxvY2sgR3JhcGhpY3NDb250ZXh0KiBjdHggPSAmZ3JhcGhpY3NDb250ZXh0OworCisgICAgd2tD QUxheWVyRW51bWVyYXRlUmVjdHNCZWluZ0RyYXduV2l0aEJsb2NrKGxheWVyLCBjb250ZXh0LCBe KENHUmVjdCByZWN0KXsKKyAgICAgICAgRmxvYXRSZWN0IHJlY3RCZWluZ0RyYXduKHJlY3QpOwor ICAgICAgICByZWN0QmVpbmdEcmF3bi5pbnRlcnNlY3QoY2xpcEJvdW5kcyk7CisgICAgICAgIAor ICAgICAgICBHcmFwaGljc0NvbnRleHRTdGF0ZVNhdmVyIHN0YXRlU2F2ZXIoKmN0eCk7CisgICAg ICAgIGN0eC0+Y2xpcChyZWN0QmVpbmdEcmF3bik7CisgICAgICAgIAorICAgICAgICBsYXllckNv bnRlbnRzLT5wbGF0Zm9ybUNBTGF5ZXJQYWludENvbnRlbnRzKCpjdHgsIGVuY2xvc2VkSW50UmVj dChyZWN0QmVpbmdEcmF3bikpOworICAgIH0pOworI2Vsc2UKKyAgICBJbnRSZWN0IGNsaXAoZW5j bG9zZWRJbnRSZWN0KGNsaXBCb3VuZHMpKTsKICAgICBsYXllckNvbnRlbnRzLT5wbGF0Zm9ybUNB TGF5ZXJQYWludENvbnRlbnRzKGdyYXBoaWNzQ29udGV4dCwgY2xpcCk7CisjZW5kaWYKIAogICAg IFtOU0dyYXBoaWNzQ29udGV4dCByZXN0b3JlR3JhcGhpY3NTdGF0ZV07CiAK