79826 2012-02-28 13:15:34 -0800 [BlackBerry] Update the WebKit API to use std::string rather than char* 2012-11-14 11:00:08 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 79818 79829 79830 0 kpiascik webkit-unassigned efidler joenotcharles manyoso mstaikos staikos tonikitoo yong.li.webkit oldest_to_newest 567014 0 kpiascik 2012-02-28 13:15:34 -0800 Currently there are several methods in both WebPage.h and WebPageClient.h which use char* where std::string would be better suited. These should be updated if possible. This will be a meta bug to track individual changes. This is to encourage smaller patches that are both reviewable and less prone to regressions and breakage. 570194 1 tonikitoo 2012-03-03 17:51:48 -0800 @all, do you have a agreement? 570195 2 tonikitoo 2012-03-03 17:52:30 -0800 (In reply to comment #1) > @all, do you have a agreement? err! @all: do we have an agreement? 571042 3 joenotcharles 2012-03-05 14:17:11 -0800 No - I agree that char* should be deprecated, but I think the API should use WebString in most places. (And in NetworkJob::notifyDataReceived and similar, it should use a buffer class that's a thin wrapper around char*, since the data is not actually a string.) std::string will need to be converted to WTF::String eventually anyway, so we might as well do it on the platform side. This will let us avoid char*->std::string->WTF::String conversions. 767062 4 staikos 2012-11-14 11:00:08 -0800 No we won't