79823 2012-02-28 12:40:37 -0800 [Chromium] Every compositing layout test with render surfaces is flaky 2019-05-02 13:51:49 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 adamk jamesr abarth ap bashi enne haraken jamesr jannywatson1999 morrita senorblanco shawnsingh suchiabram trchen ukai vangelis oldest_to_newest 566982 0 adamk 2012-02-28 12:40:37 -0800 The following layout test is failing flakily on all platforms: compositing/repaint/opacity-between-absolute.html See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=compositing%2Frepaint%2Fopacity-between-absolute.html From the dashboard, http://trac.webkit.org/changeset/108886/ looks like a possibility. Since that change, the test has been failing consistently on Linux dbg, and most of the time on Windows. 567188 1 adamk 2012-02-28 16:00:38 -0800 Also seeing similar flakiness (similarly correlated with 108886) in compositing/reflections/masked-reflection-on-composited.html: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=compositing%2Freflections%2Fmasked-reflection-on-composited.html 567192 2 adamk 2012-02-28 16:03:35 -0800 Committed r109164: <http://trac.webkit.org/changeset/109164> 577854 3 abarth 2012-03-13 15:04:14 -0700 New, seemingly related failures: compositing/geometry/fixed-position.html compositing/reflections/compositing-change-inside-reflection.html compositing/reflections/reflection-on-composited.html compositing/webgl/webgl-reflection.html platform/chromium/compositing/render-surface-alpha-blending.html 577868 4 abarth 2012-03-13 15:13:38 -0700 Committed r110621: <http://trac.webkit.org/changeset/110621> 577869 5 abarth 2012-03-13 15:13:54 -0700 Not fixed... 577892 6 abarth 2012-03-13 15:35:25 -0700 jamesr: I think there's something wrong with the compositor dropping images. Here's another example: compositing/masks/direct-image-mask.html http://build.chromium.org/f/chromium/layout_test_results/Webkit_Linux_32/results/layout-test-results/compositing/masks/direct-image-mask-diff.png It's some kind of flaky problem, which makes it hard to track down. Have their been any changes related to masking and/or reflections in the compositor recently? 577895 7 abarth 2012-03-13 15:35:44 -0700 +enne for additional thoughts. 577939 8 enne 2012-03-13 15:57:57 -0700 (In reply to comment #7) > +enne for additional thoughts. I'd be kind of surprised if r108886 broke things in a flaky manner, but I don't have any better suggestions or insight here, sorry. 577958 9 trchen 2012-03-13 16:15:23 -0700 I probably see why r108886 can cause a problem with reflection. The LayerChromium is shared between its owner GraphicsLayer and also the reflection GraphicsLayer (as replica). The impl-side clone shouldn't really use an OwnPtr for the replica layer. I think I can come up with a fix reasonably soon. Just don't know why the tests are just flaky instead of failing constantly. 578002 10 trchen 2012-03-13 16:57:30 -0700 (In reply to comment #9) > I probably see why r108886 can cause a problem with reflection. The LayerChromium is shared between its owner GraphicsLayer and also the reflection GraphicsLayer (as replica). The impl-side clone shouldn't really use an OwnPtr for the replica layer. > > I think I can come up with a fix reasonably soon. Just don't know why the tests are just flaky instead of failing constantly. NVM, it was a wrong guess. The replica layers don't seem to be shared. 578181 11 morrita 2012-03-13 22:59:05 -0700 *** Bug 81080 has been marked as a duplicate of this bug. *** 578584 12 jamesr 2012-03-14 11:23:19 -0700 Taking a look - this is really bad :/ 578687 13 senorblanco 2012-03-14 13:07:40 -0700 Some other layout tests with similar symptoms: https://bugs.webkit.org/show_bug.cgi?id=79572 https://bugs.webkit.org/show_bug.cgi?id=80563 http://crbug.com/114777 Those bugs all seem to have RenderSurface in common, which I think that's also used for reflections and masks, which are some of the failures reported on this bug. Could be related to RenderSurface in some way? 578696 14 senorblanco 2012-03-14 13:17:50 -0700 (In reply to comment #13) > Some other layout tests with similar symptoms: > > https://bugs.webkit.org/show_bug.cgi?id=79572 > https://bugs.webkit.org/show_bug.cgi?id=80563 > http://crbug.com/114777 > > Those bugs all seem to have RenderSurface in common, which I think that's also used for reflections and masks, which are some of the failures reported on this bug. Could be related to RenderSurface in some way? By RenderSurface I meant CCRenderSurface, of course. (And by <really poor grammar> I meant <really excellent grammar>.) 578699 15 jamesr 2012-03-14 13:21:29 -0700 Yeah, there's a bug with caching a CCRenderSurface pointer in LayerRendererChromium. Patch on the way. 578702 16 jamesr 2012-03-14 13:22:40 -0700 *** Bug 80563 has been marked as a duplicate of this bug. *** 578707 17 jamesr 2012-03-14 13:25:17 -0700 *** Bug 74731 has been marked as a duplicate of this bug. *** 578710 18 jamesr 2012-03-14 13:27:07 -0700 *** Bug 80007 has been marked as a duplicate of this bug. *** 578712 19 jamesr 2012-03-14 13:27:28 -0700 *** Bug 79572 has been marked as a duplicate of this bug. *** 578713 20 131910 jamesr 2012-03-14 13:30:23 -0700 Created attachment 131910 Patch 578716 21 jamesr 2012-03-14 13:31:27 -0700 *** Bug 74050 has been marked as a duplicate of this bug. *** 578720 22 131910 enne 2012-03-14 13:35:16 -0700 Comment on attachment 131910 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131910&action=review R=me. Nice catch. > Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:-395 > - // The GL viewport covers the entire visible area, including the scrollbars. > - GLC(m_context.get(), m_context->viewport(0, 0, viewportWidth(), viewportHeight())); > - m_windowMatrix = screenMatrix(0, 0, viewportWidth(), viewportHeight()); > - Good riddance to this too. 578730 23 jamesr 2012-03-14 13:52:53 -0700 Committed r110741: <http://trac.webkit.org/changeset/110741> 578804 24 jamesr 2012-03-14 14:54:15 -0700 *** Bug 79647 has been marked as a duplicate of this bug. *** 579376 25 senorblanco 2012-03-15 07:47:14 -0700 Thanks! I had it on my list to look into this after my gardening shift, but I got sidelined by other things. Fix is much appreciated! 131910 2012-03-14 13:30:23 -0700 2012-03-14 13:35:16 -0700 Patch bug-79823-20120314133022.patch text/plain 5628 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNzE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTc3NjM3MDdiMWQ0YTE2 ZjUyYTNkZWJlZmIzYjRhNWZjNWExYTZmMy4uODkyMjc0ZWE0OTM2OGRhZGZkODNhNjRjMDJjZGU5 MTlkNWZlZGJiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAzLTE0ICBKYW1l cyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBM YXlvdXQgVGVzdCBjb21wb3NpdGluZy9yZXBhaW50L29wYWNpdHktYmV0d2Vlbi1hYnNvbHV0ZS5o dG1sIGlzIGZsYWt5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03OTgyMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIExheWVyUmVuZGVyZXJDaHJvbWl1bSB3YXMgc3RvcmluZyBhIHdlYWsgcG9pbnRlciB0byB0 aGUgY3VycmVudCByZW5kZXIgc3VyZmFjZSBpbiBtX2N1cnJlbnRSZW5kZXJTdXJmYWNlIGFuZAor ICAgICAgICB1c2luZyB0aGlzIGluIHVzZVJlbmRlclN1cmZhY2UoKSB0byBhdm9pZCByZWJpbmRp bmcgaWYgd2UgY2FsbGVkIHVzZVJlbmRlclN1cmZhY2UoKSBtdWx0aXBsZSB0aW1lcyBpbiBhIHJv dyBvbgorICAgICAgICB0aGUgc2FtZSBzdXJmYWNlLiBUaGlzIHBvaW50ZXIgd2FzIG5ldmVyIGNs ZWFyZWQsIHNvIGlmIGFueSBzdWJzZXF1ZW50IHN1cmZhY2UgbGFuZGVkIGF0IHRoZSBzYW1lIGFk ZHJlc3MgdGhpcworICAgICAgICBjYWNoaW5nIHdvdWxkIG1pc2JlaGF2ZSBhbmQgd2UnZCBmYWls IHRvIGNvcnJlY3RseSBpbml0aWFsaXplIHRoZSBuZXcgcmVuZGVyIHN1cmZhY2UuIFRoZSBjYWNo aW5nIHdhc24ndAorICAgICAgICBhY3R1YWxseSBidXlpbmcgdXMgYW55dGhpbmcgYW55d2F5IHNp bmNlIHdlIG9ubHkgY2FsbCB1c2VSZW5kZXJTdXJmYWNlKCkgb25jZSBwZXIgc3VyZmFjZSBwZXIg ZnJhbWUgYW5kIHdlCisgICAgICAgIGFsd2F5cyBzZXQgdGhlIHZpZXdwb3J0IGZvciB0aGUgZGVm YXVsdCByZW5kZXIgc3VyZmFjZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXllclJl bmRlcmVyQ2hyb21pdW06OmJlZ2luRHJhd2luZ0ZyYW1lKToKKyAgICAgICAgKFdlYkNvcmU6Okxh eWVyUmVuZGVyZXJDaHJvbWl1bTo6dXNlUmVuZGVyU3VyZmFjZSk6CisKIDIwMTItMDMtMTQgIENh cmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtd IEhhbmRsZSBwcmludGluZyBlcnJvcnMgaW4gV2ViS2l0MgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJlckNocm9taXVtLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVuZGVy ZXJDaHJvbWl1bS5jcHAKaW5kZXggYjE2MmVhYjQ5ZmExMzQzYzEwMzMzZWUxZjEwMThjMmVmYTQ3 MzVjZC4uYWNmZDc3MjMyYjJkNDRjYTQwZjllZTcyZjExZWVjZWYwZmM4NTM5MyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJl ckNocm9taXVtLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJv bWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0uY3BwCkBAIC0zODksMTAgKzM4OSw2IEBAIHZvaWQg TGF5ZXJSZW5kZXJlckNocm9taXVtOjpiZWdpbkRyYXdpbmdGcmFtZSgpCiAgICAgfQogCiAgICAg bWFrZUNvbnRleHRDdXJyZW50KCk7Ci0gICAgLy8gVGhlIEdMIHZpZXdwb3J0IGNvdmVycyB0aGUg ZW50aXJlIHZpc2libGUgYXJlYSwgaW5jbHVkaW5nIHRoZSBzY3JvbGxiYXJzLgotICAgIEdMQyht X2NvbnRleHQuZ2V0KCksIG1fY29udGV4dC0+dmlld3BvcnQoMCwgMCwgdmlld3BvcnRXaWR0aCgp LCB2aWV3cG9ydEhlaWdodCgpKSk7Ci0gICAgbV93aW5kb3dNYXRyaXggPSBzY3JlZW5NYXRyaXgo MCwgMCwgdmlld3BvcnRXaWR0aCgpLCB2aWV3cG9ydEhlaWdodCgpKTsKLQogICAgIC8vIEJpbmQg dGhlIGNvbW1vbiB2ZXJ0ZXggYXR0cmlidXRlcyB1c2VkIGZvciBkcmF3aW5nIGFsbCB0aGUgbGF5 ZXJzLgogICAgIG1fc2hhcmVkR2VvbWV0cnktPnByZXBhcmVGb3JEcmF3KCk7CiAKQEAgLTExNDMs OSArMTEzOSw2IEBAIHZvaWQgTGF5ZXJSZW5kZXJlckNocm9taXVtOjpjb3B5T2Zmc2NyZWVuVGV4 dHVyZVRvRGlzcGxheSgpCiAKIGJvb2wgTGF5ZXJSZW5kZXJlckNocm9taXVtOjp1c2VSZW5kZXJT dXJmYWNlKENDUmVuZGVyU3VyZmFjZSogcmVuZGVyU3VyZmFjZSkKIHsKLSAgICBpZiAobV9jdXJy ZW50UmVuZGVyU3VyZmFjZSA9PSByZW5kZXJTdXJmYWNlKQotICAgICAgICByZXR1cm4gdHJ1ZTsK LQogICAgIG1fY3VycmVudFJlbmRlclN1cmZhY2UgPSByZW5kZXJTdXJmYWNlOwogCiAgICAgaWYg KChyZW5kZXJTdXJmYWNlID09IG1fZGVmYXVsdFJlbmRlclN1cmZhY2UgJiYgIXNldHRpbmdzKCku Y29tcG9zaXRlT2Zmc2NyZWVuKSB8fCAoIXJlbmRlclN1cmZhY2UgJiYgc2V0dGluZ3MoKS5jb21w b3NpdGVPZmZzY3JlZW4pKSB7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNmY5NmJjNDQxNGRlNDIwYmQyMDA2M2UzODk5ZmI3 M2ExN2JmOTkwZS4uMmExMGI1YjQyMmMyOTZkODNkNzgxMTBhOTlkMmRkOTc4MzBmOTM1OSAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTAzLTE0ICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBMYXlvdXQgVGVzdCBjb21wb3NpdGlu Zy9yZXBhaW50L29wYWNpdHktYmV0d2Vlbi1hYnNvbHV0ZS5odG1sIGlzIGZsYWt5CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03OTgyMworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21p dW0vdGVzdF9leHBlY3RhdGlvbnMudHh0OgorCiAyMDEyLTAzLTE0ICBKZXNzaWUgQmVybGluICA8 amJlcmxpbkBhcHBsZS5jb20+CiAKICAgICAgICAgU3VwcG9ydCBkcmFnIGluIG1vdXNlIGV2ZW50 cyBmb3IgV2ViS2l0MiBFdmVudFNlbmRlcgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v Y2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CmluZGV4IDgwMjQ1NTliNzQzNjQwOGFjN2Mz ZTJhODMwNmNlYjJhMjE0NWI4MDUuLmI5ODA3ZmIxYjg3MjNmOTkwNjMwNzMxYWI1YzhjZjE4OWNk NzIyNmUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhw ZWN0YXRpb25zLnR4dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4 cGVjdGF0aW9ucy50eHQKQEAgLTM3OTIsMjAgKzM3OTIsNiBAQCBCVUdXSzc5NjQyIDogZmFzdC9s b2FkZXIvc3VicmVzb3VyY2Utd2lsbFNlbmRSZXF1ZXN0LW51bGwuaHRtbCA9IFRJTUVPVVQKIEJV R1dLNzk3MDIgOiBmYXN0L3JlZ2V4L2xhc3RJbmRleC5odG1sID0gVEVYVAogQlVHV0s3OTcwMyA6 IGZhc3QvcmVnZXgvb3ZlcmZsb3cuaHRtbCA9IFRFWFQKIAotQlVHV0s3OTgyMyA6IGNvbXBvc2l0 aW5nL3JlcGFpbnQvb3BhY2l0eS1iZXR3ZWVuLWFic29sdXRlLmh0bWwgPSBQQVNTIElNQUdFCi1C VUdXSzc5ODIzIDogY29tcG9zaXRpbmcvcmVmbGVjdGlvbnMvbWFza2VkLXJlZmxlY3Rpb24tb24t Y29tcG9zaXRlZC5odG1sID0gUEFTUyBJTUFHRQotQlVHV0s3OTgyMyA6IGNvbXBvc2l0aW5nL3Jl ZmxlY3Rpb25zL3JlZmxlY3Rpb24tb24tY29tcG9zaXRlZC5odG1sID0gUEFTUyBJTUFHRQotQlVH V0s3OTgyMyA6IGNvbXBvc2l0aW5nL2dlb21ldHJ5L2ZpeGVkLXBvc2l0aW9uLmh0bWwgPSBQQVNT IElNQUdFCi1CVUdXSzc5ODIzIDogY29tcG9zaXRpbmcvcmVmbGVjdGlvbnMvY29tcG9zaXRpbmct Y2hhbmdlLWluc2lkZS1yZWZsZWN0aW9uLmh0bWwgPSBQQVNTIElNQUdFCi1CVUdXSzc5ODIzIDog Y29tcG9zaXRpbmcvd2ViZ2wvd2ViZ2wtcmVmbGVjdGlvbi5odG1sID0gUEFTUyBJTUFHRQotQlVH V0s3OTgyMyA6IGNvbXBvc2l0aW5nL21hc2tzL2RpcmVjdC1pbWFnZS1tYXNrLmh0bWwgPSBQQVNT IElNQUdFCi1CVUdXSzc5ODIzIDogcGxhdGZvcm0vY2hyb21pdW0vY29tcG9zaXRpbmcvcmVuZGVy LXN1cmZhY2UtYWxwaGEtYmxlbmRpbmcuaHRtbCA9IFBBU1MgSU1BR0UKLUJVR1dLNzk4MjMgOiBw bGF0Zm9ybS9jaHJvbWl1bS9jb21wb3NpdGluZy9jaGlsZC1sYXllci0zZC1zb3J0aW5nLmh0bWwg PSBQQVNTIElNQUdFCi1CVUdXSzc5ODIzIDogcGxhdGZvcm0vY2hyb21pdW0vY29tcG9zaXRpbmcv cGx1Z2lucy93ZWJwbHVnaW4tcmVmbGVjdGlvbi5odG1sID0gUEFTUyBJTUFHRQotCi0vLyBBbHJl YWR5IGFzc29jaWF0ZWQgd2l0aCBidWcgNDc5NDkgb24gTWFjLgotQlVHV0s3OTgyMyBXSU4gTElO VVggOiBjb21wb3NpdGluZy9yZWZsZWN0aW9ucy9uZXN0ZWQtcmVmbGVjdGlvbi5odG1sID0gUEFT UyBJTUFHRQotCiBCVUdXSzc5ODYyIDogZmFzdC9qcy9wcmltaXRpdmUtcHJvcGVydHktYWNjZXNz LWVkZ2UtY2FzZXMuaHRtbCA9IFRFWFQKIEJVR1dLNzk4NjIgOiBmYXN0L2pzL3JlYWQtbW9kaWZ5 LWV2YWwuaHRtbCA9IFRFWFQKIApAQCAtMzg5OCwxMSArMzg4NCw2IEBAIEJVR1dLODA3NDMgV0lO IE1BQyA6IGNvbXBvc2l0aW5nL2dlb21ldHJ5L3ZlcnRpY2FsLXNjcm9sbC1jb21wb3NpdGVkLmh0 bWwgPSBQQVNTCiBCVUdXSzgwNzQzIFdJTiBNQUMgOiBjb21wb3NpdGluZy9kaXJlY3QtaW1hZ2Ut Y29tcG9zaXRpbmcuaHRtbCA9IFBBU1MgSU1BR0UKIEJVR1dLODA3NDMgV0lOIE1BQyA6IHBsYXRm b3JtL2Nocm9taXVtL2NvbXBvc2l0aW5nL2h1Z2UtbGF5ZXItcm90YXRlZC5odG1sID0gUEFTUyBJ TUFHRQogCi1CVUdXSzgwNTYzIDogY3NzMy9maWx0ZXJzL2VmZmVjdC1jb21iaW5lZC1ody5odG1s ID0gUEFTUyBJTUFHRQotQlVHV0s4MDU2MyA6IGNzczMvZmlsdGVycy9lZmZlY3QtaHVlLXJvdGF0 ZS1ody5odG1sID0gUEFTUyBJTUFHRQotQlVHV0s4MDU2MyA6IGNzczMvZmlsdGVycy9lZmZlY3Qt b3BhY2l0eS1ody5odG1sID0gUEFTUyBJTUFHRQotQlVHV0s4MDU2MyA6IGNvbXBvc2l0aW5nL3Jl ZmxlY3Rpb25zL25lc3RlZC1yZWZsZWN0aW9uLW9wYWNpdHkuaHRtbCA9IFBBU1MgSU1BR0UKLQog QlVHV0s4MDY2NSA6IGZhc3QvanMvc3RyaW5nLW1hdGNoLmh0bWwgPSBURVhUCiBCVUdXSzgwNjY1 IDogZmFzdC9qcy9zdHJpbmctcmVwbGFjZS0yLmh0bWwgPSBURVhUCiAK