79818 2012-02-28 11:48:09 -0800 [BlackBerry] Change the API to use std::string 2012-02-28 14:23:33 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 79826 0 kpiascik webkit-unassigned tonikitoo webkit.review.bot oldest_to_newest 566931 0 kpiascik 2012-02-28 11:48:09 -0800 [BlackBerry] Change the API to use std::string 566932 1 129302 kpiascik 2012-02-28 11:48:54 -0800 Created attachment 129302 [BlackBerry] change the API to use std::string 567016 2 129302 tonikitoo 2012-02-28 13:16:25 -0800 Comment on attachment 129302 [BlackBerry] change the API to use std::string please spoke, lets please create a bug to track fixing all the char* cases. 567032 3 tonikitoo 2012-02-28 13:28:45 -0800 (In reply to comment #2) > (From update of attachment 129302 [details]) > please spoke, lets please create a bug to track fixing all the char* cases. I mean: "lets please create a bug to track fixing all the char* cases", and you have done that already, thanks 567093 4 129302 webkit.review.bot 2012-02-28 14:23:29 -0800 Comment on attachment 129302 [BlackBerry] change the API to use std::string Clearing flags on attachment: 129302 Committed r109150: <http://trac.webkit.org/changeset/109150> 567094 5 webkit.review.bot 2012-02-28 14:23:33 -0800 All reviewed patches have been landed. Closing bug. 129302 2012-02-28 11:48:54 -0800 2012-02-28 14:23:29 -0800 [BlackBerry] change the API to use std::string bug-79818-20120228144855.patch text/plain 2128 kpiascik U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5MTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA1NzE3Zjc2Y2NkOWUzYzllOTFjODM3NTBiNjVkNDUyOGI3OGU5NzgyLi5hZmI4MmU5OWI3 MmNjNTEyMjliNDlmYjdhNWQzYjhjZWFjNTBmNTFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0wMi0yOCAgS29ucmFkIFBpYXNjaWsgIDxrcGlh c2Npa0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBDaGFuZ2UgdGhlIEFQSSB0byB1 c2Ugc3RkOjpzdHJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTc5ODE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBBcGkvV2ViUGFnZS5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6Oldl YlBhZ2U6OmRpc3BhdGNoSW5zcGVjdG9yTWVzc2FnZSk6CisgICAgICAgICogQXBpL1dlYlBhZ2Uu aDoKKwogMjAxMi0wMi0yNyAgSmFja3kgSmlhbmcgIDx6aGFqaWFuZ0ByaW0uY29tPgogCiAgICAg ICAgIFtCbGFja0JlcnJ5XSBVcHN0cmVhbSBCbGFja0JlcnJ5IEFQSSB3ZWIgcGFnZSByZWxhdGVk IGZpbGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2Uu Y3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAppbmRleCBjODRm OWEyODBhMTRmYWMzYWQxODI0NjA5YTBhNjY0OThlMTFjNGNlLi5mY2I3ZmVkNjUwZjI2NmQzNTU1 MDlmMDYwZTY2MmU3OGU5YTdiNDgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvQXBpL1dlYlBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2Vi UGFnZS5jcHAKQEAgLTUwMjMsOSArNTAyMyw5IEBAIHZvaWQgV2ViUGFnZTo6ZGlzYWJsZVBhc3N3 b3JkRWNobygpCiAgICAgZC0+bV9wYWdlLT5zZXR0aW5ncygpLT5zZXRQYXNzd29yZEVjaG9FbmFi bGVkKGZhbHNlKTsKIH0KIAotdm9pZCBXZWJQYWdlOjpkaXNwYXRjaEluc3BlY3Rvck1lc3NhZ2Uo Y29uc3QgY2hhciogbWVzc2FnZSwgaW50IGxlbmd0aCkKK3ZvaWQgV2ViUGFnZTo6ZGlzcGF0Y2hJ bnNwZWN0b3JNZXNzYWdlKGNvbnN0IHN0ZDo6c3RyaW5nJiBtZXNzYWdlKQogewotICAgIFN0cmlu ZyBzdHJpbmdNZXNzYWdlKG1lc3NhZ2UsIGxlbmd0aCk7CisgICAgU3RyaW5nIHN0cmluZ01lc3Nh Z2UobWVzc2FnZS5jX3N0cigpLCBtZXNzYWdlLmxlbmd0aCgpKTsKICAgICBkLT5tX3BhZ2UtPmlu c3BlY3RvckNvbnRyb2xsZXIoKS0+ZGlzcGF0Y2hNZXNzYWdlRnJvbUZyb250ZW5kKHN0cmluZ01l c3NhZ2UpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dl YlBhZ2UuaCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5oCmluZGV4IGI3 Yjg5Y2Q4ZjE4MzUyYmI4NDA5NGZiZTJlOThlMGE5M2UzYWM1NDUuLjQ4YzE1YmZkOGI5NTZhYjBk YzYyYTdhY2UxYTUxOTIyMzVlNzg0NzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9BcGkvV2ViUGFnZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2Vi UGFnZS5oCkBAIC0zMDIsNyArMzAyLDcgQEAgcHVibGljOgogICAgIHZvaWQgZGlzYWJsZVdlYklu c3BlY3RvcigpOwogICAgIHZvaWQgZW5hYmxlUGFzc3dvcmRFY2hvKCk7CiAgICAgdm9pZCBkaXNh YmxlUGFzc3dvcmRFY2hvKCk7Ci0gICAgdm9pZCBkaXNwYXRjaEluc3BlY3Rvck1lc3NhZ2UoY29u c3QgY2hhciogbWVzc2FnZSwgaW50IGxlbmd0aCk7CisgICAgdm9pZCBkaXNwYXRjaEluc3BlY3Rv ck1lc3NhZ2UoY29uc3Qgc3RkOjpzdHJpbmcmIG1lc3NhZ2UpOwogCiAgICAgLy8gRklYTUU6IE5l ZWRzIEFQSSByZXZpZXcgb24gdGhpcyBoZWFkZXIuIFNlZSBQUiAjMTIwNDAyLgogICAgIHZvaWQg bm90aWZ5UGFnZVBhdXNlKCk7Cg==