<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>79804</bug_id>
          
          <creation_ts>2012-02-28 09:05:18 -0800</creation_ts>
          <short_desc>[GTK] Remove virtual methods of WebKitDownload signals in WebKit2 GTK+ API</short_desc>
          <delta_ts>2012-02-28 09:57:05 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Gtk</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Garcia Campos">cgarcia</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>gustavo</cc>
    
    <cc>pnormand</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>566762</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2012-02-28 09:05:18 -0800</bug_when>
    <thetext>That comes from the first patch that followed the approach of the first LoaderClient implementation. With current implementation download signals, except decide-destination, don&apos;t need to be true_handled, and they won&apos;t have a default handler implementation. Also the download object is not supposed to be inheritable, since instances are created privately by the WebContext, so it&apos;s not possible to override the virtual methods in derived classes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>566765</commentid>
    <comment_count>1</comment_count>
      <attachid>129274</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2012-02-28 09:07:42 -0800</bug_when>
    <thetext>Created attachment 129274
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>566768</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-02-28 09:10:29 -0800</bug_when>
    <thetext>Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>566814</commentid>
    <comment_count>3</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2012-02-28 09:57:05 -0800</bug_when>
    <thetext>Committed r109117: &lt;http://trac.webkit.org/changeset/109117&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>129274</attachid>
            <date>2012-02-28 09:07:42 -0800</date>
            <delta_ts>2012-02-28 09:49:32 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>wk2-downloads-vmethods.diff</filename>
            <type>text/plain</type>
            <size>8835</size>
            <attacher name="Carlos Garcia Campos">cgarcia</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No
YW5nZUxvZwppbmRleCA1ZDUyY2VkLi42ZmEzYjUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjgg
QEAKKzIwMTItMDItMjggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t
PgorCisgICAgICAgIFtHVEtdIFJlbW92ZSB2aXJ0dWFsIG1ldGhvZHMgb2YgV2ViS2l0RG93bmxv
YWQgc2lnbmFscyBpbiBXZWJLaXQyIEdUSysgQVBJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03OTgwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgIFRoYXQgY29tZXMgZnJvbSB0aGUgZmlyc3QgcGF0Y2ggdGhh
dCBmb2xsb3dlZCB0aGUgYXBwcm9hY2ggb2YgdGhlCisgICAgICAgIGZpcnN0IExvYWRlckNsaWVu
dCBpbXBsZW1lbnRhdGlvbi4gV2l0aCBjdXJyZW50IGltcGxlbWVudGF0aW9uCisgICAgICAgIGRv
d25sb2FkIHNpZ25hbHMsIGV4Y2VwdCBkZWNpZGUtZGVzdGluYXRpb24sIGRvbid0IG5lZWQgdG8g
YmUKKyAgICAgICAgdHJ1ZV9oYW5kbGVkLCBhbmQgdGhleSB3b24ndCBoYXZlIGEgZGVmYXVsdCBo
YW5kbGVyCisgICAgICAgIGltcGxlbWVudGF0aW9uLiBBbHNvIHRoZSBkb3dubG9hZCBvYmplY3Qg
aXMgbm90IHN1cHBvc2VkIHRvIGJlCisgICAgICAgIGluaGVyaXRhYmxlLCBzaW5jZSBpbnN0YW5j
ZXMgYXJlIGNyZWF0ZWQgcHJpdmF0ZWx5IGJ5IHRoZQorICAgICAgICBXZWJDb250ZXh0LCBzbyBp
dCdzIG5vdCBwb3NzaWJsZSB0byBvdmVycmlkZSB0aGUgdmlydHVhbCBtZXRob2RzCisgICAgICAg
IGluIGRlcml2ZWQgY2xhc3Nlcy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktp
dERvd25sb2FkLmNwcDoKKyAgICAgICAgKHdlYmtpdF9kb3dubG9hZF9jbGFzc19pbml0KToKKyAg
ICAgICAgKHdlYmtpdERvd25sb2FkTm90aWZ5UHJvZ3Jlc3MpOgorICAgICAgICAod2Via2l0RG93
bmxvYWRGYWlsZWQpOgorICAgICAgICAod2Via2l0RG93bmxvYWRGaW5pc2hlZCk6CisgICAgICAg
ICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0RG93bmxvYWQuaDoKKyAgICAgICAgKF9XZWJLaXRE
b3dubG9hZENsYXNzKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay93ZWJraXQybWFyc2hh
bC5saXN0OgorCiAyMDEyLTAyLTI4ICBTaGlueWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVt
Lm9yZz4KIAogICAgICAgICBFbGVtZW50IHNob3VsZCBiZSBhYmxlIHRvIGhhdmUgbXVsdGlwbGUg
c2hhZG93IHJvb3RzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9n
dGsvV2ViS2l0RG93bmxvYWQuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsv
V2ViS2l0RG93bmxvYWQuY3BwCmluZGV4IDRkNGViYTEuLjAxOGYwOGQgMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdERvd25sb2FkLmNwcAorKysgYi9T
b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXREb3dubG9hZC5jcHAKQEAgLTE2
OSwxOCArMTY5LDE0IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF9kb3dubG9hZF9jbGFzc19pbml0KFdl
YktpdERvd25sb2FkQ2xhc3MqIGRvd25sb2FkQ2xhc3MpCiAgICAgICogVGhpcyBzaWduYWwgaXMg
ZW1pdHRlZCBhZnRlciByZXNwb25zZSBpcyByZWNlaXZlZCwKICAgICAgKiBldmVyeSB0aW1lIG5l
dyBkYXRhIGhhcyBiZWVuIHdyaXR0ZW4gdG8gdGhlIGRlc3RpbmF0aW9uLiBJdCdzCiAgICAgICog
dXNlZnVsIHRvIGtub3cgdGhlIHByb2dyZXNzIG9mIHRoZSBkb3dubG9hZCBvcGVyYXRpb24uCi0g
ICAgICoKLSAgICAgKiBSZXR1cm5zOiAlVFJVRSB0byBzdG9wIG90aGVyIGhhbmRsZXJzIGZyb20g
YmVpbmcgaW52b2tlZCBmb3IgdGhlIGV2ZW50LgotICAgICAqICAgJUZBTFNFIHRvIHByb3BhZ2F0
ZSB0aGUgZXZlbnQgZnVydGhlci4KICAgICAgKi8KICAgICBzaWduYWxzW1JFQ0VJVkVEX0RBVEFd
ID0KICAgICAgICAgZ19zaWduYWxfbmV3KCJyZWNlaXZlZC1kYXRhIiwKICAgICAgICAgICAgICAg
ICAgICAgIEdfVFlQRV9GUk9NX0NMQVNTKG9iamVjdENsYXNzKSwKICAgICAgICAgICAgICAgICAg
ICAgIEdfU0lHTkFMX1JVTl9MQVNULAotICAgICAgICAgICAgICAgICAgICAgR19TVFJVQ1RfT0ZG
U0VUKFdlYktpdERvd25sb2FkQ2xhc3MsIHJlY2VpdmVkX2RhdGEpLAotICAgICAgICAgICAgICAg
ICAgICAgZ19zaWduYWxfYWNjdW11bGF0b3JfdHJ1ZV9oYW5kbGVkLCBOVUxMLAotICAgICAgICAg
ICAgICAgICAgICAgd2Via2l0X21hcnNoYWxfQk9PTEVBTl9fVUlOVDY0LAotICAgICAgICAgICAg
ICAgICAgICAgR19UWVBFX0JPT0xFQU4sIDEsCisgICAgICAgICAgICAgICAgICAgICAwLCAwLCAw
LAorICAgICAgICAgICAgICAgICAgICAgd2Via2l0X21hcnNoYWxfVk9JRF9fVUlOVDY0LAorICAg
ICAgICAgICAgICAgICAgICAgR19UWVBFX05PTkUsIDEsCiAgICAgICAgICAgICAgICAgICAgICBH
X1RZUEVfVUlOVDY0KTsKIAogICAgIC8qKgpAQCAtMTg5LDE4ICsxODUsMTQgQEAgc3RhdGljIHZv
aWQgd2Via2l0X2Rvd25sb2FkX2NsYXNzX2luaXQoV2ViS2l0RG93bmxvYWRDbGFzcyogZG93bmxv
YWRDbGFzcykKICAgICAgKgogICAgICAqIFRoaXMgc2lnbmFsIGlzIGVtaXR0ZWQgd2hlbiBkb3du
bG9hZCBmaW5pc2hlcyBzdWNjZXNzZnVsbHkgb3IgZHVlIHRvIGFuIGVycm9yLgogICAgICAqIElu
IGNhc2Ugb2YgZXJyb3JzICNXZWJLaXREb3dubG9hZDo6ZmFpbGVkIHNpZ25hbCBpcyBlbWl0dGVk
IGJlZm9yZSB0aGlzIG9uZS4KLSAgICAgKgotICAgICAqIFJldHVybnM6ICVUUlVFIHRvIHN0b3Ag
b3RoZXIgaGFuZGxlcnMgZnJvbSBiZWluZyBpbnZva2VkIGZvciB0aGUgZXZlbnQuCi0gICAgICog
ICAlRkFMU0UgdG8gcHJvcGFnYXRlIHRoZSBldmVudCBmdXJ0aGVyLgogICAgICAqLwogICAgIHNp
Z25hbHNbRklOSVNIRURdID0KICAgICAgICAgZ19zaWduYWxfbmV3KCJmaW5pc2hlZCIsCiAgICAg
ICAgICAgICAgICAgICAgICBHX1RZUEVfRlJPTV9DTEFTUyhvYmplY3RDbGFzcyksCiAgICAgICAg
ICAgICAgICAgICAgICBHX1NJR05BTF9SVU5fTEFTVCwKLSAgICAgICAgICAgICAgICAgICAgIEdf
U1RSVUNUX09GRlNFVChXZWJLaXREb3dubG9hZENsYXNzLCBmaW5pc2hlZCksCi0gICAgICAgICAg
ICAgICAgICAgICBnX3NpZ25hbF9hY2N1bXVsYXRvcl90cnVlX2hhbmRsZWQsIE5VTEwsCi0gICAg
ICAgICAgICAgICAgICAgICB3ZWJraXRfbWFyc2hhbF9CT09MRUFOX19WT0lELAotICAgICAgICAg
ICAgICAgICAgICAgR19UWVBFX0JPT0xFQU4sIDApOworICAgICAgICAgICAgICAgICAgICAgMCwg
MCwgMCwKKyAgICAgICAgICAgICAgICAgICAgIGdfY2Nsb3N1cmVfbWFyc2hhbF9WT0lEX19WT0lE
LAorICAgICAgICAgICAgICAgICAgICAgR19UWVBFX05PTkUsIDApOwogCiAgICAgLyoqCiAgICAg
ICogV2ViS2l0RG93bmxvYWQ6OmZhaWxlZDoKQEAgLTIxMywxOCArMjA1LDE0IEBAIHN0YXRpYyB2
b2lkIHdlYmtpdF9kb3dubG9hZF9jbGFzc19pbml0KFdlYktpdERvd25sb2FkQ2xhc3MqIGRvd25s
b2FkQ2xhc3MpCiAgICAgICogd2l0aCB3ZWJraXRfZG93bmxvYWRfY2FuY2VsKCksIHRoaXMgc2ln
bmFsIGlzIGVtaXR0ZWQgd2l0aCBlcnJvcgogICAgICAqICVXRUJLSVRfRE9XTkxPQURfRVJST1Jf
Q0FOQ0VMTEVEX0JZX1VTRVIuIFRoZSBkb3dubG9hZCBvcGVyYXRpb24gZmluaXNoZXMKICAgICAg
KiBhZnRlciBhbiBlcnJvciBhbmQgI1dlYktpdERvd25sb2FkOjpmaW5pc2hlZCBzaWduYWwgaXMg
ZW1pdHRlZCBhZnRlciB0aGlzIG9uZS4KLSAgICAgKgotICAgICAqIFJldHVybnM6ICVUUlVFIHRv
IHN0b3Agb3RoZXIgaGFuZGxlcnMgZnJvbSBiZWluZyBpbnZva2VkIGZvciB0aGUgZXZlbnQuCi0g
ICAgICogICAlRkFMU0UgdG8gcHJvcGFnYXRlIHRoZSBldmVudCBmdXJ0aGVyLgogICAgICAqLwog
ICAgIHNpZ25hbHNbRkFJTEVEXSA9CiAgICAgICAgIGdfc2lnbmFsX25ldygiZmFpbGVkIiwKICAg
ICAgICAgICAgICAgICAgICAgIEdfVFlQRV9GUk9NX0NMQVNTKG9iamVjdENsYXNzKSwKICAgICAg
ICAgICAgICAgICAgICAgIEdfU0lHTkFMX1JVTl9MQVNULAotICAgICAgICAgICAgICAgICAgICAg
R19TVFJVQ1RfT0ZGU0VUKFdlYktpdERvd25sb2FkQ2xhc3MsIGZhaWxlZCksCi0gICAgICAgICAg
ICAgICAgICAgICBnX3NpZ25hbF9hY2N1bXVsYXRvcl90cnVlX2hhbmRsZWQsIE5VTEwsCi0gICAg
ICAgICAgICAgICAgICAgICB3ZWJraXRfbWFyc2hhbF9CT09MRUFOX19QT0lOVEVSLAotICAgICAg
ICAgICAgICAgICAgICAgR19UWVBFX0JPT0xFQU4sIDEsCisgICAgICAgICAgICAgICAgICAgICAw
LCAwLCAwLAorICAgICAgICAgICAgICAgICAgICAgZ19jY2xvc3VyZV9tYXJzaGFsX1ZPSURfX1BP
SU5URVIsCisgICAgICAgICAgICAgICAgICAgICBHX1RZUEVfTk9ORSwgMSwKICAgICAgICAgICAg
ICAgICAgICAgIEdfVFlQRV9QT0lOVEVSKTsKIAogICAgIC8qKgpAQCAtMjU4LDE3ICsyNDYsMTMg
QEAgc3RhdGljIHZvaWQgd2Via2l0X2Rvd25sb2FkX2NsYXNzX2luaXQoV2ViS2l0RG93bmxvYWRD
bGFzcyogZG93bmxvYWRDbGFzcykKICAgICAgKiBUaGlzIHNpZ25hbCBpcyBlbWl0dGVkIGFmdGVy
ICNXZWJLaXREb3dubG9hZDo6ZGVjaWRlLWRlc3RpbmF0aW9uIGFuZCBiZWZvcmUKICAgICAgKiAj
V2ViS2l0RG93bmxvYWQ6OnJlY2VpdmVkLWRhdGEgdG8gbm90aWZ5IHRoYXQgZGVzdGluYXRpb24g
ZmlsZSBoYXMgYmVlbgogICAgICAqIGNyZWF0ZWQgc3VjY2Vzc2Z1bGx5IGF0IEBkZXN0aW5hdGlv
bi4KLSAgICAgKgotICAgICAqIFJldHVybnM6ICVUUlVFIHRvIHN0b3Agb3RoZXIgaGFuZGxlcnMg
ZnJvbSBiZWluZyBpbnZva2VkIGZvciB0aGUgZXZlbnQuCi0gICAgICogICAlRkFMU0UgdG8gcHJv
cGFnYXRlIHRoZSBldmVudCBmdXJ0aGVyLgogICAgICAqLwogICAgIHNpZ25hbHNbQ1JFQVRFRF9E
RVNUSU5BVElPTl0gPQogICAgICAgICBnX3NpZ25hbF9uZXcoImNyZWF0ZWQtZGVzdGluYXRpb24i
LAogICAgICAgICAgICAgICAgICAgICAgR19UWVBFX0ZST01fQ0xBU1Mob2JqZWN0Q2xhc3MpLAog
ICAgICAgICAgICAgICAgICAgICAgR19TSUdOQUxfUlVOX0xBU1QsCi0gICAgICAgICAgICAgICAg
ICAgICBHX1NUUlVDVF9PRkZTRVQoV2ViS2l0RG93bmxvYWRDbGFzcywgY3JlYXRlZF9kZXN0aW5h
dGlvbiksCi0gICAgICAgICAgICAgICAgICAgICBnX3NpZ25hbF9hY2N1bXVsYXRvcl90cnVlX2hh
bmRsZWQsIE5VTEwsCi0gICAgICAgICAgICAgICAgICAgICB3ZWJraXRfbWFyc2hhbF9CT09MRUFO
X19TVFJJTkcsCisgICAgICAgICAgICAgICAgICAgICAwLCAwLCAwLAorICAgICAgICAgICAgICAg
ICAgICAgZ19jY2xvc3VyZV9tYXJzaGFsX1ZPSURfX1NUUklORywKICAgICAgICAgICAgICAgICAg
ICAgIEdfVFlQRV9CT09MRUFOLCAxLAogICAgICAgICAgICAgICAgICAgICAgR19UWVBFX1NUUklO
Ryk7CiAKQEAgLTMwNCw4ICsyODgsNyBAQCB2b2lkIHdlYmtpdERvd25sb2FkTm90aWZ5UHJvZ3Jl
c3MoV2ViS2l0RG93bmxvYWQqIGRvd25sb2FkLCBndWludDY0IGJ5dGVzUmVjZWl2ZQogICAgICAg
ICBkb3dubG9hZC0+cHJpdi0+dGltZXIuc2V0KGdfdGltZXJfbmV3KCkpOwogCiAgICAgcHJpdi0+
Y3VycmVudFNpemUgKz0gYnl0ZXNSZWNlaXZlZDsKLSAgICBnYm9vbGVhbiByZXR1cm5WYWx1ZTsK
LSAgICBnX3NpZ25hbF9lbWl0KGRvd25sb2FkLCBzaWduYWxzW1JFQ0VJVkVEX0RBVEFdLCAwLCBi
eXRlc1JlY2VpdmVkLCAmcmV0dXJuVmFsdWUpOworICAgIGdfc2lnbmFsX2VtaXQoZG93bmxvYWQs
IHNpZ25hbHNbUkVDRUlWRURfREFUQV0sIDAsIGJ5dGVzUmVjZWl2ZWQpOwogCiAgICAgLy8gVGhy
b3R0bGUgcHJvZ3Jlc3Mgbm90aWZpY2F0aW9uIHRvIG5vdCBjb25zdW1lIGhpZ2ggYW1vdW50cyBv
ZgogICAgIC8vIENQVSBvbiBmYXN0IGxpbmtzLCBleGNlcHQgd2hlbiB0aGUgbGFzdCBub3RpZmlj
YXRpb24gb2NjdXJlZApAQCAtMzMzLDkgKzMxNiw5IEBAIHZvaWQgd2Via2l0RG93bmxvYWRGYWls
ZWQoV2ViS2l0RG93bmxvYWQqIGRvd25sb2FkLCBjb25zdCBSZXNvdXJjZUVycm9yJiByZXNvdXJj
CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVzb3Vy
Y2VFcnJvci5sb2NhbGl6ZWREZXNjcmlwdGlvbigpLnV0ZjgoKS5kYXRhKCkpKTsKICAgICBpZiAo
ZG93bmxvYWQtPnByaXYtPnRpbWVyKQogICAgICAgICBnX3RpbWVyX3N0b3AoZG93bmxvYWQtPnBy
aXYtPnRpbWVyLmdldCgpKTsKLSAgICBnYm9vbGVhbiByZXR1cm5WYWx1ZTsKLSAgICBnX3NpZ25h
bF9lbWl0KGRvd25sb2FkLCBzaWduYWxzW0ZBSUxFRF0sIDAsIHdlYkVycm9yLmdldCgpLCAmcmV0
dXJuVmFsdWUpOwotICAgIGdfc2lnbmFsX2VtaXQoZG93bmxvYWQsIHNpZ25hbHNbRklOSVNIRURd
LCAwLCAmcmV0dXJuVmFsdWUpOworCisgICAgZ19zaWduYWxfZW1pdChkb3dubG9hZCwgc2lnbmFs
c1tGQUlMRURdLCAwLCB3ZWJFcnJvci5nZXQoKSk7CisgICAgZ19zaWduYWxfZW1pdChkb3dubG9h
ZCwgc2lnbmFsc1tGSU5JU0hFRF0sIDAsIE5VTEwpOwogfQogCiB2b2lkIHdlYmtpdERvd25sb2Fk
Q2FuY2VsbGVkKFdlYktpdERvd25sb2FkKiBkb3dubG9hZCkKQEAgLTM1Niw4ICszMzksNyBAQCB2
b2lkIHdlYmtpdERvd25sb2FkRmluaXNoZWQoV2ViS2l0RG93bmxvYWQqIGRvd25sb2FkKQogICAg
IH0KICAgICBpZiAoZG93bmxvYWQtPnByaXYtPnRpbWVyKQogICAgICAgICBnX3RpbWVyX3N0b3Ao
ZG93bmxvYWQtPnByaXYtPnRpbWVyLmdldCgpKTsKLSAgICBnYm9vbGVhbiByZXR1cm5WYWx1ZTsK
LSAgICBnX3NpZ25hbF9lbWl0KGRvd25sb2FkLCBzaWduYWxzW0ZJTklTSEVEXSwgMCwgJnJldHVy
blZhbHVlKTsKKyAgICBnX3NpZ25hbF9lbWl0KGRvd25sb2FkLCBzaWduYWxzW0ZJTklTSEVEXSwg
MCwgTlVMTCk7CiB9CiAKIENTdHJpbmcgd2Via2l0RG93bmxvYWREZWNpZGVEZXN0aW5hdGlvbldp
dGhTdWdnZXN0ZWRGaWxlbmFtZShXZWJLaXREb3dubG9hZCogZG93bmxvYWQsIGNvbnN0IENTdHJp
bmcmIHN1Z2dlc3RlZEZpbGVuYW1lKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j
ZXNzL0FQSS9ndGsvV2ViS2l0RG93bmxvYWQuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B
UEkvZ3RrL1dlYktpdERvd25sb2FkLmgKaW5kZXggZTIwMGZlYy4uYjZjNTFmZSAxMDA2NDQKLS0t
IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0RG93bmxvYWQuaAorKysg
Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXREb3dubG9hZC5oCkBAIC01
MCwxNSArNTAsOCBAQCBzdHJ1Y3QgX1dlYktpdERvd25sb2FkIHsKIHN0cnVjdCBfV2ViS2l0RG93
bmxvYWRDbGFzcyB7CiAgICAgR09iamVjdENsYXNzIHBhcmVudF9jbGFzczsKIAotICAgIGdib29s
ZWFuICgqIHJlY2VpdmVkX2RhdGEpICAgICAgIChXZWJLaXREb3dubG9hZCAqZG93bmxvYWQsCi0g
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGd1aW50NjQgICAgICAgICBkYXRh
X2xlbmd0aCk7Ci0gICAgZ2Jvb2xlYW4gKCogZmluaXNoZWQpICAgICAgICAgICAgKFdlYktpdERv
d25sb2FkICpkb3dubG9hZCk7Ci0gICAgZ2Jvb2xlYW4gKCogZmFpbGVkKSAgICAgICAgICAgICAg
KFdlYktpdERvd25sb2FkICpkb3dubG9hZCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgR0Vycm9yICAgICAgICAgKmVycm9yKTsKICAgICBnYm9vbGVhbiAoKiBkZWNpZGVf
ZGVzdGluYXRpb24pICAoV2ViS2l0RG93bmxvYWQgKmRvd25sb2FkLAogICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBnY2hhciAgICAqc3VnZ2VzdGVkX2ZpbGVuYW1l
KTsKLSAgICBnYm9vbGVhbiAoKiBjcmVhdGVkX2Rlc3RpbmF0aW9uKSAoV2ViS2l0RG93bmxvYWQg
KmRvd25sb2FkLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBn
Y2hhciAgICAqZGVzdGluYXRpb24pOwogfTsKIAogV0VCS0lUX0FQSSBHVHlwZQpkaWZmIC0tZ2l0
IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvd2Via2l0Mm1hcnNoYWwubGlzdCBi
L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL3dlYmtpdDJtYXJzaGFsLmxpc3QKaW5k
ZXggNzdkMjY5YS4uYTBjMmI1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz
L0FQSS9ndGsvd2Via2l0Mm1hcnNoYWwubGlzdAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl
c3MvQVBJL2d0ay93ZWJraXQybWFyc2hhbC5saXN0CkBAIC0xLDE1ICsxLDExIEBACiBCT09MRUFO
OkVOVU0sU1RSSU5HLFBPSU5URVIKIEJPT0xFQU46T0JKRUNUCiBCT09MRUFOOk9CSkVDVCxFTlVN
Ci1CT09MRUFOOk9CSkVDVCxTVFJJTkcsUE9JTlRFUgotQk9PTEVBTjpQT0lOVEVSCiBCT09MRUFO
OlNUUklORwogQk9PTEVBTjpTVFJJTkcsUE9JTlRFUgogQk9PTEVBTjpTVFJJTkcsU1RSSU5HLFBP
SU5URVIKLUJPT0xFQU46VUlOVDY0Ci1CT09MRUFOOlZPSUQKIE9CSkVDVDpWT0lECi1WT0lEOkVO
VU0KIFZPSUQ6T0JKRUNULFVJTlQKIFZPSUQ6T0JKRUNULFBPSU5URVIKK1ZPSUQ6VUlOVDY0CiAK
</data>
<flag name="review"
          id="131909"
          type_id="1"
          status="+"
          setter="mrobinson"
    />
          </attachment>
      

    </bug>

</bugzilla>