79801 2012-02-28 08:49:34 -0800 Refactor SpeculativeJIT::emitAllocateJSFinalObject 2012-02-28 22:28:50 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg fpizlo webkit.review.bot oldest_to_newest 566734 0 mhahnenberg 2012-02-28 08:49:34 -0800 Currently in the DFG we only support inline allocation for JSFinalObjects. We should refactor this code slightly in such a way that it is easier to allocate various other types of objects (e.g. JSArray, JSFunction, etc.), similar to how we currently do things in the baseline JIT. 567323 1 129375 mhahnenberg 2012-02-28 18:54:42 -0800 Created attachment 129375 Patch 567342 2 129375 fpizlo 2012-02-28 20:34:22 -0800 Comment on attachment 129375 Patch r=me. 567384 3 129375 webkit.review.bot 2012-02-28 22:28:46 -0800 Comment on attachment 129375 Patch Clearing flags on attachment: 129375 Committed r109194: <http://trac.webkit.org/changeset/109194> 567385 4 webkit.review.bot 2012-02-28 22:28:50 -0800 All reviewed patches have been landed. Closing bug. 129375 2012-02-28 18:54:42 -0800 2012-02-28 22:28:46 -0800 Patch bug-79801-20120228185441.patch text/plain 4019 mhahnenberg U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5MTc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz ZjBhY2VjYmRhY2FkNGI2OWRhZjY4YTk4NDhmODE1YWRkODk0ZWJjLi45NGY2ZGI4MTY0ZTMzNWFm NmQzZDZkYTczMzMyMzJjZDdkYjkzMTFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxOCBAQAogMjAxMi0wMi0yOCAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBw bGUuY29tPgogCisgICAgICAgIFJlZmFjdG9yIFNwZWN1bGF0aXZlSklUOjplbWl0QWxsb2NhdGVK U0ZpbmFsT2JqZWN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03OTgwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogZGZnL0RGR1NwZWN1bGF0aXZlSklULmg6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3Vs YXRpdmVKSVQ6OmVtaXRBbGxvY2F0ZUJhc2ljSlNPYmplY3QpOiBTcGxpdCBlbWl0QWxsb2NhdGVK U0ZpbmFsT2JqZWN0IG91dCB0byBmb3JtIHRoaXMKKyAgICAgICAgZnVuY3Rpb24sIHdoaWNoIGlz IG1vcmUgZ2VuZXJpYyBpbiB0aGF0IGl0IGNhbiBhbGxvY2F0ZSBhIHZhcmlldHkgb2YgY2xhc3Nl cy4KKyAgICAgICAgKFNwZWN1bGF0aXZlSklUKToKKyAgICAgICAgKEpTQzo6REZHOjpTcGVjdWxh dGl2ZUpJVDo6ZW1pdEFsbG9jYXRlSlNGaW5hbE9iamVjdCk6IENoYW5nZWQgdG8gdXNlIHRoZSBu ZXcgaGVscGVyIGZ1bmN0aW9uLgorCisyMDEyLTAyLTI4ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFo bmVuYmVyZ0BhcHBsZS5jb20+CisKICAgICAgICAgUmUtZW5hYmxlIHBhcmFsbGVsIEdDIG9uIE1h YwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzk4MzcK IApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJ VC5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5oCmluZGV4 IDQ1OTUzNGM2ODYxYjRkYTM5OThmZDg2NGQwYmZlMDVkN2ViOWQ5NjEuLjBjZWM4ZmJlOGVlNjM0 NTViNzA5NzJjNTMwYjlhMTYzNWEyNDZhMjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR1NwZWN1bGF0aXZlSklULmgKQEAgLTE3MzcsMTMgKzE3MzcsMTUgQEAgcHJpdmF0ZToK ICAgICB2b2lkIGNvbXBpbGVOZXdGdW5jdGlvbk5vQ2hlY2soTm9kZSYgbm9kZSk7CiAgICAgdm9p ZCBjb21waWxlTmV3RnVuY3Rpb25FeHByZXNzaW9uKE5vZGUmIG5vZGUpOwogICAgIAotICAgIC8v IEl0IGlzIGFjY2VwdGFibGUgdG8gaGF2ZSBzdHJ1Y3R1cmUgYmUgZXF1YWwgdG8gc2NyYXRjaCwg c28gbG9uZyBhcyB5b3UncmUgZmluZQotICAgIC8vIHdpdGggdGhlIHN0cnVjdHVyZSBHUFIgYmVp bmcgY2xvYmJlcmVkLgotICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+Ci0gICAgdm9pZCBlbWl0QWxs b2NhdGVKU0ZpbmFsT2JqZWN0KFQgc3RydWN0dXJlLCBHUFJSZWcgcmVzdWx0R1BSLCBHUFJSZWcg c2NyYXRjaEdQUiwgTWFjcm9Bc3NlbWJsZXI6Okp1bXBMaXN0JiBzbG93UGF0aCkKKyAgICB0ZW1w bGF0ZSA8dHlwZW5hbWUgQ2xhc3NUeXBlLCBib29sIGRlc3RydWN0b3IsIHR5cGVuYW1lIFN0cnVj dHVyZVR5cGU+IAorICAgIHZvaWQgZW1pdEFsbG9jYXRlQmFzaWNKU09iamVjdChTdHJ1Y3R1cmVU eXBlIHN0cnVjdHVyZSwgR1BSUmVnIHJlc3VsdEdQUiwgR1BSUmVnIHNjcmF0Y2hHUFIsIE1hY3Jv QXNzZW1ibGVyOjpKdW1wTGlzdCYgc2xvd1BhdGgpCiAgICAgewotICAgICAgICBNYXJrZWRBbGxv Y2F0b3IqIGFsbG9jYXRvciA9ICZtX2ppdC5nbG9iYWxEYXRhKCktPmhlYXAuYWxsb2NhdG9yRm9y T2JqZWN0V2l0aG91dERlc3RydWN0b3Ioc2l6ZW9mKEpTRmluYWxPYmplY3QpKTsKLSAgICAgICAg CisgICAgICAgIE1hcmtlZEFsbG9jYXRvciogYWxsb2NhdG9yID0gMDsKKyAgICAgICAgaWYgKGRl c3RydWN0b3IpCisgICAgICAgICAgICBhbGxvY2F0b3IgPSAmbV9qaXQuZ2xvYmFsRGF0YSgpLT5o ZWFwLmFsbG9jYXRvckZvck9iamVjdFdpdGhEZXN0cnVjdG9yKHNpemVvZihDbGFzc1R5cGUpKTsK KyAgICAgICAgZWxzZQorICAgICAgICAgICAgYWxsb2NhdG9yID0gJm1faml0Lmdsb2JhbERhdGEo KS0+aGVhcC5hbGxvY2F0b3JGb3JPYmplY3RXaXRob3V0RGVzdHJ1Y3RvcihzaXplb2YoQ2xhc3NU eXBlKSk7CisKICAgICAgICAgbV9qaXQubG9hZFB0cigmYWxsb2NhdG9yLT5tX2ZpcnN0RnJlZUNl bGwsIHJlc3VsdEdQUik7CiAgICAgICAgIHNsb3dQYXRoLmFwcGVuZChtX2ppdC5icmFuY2hUZXN0 UHRyKE1hY3JvQXNzZW1ibGVyOjpaZXJvLCByZXN1bHRHUFIpKTsKICAgICAgICAgCkBAIC0xNzU5 LDE0ICsxNzYxLDIyIEBAIHByaXZhdGU6CiAgICAgICAgIG1faml0LnN0b3JlUHRyKHNjcmF0Y2hH UFIsICZhbGxvY2F0b3ItPm1fZmlyc3RGcmVlQ2VsbCk7CiAgICAgICAgIAogICAgICAgICAvLyBJ bml0aWFsaXplIHRoZSBvYmplY3QncyBjbGFzc0luZm8gcG9pbnRlcgotICAgICAgICBtX2ppdC5z dG9yZVB0cihNYWNyb0Fzc2VtYmxlcjo6VHJ1c3RlZEltbVB0cigmSlNGaW5hbE9iamVjdDo6c19p bmZvKSwgTWFjcm9Bc3NlbWJsZXI6OkFkZHJlc3MocmVzdWx0R1BSLCBKU0NlbGw6OmNsYXNzSW5m b09mZnNldCgpKSk7CisgICAgICAgIG1faml0LnN0b3JlUHRyKE1hY3JvQXNzZW1ibGVyOjpUcnVz dGVkSW1tUHRyKCZDbGFzc1R5cGU6OnNfaW5mbyksIE1hY3JvQXNzZW1ibGVyOjpBZGRyZXNzKHJl c3VsdEdQUiwgSlNDZWxsOjpjbGFzc0luZm9PZmZzZXQoKSkpOwogICAgICAgICAKICAgICAgICAg Ly8gSW5pdGlhbGl6ZSB0aGUgb2JqZWN0J3MgaW5oZXJpdG9ySUQuCiAgICAgICAgIG1faml0LnN0 b3JlUHRyKE1hY3JvQXNzZW1ibGVyOjpUcnVzdGVkSW1tUHRyKDApLCBNYWNyb0Fzc2VtYmxlcjo6 QWRkcmVzcyhyZXN1bHRHUFIsIEpTT2JqZWN0OjpvZmZzZXRPZkluaGVyaXRvcklEKCkpKTsKICAg ICAgICAgCiAgICAgICAgIC8vIEluaXRpYWxpemUgdGhlIG9iamVjdCdzIHByb3BlcnR5IHN0b3Jh Z2UgcG9pbnRlci4KICAgICAgICAgbV9qaXQuYWRkUHRyKE1hY3JvQXNzZW1ibGVyOjpUcnVzdGVk SW1tMzIoc2l6ZW9mKEpTT2JqZWN0KSksIHJlc3VsdEdQUiwgc2NyYXRjaEdQUik7Ci0gICAgICAg IG1faml0LnN0b3JlUHRyKHNjcmF0Y2hHUFIsIE1hY3JvQXNzZW1ibGVyOjpBZGRyZXNzKHJlc3Vs dEdQUiwgSlNGaW5hbE9iamVjdDo6b2Zmc2V0T2ZQcm9wZXJ0eVN0b3JhZ2UoKSkpOworICAgICAg ICBtX2ppdC5zdG9yZVB0cihzY3JhdGNoR1BSLCBNYWNyb0Fzc2VtYmxlcjo6QWRkcmVzcyhyZXN1 bHRHUFIsIENsYXNzVHlwZTo6b2Zmc2V0T2ZQcm9wZXJ0eVN0b3JhZ2UoKSkpOworICAgIH0KKwor ICAgIC8vIEl0IGlzIGFjY2VwdGFibGUgdG8gaGF2ZSBzdHJ1Y3R1cmUgYmUgZXF1YWwgdG8gc2Ny YXRjaCwgc28gbG9uZyBhcyB5b3UncmUgZmluZQorICAgIC8vIHdpdGggdGhlIHN0cnVjdHVyZSBH UFIgYmVpbmcgY2xvYmJlcmVkLgorICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+CisgICAgdm9pZCBl bWl0QWxsb2NhdGVKU0ZpbmFsT2JqZWN0KFQgc3RydWN0dXJlLCBHUFJSZWcgcmVzdWx0R1BSLCBH UFJSZWcgc2NyYXRjaEdQUiwgTWFjcm9Bc3NlbWJsZXI6Okp1bXBMaXN0JiBzbG93UGF0aCkKKyAg ICB7CisgICAgICAgIHJldHVybiBlbWl0QWxsb2NhdGVCYXNpY0pTT2JqZWN0PEpTRmluYWxPYmpl Y3QsIGZhbHNlPihzdHJ1Y3R1cmUsIHJlc3VsdEdQUiwgc2NyYXRjaEdQUiwgc2xvd1BhdGgpOwog ICAgIH0KIAogI2lmIFVTRShKU1ZBTFVFNjQpIAo=