79800 2012-02-28 08:49:00 -0800 [Qt] Fix build for WK2, do not use enum type if values can be outside the enum 2012-03-02 09:07:19 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 78821 1 cmarcelo cmarcelo hausmann kenneth menard ossy webkit.review.bot zoltan oldest_to_newest 566733 0 cmarcelo 2012-02-28 08:49:00 -0800 [Qt] Fix build for WK2, do not use enum type if values can be outside the enum 566737 1 129269 cmarcelo 2012-02-28 08:51:09 -0800 Created attachment 129269 Patch 566747 2 129269 kenneth 2012-02-28 08:55:32 -0800 Comment on attachment 129269 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129269&action=review > Source/WebKit2/ChangeLog:10 > + We have two different enums called NavigationRequestAction. If we use one of them > + to store the variables, compilers can rightfully warn about comparison with > + values from other enums. why do we have that? ain't they namespaced? > Source/WebKit2/ChangeLog:12 > + We might revist the strategy of exposing different enumerations in experimental, revisit 566756 3 129269 ossy 2012-02-28 09:00:23 -0800 Comment on attachment 129269 Patch rs=me to fix the build now, but we _really_ need to refactor using two NavigationRequestAction enum. :-/ 566759 4 cmarcelo 2012-02-28 09:03:47 -0800 Committed r109113: <http://trac.webkit.org/changeset/109113> 566766 5 129269 cmarcelo 2012-02-28 09:09:19 -0800 Comment on attachment 129269 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129269&action=review >> Source/WebKit2/ChangeLog:10 >> + values from other enums. > > why do we have that? ain't they namespaced? We can't choose one or other to be the type of the property since the values come from different enums. Namespacing is not an issue here. The QtWebKit API exposes a property that takes values from two different enums. 566773 6 ossy 2012-02-28 09:12:57 -0800 Reopen, because we need a proper fix instead of workaround. 569689 7 cmarcelo 2012-03-02 09:07:19 -0800 (In reply to comment #6) > Reopen, because we need a proper fix instead of workaround. I prefer closing this since it was intended just to revert the code back to its previous state. See bug 80164 for changes that deal with the workaround. 129269 2012-02-28 08:51:09 -0800 2012-02-28 09:13:07 -0800 Patch bug-79800-20120228135109.patch text/plain 4702 cmarcelo U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5MTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjk1MWZjZGRkMGY1Nzgy NjMxMjUxNDNhYzZiMjU1Y2YzMjIwNTY4YS4uMmIzMGVkNTZjYTFiMjJiMWZmYWRlODg1MTFjOWM2 Y2M2ZWUxZmI3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTAyLTI4ICBDYWlv IE1hcmNlbG8gZGUgT2xpdmVpcmEgRmlsaG8gIDxjYWlvLm9saXZlaXJhQG9wZW5ib3NzYS5vcmc+ CisKKyAgICAgICAgW1F0XSBGaXggYnVpbGQgZm9yIFdLMiwgZG8gbm90IHVzZSBlbnVtIHR5cGUg aWYgdmFsdWVzIGNhbiBiZSBvdXRzaWRlIHRoZSBlbnVtCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03OTgwMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGhhdmUgdHdvIGRpZmZlcmVudCBlbnVtcyBjYWxs ZWQgTmF2aWdhdGlvblJlcXVlc3RBY3Rpb24uIElmIHdlIHVzZSBvbmUgb2YgdGhlbQorICAgICAg ICB0byBzdG9yZSB0aGUgdmFyaWFibGVzLCBjb21waWxlcnMgY2FuIHJpZ2h0ZnVsbHkgd2FybiBh Ym91dCBjb21wYXJpc29uIHdpdGgKKyAgICAgICAgdmFsdWVzIGZyb20gb3RoZXIgZW51bXMuCisK KyAgICAgICAgV2UgbWlnaHQgcmV2aXN0IHRoZSBzdHJhdGVneSBvZiBleHBvc2luZyBkaWZmZXJl bnQgZW51bWVyYXRpb25zIGluIGV4cGVyaW1lbnRhbCwKKyAgICAgICAgYnV0IGZvciBub3csIGZh bGxiYWNrIHRvIHVzaW5nIGludCBmb3IgdGhlICdhY3Rpb24nIHByb3BlcnR5IGluCisgICAgICAg IFFXZWJOYXZpZ2F0aW9uUmVxdWVzdC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvcXdl Ym5hdmlnYXRpb25yZXF1ZXN0LmNwcDoKKyAgICAgICAgKFFXZWJOYXZpZ2F0aW9uUmVxdWVzdFBy aXZhdGUpOgorICAgICAgICAoUVdlYk5hdmlnYXRpb25SZXF1ZXN0OjpzZXRBY3Rpb24pOgorICAg ICAgICAoUVdlYk5hdmlnYXRpb25SZXF1ZXN0OjphY3Rpb24pOgorICAgICAgICAqIFVJUHJvY2Vz cy9BUEkvcXQvcXdlYm5hdmlnYXRpb25yZXF1ZXN0X3AuaDoKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL3F0L3Rlc3RzL3B1YmxpY2FwaS90c3RfcHVibGljYXBpLmNwcDoKKwogMjAxMi0wMi0yNyAg Q2FpbyBNYXJjZWxvIGRlIE9saXZlaXJhIEZpbGhvICA8Y2Fpby5vbGl2ZWlyYUBvcGVuYm9zc2Eu b3JnPgogCiAgICAgICAgIFtRdF0gQVBJIGNoYW5nZXMgdG8gUVdlYk5hdmlnYXRpb25SZXF1ZXN0 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3ZWJuYXZpZ2F0 aW9ucmVxdWVzdC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3ZWJuYXZp Z2F0aW9ucmVxdWVzdC5jcHAKaW5kZXggOTJhZjI3MTc5NmJiOGNiODQ4ZDg1YTI4ZGVjMjA0YmM3 N2FlMThkMS4uNmMzZWQ4Mzk5OTlhOTYzYjQwMzA2YTFiODE1NDcwNjVjNmMxMmEzZSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xd2VibmF2aWdhdGlvbnJlcXVl c3QuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdlYm5hdmlnYXRp b25yZXF1ZXN0LmNwcApAQCAtNDEsNyArNDEsNyBAQCBwdWJsaWM6CiAgICAgUVVybCB1cmw7CiAg ICAgUXQ6Ok1vdXNlQnV0dG9uIG1vdXNlQnV0dG9uOwogICAgIFF0OjpLZXlib2FyZE1vZGlmaWVy cyBrZXlib2FyZE1vZGlmaWVyczsKLSAgICBRUXVpY2tXZWJWaWV3OjpOYXZpZ2F0aW9uUmVxdWVz dEFjdGlvbiBhY3Rpb247CisgICAgaW50IGFjdGlvbjsKICAgICBRUXVpY2tXZWJWaWV3OjpOYXZp Z2F0aW9uVHlwZSBuYXZpZ2F0aW9uVHlwZTsKIH07CiAKQEAgLTU2LDcgKzU2LDcgQEAgUVdlYk5h dmlnYXRpb25SZXF1ZXN0Ojp+UVdlYk5hdmlnYXRpb25SZXF1ZXN0KCkKICAgICBkZWxldGUgZDsK IH0KIAotdm9pZCBRV2ViTmF2aWdhdGlvblJlcXVlc3Q6OnNldEFjdGlvbihRUXVpY2tXZWJWaWV3 OjpOYXZpZ2F0aW9uUmVxdWVzdEFjdGlvbiBhY3Rpb24pCit2b2lkIFFXZWJOYXZpZ2F0aW9uUmVx dWVzdDo6c2V0QWN0aW9uKGludCBhY3Rpb24pCiB7CiAgICAgaWYgKGQtPmFjdGlvbiA9PSBhY3Rp b24pCiAgICAgICAgIHJldHVybjsKQEAgLTgwLDcgKzgwLDcgQEAgaW50IFFXZWJOYXZpZ2F0aW9u UmVxdWVzdDo6a2V5Ym9hcmRNb2RpZmllcnMoKSBjb25zdAogICAgIHJldHVybiBpbnQoZC0+a2V5 Ym9hcmRNb2RpZmllcnMpOwogfQogCi1RUXVpY2tXZWJWaWV3OjpOYXZpZ2F0aW9uUmVxdWVzdEFj dGlvbiBRV2ViTmF2aWdhdGlvblJlcXVlc3Q6OmFjdGlvbigpIGNvbnN0CitpbnQgUVdlYk5hdmln YXRpb25SZXF1ZXN0OjphY3Rpb24oKSBjb25zdAogewogICAgIHJldHVybiBkLT5hY3Rpb247CiB9 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3ZWJuYXZpZ2F0 aW9ucmVxdWVzdF9wLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3ZWJuYXZp Z2F0aW9ucmVxdWVzdF9wLmgKaW5kZXggYjQwMWRlZGE1ZDA5NzY0MDBmNjcwZTBhNWNmYWIwNDdl ZDM1ZDBjZS4uNDcxNDM0MzY4ZWRhYzYyNGUzODQzNzgwZjBjNDFmZTRjMjI5ZDZjMCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xd2VibmF2aWdhdGlvbnJlcXVl c3RfcC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdlYm5hdmlnYXRp b25yZXF1ZXN0X3AuaApAQCAtMzMsNyArMzMsNyBAQCBjbGFzcyBRV0VCS0lUX0VYUE9SVCBRV2Vi TmF2aWdhdGlvblJlcXVlc3QgOiBwdWJsaWMgUU9iamVjdCB7CiAgICAgUV9QUk9QRVJUWShRVXJs IHVybCBSRUFEIHVybCBDT05TVEFOVCBGSU5BTCkKICAgICBRX1BST1BFUlRZKGludCBtb3VzZUJ1 dHRvbiBSRUFEIG1vdXNlQnV0dG9uIENPTlNUQU5UIEZJTkFMKQogICAgIFFfUFJPUEVSVFkoaW50 IGtleWJvYXJkTW9kaWZpZXJzIFJFQUQga2V5Ym9hcmRNb2RpZmllcnMgQ09OU1RBTlQgRklOQUwp Ci0gICAgUV9QUk9QRVJUWShRUXVpY2tXZWJWaWV3OjpOYXZpZ2F0aW9uUmVxdWVzdEFjdGlvbiBh Y3Rpb24gUkVBRCBhY3Rpb24gV1JJVEUgc2V0QWN0aW9uIE5PVElGWSBhY3Rpb25DaGFuZ2VkIEZJ TkFMKQorICAgIFFfUFJPUEVSVFkoaW50IGFjdGlvbiBSRUFEIGFjdGlvbiBXUklURSBzZXRBY3Rp b24gTk9USUZZIGFjdGlvbkNoYW5nZWQgRklOQUwpCiAgICAgUV9QUk9QRVJUWShRUXVpY2tXZWJW aWV3OjpOYXZpZ2F0aW9uVHlwZSBuYXZpZ2F0aW9uVHlwZSBSRUFEIG5hdmlnYXRpb25UeXBlIENP TlNUQU5UIEZJTkFMKQogCiBwdWJsaWM6CkBAIC00Myw5ICs0Myw5IEBAIHB1YmxpYzoKICAgICBR VXJsIHVybCgpIGNvbnN0OwogICAgIGludCBtb3VzZUJ1dHRvbigpIGNvbnN0OwogICAgIGludCBr ZXlib2FyZE1vZGlmaWVycygpIGNvbnN0OwotICAgIFFRdWlja1dlYlZpZXc6Ok5hdmlnYXRpb25S ZXF1ZXN0QWN0aW9uIGFjdGlvbigpIGNvbnN0OworICAgIGludCBhY3Rpb24oKSBjb25zdDsKIAot ICAgIHZvaWQgc2V0QWN0aW9uKFFRdWlja1dlYlZpZXc6Ok5hdmlnYXRpb25SZXF1ZXN0QWN0aW9u IGFjdGlvbik7CisgICAgdm9pZCBzZXRBY3Rpb24oaW50IGFjdGlvbik7CiAgICAgUVF1aWNrV2Vi Vmlldzo6TmF2aWdhdGlvblR5cGUgbmF2aWdhdGlvblR5cGUoKSBjb25zdDsKIAogUV9TSUdOQUxT OgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9wdWJs aWNhcGkvdHN0X3B1YmxpY2FwaS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0 L3Rlc3RzL3B1YmxpY2FwaS90c3RfcHVibGljYXBpLmNwcAppbmRleCBiYjgwM2U2NzU3NzU0ZTYz YjFmM2I0YWFiNmU3YzdlODk2ZTU3ZTcxLi5iYmQ2YjI4MjFiZTdkMjQyYmFlYWIxYmNjYjI2MzYz OGI1YTFmMjE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rl c3RzL3B1YmxpY2FwaS90c3RfcHVibGljYXBpLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL3F0L3Rlc3RzL3B1YmxpY2FwaS90c3RfcHVibGljYXBpLmNwcApAQCAtODUsNyAr ODUsNyBAQCBzdGF0aWMgUVN0cmluZ0xpc3QgZXhwZWN0ZWRBUEkgPSBRU3RyaW5nTGlzdCgpCiAg ICAgPDwgIlFXZWJOYXZpZ2F0aW9uUmVxdWVzdC51cmwgLS0+IFFVcmwiCiAgICAgPDwgIlFXZWJO YXZpZ2F0aW9uUmVxdWVzdC5tb3VzZUJ1dHRvbiAtLT4gaW50IgogICAgIDw8ICJRV2ViTmF2aWdh dGlvblJlcXVlc3Qua2V5Ym9hcmRNb2RpZmllcnMgLS0+IGludCIKLSAgICA8PCAiUVdlYk5hdmln YXRpb25SZXF1ZXN0LmFjdGlvbiAtLT4gUVF1aWNrV2ViVmlldzo6TmF2aWdhdGlvblJlcXVlc3RB Y3Rpb24iCisgICAgPDwgIlFXZWJOYXZpZ2F0aW9uUmVxdWVzdC5hY3Rpb24gLS0+IGludCIKICAg ICA8PCAiUVdlYk5hdmlnYXRpb25SZXF1ZXN0Lm5hdmlnYXRpb25UeXBlIC0tPiBRUXVpY2tXZWJW aWV3OjpOYXZpZ2F0aW9uVHlwZSIKICAgICA8PCAiUVdlYk5hdmlnYXRpb25SZXF1ZXN0LmFjdGlv bkNoYW5nZWQoKSAtLT4gdm9pZCIKICAgICA7Cg==