79799 2012-02-28 08:40:25 -0800 webkit-patch can't find bug numbers from ChangeLog entries that use wkb.ug URLs 2012-02-28 09:13:30 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 79806 1 aroben aroben abarth mitz ojan webkit.review.bot oldest_to_newest 566721 0 aroben 2012-02-28 08:40:25 -0800 webkit-patch can't find bug numbers from ChangeLog entries that use wkb.ug URLs 566722 1 129262 aroben 2012-02-28 08:40:58 -0800 Created attachment 129262 Patch 566735 2 aroben 2012-02-28 08:49:52 -0800 Committed r109110: <http://trac.webkit.org/changeset/109110> 566739 3 mitz 2012-02-28 08:52:35 -0800 I don't think it's good to have this link format in change logs. Why make it easier to do so? 566743 4 aroben 2012-02-28 08:54:44 -0800 (In reply to comment #3) > I don't think it's good to have this link format in change logs. Why make it easier to do so? I added it for consistency with our support for http://webkit.org/b/NNNNN. Do you think that format also doesn't belong in ChangeLogs? 566757 5 mitz 2012-02-28 09:01:29 -0800 (In reply to comment #4) > (In reply to comment #3) > > I don't think it's good to have this link format in change logs. Why make it easier to do so? > > I added it for consistency with our support for http://webkit.org/b/NNNNN. Do you think that format also doesn't belong in ChangeLogs? I think that format is fine. It's in the same high-level domain as the bug database itself (webkit.org). 566769 6 aroben 2012-02-28 09:10:57 -0800 OK, I'll roll this out. 129262 2012-02-28 08:40:58 -0800 2012-02-28 08:41:59 -0800 Patch bug-79799-20120228114056.patch text/plain 5011 aroben U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5MTAzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWQ0YTMxMTRiY2Q2NTM1YmMyMTljYjRhYWViNDRiY2Zk YzZmYjk0MS4uZmYxMjk4ZGYwNTkxNGM1ZWViYmQ1OTVhN2RjZDdjNDU2OGY5YTBlYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDEyLTAyLTI4ICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KKworICAgICAg ICBUZWFjaCB3ZWJraXRweSBhYm91dCB3a2IudWcgVVJMcworCisgICAgICAgIEZpeGVzIDxodHRw Oi8vd2tiLnVnLzc5Nzk5PiB3ZWJraXQtcGF0Y2ggY2FuJ3QgZmluZCBidWcgbnVtYmVycyBmcm9t IENoYW5nZUxvZyBlbnRyaWVzIHRoYXQKKyAgICAgICAgdXNlIHdrYi51ZyBVUkxzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi9jaGVja291dC9jaGFuZ2Vsb2cucHk6CisgICAgICAgIChwYXJzZV9idWdfaWQp OgorICAgICAgICAocGFyc2VfYnVnX2lkX2Zyb21fY2hhbmdlbG9nKToKKyAgICAgICAgRmFsbCBi YWNrIHRvIHRoZSB0aW55IFVSTCBmb3JtYXQgaWYgbmVpdGhlciB0aGUgc2hvcnQgbm9yIGxvbmcg VVJMIGZvcm1hdHMgd29yay4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2No ZWNrb3V0L2NoYW5nZWxvZ191bml0dGVzdC5weToKKyAgICAgICAgKENoYW5nZUxvZ1Rlc3QudGVz dF9wYXJzZV9idWdfaWRfZnJvbV9jaGFuZ2Vsb2cpOiBBZGRlZCB0ZXN0cyBmb3IgdGhlIGFib3Zl IGNoYW5nZXMuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvdXJs cy5weTogQWRkZWQgYnVnX3VybF90aW55LCB3aGljaCBjYW4gYmUgdXNlZCB0byBtYXRjaAorICAg ICAgICB3a2IudWcgVVJMcy4KKwogMjAxMi0wMi0yOCAgQWRhbSBSb2JlbiAgPGFyb2JlbkB3ZWJr aXQub3JnPgogCiAgICAgICAgIEFkZCBteSBuZXcgZW1haWwgYWRkcmVzcwpkaWZmIC0tZ2l0IGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvY2hhbmdlbG9nLnB5IGIvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvY2hhbmdlbG9nLnB5CmluZGV4IDU1 YjA1OTgyYjllMTdkNWQyYzc5YmU0YTBhMmQ1Mzc0MmI1NTFkYzYuLjJkNmNkN2QwODJjOGNmYzNk YTE5MDRiYTJiY2RlZTEyNTgwMjNmYjggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvY29tbW9uL2NoZWNrb3V0L2NoYW5nZWxvZy5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi9jaGVja291dC9jaGFuZ2Vsb2cucHkKQEAgLTUwLDYgKzUwLDkgQEAgZGVmIHBh cnNlX2J1Z19pZChtZXNzYWdlKToKICAgICBtYXRjaCA9IHJlLnNlYXJjaChjb25maWdfdXJscy5i dWdfdXJsX2xvbmcsIG1lc3NhZ2UpCiAgICAgaWYgbWF0Y2g6CiAgICAgICAgIHJldHVybiBpbnQo bWF0Y2guZ3JvdXAoJ2J1Z19pZCcpKQorICAgIG1hdGNoID0gcmUuc2VhcmNoKGNvbmZpZ191cmxz LmJ1Z191cmxfdGlueSwgbWVzc2FnZSkKKyAgICBpZiBtYXRjaDoKKyAgICAgICAgcmV0dXJuIGlu dChtYXRjaC5ncm91cCgnYnVnX2lkJykpCiAgICAgcmV0dXJuIE5vbmUKIAogCkBAIC02NSw2ICs2 OCw5IEBAIGRlZiBwYXJzZV9idWdfaWRfZnJvbV9jaGFuZ2Vsb2cobWVzc2FnZSk6CiAgICAgbWF0 Y2ggPSByZS5zZWFyY2goIl5ccyoiICsgY29uZmlnX3VybHMuYnVnX3VybF9sb25nICsgIiQiLCBt ZXNzYWdlLCByZS5NVUxUSUxJTkUpCiAgICAgaWYgbWF0Y2g6CiAgICAgICAgIHJldHVybiBpbnQo bWF0Y2guZ3JvdXAoJ2J1Z19pZCcpKQorICAgIG1hdGNoID0gcmUuc2VhcmNoKCJeXHMqIiArIGNv bmZpZ191cmxzLmJ1Z191cmxfdGlueSArICIkIiwgbWVzc2FnZSwgcmUuTVVMVElMSU5FKQorICAg IGlmIG1hdGNoOgorICAgICAgICByZXR1cm4gaW50KG1hdGNoLmdyb3VwKCdidWdfaWQnKSkKICAg ICAjIFdlIHdlcmVuJ3QgYWJsZSB0byBmaW5kIGEgYnVnIFVSTCBpbiB0aGUgZm9ybWF0IHVzZWQg YnkgcHJlcGFyZS1DaGFuZ2VMb2cuIEZhbGwgYmFjayB0byB0aGUKICAgICAjIGZpcnN0IGJ1ZyBV UkwgZm91bmQgYW55d2hlcmUgaW4gdGhlIG1lc3NhZ2UuCiAgICAgcmV0dXJuIHBhcnNlX2J1Z19p ZChtZXNzYWdlKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hl Y2tvdXQvY2hhbmdlbG9nX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21t b24vY2hlY2tvdXQvY2hhbmdlbG9nX3VuaXR0ZXN0LnB5CmluZGV4IDQzMWM4NjcwMWZiOTQyYjMz ZWQ3M2ExMmNjMzg4MWIwYzIxMzMxOTkuLmIyOWZiMTYwYTkwODIzNTNhN2NkYjgzZmNlYmY2YmRk NTQ2MWFkMWYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNr b3V0L2NoYW5nZWxvZ191bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2Nv bW1vbi9jaGVja291dC9jaGFuZ2Vsb2dfdW5pdHRlc3QucHkKQEAgLTE5Nyw2ICsxOTcsMTkgQEAg Y2xhc3MgQ2hhbmdlTG9nVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgIHNlbGYuYXNz ZXJ0RXF1YWxzKDEyMzQ1LCBwYXJzZV9idWdfaWRfZnJvbV9jaGFuZ2Vsb2coY29tbWl0X3RleHQp KQogCiAgICAgICAgIGNvbW1pdF90ZXh0ID0gJycnCisyMDExLTAzLTIzICBPamFuIFZhZmFpICA8 b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQWRkIGZhaWxpbmcgcmVzdWx0IGZvciBXZWJL aXQyLiBBbGwgdGVzdHMgdGhhdCByZXF1aXJlCisgICAgICAgIGZvY3VzIGZhaWwgb24gV2ViS2l0 Mi4gU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Njk4OC4KKyAg ICAgICAgaHR0cDovL3drYi51Zy8xMjM0NQorCisgICAgICAgICogcGxhdGZvcm0vbWFjLXdrMi9m YXN0L2Nzcy9wc2V1ZG8tYW55LWV4cGVjdGVkLnR4dDogQWRkZWQuCisKKyAgICAgICAgJycnCisK KyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoMTIzNDUsIHBhcnNlX2J1Z19pZF9mcm9tX2NoYW5n ZWxvZyhjb21taXRfdGV4dCkpCisKKyAgICAgICAgY29tbWl0X3RleHQgPSAnJycKIDIwMTEtMDMt MzEgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFF1b3RlIHRoZSBl eGVjdXRhYmxlIHBhdGggd2UgcGFzcyB0byA6OkNyZWF0ZVByb2Nlc3NXCkBAIC0yMzIsNiArMjQ1 LDI1IEBAIGNsYXNzIENoYW5nZUxvZ1Rlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogCiAgICAgICAg IHNlbGYuYXNzZXJ0RXF1YWxzKDU3MzU0LCBwYXJzZV9idWdfaWRfZnJvbV9jaGFuZ2Vsb2coY29t bWl0X3RleHQpKQogCisgICAgICAgIGNvbW1pdF90ZXh0ID0gJycnCisyMDExLTAzLTMxICBBZGFt IFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KKworICAgICAgICBRdW90ZSB0aGUgZXhlY3V0YWJs ZSBwYXRoIHdlIHBhc3MgdG8gOjpDcmVhdGVQcm9jZXNzVworCisgICAgICAgIFRoaXMgd2lsbCBl bnN1cmUgdGhhdCBzcGFjZXMgaW4gdGhlIHBhdGggd2lsbCBiZSBpbnRlcnByZXRlZCBjb3JyZWN0 bHkuCisKKyAgICAgICAgRml4ZXMgPGh0dHA6Ly93a2IudWcvNTc1Njk+IFdlYiBwcm9jZXNzIHNv bWV0aW1lcyBmYWlscyB0byBsYXVuY2ggd2hlbiB0aGVyZSBhcmUKKyAgICAgICAgc3BhY2VzIGlu IGl0cyBwYXRoCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgU3RldmUgRmFsa2VuYnVyZy4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9MYXVuY2hlci93aW4vUHJvY2Vzc0xhdW5jaGVyV2luLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6UHJvY2Vzc0xhdW5jaGVyOjpsYXVuY2hQcm9jZXNzKTogU3Vycm91bmQg dGhlIGV4ZWN1dGFibGUgcGF0aCBpbiBxdW90ZXMuCisKKyAgICAgICAgJycnCisKKyAgICAgICAg c2VsZi5hc3NlcnRFcXVhbHMoNTc1NjksIHBhcnNlX2J1Z19pZF9mcm9tX2NoYW5nZWxvZyhjb21t aXRfdGV4dCkpCisKICAgICBkZWYgdGVzdF9wYXJzZV9sb2dfZW50cmllc19mcm9tX2NoYW5nZWxv ZyhzZWxmKToKICAgICAgICAgY2hhbmdlbG9nX2ZpbGUgPSBTdHJpbmdJTyhzZWxmLl9leGFtcGxl X2NoYW5nZWxvZykKICAgICAgICAgcGFyc2VkX2VudHJpZXMgPSBsaXN0KENoYW5nZUxvZy5wYXJz ZV9lbnRyaWVzX2Zyb21fZmlsZShjaGFuZ2Vsb2dfZmlsZSkpCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvdXJscy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvY29tbW9uL2NvbmZpZy91cmxzLnB5CmluZGV4IDFmOTAyZjQ2Mzk4MTNlMWRkNDNjZjE5 NDBkNGVjMDZjNTk4OTM0YzIuLjM4MGFhNGE2OWYzNmU0ZTM0ODA2YTQxOGU5OTFjY2I4ODNjYTFl Y2IgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy91cmxz LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy91cmxzLnB5CkBA IC00OCw2ICs0OCw3IEBAIF9idWdfc2VydmVyX3JlZ2V4ID0gImh0dHBzPzovLyVzLyIgJSByZS5z dWIoJ1wuJywgJ1xcLicsIGJ1Z19zZXJ2ZXJfaG9zdCkKIGJ1Z19zZXJ2ZXJfdXJsID0gImh0dHBz Oi8vJXMvIiAlIGJ1Z19zZXJ2ZXJfaG9zdAogYnVnX3VybF9sb25nID0gX2J1Z19zZXJ2ZXJfcmVn ZXggKyByInNob3dfYnVnXC5jZ2lcP2lkPSg/UDxidWdfaWQ+XGQrKSgmY3R5cGU9eG1sKT8iCiBi dWdfdXJsX3Nob3J0ID0gciJodHRwcz9cOi8vd2Via2l0XC5vcmcvYi8oP1A8YnVnX2lkPlxkKyki CitidWdfdXJsX3RpbnkgPSByImh0dHA6Ly93a2JcLnVnLyg/UDxidWdfaWQ+XGQrKSIKIAogYnVp bGRib3RfdXJsID0gImh0dHA6Ly9idWlsZC53ZWJraXQub3JnIgogY2hyb21pdW1fYnVpbGRib3Rf dXJsID0gImh0dHA6Ly9idWlsZC5jaHJvbWl1bS5vcmcvcC9jaHJvbWl1bS53ZWJraXQiCg==