79792 2012-02-28 07:38:41 -0800 Web Inspector: preserve memory counters size after frontend reopening 2012-02-28 08:27:56 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 yurys yurys apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 566664 0 yurys 2012-02-28 07:38:41 -0800 The size should be restored. 566667 1 129253 yurys 2012-02-28 07:40:41 -0800 Created attachment 129253 Patch 566691 2 129253 pfeldman 2012-02-28 08:12:13 -0800 Comment on attachment 129253 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129253&action=review > Source/WebCore/inspector/front-end/TimelinePanel.js:66 > + WebInspector.settings.memoryCounterGraphsHeight = WebInspector.settings.createSetting("memoryCounterGraphsHeight", 600); Inspector's default height is 600, this should be 150. > Source/WebCore/inspector/front-end/TimelinePanel.js:175 > + WebInspector.settings.memoryCounterGraphsHeight.set(top); this should be a part of _endSplitterDragging. 566700 3 yurys 2012-02-28 08:22:00 -0800 (In reply to comment #2) > (From update of attachment 129253 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=129253&action=review > > > Source/WebCore/inspector/front-end/TimelinePanel.js:66 > > + WebInspector.settings.memoryCounterGraphsHeight = WebInspector.settings.createSetting("memoryCounterGraphsHeight", 600); > > Inspector's default height is 600, this should be 150. > Done. > > Source/WebCore/inspector/front-end/TimelinePanel.js:175 > > + WebInspector.settings.memoryCounterGraphsHeight.set(top); > > this should be a part of _endSplitterDragging. Done. 566705 4 yurys 2012-02-28 08:27:56 -0800 Committed r109109: <http://trac.webkit.org/changeset/109109> 129253 2012-02-28 07:40:41 -0800 2012-02-28 08:12:13 -0800 Patch bug-79792-20120228194039.patch text/plain 4457 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5MTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTIyMGQwOTAzMDc0NjQy YWM5MWEwMWYxYTE5YWNlNmE2ZWUzOTQwNS4uZjY0MTRlYjViNjQxOGM1OWNlNTVkYmUyNzk3ZGFj NjM4M2JkYWRmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDEyLTAyLTI4ICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgogCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IHByZXNlcnZlIG1lbW9yeSBjb3VudGVycyBzaXplIGFmdGVyIGZyb250ZW5kIHJlb3Blbmlu ZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzk3OTIK KworICAgICAgICBDbGVhciBjb2xsZWN0ZWQgY291bnRlciB2YWx1ZXMgd2hlbiB0aW1lbGluZSBw YW5lbCBpcyByZXNldC4gUGVyc2lzdAorICAgICAgICB0aW1lbGluZSBncmlkL2NvdW50ZXJzIHNw bGl0dGVyIHBvc2l0aW9uIHRvIHJlc3RvcmUgaXQgd2hlbiBmcm9udC1lbmQKKyAgICAgICAgaXMg b3BlbmVkIG5leHQgdGltZS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvTWVtb3J5U3RhdGlzdGljcy5qczoKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5NZW1vcnlTdGF0aXN0aWNzLnByb3RvdHlwZS5yZXNldCk6Cisg ICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZVBhbmVsLmpzOgorICAgICAgICAo V2ViSW5zcGVjdG9yLlRpbWVsaW5lUGFuZWwpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVs aW5lUGFuZWwucHJvdG90eXBlLl9zZXRTcGxpdHRlclBvc2l0aW9uKToKKyAgICAgICAgKFdlYklu c3BlY3Rvci5UaW1lbGluZVBhbmVsLnByb3RvdHlwZS5fcmVzZXRQYW5lbCk6CisgICAgICAgICog aW5zcGVjdG9yL2Zyb250LWVuZC90aW1lbGluZVBhbmVsLmNzczoKKyAgICAgICAgKCNjb3VudGVy LXZhbHVlcy1iYXIpOgorCisyMDEyLTAyLTI4ICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hy b21pdW0ub3JnPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IHNob3cgcmVzb3VyY2UgZGl2aWRl cnMgb24gbWVtb3J5IGNvdW50ZXIgZ3JhcGhzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD03OTc4MgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL01lbW9yeVN0YXRpc3RpY3MuanMgYi9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL01lbW9yeVN0YXRpc3RpY3MuanMKaW5kZXggODk5Yzc2ZjEzZWI3 ZjExZDAwOWQ4ZGFhN2UyZDUxNGQxOThjODhmZi4uYzNmZGZiNTA2N2M0NGEzYjA3MjgyNzMwZWJh YTFjZjk5NGEzODc4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9NZW1vcnlTdGF0aXN0aWNzLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvTWVtb3J5U3RhdGlzdGljcy5qcwpAQCAtMjA3LDYgKzIwNywxMSBAQCBXZWJJbnNw ZWN0b3IuQ291bnRlclVJLnByb3RvdHlwZSA9IHsKIAogCiBXZWJJbnNwZWN0b3IuTWVtb3J5U3Rh dGlzdGljcy5wcm90b3R5cGUgPSB7CisgICAgcmVzZXQ6IGZ1bmN0aW9uKCkKKyAgICB7CisgICAg ICAgIHRoaXMuX2NvdW50ZXJzID0gW107CisgICAgfSwKKwogICAgIHNldE1haW5UaW1lbGluZUdy aWQ6IGZ1bmN0aW9uKHRpbWVsaW5lR3JpZCkKICAgICB7CiAgICAgICAgIHRoaXMuX21haW5UaW1l bGluZUdyaWQgPSB0aW1lbGluZUdyaWQ7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanMKaW5kZXggM2M1MTZjNTg5OThlZDZmZTJkNDBh ZWQ5YzY2NTRhYjkwOTYwZmRjNi4uYTQ5ZWEzN2NjM2VjMzcxODAzYjA3NWRkM2U2ZjljNzhlNTRj ODg4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1l bGluZVBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGlt ZWxpbmVQYW5lbC5qcwpAQCAtNjMsNiArNjMsNyBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVQYW5l bCA9IGZ1bmN0aW9uKCkKICAgICAgICAgdGhpcy5fdGltZWxpbmVNZW1vcnlTcGxpdHRlci5hZGRT dHlsZUNsYXNzKCJoaWRkZW4iKTsKICAgICAgICAgdGhpcy5fbWVtb3J5U3RhdGlzdGljcyA9IG5l dyBXZWJJbnNwZWN0b3IuTWVtb3J5U3RhdGlzdGljcyh0aGlzLCB0aGlzLnNwbGl0Vmlldy5wcmVm ZXJyZWRTaWRlYmFyV2lkdGgoKSk7CiAgICAgICAgIHRoaXMuX292ZXJ2aWV3UGFuZS5hZGRFdmVu dExpc3RlbmVyKFdlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3UGFuZS5FdmVudHMuTW9kZUNo YW5nZWQsIHRoaXMuX3RpbWVsaW5lc092ZXJ2aWV3TW9kZUNoYW5nZWQsIHRoaXMpOworICAgICAg ICBXZWJJbnNwZWN0b3Iuc2V0dGluZ3MubWVtb3J5Q291bnRlckdyYXBoc0hlaWdodCA9IFdlYklu c3BlY3Rvci5zZXR0aW5ncy5jcmVhdGVTZXR0aW5nKCJtZW1vcnlDb3VudGVyR3JhcGhzSGVpZ2h0 IiwgNjAwKTsKICAgICB9CiAKICAgICB2YXIgaXRlbXNUcmVlRWxlbWVudCA9IG5ldyBXZWJJbnNw ZWN0b3IuU2lkZWJhclNlY3Rpb25UcmVlRWxlbWVudChXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlJF Q09SRFMiKSwge30sIHRydWUpOwpAQCAtMTcxLDYgKzE3Miw3IEBAIFdlYkluc3BlY3Rvci5UaW1l bGluZVBhbmVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgdGhpcy5zcGxpdFZpZXcuZWxlbWVudC5z dHlsZS5oZWlnaHQgPSAodG9wIC0gb3ZlcnZpZXdIZWlnaHQpICsgInB4IjsKICAgICAgICAgdGhp cy5fdGltZWxpbmVNZW1vcnlTcGxpdHRlci5zdHlsZS50b3AgPSAodG9wIC0gMikgKyAicHgiOwog ICAgICAgICB0aGlzLl9tZW1vcnlTdGF0aXN0aWNzLnNldFRvcFBvc2l0aW9uKHRvcCk7CisgICAg ICAgIFdlYkluc3BlY3Rvci5zZXR0aW5ncy5tZW1vcnlDb3VudGVyR3JhcGhzSGVpZ2h0LnNldCh0 b3ApOwogICAgIH0sCiAKICAgICBnZXQgY2FsY3VsYXRvcigpCkBAIC0zODQsNyArMzg2LDcgQEAg V2ViSW5zcGVjdG9yLlRpbWVsaW5lUGFuZWwucHJvdG90eXBlID0gewogICAgICAgICAgICAgdGhp cy5fdGltZWxpbmVNZW1vcnlTcGxpdHRlci5yZW1vdmVTdHlsZUNsYXNzKCJoaWRkZW4iKTsKICAg ICAgICAgICAgIHRoaXMuX21lbW9yeVN0YXRpc3RpY3Muc2hvdygpOwogICAgICAgICAgICAgdGhp cy5zcGxpdFZpZXcuZWxlbWVudC5zdHlsZS5ib3R0b20gPSAiYXV0byI7Ci0gICAgICAgICAgICB0 aGlzLl9zZXRTcGxpdHRlclBvc2l0aW9uKDYwMCk7CisgICAgICAgICAgICB0aGlzLl9zZXRTcGxp dHRlclBvc2l0aW9uKFdlYkluc3BlY3Rvci5zZXR0aW5ncy5tZW1vcnlDb3VudGVyR3JhcGhzSGVp Z2h0LmdldCgpKTsKICAgICAgICAgfQogICAgICAgICB0aGlzLl9yZWZyZXNoKCk7CiAgICAgfSwK QEAgLTU2Nyw2ICs1NjksOCBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVQYW5lbC5wcm90b3R5cGUg PSB7CiAgICAgICAgIHRoaXMuX2Nsb3NlUmVjb3JkRGV0YWlscygpOwogICAgICAgICB0aGlzLl92 aXNpYmxlUmVjb3Jkc0NvdW50ID0gMDsKICAgICAgICAgdGhpcy5fYWxsUmVjb3Jkc0NvdW50ID0g MDsKKyAgICAgICAgaWYgKHRoaXMuX21lbW9yeVN0YXRpc3RpY3MpCisgICAgICAgICAgICB0aGlz Ll9tZW1vcnlTdGF0aXN0aWNzLnJlc2V0KCk7CiAgICAgfSwKIAogICAgIGVsZW1lbnRzVG9SZXN0 b3JlU2Nyb2xsUG9zaXRpb25zRm9yOiBmdW5jdGlvbigpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3RpbWVsaW5lUGFuZWwuY3NzIGIvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC90aW1lbGluZVBhbmVsLmNzcwppbmRleCAyYTIwYTk3MDU0 OTNjMWFlNWVhZTJmMTY4NTA2MTE5YTIyZGFmNWM0Li40MzkwZmYwYTQ0MTA5ZjVjYzlmM2M3NGE0 MDA1YzVlMzFlZDY4Y2M5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL3RpbWVsaW5lUGFuZWwuY3NzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvdGltZWxpbmVQYW5lbC5jc3MKQEAgLTU5OSw2ICs1OTksNyBAQAogCiAjY291bnRl ci12YWx1ZXMtYmFyIHsKICAgICBib3JkZXItYm90dG9tOiBzb2xpZCAxcHggbGlnaHRncmF5Owor ICAgIG1pbi1oZWlnaHQ6IDE1cHg7CiB9CiAKIC50aW1lbGluZS1vdmVydmlldy1zdGFydC1hdC16 ZXJvLWJhcnMgewo=