79787 2012-02-28 07:12:14 -0800 Do not iterate all tiles for resizing when the content didn't change 2012-02-29 09:02:11 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kenneth kenneth hausmann jturcotte noam oldest_to_newest 566635 0 kenneth 2012-02-28 07:12:14 -0800 SSIA 566637 1 129243 kenneth 2012-02-28 07:13:28 -0800 Created attachment 129243 Patch 566658 2 129243 jturcotte 2012-02-28 07:34:48 -0800 Comment on attachment 129243 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129243&action=review > Source/WebCore/platform/graphics/TiledBackingStore.cpp:241 > + if (visibleRect != m_previousVisibleRect) > + didResizeTiles = resizeEdgeTiles(); m_visibleRect and m_previousVisibleRect are both set in coverWithTilesIfNeeded, and then the creation timer is started. So in most case they will be equal and this code will never run, unless the visible rect changed between the timer start and fire which is unlikely. 566662 3 jturcotte 2012-02-28 07:37:30 -0800 (In reply to comment #2) Err, I mean the value of visibleContentsRect() instead of m_visibleRect. 566666 4 kenneth 2012-02-28 07:39:50 -0800 (In reply to comment #2) > (From update of attachment 129243 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=129243&action=review > > > Source/WebCore/platform/graphics/TiledBackingStore.cpp:241 > > + if (visibleRect != m_previousVisibleRect) > > + didResizeTiles = resizeEdgeTiles(); > > m_visibleRect and m_previousVisibleRect are both set in coverWithTilesIfNeeded, and then the creation timer is started. > So in most case they will be equal and this code will never run, unless the visible rect changed between the timer start and fire which is unlikely. This method (createTiles) is also called as a result of viewport change, which means that they are different. 566668 5 129243 noam 2012-02-28 07:41:41 -0800 Comment on attachment 129243 Patch I believe this code makes inappropriate use of m_previousVisibleRect. 566671 6 129243 kenneth 2012-02-28 07:45:14 -0800 Comment on attachment 129243 Patch I need coffee :-) This is wrong! 566724 7 129263 kenneth 2012-02-28 08:43:00 -0800 Created attachment 129263 Patch 566727 8 129265 kenneth 2012-02-28 08:44:15 -0800 Created attachment 129265 Patch 566816 9 129265 jturcotte 2012-02-28 10:00:08 -0800 Comment on attachment 129265 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129265&action=review > Source/WebCore/platform/graphics/TiledBackingStore.cpp:236 > + const IntRect& visibleRect = visibleContentsRect(); Is it OK to use a reference here? > Source/WebCore/platform/graphics/TiledBackingStore.cpp:246 > + if (contentsSize != m_previousContentsSize) m_previousContentsSize is never assigned, so this patch doesn't do much, unless I'm missing something :/ 566818 10 129265 noam 2012-02-28 10:02:07 -0800 Comment on attachment 129265 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129265&action=review r- based on jocelyn's comments. >> Source/WebCore/platform/graphics/TiledBackingStore.cpp:236 >> + const IntRect& visibleRect = visibleContentsRect(); > > Is it OK to use a reference here? I think it doesn't add much to use references. Let's use regular assignment. 567486 11 kenneth 2012-02-29 01:07:45 -0800 (In reply to comment #9) > (From update of attachment 129265 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=129265&action=review > > > Source/WebCore/platform/graphics/TiledBackingStore.cpp:236 > > + const IntRect& visibleRect = visibleContentsRect(); > > Is it OK to use a reference here? > > > Source/WebCore/platform/graphics/TiledBackingStore.cpp:246 > > + if (contentsSize != m_previousContentsSize) > > m_previousContentsSize is never assigned, so this patch doesn't do much, unless I'm missing something :/ I guess my brain wasn't working correctly yesterday. I ofcourse meant to assign it just as we do with the visible rect 567506 12 129414 kenneth 2012-02-29 01:33:30 -0800 Created attachment 129414 Patch 567547 13 129414 hausmann 2012-02-29 03:05:29 -0800 Comment on attachment 129414 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129414&action=review > Source/WebCore/ChangeLog:3 > + Do not interate all tiles for resizing when the content didn't change Interate looks like a typo :) 567663 14 kenneth 2012-02-29 09:02:11 -0800 Landed in 109219. 129243 2012-02-28 07:13:28 -0800 2012-02-28 08:42:51 -0800 Patch bug-79787-20120228160656.patch text/plain 1807 kenneth U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4OTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmZhMTg3NWU2NDIwNWRi YjMzZTQ3YmE1MjQ3YjkyZGU2YjU3YWFiMi4uMTQyYmVkNzRkODA5ZTIwMTliYmQ5OGYxZDM4M2Y1 OGU2YmE0OWYzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAyLTI4ICBLZW5u ZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KKworICAgICAgICBE byBub3QgaW50ZXJhdGUgYWxsIHRpbGVzIGZvciByZXNpemluZyB3aGVuIHRoZSB2aWV3cG9ydCBk aWRuJ3QgY2hhbmdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03OTc4NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvVGlsZWRCYWNraW5nU3RvcmUuY3BwOgorICAgICAgICAo V2ViQ29yZTo6VGlsZWRCYWNraW5nU3RvcmU6OmNyZWF0ZVRpbGVzKToKKwogMjAxMi0wMi0yNyAg S2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4gIDxrZW5uZXRoQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgSW1wcm92ZSB0aGUgdmlzdWFsIG9mIHRoZSB0aWxpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1RpbGVkQmFja2luZ1N0b3JlLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1RpbGVkQmFja2luZ1N0b3JlLmNwcAppbmRleCBmYWFj MGJiZjgxMjM5M2VjNGIyZTVlYzg3ZGMyZmUzMjIwZjc0MjgzLi5jNDdmZjg5YWY5OTFiNmYyZDIz YWE2MDljZjkwYWM3ZjMxZWJiMmI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9UaWxlZEJhY2tpbmdTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvVGlsZWRCYWNraW5nU3RvcmUuY3BwCkBAIC0yMzIsMTYgKzIzMiwxOSBA QCB2b2lkIFRpbGVkQmFja2luZ1N0b3JlOjpjcmVhdGVUaWxlcygpCiB7CiAgICAgaWYgKG1fY29u dGVudHNGcm96ZW4pCiAgICAgICAgIHJldHVybjsKLSAgICAKLSAgICBJbnRSZWN0IHZpc2libGVS ZWN0ID0gdmlzaWJsZUNvbnRlbnRzUmVjdCgpOworCisgICAgY29uc3QgSW50UmVjdCYgdmlzaWJs ZVJlY3QgPSB2aXNpYmxlQ29udGVudHNSZWN0KCk7CisKKyAgICAvLyBSZXNpemUgdGlsZXMgb24g ZWRnZXMgaW4gY2FzZSB0aGUgY29udGVudHMgc2l6ZSBoYXMgY2hhbmdlZC4KKyAgICBib29sIGRp ZFJlc2l6ZVRpbGVzID0gZmFsc2U7CisgICAgaWYgKHZpc2libGVSZWN0ICE9IG1fcHJldmlvdXNW aXNpYmxlUmVjdCkKKyAgICAgICAgZGlkUmVzaXplVGlsZXMgPSByZXNpemVFZGdlVGlsZXMoKTsK KwogICAgIG1fcHJldmlvdXNWaXNpYmxlUmVjdCA9IHZpc2libGVSZWN0OwogCiAgICAgaWYgKHZp c2libGVSZWN0LmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgLy8gUmVzaXplIHRp bGVzIG9uIGVkZ2VzIGluIGNhc2UgdGhlIGNvbnRlbnRzIHNpemUgaGFzIGNoYW5nZWQuCi0gICAg Ym9vbCBkaWRSZXNpemVUaWxlcyA9IHJlc2l6ZUVkZ2VUaWxlcygpOwotCiAgICAgSW50UmVjdCBr ZWVwUmVjdDsKICAgICBJbnRSZWN0IGNvdmVyUmVjdDsKICAgICBjb21wdXRlQ292ZXJBbmRLZWVw UmVjdCh2aXNpYmxlUmVjdCwgY292ZXJSZWN0LCBrZWVwUmVjdCk7Cg== 129263 2012-02-28 08:43:00 -0800 2012-02-28 08:44:09 -0800 Patch bug-79787-20120228173626.patch text/plain 2351 kenneth U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4OTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmZhMTg3NWU2NDIwNWRi YjMzZTQ3YmE1MjQ3YjkyZGU2YjU3YWFiMi4uMTQyYmVkNzRkODA5ZTIwMTliYmQ5OGYxZDM4M2Y1 OGU2YmE0OWYzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAyLTI4ICBLZW5u ZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KKworICAgICAgICBE byBub3QgaW50ZXJhdGUgYWxsIHRpbGVzIGZvciByZXNpemluZyB3aGVuIHRoZSB2aWV3cG9ydCBk aWRuJ3QgY2hhbmdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03OTc4NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvVGlsZWRCYWNraW5nU3RvcmUuY3BwOgorICAgICAgICAo V2ViQ29yZTo6VGlsZWRCYWNraW5nU3RvcmU6OmNyZWF0ZVRpbGVzKToKKwogMjAxMi0wMi0yNyAg S2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4gIDxrZW5uZXRoQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgSW1wcm92ZSB0aGUgdmlzdWFsIG9mIHRoZSB0aWxpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1RpbGVkQmFja2luZ1N0b3JlLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1RpbGVkQmFja2luZ1N0b3JlLmNwcAppbmRleCBmYWFj MGJiZjgxMjM5M2VjNGIyZTVlYzg3ZGMyZmUzMjIwZjc0MjgzLi41OGYzZTY0OWE1OTUzNmIyYjlh M2JlYTBjMDVkNzc0ZDhhOTk1NzhjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9UaWxlZEJhY2tpbmdTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvVGlsZWRCYWNraW5nU3RvcmUuY3BwCkBAIC0yMzIsMTUgKzIzMiwxOSBA QCB2b2lkIFRpbGVkQmFja2luZ1N0b3JlOjpjcmVhdGVUaWxlcygpCiB7CiAgICAgaWYgKG1fY29u dGVudHNGcm96ZW4pCiAgICAgICAgIHJldHVybjsKLSAgICAKLSAgICBJbnRSZWN0IHZpc2libGVS ZWN0ID0gdmlzaWJsZUNvbnRlbnRzUmVjdCgpOworCisgICAgY29uc3QgSW50UmVjdCYgdmlzaWJs ZVJlY3QgPSB2aXNpYmxlQ29udGVudHNSZWN0KCk7CiAgICAgbV9wcmV2aW91c1Zpc2libGVSZWN0 ID0gdmlzaWJsZVJlY3Q7CiAKICAgICBpZiAodmlzaWJsZVJlY3QuaXNFbXB0eSgpKQogICAgICAg ICByZXR1cm47CiAKICAgICAvLyBSZXNpemUgdGlsZXMgb24gZWRnZXMgaW4gY2FzZSB0aGUgY29u dGVudHMgc2l6ZSBoYXMgY2hhbmdlZC4KLSAgICBib29sIGRpZFJlc2l6ZVRpbGVzID0gcmVzaXpl RWRnZVRpbGVzKCk7CisgICAgYm9vbCBkaWRSZXNpemVUaWxlcyA9IGZhbHNlOworICAgIGNvbnN0 IEludFNpemUmIGNvbnRlbnRzU2l6ZSA9IGNvbnRlbnRzUmVjdCgpLnNpemUoKTsKKworICAgIGlm IChjb250ZW50c1NpemUgIT0gbV9wcmV2aW91c0NvbnRlbnRzU2l6ZSkKKyAgICAgICAgZGlkUmVz aXplVGlsZXMgPSByZXNpemVFZGdlVGlsZXMoKTsKIAogICAgIEludFJlY3Qga2VlcFJlY3Q7CiAg ICAgSW50UmVjdCBjb3ZlclJlY3Q7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9UaWxlZEJhY2tpbmdTdG9yZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvVGlsZWRCYWNraW5nU3RvcmUuaAppbmRleCBlYTU2MDdiMTYxMTVmZjM5NmFmMTky YmNlNGNkMjkwNDljNjFkYmI4Li5hOWQxZWJkNzU4ZWVhY2RmNzcyOTQ2Nzc4MDY4Yzc3MWIwYWE5 YzM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9UaWxlZEJh Y2tpbmdTdG9yZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1RpbGVk QmFja2luZ1N0b3JlLmgKQEAgLTEyMSw4ICsxMjEsMTAgQEAgcHJpdmF0ZToKICAgICBkb3VibGUg bV90aWxlQ3JlYXRpb25EZWxheTsKICAgICBmbG9hdCBtX2NvdmVyQXJlYU11bHRpcGxpZXI7CiAg ICAgRmxvYXRQb2ludCBtX3Zpc2libGVSZWN0VHJhamVjdG9yeVZlY3RvcjsKLSAgICAKKwogICAg IEludFJlY3QgbV9wcmV2aW91c1Zpc2libGVSZWN0OworICAgIEludFNpemUgbV9wcmV2aW91c0Nv bnRlbnRzU2l6ZTsKKwogICAgIGZsb2F0IG1fY29udGVudHNTY2FsZTsKICAgICBmbG9hdCBtX3Bl bmRpbmdTY2FsZTsKIAo= 129265 2012-02-28 08:44:15 -0800 2012-02-29 01:33:23 -0800 Patch bug-79787-20120228173742.patch text/plain 2350 kenneth U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4OTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmZhMTg3NWU2NDIwNWRi YjMzZTQ3YmE1MjQ3YjkyZGU2YjU3YWFiMi4uNWVmNTRhMDliOGMyYTQ5MWIwZTI5MTllMzY2YzMz ODhkYzM3NzczZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAyLTI4ICBLZW5u ZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KKworICAgICAgICBE byBub3QgaW50ZXJhdGUgYWxsIHRpbGVzIGZvciByZXNpemluZyB3aGVuIHRoZSBjb250ZW50IGRp ZG4ndCBjaGFuZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTc5Nzg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9UaWxlZEJhY2tpbmdTdG9yZS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpUaWxlZEJhY2tpbmdTdG9yZTo6Y3JlYXRlVGlsZXMpOgorCiAyMDEyLTAyLTI3ICBL ZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KIAogICAgICAg ICBJbXByb3ZlIHRoZSB2aXN1YWwgb2YgdGhlIHRpbGluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvVGlsZWRCYWNraW5nU3RvcmUuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvVGlsZWRCYWNraW5nU3RvcmUuY3BwCmluZGV4IGZhYWMw YmJmODEyMzkzZWM0YjJlNWVjODdkYzJmZTMyMjBmNzQyODMuLjU4ZjNlNjQ5YTU5NTM2YjJiOWEz YmVhMGMwNWQ3NzRkOGE5OTU3OGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL1RpbGVkQmFja2luZ1N0b3JlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9UaWxlZEJhY2tpbmdTdG9yZS5jcHAKQEAgLTIzMiwxNSArMjMyLDE5IEBA IHZvaWQgVGlsZWRCYWNraW5nU3RvcmU6OmNyZWF0ZVRpbGVzKCkKIHsKICAgICBpZiAobV9jb250 ZW50c0Zyb3plbikKICAgICAgICAgcmV0dXJuOwotICAgIAotICAgIEludFJlY3QgdmlzaWJsZVJl Y3QgPSB2aXNpYmxlQ29udGVudHNSZWN0KCk7CisKKyAgICBjb25zdCBJbnRSZWN0JiB2aXNpYmxl UmVjdCA9IHZpc2libGVDb250ZW50c1JlY3QoKTsKICAgICBtX3ByZXZpb3VzVmlzaWJsZVJlY3Qg PSB2aXNpYmxlUmVjdDsKIAogICAgIGlmICh2aXNpYmxlUmVjdC5pc0VtcHR5KCkpCiAgICAgICAg IHJldHVybjsKIAogICAgIC8vIFJlc2l6ZSB0aWxlcyBvbiBlZGdlcyBpbiBjYXNlIHRoZSBjb250 ZW50cyBzaXplIGhhcyBjaGFuZ2VkLgotICAgIGJvb2wgZGlkUmVzaXplVGlsZXMgPSByZXNpemVF ZGdlVGlsZXMoKTsKKyAgICBib29sIGRpZFJlc2l6ZVRpbGVzID0gZmFsc2U7CisgICAgY29uc3Qg SW50U2l6ZSYgY29udGVudHNTaXplID0gY29udGVudHNSZWN0KCkuc2l6ZSgpOworCisgICAgaWYg KGNvbnRlbnRzU2l6ZSAhPSBtX3ByZXZpb3VzQ29udGVudHNTaXplKQorICAgICAgICBkaWRSZXNp emVUaWxlcyA9IHJlc2l6ZUVkZ2VUaWxlcygpOwogCiAgICAgSW50UmVjdCBrZWVwUmVjdDsKICAg ICBJbnRSZWN0IGNvdmVyUmVjdDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL1RpbGVkQmFja2luZ1N0b3JlLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9UaWxlZEJhY2tpbmdTdG9yZS5oCmluZGV4IGVhNTYwN2IxNjExNWZmMzk2YWYxOTJi Y2U0Y2QyOTA0OWM2MWRiYjguLmE5ZDFlYmQ3NThlZWFjZGY3NzI5NDY3NzgwNjhjNzcxYjBhYTlj MzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1RpbGVkQmFj a2luZ1N0b3JlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvVGlsZWRC YWNraW5nU3RvcmUuaApAQCAtMTIxLDggKzEyMSwxMCBAQCBwcml2YXRlOgogICAgIGRvdWJsZSBt X3RpbGVDcmVhdGlvbkRlbGF5OwogICAgIGZsb2F0IG1fY292ZXJBcmVhTXVsdGlwbGllcjsKICAg ICBGbG9hdFBvaW50IG1fdmlzaWJsZVJlY3RUcmFqZWN0b3J5VmVjdG9yOwotICAgIAorCiAgICAg SW50UmVjdCBtX3ByZXZpb3VzVmlzaWJsZVJlY3Q7CisgICAgSW50U2l6ZSBtX3ByZXZpb3VzQ29u dGVudHNTaXplOworCiAgICAgZmxvYXQgbV9jb250ZW50c1NjYWxlOwogICAgIGZsb2F0IG1fcGVu ZGluZ1NjYWxlOwogCg== 129414 2012-02-29 01:33:30 -0800 2012-02-29 03:05:29 -0800 Patch bug-79787-20120229102653.patch text/plain 2778 kenneth U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5MTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmYxOGFhNjc0OTMzMWIx MDYwMjFiYjA5Mjg2ZTkwYjI0YTk2MmE2Yy4uOGU2Zjc3YWM2YWIyMGEyN2M3MGI1MWQ1NjRjMzRl NzBiMDg0OWQzOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAyLTI4ICBLZW5u ZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KKworICAgICAgICBE byBub3QgaW50ZXJhdGUgYWxsIHRpbGVzIGZvciByZXNpemluZyB3aGVuIHRoZSBjb250ZW50IGRp ZG4ndCBjaGFuZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTc5Nzg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9UaWxlZEJhY2tpbmdTdG9yZS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpUaWxlZEJhY2tpbmdTdG9yZTo6Y3JlYXRlVGlsZXMpOgorCiAyMDEyLTAyLTI3ICBL ZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KIAogICAgICAg ICBJbXByb3ZlIHRoZSB2aXN1YWwgb2YgdGhlIHRpbGluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvVGlsZWRCYWNraW5nU3RvcmUuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvVGlsZWRCYWNraW5nU3RvcmUuY3BwCmluZGV4IGZhYWMw YmJmODEyMzkzZWM0YjJlNWVjODdkYzJmZTMyMjBmNzQyODMuLjhmNzA1MmM1ZmU5YWQ2ZjE1ODcx YWRhYTgwOTZiYTU2NDY3NzY4Y2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL1RpbGVkQmFja2luZ1N0b3JlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9UaWxlZEJhY2tpbmdTdG9yZS5jcHAKQEAgLTIzMiwyMiArMjMyLDI4IEBA IHZvaWQgVGlsZWRCYWNraW5nU3RvcmU6OmNyZWF0ZVRpbGVzKCkKIHsKICAgICBpZiAobV9jb250 ZW50c0Zyb3plbikKICAgICAgICAgcmV0dXJuOwotICAgIAotICAgIEludFJlY3QgdmlzaWJsZVJl Y3QgPSB2aXNpYmxlQ29udGVudHNSZWN0KCk7CisKKyAgICBjb25zdCBJbnRSZWN0IHZpc2libGVS ZWN0ID0gdmlzaWJsZUNvbnRlbnRzUmVjdCgpOwogICAgIG1fcHJldmlvdXNWaXNpYmxlUmVjdCA9 IHZpc2libGVSZWN0OwogCiAgICAgaWYgKHZpc2libGVSZWN0LmlzRW1wdHkoKSkKICAgICAgICAg cmV0dXJuOwogCiAgICAgLy8gUmVzaXplIHRpbGVzIG9uIGVkZ2VzIGluIGNhc2UgdGhlIGNvbnRl bnRzIHNpemUgaGFzIGNoYW5nZWQuCi0gICAgYm9vbCBkaWRSZXNpemVUaWxlcyA9IHJlc2l6ZUVk Z2VUaWxlcygpOworICAgIGJvb2wgZGlkUmVzaXplVGlsZXMgPSBmYWxzZTsKKyAgICBjb25zdCBJ bnRTaXplIGNvbnRlbnRzU2l6ZSA9IGNvbnRlbnRzUmVjdCgpLnNpemUoKTsKKworICAgIGlmIChj b250ZW50c1NpemUgIT0gbV9wcmV2aW91c0NvbnRlbnRzU2l6ZSkgeworICAgICAgICBtX3ByZXZp b3VzQ29udGVudHNTaXplID0gY29udGVudHNTaXplOworICAgICAgICBkaWRSZXNpemVUaWxlcyA9 IHJlc2l6ZUVkZ2VUaWxlcygpOworICAgIH0KIAogICAgIEludFJlY3Qga2VlcFJlY3Q7CiAgICAg SW50UmVjdCBjb3ZlclJlY3Q7CiAgICAgY29tcHV0ZUNvdmVyQW5kS2VlcFJlY3QodmlzaWJsZVJl Y3QsIGNvdmVyUmVjdCwga2VlcFJlY3QpOwogCiAgICAgZHJvcFRpbGVzT3V0c2lkZVJlY3Qoa2Vl cFJlY3QpOwotICAgIAorCiAgICAgLy8gU2VhcmNoIGZvciB0aGUgdGlsZSBwb3NpdGlvbiBjbG9z ZXN0IHRvIHRoZSB2aWV3cG9ydCBjZW50ZXIgdGhhdCBkb2VzIG5vdCB5ZXQgY29udGFpbiBhIHRp bGUuIAogICAgIC8vIFdoaWNoIHBvc2l0aW9uIGlzIGNvbnNpZGVyZWQgdGhlIGNsb3Nlc3QgZGVw ZW5kcyBvbiB0aGUgdGlsZURpc3RhbmNlIGZ1bmN0aW9uLgogICAgIGRvdWJsZSBzaG9ydGVzdERp c3RhbmNlID0gc3RkOjpudW1lcmljX2xpbWl0czxkb3VibGU+OjppbmZpbml0eSgpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvVGlsZWRCYWNraW5nU3RvcmUu aCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1RpbGVkQmFja2luZ1N0b3JlLmgK aW5kZXggZWE1NjA3YjE2MTE1ZmYzOTZhZjE5MmJjZTRjZDI5MDQ5YzYxZGJiOC4uYTlkMWViZDc1 OGVlYWNkZjc3Mjk0Njc3ODA2OGM3NzFiMGFhOWMzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvVGlsZWRCYWNraW5nU3RvcmUuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9UaWxlZEJhY2tpbmdTdG9yZS5oCkBAIC0xMjEsOCArMTIx LDEwIEBAIHByaXZhdGU6CiAgICAgZG91YmxlIG1fdGlsZUNyZWF0aW9uRGVsYXk7CiAgICAgZmxv YXQgbV9jb3ZlckFyZWFNdWx0aXBsaWVyOwogICAgIEZsb2F0UG9pbnQgbV92aXNpYmxlUmVjdFRy YWplY3RvcnlWZWN0b3I7Ci0gICAgCisKICAgICBJbnRSZWN0IG1fcHJldmlvdXNWaXNpYmxlUmVj dDsKKyAgICBJbnRTaXplIG1fcHJldmlvdXNDb250ZW50c1NpemU7CisKICAgICBmbG9hdCBtX2Nv bnRlbnRzU2NhbGU7CiAgICAgZmxvYXQgbV9wZW5kaW5nU2NhbGU7CiAK