79761 2012-02-28 00:39:28 -0800 Align InlineBox::m_expansion to a byte boundary 2012-02-29 09:07:15 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bashi bashi morrita webkit.review.bot oldest_to_newest 566467 0 bashi 2012-02-28 00:39:28 -0800 Valgrind memcheck complains that TextRun::expantion() is uninitialized. http://code.google.com/p/chromium/issues/detail?id=115808#c5 TextRun::m_expansion is initialized by InlineBox::m_expansion to InlineTextBox::constructTextRun(), which is initialized to zero. After some investigation, I noticed that m_expansion doesn't align to a byte boundary. This caused the valgrind errors. 566473 1 129210 bashi 2012-02-28 00:50:18 -0800 Created attachment 129210 Patch 566477 2 bashi 2012-02-28 00:54:13 -0800 (In reply to comment #1) > Created an attachment (id=129210) [details] > Patch I checked: - Valgrind memecheck doesn't detect uninitialized value references in HarfBuzzShaperBase. - The size of InlineBox is the same Morrita-san, could you please review? 567511 3 129210 morrita 2012-02-29 01:43:05 -0800 Comment on attachment 129210 Patch Could you claim the fact about the sizeof(InlineBox) in ChangeLog? 567548 4 129427 bashi 2012-02-29 03:07:11 -0800 Created attachment 129427 Patch for landing 567668 5 129427 webkit.review.bot 2012-02-29 09:07:10 -0800 Comment on attachment 129427 Patch for landing Clearing flags on attachment: 129427 Committed r109220: <http://trac.webkit.org/changeset/109220> 567669 6 webkit.review.bot 2012-02-29 09:07:15 -0800 All reviewed patches have been landed. Closing bug. 129210 2012-02-28 00:50:18 -0800 2012-02-29 03:07:06 -0800 Patch bug-79761-20120228175016.patch text/plain 1393 bashi U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5MDcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDcwZjdmMmRkN2Q1ZGI0 YzdkOGQ5ZGMzNDFmYWZjZjlkMTQwNTgxZi4uZTQ3NDQwZmIxYmQ5NmNjOGYyNTVjMzhlOThmMjZi N2U1ZDg3NjFiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAyLTI4ICBLZW5p Y2hpIElzaGliYXNoaSAgPGJhc2hpQGNocm9taXVtLm9yZz4KKworICAgICAgICBBbGlnbiBJbmxp bmVCb3g6Om1fZXhwYW5zaW9uIHRvIGEgYnl0ZSBib3VuZGFyeQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzk3NjEKKworICAgICAgICBBZGQgYSBiaXQg dG8gbV9leHBhbnNpb24gdG8gYWxpZ24gYSBieXRlIGJvdW5kYXJ5LgorICAgICAgICBUaGlzIHdp bGwgbWFrZSB2YWxncmluZCBtZW1jaGVjayBoYXBweS4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIE5vIGJlaGF2aW9yIGNoYW5n ZXMuCisKKyAgICAgICAgKiByZW5kZXJpbmcvSW5saW5lQm94Lmg6CisgICAgICAgIChJbmxpbmVC b3gpOiBBbGlnbmVkIG1fZXhwYW5zaW9uIHRvIGEgYnl0ZSBib3VuZGFyeS4KKwogMjAxMi0wMi0y NyAgS2VuaWNoaSBJc2hpYmFzaGkgIDxiYXNoaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0No cm9taXVtXSBVbnJldmlld2VkIGdhcmRlbmluZywgZnVydGhlciBjb21waWxlIGZpeGVzIGZvcgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZUJveC5oIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZUJveC5oCmluZGV4IDMyNmY5YzliYjQ3YjYxZGFlOWQ1 YjE0ZjllYTE1OTA1NTc0OTJhY2MuLmY4YTM1NGFkNzNlYWJiYjdmNjYzYTUwNzM3NjRhZjQ0NGVl OGUzNzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVCb3guaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5lQm94LmgKQEAgLTM1OCw3ICszNTgs NyBAQCBwdWJsaWM6CiBwcm90ZWN0ZWQ6CiAgICAgbXV0YWJsZSBib29sIG1fZGV0ZXJtaW5lZElm TmV4dE9uTGluZUV4aXN0cyA6IDE7CiAgICAgbXV0YWJsZSBib29sIG1fbmV4dE9uTGluZUV4aXN0 cyA6IDE7Ci0gICAgc2lnbmVkIG1fZXhwYW5zaW9uIDogMTE7IC8vIGZvciBqdXN0aWZpZWQgdGV4 dAorICAgIHNpZ25lZCBtX2V4cGFuc2lvbiA6IDEyOyAvLyBmb3IganVzdGlmaWVkIHRleHQKIAog I2lmbmRlZiBOREVCVUcKIHByaXZhdGU6Cg== 129427 2012-02-29 03:07:11 -0800 2012-02-29 09:07:10 -0800 Patch for landing bug-79761-20120229200710.patch text/plain 1444 bashi U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5MjA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODdjOTUwMTZiZGEwN2Vh ZTE3MWEzYTJmMWFmYjUwYjYxZmRiZjkxOC4uNzFlNjUwMGFjOTA4Yzc3NWFiNGIyYmEyMjc4ZmI0 N2NmZjQ3NTUzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAyLTI5ICBLZW5p Y2hpIElzaGliYXNoaSAgPGJhc2hpQGNocm9taXVtLm9yZz4KKworICAgICAgICBBbGlnbiBJbmxp bmVCb3g6Om1fZXhwYW5zaW9uIHRvIGEgYnl0ZSBib3VuZGFyeQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzk3NjEKKworICAgICAgICBBZGQgYSBiaXQg dG8gbV9leHBhbnNpb24gdG8gYWxpZ24gYSBieXRlIGJvdW5kYXJ5LgorICAgICAgICBUaGlzIHdp bGwgbWFrZSB2YWxncmluZCBtZW1jaGVjayBoYXBweS4KKyAgICAgICAgSSBjb25maXJtZWQgc2l6 ZW9mKElubGluZUJveCkgaXMgdW5jaGFuZ2VkLgorCisgICAgICAgIFJldmlld2VkIGJ5IEhhamlt ZSBNb3JpdGEuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBObyBiZWhhdmlvciBjaGFuZ2VzLgor CisgICAgICAgICogcmVuZGVyaW5nL0lubGluZUJveC5oOgorICAgICAgICAoSW5saW5lQm94KTog QWxpZ25lZCBtX2V4cGFuc2lvbiB0byBhIGJ5dGUgYm91bmRhcnkuCisKIDIwMTItMDItMjggIFl1 cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3Bl Y3RvcjogbW92ZSBET00gY291bnRlciBncmFwaHMgb3V0IG9mIGV4cGVyaW1lbnRhbApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZUJveC5oIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL0lubGluZUJveC5oCmluZGV4IDMyNmY5YzliYjQ3YjYxZGFlOWQ1YjE0Zjll YTE1OTA1NTc0OTJhY2MuLmY4YTM1NGFkNzNlYWJiYjdmNjYzYTUwNzM3NjRhZjQ0NGVlOGUzNzMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVCb3guaAorKysgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5lQm94LmgKQEAgLTM1OCw3ICszNTgsNyBAQCBw dWJsaWM6CiBwcm90ZWN0ZWQ6CiAgICAgbXV0YWJsZSBib29sIG1fZGV0ZXJtaW5lZElmTmV4dE9u TGluZUV4aXN0cyA6IDE7CiAgICAgbXV0YWJsZSBib29sIG1fbmV4dE9uTGluZUV4aXN0cyA6IDE7 Ci0gICAgc2lnbmVkIG1fZXhwYW5zaW9uIDogMTE7IC8vIGZvciBqdXN0aWZpZWQgdGV4dAorICAg IHNpZ25lZCBtX2V4cGFuc2lvbiA6IDEyOyAvLyBmb3IganVzdGlmaWVkIHRleHQKIAogI2lmbmRl ZiBOREVCVUcKIHByaXZhdGU6Cg==